Cleanup conversion to Arcade - #1014

Merged
natemcmaster merged 14 commits into
dotnet:masterfrom
natemcmaster:cleanup
Jan 30, 2019
Merged

Cleanup conversion to Arcade#1014
natemcmaster merged 14 commits into
dotnet:masterfrom
natemcmaster:cleanup

Conversation

@natemcmaster

@natemcmasternatemcmaster commented Jan 29, 2019•
edited
Loading

Copy link
Copy Markdown

Changes:

  • Revert bad merge on eng/Versions.props
  • Remove more obsolete code, mostly properties that were required for KoreBuild, but are now no longer in use
  • Update documentation to show new usage of build scripts
  • Add startvs.cmd
  • Replace IsProductComponent with IsShipping
  • Update artifact layout to match Arcade conventions
  • Rename RepositoryRoot to RepoRoot (arcade convention)
  • Update lang version to 7.3
  • Remove publish.proj and tools.proj (Arcade does this for us automatically)
  • Replace usages of IsTestProject with IsUnitTestProject (Arcade convention)
  • Fix warning as errors problem
  • Add ./eng/scripts/GenerateProjectList.ps1
  • Remove API check baseline.json files

@natemcmaster

natemcmaster commented Jan 29, 2019

Copy link
Copy Markdown
Author

I recommend reviewing individual commits on this PR. Removing the baseline.json files along is like 30k changed lines. I put the massive changes into individual commits.

ryanbrandenburg
ryanbrandenburg approved these changes Jan 30, 2019
View reviewed changes

@ryanbrandenburgryanbrandenburg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for doing this, I didn't know that a fair portion of this was KoreBuild specific.

Comment threadglobal.json
{
"sdk": {
"version": "3.0.100-preview-009750"
"version": "3.0.100-preview-010184"

@ryanbrandenburgryanbrandenburgJan 29, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got one that met our criteria? Awesome.

@natemcmasternatemcmasterJan 30, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for aspnet/Extensions, yes.

@natemcmaster

natemcmaster commented Jan 30, 2019

Copy link
Copy Markdown
Author

/AzurePipelines run all

@natemcmaster
natemcmaster merged commit f41cfde into dotnet:masterJan 30, 2019
@natemcmaster
natemcmaster deleted the cleanup branch January 30, 2019 02:34
@natemcmasternatemcmaster mentioned this pull request Jan 30, 2019
Merged
natemcmaster added a commit that referenced this pull request Jan 31, 2019
@natemcmaster
Remove unused .props file (#1024)
8535a13
Follow-up to #1014. This props file should be unnecessary now.
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 12, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
298ca80
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 15, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
154ab28
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4ced4a5
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
9a0515f
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1038c42
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
be011a9
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
a0f9369
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
b630627
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit to maryamariyan/performance that referenced this pull request Apr 3, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit to maryamariyan/performance that referenced this pull request Apr 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4f9945d
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
adamsitnik added a commit to dotnet/performance that referenced this pull request Jun 23, 2020
@maryamariyanNate McMaster
@pakrym@ryanbrandenburg@natemcmaster@benaadamsRyan NowakJohn Luo@sharwell@adamsitnik
Adds Microsoft.Extensions.* performance tests with history (#1362)
1a40f0f
* Reorganize source code
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
* Merge branch 'release/2.1' into release/2.2
Commit migrated from dotnet/extensions@18fcffb
* Merge branch 'release/2.2'
Commit migrated from dotnet/extensions@34204b6
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
* Use the SharedSourceRoot variable in project files
Commit migrated from dotnet/extensions@888bcba
* Allow caching of IEnumerable services (dotnet/extensions#575)
Commit migrated from dotnet/extensions@c89a5b5
* Reduce event source logger allocations (dotnet/extensions#870)
Commit migrated from dotnet/extensions@091ee13
* Use Arcade (dotnet/extensions#586)
Use arcade
Commit migrated from dotnet/extensions@f045899
* Cleanup conversion to Arcade (dotnet/extensions#1014)
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
* Shrink StringValues (dotnet/extensions#1283)
Commit migrated from dotnet/extensions@2f8e1fb
* Disable transitive project references in test projects (dotnet/extensions#1834)
Commit migrated from dotnet/extensions@e7d5bea
* Fix HTTP client benchmarks
Commit migrated from dotnet/extensions@8f0f7fa
* Add typed client creation benchmark
Commit migrated from dotnet/extensions@20ce03a
* Support netcoreapp3.1 TFM (dotnet/extensions#2336)
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
* Normalize all file headers to the expected Apache 2.0 license
Commit migrated from dotnet/extensions@cec6e75
* Switch file headers to the MIT license
Commit migrated from dotnet/extensions@321a30c
* Moves Microsoft.Extensions.* perf tests over
* Using the Open key to fully sign assembly
- Needed to later get InternalsVisibleTo on DI
* Apply suggestions from code review
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Fix compile + other feedback
* Apply suggestions from code review
Co-authored-by: Nate McMaster <nate.mcmaster@microsoft.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: Ryan Brandenburg <rybrande@microsoft.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ryan Nowak <rynowak@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Nov 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1ef0698
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
@ghostghost locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pakrympakrymAwaiting requested review from pakrym
@TratcherTratcherAwaiting requested review from TratcherTratcher is a code owner
1 more reviewer
@ryanbrandenburgryanbrandenburgryanbrandenburg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@natemcmaster@ryanbrandenburg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Cleanup conversion to Arcade - #1014
Merged
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Jan 30, 2019
Merged
Cleanup conversion to Arcade#1014
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Conversation
@natemcmaster
@natemcmasternatemcmaster
commented
Jan 29, 2019•

edited

Loading

Copy link


Copy Markdown

Changes:
  • Revert bad merge on eng/Versions.props
  • Remove more obsolete code, mostly properties that were required for KoreBuild, but are now no longer in use
  • Update documentation to show new usage of build scripts
  • Add startvs.cmd
  • Replace IsProductComponent with IsShipping
  • Update artifact layout to match Arcade conventions
  • Rename RepositoryRoot to RepoRoot (arcade convention)
  • Update lang version to 7.3
  • Remove publish.proj and tools.proj (Arcade does this for us automatically)
  • Replace usages of IsTestProject with IsUnitTestProject (Arcade convention)
  • Fix warning as errors problem
  • Add ./eng/scripts/GenerateProjectList.ps1
  • Remove API check baseline.json files
@natemcmaster
natemcmaster
commented
Jan 29, 2019

Copy link


Copy Markdown

Author
I recommend reviewing individual commits on this PR. Removing the baseline.json files along is like 30k changed lines. I put the massive changes into individual commits.
ryanbrandenburg
ryanbrandenburg
approved these changes
Jan 30, 2019
View reviewed changes
@ryanbrandenburgryanbrandenburg
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for doing this, I didn't know that a fair portion of this was KoreBuild specific.
Comment threadglobal.json
{
 "sdk": {
 "version": "3.0.100-preview-009750"
 "version": "3.0.100-preview-010184"
@ryanbrandenburgryanbrandenburgJan 29, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got one that met our criteria? Awesome.
@natemcmasternatemcmasterJan 30, 2019

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for aspnet/Extensions, yes.
@natemcmaster
natemcmaster
commented
Jan 30, 2019

Copy link


Copy Markdown

Author
/AzurePipelines run all
@natemcmaster
natemcmaster
merged commit f41cfde
into
dotnet:masterJan 30, 2019
@natemcmaster
natemcmaster
deleted the

cleanup

branch
January 30, 2019 02:34
@natemcmasternatemcmaster
mentioned this pull request
Jan 30, 2019
 Merged

natemcmaster added a commit
that referenced
this pull request
Jan 31, 2019
@natemcmaster
Remove unused .props file (#1024)
8535a13
Follow-up to #1014. This props file should be unnecessary now.
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
298ca80
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
154ab28
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4ced4a5
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
9a0515f
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1038c42
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
be011a9
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
a0f9369
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
b630627
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 3, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4f9945d
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
adamsitnik added a commit
to dotnet/performance
that referenced
this pull request
Jun 23, 2020
@maryamariyanNate McMaster
@pakrym@ryanbrandenburg@natemcmaster@benaadamsRyan NowakJohn Luo@sharwell@adamsitnik
Adds Microsoft.Extensions.* performance tests with history (#1362)
1a40f0f
* Reorganize source code
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
* Merge branch 'release/2.1' into release/2.2
Commit migrated from dotnet/extensions@18fcffb
* Merge branch 'release/2.2'
Commit migrated from dotnet/extensions@34204b6
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
* Use the SharedSourceRoot variable in project files
Commit migrated from dotnet/extensions@888bcba
* Allow caching of IEnumerable services (dotnet/extensions#575)
Commit migrated from dotnet/extensions@c89a5b5
* Reduce event source logger allocations (dotnet/extensions#870)
Commit migrated from dotnet/extensions@091ee13
* Use Arcade (dotnet/extensions#586)
Use arcade
Commit migrated from dotnet/extensions@f045899
* Cleanup conversion to Arcade (dotnet/extensions#1014)
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
* Shrink StringValues (dotnet/extensions#1283)
Commit migrated from dotnet/extensions@2f8e1fb
* Disable transitive project references in test projects (dotnet/extensions#1834)
Commit migrated from dotnet/extensions@e7d5bea
* Fix HTTP client benchmarks
Commit migrated from dotnet/extensions@8f0f7fa
* Add typed client creation benchmark
Commit migrated from dotnet/extensions@20ce03a
* Support netcoreapp3.1 TFM (dotnet/extensions#2336)
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
* Normalize all file headers to the expected Apache 2.0 license
Commit migrated from dotnet/extensions@cec6e75
* Switch file headers to the MIT license
Commit migrated from dotnet/extensions@321a30c
* Moves Microsoft.Extensions.* perf tests over
* Using the Open key to fully sign assembly
- Needed to later get InternalsVisibleTo on DI
* Apply suggestions from code review
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Fix compile + other feedback
* Apply suggestions from code review
Co-authored-by: Nate McMaster <nate.mcmaster@microsoft.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: Ryan Brandenburg <rybrande@microsoft.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ryan Nowak <rynowak@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1ef0698
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
@ghostghost
locked as resolved and limited conversation to collaborators
May 29, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pakrympakrymAwaiting requested review from pakrym
@TratcherTratcherAwaiting requested review from TratcherTratcher is a code owner

1 more reviewer

@ryanbrandenburgryanbrandenburgryanbrandenburg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@natemcmaster@ryanbrandenburg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cleanup conversion to Arcade - #1014
Merged
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Jan 30, 2019
Merged
Cleanup conversion to Arcade#1014
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Conversation
@natemcmaster
@natemcmasternatemcmaster
commented
Jan 29, 2019•

edited

Loading

Copy link


Copy Markdown

Changes:
  • Revert bad merge on eng/Versions.props
  • Remove more obsolete code, mostly properties that were required for KoreBuild, but are now no longer in use
  • Update documentation to show new usage of build scripts
  • Add startvs.cmd
  • Replace IsProductComponent with IsShipping
  • Update artifact layout to match Arcade conventions
  • Rename RepositoryRoot to RepoRoot (arcade convention)
  • Update lang version to 7.3
  • Remove publish.proj and tools.proj (Arcade does this for us automatically)
  • Replace usages of IsTestProject with IsUnitTestProject (Arcade convention)
  • Fix warning as errors problem
  • Add ./eng/scripts/GenerateProjectList.ps1
  • Remove API check baseline.json files
@natemcmaster
natemcmaster
commented
Jan 29, 2019

Copy link


Copy Markdown

Author
I recommend reviewing individual commits on this PR. Removing the baseline.json files along is like 30k changed lines. I put the massive changes into individual commits.
ryanbrandenburg
ryanbrandenburg
approved these changes
Jan 30, 2019
View reviewed changes
@ryanbrandenburgryanbrandenburg
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for doing this, I didn't know that a fair portion of this was KoreBuild specific.
Comment threadglobal.json
{
 "sdk": {
 "version": "3.0.100-preview-009750"
 "version": "3.0.100-preview-010184"
@ryanbrandenburgryanbrandenburgJan 29, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got one that met our criteria? Awesome.
@natemcmasternatemcmasterJan 30, 2019

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for aspnet/Extensions, yes.
@natemcmaster
natemcmaster
commented
Jan 30, 2019

Copy link


Copy Markdown

Author
/AzurePipelines run all
@natemcmaster
natemcmaster
merged commit f41cfde
into
dotnet:masterJan 30, 2019
@natemcmaster
natemcmaster
deleted the

cleanup

branch
January 30, 2019 02:34
@natemcmasternatemcmaster
mentioned this pull request
Jan 30, 2019
 Merged

natemcmaster added a commit
that referenced
this pull request
Jan 31, 2019
@natemcmaster
Remove unused .props file (#1024)
8535a13
Follow-up to #1014. This props file should be unnecessary now.
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
298ca80
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
154ab28
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4ced4a5
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
9a0515f
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1038c42
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
be011a9
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
a0f9369
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
b630627
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 3, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4f9945d
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
adamsitnik added a commit
to dotnet/performance
that referenced
this pull request
Jun 23, 2020
@maryamariyanNate McMaster
@pakrym@ryanbrandenburg@natemcmaster@benaadamsRyan NowakJohn Luo@sharwell@adamsitnik
Adds Microsoft.Extensions.* performance tests with history (#1362)
1a40f0f
* Reorganize source code
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
* Merge branch 'release/2.1' into release/2.2
Commit migrated from dotnet/extensions@18fcffb
* Merge branch 'release/2.2'
Commit migrated from dotnet/extensions@34204b6
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
* Use the SharedSourceRoot variable in project files
Commit migrated from dotnet/extensions@888bcba
* Allow caching of IEnumerable services (dotnet/extensions#575)
Commit migrated from dotnet/extensions@c89a5b5
* Reduce event source logger allocations (dotnet/extensions#870)
Commit migrated from dotnet/extensions@091ee13
* Use Arcade (dotnet/extensions#586)
Use arcade
Commit migrated from dotnet/extensions@f045899
* Cleanup conversion to Arcade (dotnet/extensions#1014)
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
* Shrink StringValues (dotnet/extensions#1283)
Commit migrated from dotnet/extensions@2f8e1fb
* Disable transitive project references in test projects (dotnet/extensions#1834)
Commit migrated from dotnet/extensions@e7d5bea
* Fix HTTP client benchmarks
Commit migrated from dotnet/extensions@8f0f7fa
* Add typed client creation benchmark
Commit migrated from dotnet/extensions@20ce03a
* Support netcoreapp3.1 TFM (dotnet/extensions#2336)
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
* Normalize all file headers to the expected Apache 2.0 license
Commit migrated from dotnet/extensions@cec6e75
* Switch file headers to the MIT license
Commit migrated from dotnet/extensions@321a30c
* Moves Microsoft.Extensions.* perf tests over
* Using the Open key to fully sign assembly
- Needed to later get InternalsVisibleTo on DI
* Apply suggestions from code review
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Fix compile + other feedback
* Apply suggestions from code review
Co-authored-by: Nate McMaster <nate.mcmaster@microsoft.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: Ryan Brandenburg <rybrande@microsoft.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ryan Nowak <rynowak@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1ef0698
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
@ghostghost
locked as resolved and limited conversation to collaborators
May 29, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pakrympakrymAwaiting requested review from pakrym
@TratcherTratcherAwaiting requested review from TratcherTratcher is a code owner

1 more reviewer

@ryanbrandenburgryanbrandenburgryanbrandenburg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@natemcmaster@ryanbrandenburg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cleanup conversion to Arcade - #1014
Merged
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Jan 30, 2019
Merged
Cleanup conversion to Arcade#1014
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Conversation
@natemcmaster
@natemcmasternatemcmaster
commented
Jan 29, 2019•

edited

Loading

Copy link


Copy Markdown

Changes:
  • Revert bad merge on eng/Versions.props
  • Remove more obsolete code, mostly properties that were required for KoreBuild, but are now no longer in use
  • Update documentation to show new usage of build scripts
  • Add startvs.cmd
  • Replace IsProductComponent with IsShipping
  • Update artifact layout to match Arcade conventions
  • Rename RepositoryRoot to RepoRoot (arcade convention)
  • Update lang version to 7.3
  • Remove publish.proj and tools.proj (Arcade does this for us automatically)
  • Replace usages of IsTestProject with IsUnitTestProject (Arcade convention)
  • Fix warning as errors problem
  • Add ./eng/scripts/GenerateProjectList.ps1
  • Remove API check baseline.json files
@natemcmaster
natemcmaster
commented
Jan 29, 2019

Copy link


Copy Markdown

Author
I recommend reviewing individual commits on this PR. Removing the baseline.json files along is like 30k changed lines. I put the massive changes into individual commits.
ryanbrandenburg
ryanbrandenburg
approved these changes
Jan 30, 2019
View reviewed changes
@ryanbrandenburgryanbrandenburg
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for doing this, I didn't know that a fair portion of this was KoreBuild specific.
Comment threadglobal.json
{
 "sdk": {
 "version": "3.0.100-preview-009750"
 "version": "3.0.100-preview-010184"
@ryanbrandenburgryanbrandenburgJan 29, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got one that met our criteria? Awesome.
@natemcmasternatemcmasterJan 30, 2019

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for aspnet/Extensions, yes.
@natemcmaster
natemcmaster
commented
Jan 30, 2019

Copy link


Copy Markdown

Author
/AzurePipelines run all
@natemcmaster
natemcmaster
merged commit f41cfde
into
dotnet:masterJan 30, 2019
@natemcmaster
natemcmaster
deleted the

cleanup

branch
January 30, 2019 02:34
@natemcmasternatemcmaster
mentioned this pull request
Jan 30, 2019
 Merged

natemcmaster added a commit
that referenced
this pull request
Jan 31, 2019
@natemcmaster
Remove unused .props file (#1024)
8535a13
Follow-up to #1014. This props file should be unnecessary now.
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
298ca80
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
154ab28
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4ced4a5
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
9a0515f
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1038c42
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
be011a9
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
a0f9369
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
b630627
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 3, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4f9945d
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
adamsitnik added a commit
to dotnet/performance
that referenced
this pull request
Jun 23, 2020
@maryamariyanNate McMaster
@pakrym@ryanbrandenburg@natemcmaster@benaadamsRyan NowakJohn Luo@sharwell@adamsitnik
Adds Microsoft.Extensions.* performance tests with history (#1362)
1a40f0f
* Reorganize source code
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
* Merge branch 'release/2.1' into release/2.2
Commit migrated from dotnet/extensions@18fcffb
* Merge branch 'release/2.2'
Commit migrated from dotnet/extensions@34204b6
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
* Use the SharedSourceRoot variable in project files
Commit migrated from dotnet/extensions@888bcba
* Allow caching of IEnumerable services (dotnet/extensions#575)
Commit migrated from dotnet/extensions@c89a5b5
* Reduce event source logger allocations (dotnet/extensions#870)
Commit migrated from dotnet/extensions@091ee13
* Use Arcade (dotnet/extensions#586)
Use arcade
Commit migrated from dotnet/extensions@f045899
* Cleanup conversion to Arcade (dotnet/extensions#1014)
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
* Shrink StringValues (dotnet/extensions#1283)
Commit migrated from dotnet/extensions@2f8e1fb
* Disable transitive project references in test projects (dotnet/extensions#1834)
Commit migrated from dotnet/extensions@e7d5bea
* Fix HTTP client benchmarks
Commit migrated from dotnet/extensions@8f0f7fa
* Add typed client creation benchmark
Commit migrated from dotnet/extensions@20ce03a
* Support netcoreapp3.1 TFM (dotnet/extensions#2336)
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
* Normalize all file headers to the expected Apache 2.0 license
Commit migrated from dotnet/extensions@cec6e75
* Switch file headers to the MIT license
Commit migrated from dotnet/extensions@321a30c
* Moves Microsoft.Extensions.* perf tests over
* Using the Open key to fully sign assembly
- Needed to later get InternalsVisibleTo on DI
* Apply suggestions from code review
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Fix compile + other feedback
* Apply suggestions from code review
Co-authored-by: Nate McMaster <nate.mcmaster@microsoft.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: Ryan Brandenburg <rybrande@microsoft.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ryan Nowak <rynowak@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1ef0698
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
@ghostghost
locked as resolved and limited conversation to collaborators
May 29, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pakrympakrymAwaiting requested review from pakrym
@TratcherTratcherAwaiting requested review from TratcherTratcher is a code owner

1 more reviewer

@ryanbrandenburgryanbrandenburgryanbrandenburg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@natemcmaster@ryanbrandenburg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Cleanup conversion to Arcade - #1014
Merged
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Jan 30, 2019
Merged
Cleanup conversion to Arcade#1014
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Conversation
@natemcmaster
@natemcmasternatemcmaster
commented
Jan 29, 2019•

edited

Loading

Copy link


Copy Markdown

Changes:
  • Revert bad merge on eng/Versions.props
  • Remove more obsolete code, mostly properties that were required for KoreBuild, but are now no longer in use
  • Update documentation to show new usage of build scripts
  • Add startvs.cmd
  • Replace IsProductComponent with IsShipping
  • Update artifact layout to match Arcade conventions
  • Rename RepositoryRoot to RepoRoot (arcade convention)
  • Update lang version to 7.3
  • Remove publish.proj and tools.proj (Arcade does this for us automatically)
  • Replace usages of IsTestProject with IsUnitTestProject (Arcade convention)
  • Fix warning as errors problem
  • Add ./eng/scripts/GenerateProjectList.ps1
  • Remove API check baseline.json files
@natemcmaster
natemcmaster
commented
Jan 29, 2019

Copy link


Copy Markdown

Author
I recommend reviewing individual commits on this PR. Removing the baseline.json files along is like 30k changed lines. I put the massive changes into individual commits.
ryanbrandenburg
ryanbrandenburg
approved these changes
Jan 30, 2019
View reviewed changes
@ryanbrandenburgryanbrandenburg
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for doing this, I didn't know that a fair portion of this was KoreBuild specific.
Comment threadglobal.json
{
 "sdk": {
 "version": "3.0.100-preview-009750"
 "version": "3.0.100-preview-010184"
@ryanbrandenburgryanbrandenburgJan 29, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got one that met our criteria? Awesome.
@natemcmasternatemcmasterJan 30, 2019

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for aspnet/Extensions, yes.
@natemcmaster
natemcmaster
commented
Jan 30, 2019

Copy link


Copy Markdown

Author
/AzurePipelines run all
@natemcmaster
natemcmaster
merged commit f41cfde
into
dotnet:masterJan 30, 2019
@natemcmaster
natemcmaster
deleted the

cleanup

branch
January 30, 2019 02:34
@natemcmasternatemcmaster
mentioned this pull request
Jan 30, 2019
 Merged

natemcmaster added a commit
that referenced
this pull request
Jan 31, 2019
@natemcmaster
Remove unused .props file (#1024)
8535a13
Follow-up to #1014. This props file should be unnecessary now.
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
298ca80
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
154ab28
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4ced4a5
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
9a0515f
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1038c42
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
be011a9
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
a0f9369
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
b630627
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 3, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4f9945d
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
adamsitnik added a commit
to dotnet/performance
that referenced
this pull request
Jun 23, 2020
@maryamariyanNate McMaster
@pakrym@ryanbrandenburg@natemcmaster@benaadamsRyan NowakJohn Luo@sharwell@adamsitnik
Adds Microsoft.Extensions.* performance tests with history (#1362)
1a40f0f
* Reorganize source code
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
* Merge branch 'release/2.1' into release/2.2
Commit migrated from dotnet/extensions@18fcffb
* Merge branch 'release/2.2'
Commit migrated from dotnet/extensions@34204b6
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
* Use the SharedSourceRoot variable in project files
Commit migrated from dotnet/extensions@888bcba
* Allow caching of IEnumerable services (dotnet/extensions#575)
Commit migrated from dotnet/extensions@c89a5b5
* Reduce event source logger allocations (dotnet/extensions#870)
Commit migrated from dotnet/extensions@091ee13
* Use Arcade (dotnet/extensions#586)
Use arcade
Commit migrated from dotnet/extensions@f045899
* Cleanup conversion to Arcade (dotnet/extensions#1014)
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
* Shrink StringValues (dotnet/extensions#1283)
Commit migrated from dotnet/extensions@2f8e1fb
* Disable transitive project references in test projects (dotnet/extensions#1834)
Commit migrated from dotnet/extensions@e7d5bea
* Fix HTTP client benchmarks
Commit migrated from dotnet/extensions@8f0f7fa
* Add typed client creation benchmark
Commit migrated from dotnet/extensions@20ce03a
* Support netcoreapp3.1 TFM (dotnet/extensions#2336)
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
* Normalize all file headers to the expected Apache 2.0 license
Commit migrated from dotnet/extensions@cec6e75
* Switch file headers to the MIT license
Commit migrated from dotnet/extensions@321a30c
* Moves Microsoft.Extensions.* perf tests over
* Using the Open key to fully sign assembly
- Needed to later get InternalsVisibleTo on DI
* Apply suggestions from code review
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Fix compile + other feedback
* Apply suggestions from code review
Co-authored-by: Nate McMaster <nate.mcmaster@microsoft.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: Ryan Brandenburg <rybrande@microsoft.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ryan Nowak <rynowak@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1ef0698
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
@ghostghost
locked as resolved and limited conversation to collaborators
May 29, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pakrympakrymAwaiting requested review from pakrym
@TratcherTratcherAwaiting requested review from TratcherTratcher is a code owner

1 more reviewer

@ryanbrandenburgryanbrandenburgryanbrandenburg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@natemcmaster@ryanbrandenburg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cleanup conversion to Arcade - #1014
Merged
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Jan 30, 2019
Merged
Cleanup conversion to Arcade#1014
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Conversation
@natemcmaster
@natemcmasternatemcmaster
commented
Jan 29, 2019•

edited

Loading

Copy link


Copy Markdown

Changes:
  • Revert bad merge on eng/Versions.props
  • Remove more obsolete code, mostly properties that were required for KoreBuild, but are now no longer in use
  • Update documentation to show new usage of build scripts
  • Add startvs.cmd
  • Replace IsProductComponent with IsShipping
  • Update artifact layout to match Arcade conventions
  • Rename RepositoryRoot to RepoRoot (arcade convention)
  • Update lang version to 7.3
  • Remove publish.proj and tools.proj (Arcade does this for us automatically)
  • Replace usages of IsTestProject with IsUnitTestProject (Arcade convention)
  • Fix warning as errors problem
  • Add ./eng/scripts/GenerateProjectList.ps1
  • Remove API check baseline.json files
@natemcmaster
natemcmaster
commented
Jan 29, 2019

Copy link


Copy Markdown

Author
I recommend reviewing individual commits on this PR. Removing the baseline.json files along is like 30k changed lines. I put the massive changes into individual commits.
ryanbrandenburg
ryanbrandenburg
approved these changes
Jan 30, 2019
View reviewed changes
@ryanbrandenburgryanbrandenburg
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for doing this, I didn't know that a fair portion of this was KoreBuild specific.
Comment threadglobal.json
{
 "sdk": {
 "version": "3.0.100-preview-009750"
 "version": "3.0.100-preview-010184"
@ryanbrandenburgryanbrandenburgJan 29, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got one that met our criteria? Awesome.
@natemcmasternatemcmasterJan 30, 2019

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for aspnet/Extensions, yes.
@natemcmaster
natemcmaster
commented
Jan 30, 2019

Copy link


Copy Markdown

Author
/AzurePipelines run all
@natemcmaster
natemcmaster
merged commit f41cfde
into
dotnet:masterJan 30, 2019
@natemcmaster
natemcmaster
deleted the

cleanup

branch
January 30, 2019 02:34
@natemcmasternatemcmaster
mentioned this pull request
Jan 30, 2019
 Merged

natemcmaster added a commit
that referenced
this pull request
Jan 31, 2019
@natemcmaster
Remove unused .props file (#1024)
8535a13
Follow-up to #1014. This props file should be unnecessary now.
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
298ca80
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
154ab28
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4ced4a5
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
9a0515f
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1038c42
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
be011a9
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
a0f9369
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
b630627
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 3, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4f9945d
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
adamsitnik added a commit
to dotnet/performance
that referenced
this pull request
Jun 23, 2020
@maryamariyanNate McMaster
@pakrym@ryanbrandenburg@natemcmaster@benaadamsRyan NowakJohn Luo@sharwell@adamsitnik
Adds Microsoft.Extensions.* performance tests with history (#1362)
1a40f0f
* Reorganize source code
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
* Merge branch 'release/2.1' into release/2.2
Commit migrated from dotnet/extensions@18fcffb
* Merge branch 'release/2.2'
Commit migrated from dotnet/extensions@34204b6
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
* Use the SharedSourceRoot variable in project files
Commit migrated from dotnet/extensions@888bcba
* Allow caching of IEnumerable services (dotnet/extensions#575)
Commit migrated from dotnet/extensions@c89a5b5
* Reduce event source logger allocations (dotnet/extensions#870)
Commit migrated from dotnet/extensions@091ee13
* Use Arcade (dotnet/extensions#586)
Use arcade
Commit migrated from dotnet/extensions@f045899
* Cleanup conversion to Arcade (dotnet/extensions#1014)
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
* Shrink StringValues (dotnet/extensions#1283)
Commit migrated from dotnet/extensions@2f8e1fb
* Disable transitive project references in test projects (dotnet/extensions#1834)
Commit migrated from dotnet/extensions@e7d5bea
* Fix HTTP client benchmarks
Commit migrated from dotnet/extensions@8f0f7fa
* Add typed client creation benchmark
Commit migrated from dotnet/extensions@20ce03a
* Support netcoreapp3.1 TFM (dotnet/extensions#2336)
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
* Normalize all file headers to the expected Apache 2.0 license
Commit migrated from dotnet/extensions@cec6e75
* Switch file headers to the MIT license
Commit migrated from dotnet/extensions@321a30c
* Moves Microsoft.Extensions.* perf tests over
* Using the Open key to fully sign assembly
- Needed to later get InternalsVisibleTo on DI
* Apply suggestions from code review
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Fix compile + other feedback
* Apply suggestions from code review
Co-authored-by: Nate McMaster <nate.mcmaster@microsoft.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: Ryan Brandenburg <rybrande@microsoft.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ryan Nowak <rynowak@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1ef0698
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
@ghostghost
locked as resolved and limited conversation to collaborators
May 29, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pakrympakrymAwaiting requested review from pakrym
@TratcherTratcherAwaiting requested review from TratcherTratcher is a code owner

1 more reviewer

@ryanbrandenburgryanbrandenburgryanbrandenburg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@natemcmaster@ryanbrandenburg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Cleanup conversion to Arcade - #1014
Merged
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Jan 30, 2019
Merged
Cleanup conversion to Arcade#1014
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Conversation
@natemcmaster
@natemcmasternatemcmaster
commented
Jan 29, 2019•

edited

Loading

Copy link


Copy Markdown

Changes:
  • Revert bad merge on eng/Versions.props
  • Remove more obsolete code, mostly properties that were required for KoreBuild, but are now no longer in use
  • Update documentation to show new usage of build scripts
  • Add startvs.cmd
  • Replace IsProductComponent with IsShipping
  • Update artifact layout to match Arcade conventions
  • Rename RepositoryRoot to RepoRoot (arcade convention)
  • Update lang version to 7.3
  • Remove publish.proj and tools.proj (Arcade does this for us automatically)
  • Replace usages of IsTestProject with IsUnitTestProject (Arcade convention)
  • Fix warning as errors problem
  • Add ./eng/scripts/GenerateProjectList.ps1
  • Remove API check baseline.json files
@natemcmaster
natemcmaster
commented
Jan 29, 2019

Copy link


Copy Markdown

Author
I recommend reviewing individual commits on this PR. Removing the baseline.json files along is like 30k changed lines. I put the massive changes into individual commits.
ryanbrandenburg
ryanbrandenburg
approved these changes
Jan 30, 2019
View reviewed changes
@ryanbrandenburgryanbrandenburg
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for doing this, I didn't know that a fair portion of this was KoreBuild specific.
Comment threadglobal.json
{
 "sdk": {
 "version": "3.0.100-preview-009750"
 "version": "3.0.100-preview-010184"
@ryanbrandenburgryanbrandenburgJan 29, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got one that met our criteria? Awesome.
@natemcmasternatemcmasterJan 30, 2019

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for aspnet/Extensions, yes.
@natemcmaster
natemcmaster
commented
Jan 30, 2019

Copy link


Copy Markdown

Author
/AzurePipelines run all
@natemcmaster
natemcmaster
merged commit f41cfde
into
dotnet:masterJan 30, 2019
@natemcmaster
natemcmaster
deleted the

cleanup

branch
January 30, 2019 02:34
@natemcmasternatemcmaster
mentioned this pull request
Jan 30, 2019
 Merged

natemcmaster added a commit
that referenced
this pull request
Jan 31, 2019
@natemcmaster
Remove unused .props file (#1024)
8535a13
Follow-up to #1014. This props file should be unnecessary now.
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
298ca80
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
154ab28
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4ced4a5
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
9a0515f
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1038c42
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
be011a9
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
a0f9369
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
b630627
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 3, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4f9945d
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
adamsitnik added a commit
to dotnet/performance
that referenced
this pull request
Jun 23, 2020
@maryamariyanNate McMaster
@pakrym@ryanbrandenburg@natemcmaster@benaadamsRyan NowakJohn Luo@sharwell@adamsitnik
Adds Microsoft.Extensions.* performance tests with history (#1362)
1a40f0f
* Reorganize source code
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
* Merge branch 'release/2.1' into release/2.2
Commit migrated from dotnet/extensions@18fcffb
* Merge branch 'release/2.2'
Commit migrated from dotnet/extensions@34204b6
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
* Use the SharedSourceRoot variable in project files
Commit migrated from dotnet/extensions@888bcba
* Allow caching of IEnumerable services (dotnet/extensions#575)
Commit migrated from dotnet/extensions@c89a5b5
* Reduce event source logger allocations (dotnet/extensions#870)
Commit migrated from dotnet/extensions@091ee13
* Use Arcade (dotnet/extensions#586)
Use arcade
Commit migrated from dotnet/extensions@f045899
* Cleanup conversion to Arcade (dotnet/extensions#1014)
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
* Shrink StringValues (dotnet/extensions#1283)
Commit migrated from dotnet/extensions@2f8e1fb
* Disable transitive project references in test projects (dotnet/extensions#1834)
Commit migrated from dotnet/extensions@e7d5bea
* Fix HTTP client benchmarks
Commit migrated from dotnet/extensions@8f0f7fa
* Add typed client creation benchmark
Commit migrated from dotnet/extensions@20ce03a
* Support netcoreapp3.1 TFM (dotnet/extensions#2336)
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
* Normalize all file headers to the expected Apache 2.0 license
Commit migrated from dotnet/extensions@cec6e75
* Switch file headers to the MIT license
Commit migrated from dotnet/extensions@321a30c
* Moves Microsoft.Extensions.* perf tests over
* Using the Open key to fully sign assembly
- Needed to later get InternalsVisibleTo on DI
* Apply suggestions from code review
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Fix compile + other feedback
* Apply suggestions from code review
Co-authored-by: Nate McMaster <nate.mcmaster@microsoft.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: Ryan Brandenburg <rybrande@microsoft.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ryan Nowak <rynowak@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1ef0698
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
@ghostghost
locked as resolved and limited conversation to collaborators
May 29, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pakrympakrymAwaiting requested review from pakrym
@TratcherTratcherAwaiting requested review from TratcherTratcher is a code owner

1 more reviewer

@ryanbrandenburgryanbrandenburgryanbrandenburg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@natemcmaster@ryanbrandenburg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Cleanup conversion to Arcade - #1014
Merged
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Jan 30, 2019
Merged
Cleanup conversion to Arcade#1014
natemcmaster merged 14 commits into
dotnet:masterfrom 
natemcmaster:cleanup
Conversation
@natemcmaster
@natemcmasternatemcmaster
commented
Jan 29, 2019•

edited

Loading

Copy link


Copy Markdown

Changes:
  • Revert bad merge on eng/Versions.props
  • Remove more obsolete code, mostly properties that were required for KoreBuild, but are now no longer in use
  • Update documentation to show new usage of build scripts
  • Add startvs.cmd
  • Replace IsProductComponent with IsShipping
  • Update artifact layout to match Arcade conventions
  • Rename RepositoryRoot to RepoRoot (arcade convention)
  • Update lang version to 7.3
  • Remove publish.proj and tools.proj (Arcade does this for us automatically)
  • Replace usages of IsTestProject with IsUnitTestProject (Arcade convention)
  • Fix warning as errors problem
  • Add ./eng/scripts/GenerateProjectList.ps1
  • Remove API check baseline.json files
@natemcmaster
natemcmaster
commented
Jan 29, 2019

Copy link


Copy Markdown

Author
I recommend reviewing individual commits on this PR. Removing the baseline.json files along is like 30k changed lines. I put the massive changes into individual commits.
ryanbrandenburg
ryanbrandenburg
approved these changes
Jan 30, 2019
View reviewed changes
@ryanbrandenburgryanbrandenburg
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for doing this, I didn't know that a fair portion of this was KoreBuild specific.
Comment threadglobal.json
{
 "sdk": {
 "version": "3.0.100-preview-009750"
 "version": "3.0.100-preview-010184"
@ryanbrandenburgryanbrandenburgJan 29, 2019

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got one that met our criteria? Awesome.
@natemcmasternatemcmasterJan 30, 2019

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for aspnet/Extensions, yes.
@natemcmaster
natemcmaster
commented
Jan 30, 2019

Copy link


Copy Markdown

Author
/AzurePipelines run all
@natemcmaster
natemcmaster
merged commit f41cfde
into
dotnet:masterJan 30, 2019
@natemcmaster
natemcmaster
deleted the

cleanup

branch
January 30, 2019 02:34
@natemcmasternatemcmaster
mentioned this pull request
Jan 30, 2019
 Merged

natemcmaster added a commit
that referenced
this pull request
Jan 31, 2019
@natemcmaster
Remove unused .props file (#1024)
8535a13
Follow-up to #1014. This props file should be unnecessary now.
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
298ca80
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
154ab28
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4ced4a5
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
9a0515f
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1038c42
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
be011a9
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
a0f9369
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
b630627
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 3, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
maryamariyan pushed a commit
to maryamariyan/performance
that referenced
this pull request
Apr 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
4f9945d
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
adamsitnik added a commit
to dotnet/performance
that referenced
this pull request
Jun 23, 2020
@maryamariyanNate McMaster
@pakrym@ryanbrandenburg@natemcmaster@benaadamsRyan NowakJohn Luo@sharwell@adamsitnik
Adds Microsoft.Extensions.* performance tests with history (#1362)
1a40f0f
* Reorganize source code
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
* Merge branch 'release/2.1' into release/2.2
Commit migrated from dotnet/extensions@18fcffb
* Merge branch 'release/2.2'
Commit migrated from dotnet/extensions@34204b6
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
* Reorganize source code in preparation to move into aspnet/Extensions
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
* Use the SharedSourceRoot variable in project files
Commit migrated from dotnet/extensions@888bcba
* Allow caching of IEnumerable services (dotnet/extensions#575)
Commit migrated from dotnet/extensions@c89a5b5
* Reduce event source logger allocations (dotnet/extensions#870)
Commit migrated from dotnet/extensions@091ee13
* Use Arcade (dotnet/extensions#586)
Use arcade
Commit migrated from dotnet/extensions@f045899
* Cleanup conversion to Arcade (dotnet/extensions#1014)
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
* Shrink StringValues (dotnet/extensions#1283)
Commit migrated from dotnet/extensions@2f8e1fb
* Disable transitive project references in test projects (dotnet/extensions#1834)
Commit migrated from dotnet/extensions@e7d5bea
* Fix HTTP client benchmarks
Commit migrated from dotnet/extensions@8f0f7fa
* Add typed client creation benchmark
Commit migrated from dotnet/extensions@20ce03a
* Support netcoreapp3.1 TFM (dotnet/extensions#2336)
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
* Normalize all file headers to the expected Apache 2.0 license
Commit migrated from dotnet/extensions@cec6e75
* Switch file headers to the MIT license
Commit migrated from dotnet/extensions@321a30c
* Moves Microsoft.Extensions.* perf tests over
* Using the Open key to fully sign assembly
- Needed to later get InternalsVisibleTo on DI
* Apply suggestions from code review
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Fix compile + other feedback
* Apply suggestions from code review
Co-authored-by: Nate McMaster <nate.mcmaster@microsoft.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: Ryan Brandenburg <rybrande@microsoft.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ryan Nowak <rynowak@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
JunTaoLuo pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
1ef0698
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde
@ghostghost
locked as resolved and limited conversation to collaborators
May 29, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@pakrympakrymAwaiting requested review from pakrym
@TratcherTratcherAwaiting requested review from TratcherTratcher is a code owner

1 more reviewer

@ryanbrandenburgryanbrandenburgryanbrandenburg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@natemcmaster@ryanbrandenburg