Adds Microsoft.Extensions.* performance tests with history - #1362

Merged
adamsitnik merged 33 commits into
dotnet:masterfrom
maryamariyan:complete-perf
Jun 23, 2020
Merged

Adds Microsoft.Extensions.* performance tests with history#1362
adamsitnik merged 33 commits into
dotnet:masterfrom
maryamariyan:complete-perf

Conversation

@maryamariyan

@maryamariyanmaryamariyan commented Jun 17, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Nate McMasterand others added 29 commits October 30, 2018 14:18
Nate McMaster
Reorganize source code
1690290
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
Nate McMaster
Merge branch 'release/2.1' into release/2.2
0194014
Commit migrated from dotnet/extensions@18fcffb
Nate McMaster
Merge branch 'release/2.2'
814a3b0
Commit migrated from dotnet/extensions@34204b6
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
f240aca
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
5c3d7d7
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
4548ba5
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
Nate McMaster
Merge the source code from aspnet/DependencyInjection release/2.1
4ee3c9e
Commit migrated from dotnet/extensions@8b174f1
Nate McMaster
Merge branch 'release/2.1' into release/2.2
b7ccbb6
Commit migrated from dotnet/extensions@5b8b6c7
Nate McMaster
Merge branch 'release/2.2'
b52a855
Commit migrated from dotnet/extensions@3ba072c
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
2c88e33
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
Nate McMaster
Merge branch 'release/2.2'
d746978
Commit migrated from dotnet/extensions@f162f10
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
893cb96
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
Nate McMaster
Use the SharedSourceRoot variable in project files
14a2e29
Commit migrated from dotnet/extensions@888bcba
Nate McMaster
Merge the source code from aspnet/HttpClientFactory into this repo
d58cbe8
Commit migrated from dotnet/extensions@8fad574
Nate McMaster
Merge branch 'release/2.1' into release/2.2
7bc945d
Commit migrated from dotnet/extensions@63cde57
Nate McMaster
Merge branch 'release/2.2'
bfc6f92
This includes the master branch of aspnet/HttpClientFactory
Commit migrated from dotnet/extensions@557995e
@pakrym
Allow caching of IEnumerable services (dotnet/extensions#575)
0d0378b
Commit migrated from dotnet/extensions@c89a5b5
@pakrym
Reduce event source logger allocations (dotnet/extensions#870)
c7451bd
Commit migrated from dotnet/extensions@091ee13
@ryanbrandenburg
Use Arcade (dotnet/extensions#586)
89bed04
Use arcade
Commit migrated from dotnet/extensions@f045899
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
@benaadams@Tratcher
Shrink StringValues (dotnet/extensions#1283)
dd2d8d7
Commit migrated from dotnet/extensions@2f8e1fb
@natemcmaster
Disable transitive project references in test projects (dotnet/extens…
32e853b
…ions#1834)
Commit migrated from dotnet/extensions@e7d5bea
Ryan Nowak@rynowak
Fix HTTP client benchmarks
fc1df90
Commit migrated from dotnet/extensions@8f0f7fa
Ryan Nowak@rynowak
Add typed client creation benchmark
bdac559
Commit migrated from dotnet/extensions@20ce03a
John Luo
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0afd56b
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
@sharwell
Normalize all file headers to the expected Apache 2.0 license
c303731
Commit migrated from dotnet/extensions@cec6e75
@sharwell
Switch file headers to the MIT license
8ffa5b7
Commit migrated from dotnet/extensions@321a30c
@maryamariyan
Merge branch 'master' ofhttps://github.com/dotnet/performanceinto 4in1
4622cb5
@maryamariyan
Moves Microsoft.Extensions.* perf tests over
48ba3c4
@maryamariyanmaryamariyan mentioned this pull request Jun 17, 2020
Closed
@maryamariyanmaryamariyan mentioned this pull request Jun 17, 2020
Closed
@maryamariyanmaryamariyan mentioned this pull request Jun 17, 2020
Merged
@maryamariyan
Using the Open key to fully sign assembly
fe1da91
- Needed to later get InternalsVisibleTo on DI
adamsitnik
adamsitnik requested changes Jun 19, 2020
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryamariyan big thanks for porting all these benchmarks to the performance repo!

the porting itself looks very good, however, I have some comments related to the benchmarks themselves. Before we merge them we should make sure that they follow our guidelines

As soon as all suggestions are applied, I am going to merge this PR.

Once again big thanks for all the work @maryamariyan ! It took me a few hours to review it, I can imagine how long it took to actually port them!

Comment threadsrc/Directory.Build.props Outdated
Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs Outdated
Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs Outdated
Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs Outdated
Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs Outdated
Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs Outdated
Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs Outdated
Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs Outdated
Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/LoggingOverheadBenchmark.cs Outdated
Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/CreationOverheadBenchmark.cs Outdated
@maryamariyan@adamsitnik
Apply suggestions from code review
32a0653
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@maryamariyan

maryamariyan commented Jun 22, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@adamsitnik ready for re-review.
Aside from comments #1362 (comment) and #1362 (comment), I applied the rest of them. Thanks for making it easy with those commit batch suggestions :)

adamsitnik
adamsitnik approved these changes Jun 23, 2020
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @maryamariyan !

Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs Outdated
Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs Outdated
@adamsitnik

adamsitnik commented Jun 23, 2020•
edited
Loading

Copy link
Copy Markdown
Member

One of the CI legs failed with a really strange error:

 --------------------------------------------------
Building .NET micro benchmarks for 'netcoreapp5.0'
--------------------------------------------------
$ pushd "C:\h\w\AB6A0982\p\src\benchmarks\micro"
$ dotnet build C:\h\w\AB6A0982\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework netcoreapp5.0 --no-restore /p:NuGetPackageRoot=C:\h\w\AB6A0982\p\artifacts\packages
Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
Build FAILED.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
0 Warning(s)
1 Error(s)

I am going to re-run it.

Edit: I can see exactly same error in #1372 so it's not related to this PR

@adamsitnik
adamsitnik merged commit 1a40f0f into dotnet:masterJun 23, 2020
@adamsitnikadamsitnik mentioned this pull request Jun 26, 2020
Closed
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes
+2 more reviewers
@davidfowldavidfowldavidfowl approved these changes
@JunTaoLuoJunTaoLuoJunTaoLuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@maryamariyan@adamsitnik@davidfowl@JunTaoLuo@pakrym@ryanbrandenburg@natemcmaster@benaadams@sharwell
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Adds Microsoft.Extensions.* performance tests with history - #1362
Merged
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Jun 23, 2020
Merged
Adds Microsoft.Extensions.* performance tests with history#1362
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Conversation
@maryamariyan
@maryamariyanmaryamariyan
commented
Jun 17, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Nate McMasterand others
added 29 commits
October 30, 2018 14:18
Nate McMaster
Reorganize source code
1690290
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
Nate McMaster
Merge branch 'release/2.1' into release/2.2
0194014
Commit migrated from dotnet/extensions@18fcffb
Nate McMaster
Merge branch 'release/2.2'
814a3b0
Commit migrated from dotnet/extensions@34204b6
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
f240aca
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
5c3d7d7
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
4548ba5
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
Nate McMaster
Merge the source code from aspnet/DependencyInjection release/2.1
4ee3c9e
Commit migrated from dotnet/extensions@8b174f1
Nate McMaster
Merge branch 'release/2.1' into release/2.2
b7ccbb6
Commit migrated from dotnet/extensions@5b8b6c7
Nate McMaster
Merge branch 'release/2.2'
b52a855
Commit migrated from dotnet/extensions@3ba072c
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
2c88e33
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
Nate McMaster
Merge branch 'release/2.2'
d746978
Commit migrated from dotnet/extensions@f162f10
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
893cb96
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
Nate McMaster
Use the SharedSourceRoot variable in project files
14a2e29
Commit migrated from dotnet/extensions@888bcba
Nate McMaster
Merge the source code from aspnet/HttpClientFactory into this repo
d58cbe8
Commit migrated from dotnet/extensions@8fad574
Nate McMaster
Merge branch 'release/2.1' into release/2.2
7bc945d
Commit migrated from dotnet/extensions@63cde57
Nate McMaster
Merge branch 'release/2.2'
bfc6f92
This includes the master branch of aspnet/HttpClientFactory
Commit migrated from dotnet/extensions@557995e
@pakrym
Allow caching of IEnumerable services (dotnet/extensions#575)
0d0378b
Commit migrated from dotnet/extensions@c89a5b5
@pakrym
Reduce event source logger allocations (dotnet/extensions#870)
c7451bd
Commit migrated from dotnet/extensions@091ee13
@ryanbrandenburg
Use Arcade (dotnet/extensions#586)
89bed04
Use arcade
Commit migrated from dotnet/extensions@f045899
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
@benaadams@Tratcher
Shrink StringValues (dotnet/extensions#1283)
dd2d8d7
Commit migrated from dotnet/extensions@2f8e1fb
@natemcmaster
Disable transitive project references in test projects (dotnet/extens…
32e853b
…ions#1834)
Commit migrated from dotnet/extensions@e7d5bea
Ryan Nowak@rynowak
Fix HTTP client benchmarks
fc1df90
Commit migrated from dotnet/extensions@8f0f7fa
Ryan Nowak@rynowak
Add typed client creation benchmark
bdac559
Commit migrated from dotnet/extensions@20ce03a
John Luo
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0afd56b
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
@sharwell
Normalize all file headers to the expected Apache 2.0 license
c303731
Commit migrated from dotnet/extensions@cec6e75
@sharwell
Switch file headers to the MIT license
8ffa5b7
Commit migrated from dotnet/extensions@321a30c
@maryamariyan
Merge branch 'master' ofhttps://github.com/dotnet/performanceinto 4in1
4622cb5
@maryamariyan
Moves Microsoft.Extensions.* perf tests over
48ba3c4
@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Merged

@maryamariyan
Using the Open key to fully sign assembly
fe1da91
- Needed to later get InternalsVisibleTo on DI
adamsitnik
adamsitnik
requested changes
Jun 19, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryamariyan big thanks for porting all these benchmarks to the performance repo!
the porting itself looks very good, however, I have some comments related to the benchmarks themselves. Before we merge them we should make sure that they follow our guidelines
As soon as all suggestions are applied, I am going to merge this PR.
Once again big thanks for all the work @maryamariyan ! It took me a few hours to review it, I can imagine how long it took to actually port them!
Comment threadsrc/Directory.Build.props
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/LoggingOverheadBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/CreationOverheadBenchmark.cs
Outdated

@maryamariyan@adamsitnik
Apply suggestions from code review
32a0653
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@maryamariyan
maryamariyan
commented
Jun 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@adamsitnik ready for re-review.

Aside from comments #1362 (comment) and #1362 (comment), I applied the rest of them. Thanks for making it easy with those commit batch suggestions :)
adamsitnik
adamsitnik
approved these changes
Jun 23, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @maryamariyan !
Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

@adamsitnik
adamsitnik
commented
Jun 23, 2020•

edited

Loading

Copy link


Copy Markdown

Member
One of the CI legs failed with a really strange error:
 --------------------------------------------------
Building .NET micro benchmarks for 'netcoreapp5.0'
--------------------------------------------------
$ pushd "C:\h\w\AB6A0982\p\src\benchmarks\micro"
$ dotnet build C:\h\w\AB6A0982\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework netcoreapp5.0 --no-restore /p:NuGetPackageRoot=C:\h\w\AB6A0982\p\artifacts\packages
Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
Build FAILED.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
0 Warning(s)
1 Error(s)

I am going to re-run it.
Edit: I can see exactly same error in #1372 so it's not related to this PR
@adamsitnik
adamsitnik
merged commit 1a40f0f
into
dotnet:masterJun 23, 2020
@adamsitnikadamsitnik
mentioned this pull request
Jun 26, 2020
 Closed

1 task
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

+2 more reviewers

@davidfowldavidfowldavidfowl approved these changes
@JunTaoLuoJunTaoLuoJunTaoLuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@maryamariyan@adamsitnik@davidfowl@JunTaoLuo@pakrym@ryanbrandenburg@natemcmaster@benaadams@sharwell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Adds Microsoft.Extensions.* performance tests with history - #1362
Merged
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Jun 23, 2020
Merged
Adds Microsoft.Extensions.* performance tests with history#1362
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Conversation
@maryamariyan
@maryamariyanmaryamariyan
commented
Jun 17, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Nate McMasterand others
added 29 commits
October 30, 2018 14:18
Nate McMaster
Reorganize source code
1690290
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
Nate McMaster
Merge branch 'release/2.1' into release/2.2
0194014
Commit migrated from dotnet/extensions@18fcffb
Nate McMaster
Merge branch 'release/2.2'
814a3b0
Commit migrated from dotnet/extensions@34204b6
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
f240aca
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
5c3d7d7
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
4548ba5
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
Nate McMaster
Merge the source code from aspnet/DependencyInjection release/2.1
4ee3c9e
Commit migrated from dotnet/extensions@8b174f1
Nate McMaster
Merge branch 'release/2.1' into release/2.2
b7ccbb6
Commit migrated from dotnet/extensions@5b8b6c7
Nate McMaster
Merge branch 'release/2.2'
b52a855
Commit migrated from dotnet/extensions@3ba072c
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
2c88e33
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
Nate McMaster
Merge branch 'release/2.2'
d746978
Commit migrated from dotnet/extensions@f162f10
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
893cb96
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
Nate McMaster
Use the SharedSourceRoot variable in project files
14a2e29
Commit migrated from dotnet/extensions@888bcba
Nate McMaster
Merge the source code from aspnet/HttpClientFactory into this repo
d58cbe8
Commit migrated from dotnet/extensions@8fad574
Nate McMaster
Merge branch 'release/2.1' into release/2.2
7bc945d
Commit migrated from dotnet/extensions@63cde57
Nate McMaster
Merge branch 'release/2.2'
bfc6f92
This includes the master branch of aspnet/HttpClientFactory
Commit migrated from dotnet/extensions@557995e
@pakrym
Allow caching of IEnumerable services (dotnet/extensions#575)
0d0378b
Commit migrated from dotnet/extensions@c89a5b5
@pakrym
Reduce event source logger allocations (dotnet/extensions#870)
c7451bd
Commit migrated from dotnet/extensions@091ee13
@ryanbrandenburg
Use Arcade (dotnet/extensions#586)
89bed04
Use arcade
Commit migrated from dotnet/extensions@f045899
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
@benaadams@Tratcher
Shrink StringValues (dotnet/extensions#1283)
dd2d8d7
Commit migrated from dotnet/extensions@2f8e1fb
@natemcmaster
Disable transitive project references in test projects (dotnet/extens…
32e853b
…ions#1834)
Commit migrated from dotnet/extensions@e7d5bea
Ryan Nowak@rynowak
Fix HTTP client benchmarks
fc1df90
Commit migrated from dotnet/extensions@8f0f7fa
Ryan Nowak@rynowak
Add typed client creation benchmark
bdac559
Commit migrated from dotnet/extensions@20ce03a
John Luo
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0afd56b
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
@sharwell
Normalize all file headers to the expected Apache 2.0 license
c303731
Commit migrated from dotnet/extensions@cec6e75
@sharwell
Switch file headers to the MIT license
8ffa5b7
Commit migrated from dotnet/extensions@321a30c
@maryamariyan
Merge branch 'master' ofhttps://github.com/dotnet/performanceinto 4in1
4622cb5
@maryamariyan
Moves Microsoft.Extensions.* perf tests over
48ba3c4
@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Merged

@maryamariyan
Using the Open key to fully sign assembly
fe1da91
- Needed to later get InternalsVisibleTo on DI
adamsitnik
adamsitnik
requested changes
Jun 19, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryamariyan big thanks for porting all these benchmarks to the performance repo!
the porting itself looks very good, however, I have some comments related to the benchmarks themselves. Before we merge them we should make sure that they follow our guidelines
As soon as all suggestions are applied, I am going to merge this PR.
Once again big thanks for all the work @maryamariyan ! It took me a few hours to review it, I can imagine how long it took to actually port them!
Comment threadsrc/Directory.Build.props
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/LoggingOverheadBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/CreationOverheadBenchmark.cs
Outdated

@maryamariyan@adamsitnik
Apply suggestions from code review
32a0653
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@maryamariyan
maryamariyan
commented
Jun 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@adamsitnik ready for re-review.

Aside from comments #1362 (comment) and #1362 (comment), I applied the rest of them. Thanks for making it easy with those commit batch suggestions :)
adamsitnik
adamsitnik
approved these changes
Jun 23, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @maryamariyan !
Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

@adamsitnik
adamsitnik
commented
Jun 23, 2020•

edited

Loading

Copy link


Copy Markdown

Member
One of the CI legs failed with a really strange error:
 --------------------------------------------------
Building .NET micro benchmarks for 'netcoreapp5.0'
--------------------------------------------------
$ pushd "C:\h\w\AB6A0982\p\src\benchmarks\micro"
$ dotnet build C:\h\w\AB6A0982\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework netcoreapp5.0 --no-restore /p:NuGetPackageRoot=C:\h\w\AB6A0982\p\artifacts\packages
Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
Build FAILED.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
0 Warning(s)
1 Error(s)

I am going to re-run it.
Edit: I can see exactly same error in #1372 so it's not related to this PR
@adamsitnik
adamsitnik
merged commit 1a40f0f
into
dotnet:masterJun 23, 2020
@adamsitnikadamsitnik
mentioned this pull request
Jun 26, 2020
 Closed

1 task
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

+2 more reviewers

@davidfowldavidfowldavidfowl approved these changes
@JunTaoLuoJunTaoLuoJunTaoLuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@maryamariyan@adamsitnik@davidfowl@JunTaoLuo@pakrym@ryanbrandenburg@natemcmaster@benaadams@sharwell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Adds Microsoft.Extensions.* performance tests with history - #1362
Merged
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Jun 23, 2020
Merged
Adds Microsoft.Extensions.* performance tests with history#1362
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Conversation
@maryamariyan
@maryamariyanmaryamariyan
commented
Jun 17, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Nate McMasterand others
added 29 commits
October 30, 2018 14:18
Nate McMaster
Reorganize source code
1690290
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
Nate McMaster
Merge branch 'release/2.1' into release/2.2
0194014
Commit migrated from dotnet/extensions@18fcffb
Nate McMaster
Merge branch 'release/2.2'
814a3b0
Commit migrated from dotnet/extensions@34204b6
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
f240aca
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
5c3d7d7
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
4548ba5
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
Nate McMaster
Merge the source code from aspnet/DependencyInjection release/2.1
4ee3c9e
Commit migrated from dotnet/extensions@8b174f1
Nate McMaster
Merge branch 'release/2.1' into release/2.2
b7ccbb6
Commit migrated from dotnet/extensions@5b8b6c7
Nate McMaster
Merge branch 'release/2.2'
b52a855
Commit migrated from dotnet/extensions@3ba072c
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
2c88e33
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
Nate McMaster
Merge branch 'release/2.2'
d746978
Commit migrated from dotnet/extensions@f162f10
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
893cb96
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
Nate McMaster
Use the SharedSourceRoot variable in project files
14a2e29
Commit migrated from dotnet/extensions@888bcba
Nate McMaster
Merge the source code from aspnet/HttpClientFactory into this repo
d58cbe8
Commit migrated from dotnet/extensions@8fad574
Nate McMaster
Merge branch 'release/2.1' into release/2.2
7bc945d
Commit migrated from dotnet/extensions@63cde57
Nate McMaster
Merge branch 'release/2.2'
bfc6f92
This includes the master branch of aspnet/HttpClientFactory
Commit migrated from dotnet/extensions@557995e
@pakrym
Allow caching of IEnumerable services (dotnet/extensions#575)
0d0378b
Commit migrated from dotnet/extensions@c89a5b5
@pakrym
Reduce event source logger allocations (dotnet/extensions#870)
c7451bd
Commit migrated from dotnet/extensions@091ee13
@ryanbrandenburg
Use Arcade (dotnet/extensions#586)
89bed04
Use arcade
Commit migrated from dotnet/extensions@f045899
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
@benaadams@Tratcher
Shrink StringValues (dotnet/extensions#1283)
dd2d8d7
Commit migrated from dotnet/extensions@2f8e1fb
@natemcmaster
Disable transitive project references in test projects (dotnet/extens…
32e853b
…ions#1834)
Commit migrated from dotnet/extensions@e7d5bea
Ryan Nowak@rynowak
Fix HTTP client benchmarks
fc1df90
Commit migrated from dotnet/extensions@8f0f7fa
Ryan Nowak@rynowak
Add typed client creation benchmark
bdac559
Commit migrated from dotnet/extensions@20ce03a
John Luo
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0afd56b
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
@sharwell
Normalize all file headers to the expected Apache 2.0 license
c303731
Commit migrated from dotnet/extensions@cec6e75
@sharwell
Switch file headers to the MIT license
8ffa5b7
Commit migrated from dotnet/extensions@321a30c
@maryamariyan
Merge branch 'master' ofhttps://github.com/dotnet/performanceinto 4in1
4622cb5
@maryamariyan
Moves Microsoft.Extensions.* perf tests over
48ba3c4
@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Merged

@maryamariyan
Using the Open key to fully sign assembly
fe1da91
- Needed to later get InternalsVisibleTo on DI
adamsitnik
adamsitnik
requested changes
Jun 19, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryamariyan big thanks for porting all these benchmarks to the performance repo!
the porting itself looks very good, however, I have some comments related to the benchmarks themselves. Before we merge them we should make sure that they follow our guidelines
As soon as all suggestions are applied, I am going to merge this PR.
Once again big thanks for all the work @maryamariyan ! It took me a few hours to review it, I can imagine how long it took to actually port them!
Comment threadsrc/Directory.Build.props
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/LoggingOverheadBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/CreationOverheadBenchmark.cs
Outdated

@maryamariyan@adamsitnik
Apply suggestions from code review
32a0653
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@maryamariyan
maryamariyan
commented
Jun 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@adamsitnik ready for re-review.

Aside from comments #1362 (comment) and #1362 (comment), I applied the rest of them. Thanks for making it easy with those commit batch suggestions :)
adamsitnik
adamsitnik
approved these changes
Jun 23, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @maryamariyan !
Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

@adamsitnik
adamsitnik
commented
Jun 23, 2020•

edited

Loading

Copy link


Copy Markdown

Member
One of the CI legs failed with a really strange error:
 --------------------------------------------------
Building .NET micro benchmarks for 'netcoreapp5.0'
--------------------------------------------------
$ pushd "C:\h\w\AB6A0982\p\src\benchmarks\micro"
$ dotnet build C:\h\w\AB6A0982\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework netcoreapp5.0 --no-restore /p:NuGetPackageRoot=C:\h\w\AB6A0982\p\artifacts\packages
Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
Build FAILED.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
0 Warning(s)
1 Error(s)

I am going to re-run it.
Edit: I can see exactly same error in #1372 so it's not related to this PR
@adamsitnik
adamsitnik
merged commit 1a40f0f
into
dotnet:masterJun 23, 2020
@adamsitnikadamsitnik
mentioned this pull request
Jun 26, 2020
 Closed

1 task
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

+2 more reviewers

@davidfowldavidfowldavidfowl approved these changes
@JunTaoLuoJunTaoLuoJunTaoLuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@maryamariyan@adamsitnik@davidfowl@JunTaoLuo@pakrym@ryanbrandenburg@natemcmaster@benaadams@sharwell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Adds Microsoft.Extensions.* performance tests with history - #1362
Merged
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Jun 23, 2020
Merged
Adds Microsoft.Extensions.* performance tests with history#1362
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Conversation
@maryamariyan
@maryamariyanmaryamariyan
commented
Jun 17, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Nate McMasterand others
added 29 commits
October 30, 2018 14:18
Nate McMaster
Reorganize source code
1690290
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
Nate McMaster
Merge branch 'release/2.1' into release/2.2
0194014
Commit migrated from dotnet/extensions@18fcffb
Nate McMaster
Merge branch 'release/2.2'
814a3b0
Commit migrated from dotnet/extensions@34204b6
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
f240aca
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
5c3d7d7
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
4548ba5
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
Nate McMaster
Merge the source code from aspnet/DependencyInjection release/2.1
4ee3c9e
Commit migrated from dotnet/extensions@8b174f1
Nate McMaster
Merge branch 'release/2.1' into release/2.2
b7ccbb6
Commit migrated from dotnet/extensions@5b8b6c7
Nate McMaster
Merge branch 'release/2.2'
b52a855
Commit migrated from dotnet/extensions@3ba072c
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
2c88e33
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
Nate McMaster
Merge branch 'release/2.2'
d746978
Commit migrated from dotnet/extensions@f162f10
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
893cb96
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
Nate McMaster
Use the SharedSourceRoot variable in project files
14a2e29
Commit migrated from dotnet/extensions@888bcba
Nate McMaster
Merge the source code from aspnet/HttpClientFactory into this repo
d58cbe8
Commit migrated from dotnet/extensions@8fad574
Nate McMaster
Merge branch 'release/2.1' into release/2.2
7bc945d
Commit migrated from dotnet/extensions@63cde57
Nate McMaster
Merge branch 'release/2.2'
bfc6f92
This includes the master branch of aspnet/HttpClientFactory
Commit migrated from dotnet/extensions@557995e
@pakrym
Allow caching of IEnumerable services (dotnet/extensions#575)
0d0378b
Commit migrated from dotnet/extensions@c89a5b5
@pakrym
Reduce event source logger allocations (dotnet/extensions#870)
c7451bd
Commit migrated from dotnet/extensions@091ee13
@ryanbrandenburg
Use Arcade (dotnet/extensions#586)
89bed04
Use arcade
Commit migrated from dotnet/extensions@f045899
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
@benaadams@Tratcher
Shrink StringValues (dotnet/extensions#1283)
dd2d8d7
Commit migrated from dotnet/extensions@2f8e1fb
@natemcmaster
Disable transitive project references in test projects (dotnet/extens…
32e853b
…ions#1834)
Commit migrated from dotnet/extensions@e7d5bea
Ryan Nowak@rynowak
Fix HTTP client benchmarks
fc1df90
Commit migrated from dotnet/extensions@8f0f7fa
Ryan Nowak@rynowak
Add typed client creation benchmark
bdac559
Commit migrated from dotnet/extensions@20ce03a
John Luo
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0afd56b
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
@sharwell
Normalize all file headers to the expected Apache 2.0 license
c303731
Commit migrated from dotnet/extensions@cec6e75
@sharwell
Switch file headers to the MIT license
8ffa5b7
Commit migrated from dotnet/extensions@321a30c
@maryamariyan
Merge branch 'master' ofhttps://github.com/dotnet/performanceinto 4in1
4622cb5
@maryamariyan
Moves Microsoft.Extensions.* perf tests over
48ba3c4
@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Merged

@maryamariyan
Using the Open key to fully sign assembly
fe1da91
- Needed to later get InternalsVisibleTo on DI
adamsitnik
adamsitnik
requested changes
Jun 19, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryamariyan big thanks for porting all these benchmarks to the performance repo!
the porting itself looks very good, however, I have some comments related to the benchmarks themselves. Before we merge them we should make sure that they follow our guidelines
As soon as all suggestions are applied, I am going to merge this PR.
Once again big thanks for all the work @maryamariyan ! It took me a few hours to review it, I can imagine how long it took to actually port them!
Comment threadsrc/Directory.Build.props
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/LoggingOverheadBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/CreationOverheadBenchmark.cs
Outdated

@maryamariyan@adamsitnik
Apply suggestions from code review
32a0653
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@maryamariyan
maryamariyan
commented
Jun 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@adamsitnik ready for re-review.

Aside from comments #1362 (comment) and #1362 (comment), I applied the rest of them. Thanks for making it easy with those commit batch suggestions :)
adamsitnik
adamsitnik
approved these changes
Jun 23, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @maryamariyan !
Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

@adamsitnik
adamsitnik
commented
Jun 23, 2020•

edited

Loading

Copy link


Copy Markdown

Member
One of the CI legs failed with a really strange error:
 --------------------------------------------------
Building .NET micro benchmarks for 'netcoreapp5.0'
--------------------------------------------------
$ pushd "C:\h\w\AB6A0982\p\src\benchmarks\micro"
$ dotnet build C:\h\w\AB6A0982\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework netcoreapp5.0 --no-restore /p:NuGetPackageRoot=C:\h\w\AB6A0982\p\artifacts\packages
Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
Build FAILED.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
0 Warning(s)
1 Error(s)

I am going to re-run it.
Edit: I can see exactly same error in #1372 so it's not related to this PR
@adamsitnik
adamsitnik
merged commit 1a40f0f
into
dotnet:masterJun 23, 2020
@adamsitnikadamsitnik
mentioned this pull request
Jun 26, 2020
 Closed

1 task
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

+2 more reviewers

@davidfowldavidfowldavidfowl approved these changes
@JunTaoLuoJunTaoLuoJunTaoLuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@maryamariyan@adamsitnik@davidfowl@JunTaoLuo@pakrym@ryanbrandenburg@natemcmaster@benaadams@sharwell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Adds Microsoft.Extensions.* performance tests with history - #1362
Merged
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Jun 23, 2020
Merged
Adds Microsoft.Extensions.* performance tests with history#1362
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Conversation
@maryamariyan
@maryamariyanmaryamariyan
commented
Jun 17, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Nate McMasterand others
added 29 commits
October 30, 2018 14:18
Nate McMaster
Reorganize source code
1690290
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
Nate McMaster
Merge branch 'release/2.1' into release/2.2
0194014
Commit migrated from dotnet/extensions@18fcffb
Nate McMaster
Merge branch 'release/2.2'
814a3b0
Commit migrated from dotnet/extensions@34204b6
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
f240aca
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
5c3d7d7
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
4548ba5
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
Nate McMaster
Merge the source code from aspnet/DependencyInjection release/2.1
4ee3c9e
Commit migrated from dotnet/extensions@8b174f1
Nate McMaster
Merge branch 'release/2.1' into release/2.2
b7ccbb6
Commit migrated from dotnet/extensions@5b8b6c7
Nate McMaster
Merge branch 'release/2.2'
b52a855
Commit migrated from dotnet/extensions@3ba072c
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
2c88e33
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
Nate McMaster
Merge branch 'release/2.2'
d746978
Commit migrated from dotnet/extensions@f162f10
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
893cb96
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
Nate McMaster
Use the SharedSourceRoot variable in project files
14a2e29
Commit migrated from dotnet/extensions@888bcba
Nate McMaster
Merge the source code from aspnet/HttpClientFactory into this repo
d58cbe8
Commit migrated from dotnet/extensions@8fad574
Nate McMaster
Merge branch 'release/2.1' into release/2.2
7bc945d
Commit migrated from dotnet/extensions@63cde57
Nate McMaster
Merge branch 'release/2.2'
bfc6f92
This includes the master branch of aspnet/HttpClientFactory
Commit migrated from dotnet/extensions@557995e
@pakrym
Allow caching of IEnumerable services (dotnet/extensions#575)
0d0378b
Commit migrated from dotnet/extensions@c89a5b5
@pakrym
Reduce event source logger allocations (dotnet/extensions#870)
c7451bd
Commit migrated from dotnet/extensions@091ee13
@ryanbrandenburg
Use Arcade (dotnet/extensions#586)
89bed04
Use arcade
Commit migrated from dotnet/extensions@f045899
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
@benaadams@Tratcher
Shrink StringValues (dotnet/extensions#1283)
dd2d8d7
Commit migrated from dotnet/extensions@2f8e1fb
@natemcmaster
Disable transitive project references in test projects (dotnet/extens…
32e853b
…ions#1834)
Commit migrated from dotnet/extensions@e7d5bea
Ryan Nowak@rynowak
Fix HTTP client benchmarks
fc1df90
Commit migrated from dotnet/extensions@8f0f7fa
Ryan Nowak@rynowak
Add typed client creation benchmark
bdac559
Commit migrated from dotnet/extensions@20ce03a
John Luo
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0afd56b
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
@sharwell
Normalize all file headers to the expected Apache 2.0 license
c303731
Commit migrated from dotnet/extensions@cec6e75
@sharwell
Switch file headers to the MIT license
8ffa5b7
Commit migrated from dotnet/extensions@321a30c
@maryamariyan
Merge branch 'master' ofhttps://github.com/dotnet/performanceinto 4in1
4622cb5
@maryamariyan
Moves Microsoft.Extensions.* perf tests over
48ba3c4
@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Merged

@maryamariyan
Using the Open key to fully sign assembly
fe1da91
- Needed to later get InternalsVisibleTo on DI
adamsitnik
adamsitnik
requested changes
Jun 19, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryamariyan big thanks for porting all these benchmarks to the performance repo!
the porting itself looks very good, however, I have some comments related to the benchmarks themselves. Before we merge them we should make sure that they follow our guidelines
As soon as all suggestions are applied, I am going to merge this PR.
Once again big thanks for all the work @maryamariyan ! It took me a few hours to review it, I can imagine how long it took to actually port them!
Comment threadsrc/Directory.Build.props
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/LoggingOverheadBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/CreationOverheadBenchmark.cs
Outdated

@maryamariyan@adamsitnik
Apply suggestions from code review
32a0653
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@maryamariyan
maryamariyan
commented
Jun 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@adamsitnik ready for re-review.

Aside from comments #1362 (comment) and #1362 (comment), I applied the rest of them. Thanks for making it easy with those commit batch suggestions :)
adamsitnik
adamsitnik
approved these changes
Jun 23, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @maryamariyan !
Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

@adamsitnik
adamsitnik
commented
Jun 23, 2020•

edited

Loading

Copy link


Copy Markdown

Member
One of the CI legs failed with a really strange error:
 --------------------------------------------------
Building .NET micro benchmarks for 'netcoreapp5.0'
--------------------------------------------------
$ pushd "C:\h\w\AB6A0982\p\src\benchmarks\micro"
$ dotnet build C:\h\w\AB6A0982\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework netcoreapp5.0 --no-restore /p:NuGetPackageRoot=C:\h\w\AB6A0982\p\artifacts\packages
Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
Build FAILED.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
0 Warning(s)
1 Error(s)

I am going to re-run it.
Edit: I can see exactly same error in #1372 so it's not related to this PR
@adamsitnik
adamsitnik
merged commit 1a40f0f
into
dotnet:masterJun 23, 2020
@adamsitnikadamsitnik
mentioned this pull request
Jun 26, 2020
 Closed

1 task
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

+2 more reviewers

@davidfowldavidfowldavidfowl approved these changes
@JunTaoLuoJunTaoLuoJunTaoLuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@maryamariyan@adamsitnik@davidfowl@JunTaoLuo@pakrym@ryanbrandenburg@natemcmaster@benaadams@sharwell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Adds Microsoft.Extensions.* performance tests with history - #1362
Merged
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Jun 23, 2020
Merged
Adds Microsoft.Extensions.* performance tests with history#1362
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Conversation
@maryamariyan
@maryamariyanmaryamariyan
commented
Jun 17, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Nate McMasterand others
added 29 commits
October 30, 2018 14:18
Nate McMaster
Reorganize source code
1690290
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
Nate McMaster
Merge branch 'release/2.1' into release/2.2
0194014
Commit migrated from dotnet/extensions@18fcffb
Nate McMaster
Merge branch 'release/2.2'
814a3b0
Commit migrated from dotnet/extensions@34204b6
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
f240aca
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
5c3d7d7
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
4548ba5
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
Nate McMaster
Merge the source code from aspnet/DependencyInjection release/2.1
4ee3c9e
Commit migrated from dotnet/extensions@8b174f1
Nate McMaster
Merge branch 'release/2.1' into release/2.2
b7ccbb6
Commit migrated from dotnet/extensions@5b8b6c7
Nate McMaster
Merge branch 'release/2.2'
b52a855
Commit migrated from dotnet/extensions@3ba072c
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
2c88e33
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
Nate McMaster
Merge branch 'release/2.2'
d746978
Commit migrated from dotnet/extensions@f162f10
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
893cb96
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
Nate McMaster
Use the SharedSourceRoot variable in project files
14a2e29
Commit migrated from dotnet/extensions@888bcba
Nate McMaster
Merge the source code from aspnet/HttpClientFactory into this repo
d58cbe8
Commit migrated from dotnet/extensions@8fad574
Nate McMaster
Merge branch 'release/2.1' into release/2.2
7bc945d
Commit migrated from dotnet/extensions@63cde57
Nate McMaster
Merge branch 'release/2.2'
bfc6f92
This includes the master branch of aspnet/HttpClientFactory
Commit migrated from dotnet/extensions@557995e
@pakrym
Allow caching of IEnumerable services (dotnet/extensions#575)
0d0378b
Commit migrated from dotnet/extensions@c89a5b5
@pakrym
Reduce event source logger allocations (dotnet/extensions#870)
c7451bd
Commit migrated from dotnet/extensions@091ee13
@ryanbrandenburg
Use Arcade (dotnet/extensions#586)
89bed04
Use arcade
Commit migrated from dotnet/extensions@f045899
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
@benaadams@Tratcher
Shrink StringValues (dotnet/extensions#1283)
dd2d8d7
Commit migrated from dotnet/extensions@2f8e1fb
@natemcmaster
Disable transitive project references in test projects (dotnet/extens…
32e853b
…ions#1834)
Commit migrated from dotnet/extensions@e7d5bea
Ryan Nowak@rynowak
Fix HTTP client benchmarks
fc1df90
Commit migrated from dotnet/extensions@8f0f7fa
Ryan Nowak@rynowak
Add typed client creation benchmark
bdac559
Commit migrated from dotnet/extensions@20ce03a
John Luo
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0afd56b
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
@sharwell
Normalize all file headers to the expected Apache 2.0 license
c303731
Commit migrated from dotnet/extensions@cec6e75
@sharwell
Switch file headers to the MIT license
8ffa5b7
Commit migrated from dotnet/extensions@321a30c
@maryamariyan
Merge branch 'master' ofhttps://github.com/dotnet/performanceinto 4in1
4622cb5
@maryamariyan
Moves Microsoft.Extensions.* perf tests over
48ba3c4
@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Merged

@maryamariyan
Using the Open key to fully sign assembly
fe1da91
- Needed to later get InternalsVisibleTo on DI
adamsitnik
adamsitnik
requested changes
Jun 19, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryamariyan big thanks for porting all these benchmarks to the performance repo!
the porting itself looks very good, however, I have some comments related to the benchmarks themselves. Before we merge them we should make sure that they follow our guidelines
As soon as all suggestions are applied, I am going to merge this PR.
Once again big thanks for all the work @maryamariyan ! It took me a few hours to review it, I can imagine how long it took to actually port them!
Comment threadsrc/Directory.Build.props
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/LoggingOverheadBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/CreationOverheadBenchmark.cs
Outdated

@maryamariyan@adamsitnik
Apply suggestions from code review
32a0653
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@maryamariyan
maryamariyan
commented
Jun 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@adamsitnik ready for re-review.

Aside from comments #1362 (comment) and #1362 (comment), I applied the rest of them. Thanks for making it easy with those commit batch suggestions :)
adamsitnik
adamsitnik
approved these changes
Jun 23, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @maryamariyan !
Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

@adamsitnik
adamsitnik
commented
Jun 23, 2020•

edited

Loading

Copy link


Copy Markdown

Member
One of the CI legs failed with a really strange error:
 --------------------------------------------------
Building .NET micro benchmarks for 'netcoreapp5.0'
--------------------------------------------------
$ pushd "C:\h\w\AB6A0982\p\src\benchmarks\micro"
$ dotnet build C:\h\w\AB6A0982\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework netcoreapp5.0 --no-restore /p:NuGetPackageRoot=C:\h\w\AB6A0982\p\artifacts\packages
Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
Build FAILED.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
0 Warning(s)
1 Error(s)

I am going to re-run it.
Edit: I can see exactly same error in #1372 so it's not related to this PR
@adamsitnik
adamsitnik
merged commit 1a40f0f
into
dotnet:masterJun 23, 2020
@adamsitnikadamsitnik
mentioned this pull request
Jun 26, 2020
 Closed

1 task
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

+2 more reviewers

@davidfowldavidfowldavidfowl approved these changes
@JunTaoLuoJunTaoLuoJunTaoLuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@maryamariyan@adamsitnik@davidfowl@JunTaoLuo@pakrym@ryanbrandenburg@natemcmaster@benaadams@sharwell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Adds Microsoft.Extensions.* performance tests with history - #1362
Merged
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Jun 23, 2020
Merged
Adds Microsoft.Extensions.* performance tests with history#1362
adamsitnik merged 33 commits into
dotnet:masterfrom 
maryamariyan:complete-perf
Conversation
@maryamariyan
@maryamariyanmaryamariyan
commented
Jun 17, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Nate McMasterand others
added 29 commits
October 30, 2018 14:18
Nate McMaster
Reorganize source code
1690290
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.
Commit migrated from dotnet/extensions@7ce647c
Nate McMaster
Merge branch 'release/2.1' into release/2.2
0194014
Commit migrated from dotnet/extensions@18fcffb
Nate McMaster
Merge branch 'release/2.2'
814a3b0
Commit migrated from dotnet/extensions@34204b6
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
f240aca
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96
Commit migrated from dotnet/extensions@689c4a8
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
5c3d7d7
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee
Commit migrated from dotnet/extensions@04e957b
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
4548ba5
Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185
Commit migrated from dotnet/extensions@9a4c61b
Nate McMaster
Merge the source code from aspnet/DependencyInjection release/2.1
4ee3c9e
Commit migrated from dotnet/extensions@8b174f1
Nate McMaster
Merge branch 'release/2.1' into release/2.2
b7ccbb6
Commit migrated from dotnet/extensions@5b8b6c7
Nate McMaster
Merge branch 'release/2.2'
b52a855
Commit migrated from dotnet/extensions@3ba072c
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
2c88e33
Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d
Commit migrated from dotnet/extensions@f3cd14a
Nate McMaster
Merge branch 'release/2.2'
d746978
Commit migrated from dotnet/extensions@f162f10
Nate McMaster
Reorganize source code in preparation to move into aspnet/Extensions
893cb96
Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7
Commit migrated from dotnet/extensions@c38f9c1
Nate McMaster
Use the SharedSourceRoot variable in project files
14a2e29
Commit migrated from dotnet/extensions@888bcba
Nate McMaster
Merge the source code from aspnet/HttpClientFactory into this repo
d58cbe8
Commit migrated from dotnet/extensions@8fad574
Nate McMaster
Merge branch 'release/2.1' into release/2.2
7bc945d
Commit migrated from dotnet/extensions@63cde57
Nate McMaster
Merge branch 'release/2.2'
bfc6f92
This includes the master branch of aspnet/HttpClientFactory
Commit migrated from dotnet/extensions@557995e
@pakrym
Allow caching of IEnumerable services (dotnet/extensions#575)
0d0378b
Commit migrated from dotnet/extensions@c89a5b5
@pakrym
Reduce event source logger allocations (dotnet/extensions#870)
c7451bd
Commit migrated from dotnet/extensions@091ee13
@ryanbrandenburg
Use Arcade (dotnet/extensions#586)
89bed04
Use arcade
Commit migrated from dotnet/extensions@f045899
@natemcmaster
Cleanup conversion to Arcade (dotnet/extensions#1014)
242f3a1
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel
Commit migrated from dotnet/extensions@f41cfde
@benaadams@Tratcher
Shrink StringValues (dotnet/extensions#1283)
dd2d8d7
Commit migrated from dotnet/extensions@2f8e1fb
@natemcmaster
Disable transitive project references in test projects (dotnet/extens…
32e853b
…ions#1834)
Commit migrated from dotnet/extensions@e7d5bea
Ryan Nowak@rynowak
Fix HTTP client benchmarks
fc1df90
Commit migrated from dotnet/extensions@8f0f7fa
Ryan Nowak@rynowak
Add typed client creation benchmark
bdac559
Commit migrated from dotnet/extensions@20ce03a
John Luo
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0afd56b
* Support netcoreapp3.1 TFM
* Unpin SDK for source build
* Update to preview1 branding
Commit migrated from dotnet/extensions@32cc816
@sharwell
Normalize all file headers to the expected Apache 2.0 license
c303731
Commit migrated from dotnet/extensions@cec6e75
@sharwell
Switch file headers to the MIT license
8ffa5b7
Commit migrated from dotnet/extensions@321a30c
@maryamariyan
Merge branch 'master' ofhttps://github.com/dotnet/performanceinto 4in1
4622cb5
@maryamariyan
Moves Microsoft.Extensions.* perf tests over
48ba3c4
@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Closed

@maryamariyanmaryamariyan
mentioned this pull request
Jun 17, 2020
 Merged

@maryamariyan
Using the Open key to fully sign assembly
fe1da91
- Needed to later get InternalsVisibleTo on DI
adamsitnik
adamsitnik
requested changes
Jun 19, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryamariyan big thanks for porting all these benchmarks to the performance repo!
the porting itself looks very good, however, I have some comments related to the benchmarks themselves. Before we merge them we should make sure that they follow our guidelines
As soon as all suggestions are applied, I am going to merge this PR.
Once again big thanks for all the work @maryamariyan ! It took me a few hours to review it, I can imagine how long it took to actually port them!
Comment threadsrc/Directory.Build.props
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment thread...arks/micro/libraries/Microsoft.Extensions.DependencyInjection/ActivatorUtilitiesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Primitives/StringValuesBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/LoggingOverheadBenchmark.cs
Outdated

Comment threadsrc/benchmarks/micro/libraries/Microsoft.Extensions.Http/CreationOverheadBenchmark.cs
Outdated

@maryamariyan@adamsitnik
Apply suggestions from code review
32a0653
Make batch commit using suggestions in PR feedback
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@maryamariyan
maryamariyan
commented
Jun 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@adamsitnik ready for re-review.

Aside from comments #1362 (comment) and #1362 (comment), I applied the rest of them. Thanks for making it easy with those commit batch suggestions :)
adamsitnik
adamsitnik
approved these changes
Jun 23, 2020
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @maryamariyan !
Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

Comment thread...s/micro/libraries/Microsoft.Extensions.DependencyInjection/ServiceProviderEngineBenchmark.cs
Outdated

@adamsitnik
adamsitnik
commented
Jun 23, 2020•

edited

Loading

Copy link


Copy Markdown

Member
One of the CI legs failed with a really strange error:
 --------------------------------------------------
Building .NET micro benchmarks for 'netcoreapp5.0'
--------------------------------------------------
$ pushd "C:\h\w\AB6A0982\p\src\benchmarks\micro"
$ dotnet build C:\h\w\AB6A0982\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework netcoreapp5.0 --no-restore /p:NuGetPackageRoot=C:\h\w\AB6A0982\p\artifacts\packages
Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
Build FAILED.
C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
0 Warning(s)
1 Error(s)

I am going to re-run it.
Edit: I can see exactly same error in #1372 so it's not related to this PR
@adamsitnik
adamsitnik
merged commit 1a40f0f
into
dotnet:masterJun 23, 2020
@adamsitnikadamsitnik
mentioned this pull request
Jun 26, 2020
 Closed

1 task
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

+2 more reviewers

@davidfowldavidfowldavidfowl approved these changes
@JunTaoLuoJunTaoLuoJunTaoLuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@maryamariyan@adamsitnik@davidfowl@JunTaoLuo@pakrym@ryanbrandenburg@natemcmaster@benaadams@sharwell