WIP: Create a FAKE Build by forki · Pull Request #15 · dotnet/fsharp

forki · 2015-01-14T10:58:05Z

Orignally posted as https://visualfsharp.codeplex.com/SourceControl/network/forks/forki/fsharp/contribution/7167

I took @jack-pappas excellent work at https://visualfsharp.codeplex.com/SourceControl/network/forks/jackpappas/fsharpcontrib/contribution/7155 and converted it into a basic FAKE script.

It also contains fixes by @KevinRansom

In order to test it run build.cmd as administrator. It then will download FAKE and run the build.fsx.

Also solves things like: #3

I will try to rebase this and check if it still works.

forki · 2015-01-14T11:10:52Z

rebased on fsharp4

forki · 2015-01-18T18:33:15Z

I activated AppVeyor for my fork: https://ci.appveyor.com/project/SteffenForkmann/visualfsharp let's see how this works. (see also #53)

jack-pappas · 2015-01-19T16:12:32Z

This is great work, Steffen. I see the AppVeyor build completed successfully; is there any other work that needs to be done before merging this into the master or fsharp4 branch? Anything the community can assist with?

forki · 2015-01-19T16:14:45Z

From my point of view: the DEVGUIDE and TESTGUIDE needs to be rewritten.

brodyberg · 2015-01-19T18:52:55Z

@forki Agree x1000 on devguide, added issue: #64

brodyberg · 2015-01-20T04:28:48Z

Why the administrator requirement?

forki · 2015-01-20T07:31:12Z

https://github.com/Microsoft/visualfsharp/pull/15/files#diff-6074983490330a0aac1bd23c958232d7R57

https://github.com/Microsoft/visualfsharp/pull/15/files#diff-6074983490330a0aac1bd23c958232d7R173

forki · 2015-01-20T08:08:03Z

I set up a Travis build and will try to move things a bit forward. https://travis-ci.org/forki/visualfsharp

forki · 2015-01-20T08:54:22Z

Ok now I get:

 gacutil /i "lkg/FSharp-2.0.50726.900/bin/FSharp.Core.dll"
Failure adding assembly lkg/FSharp-2.0.50726.900/bin/FSharp.Core.dll to the cache: gac directories could not be created, possibly permission issues.

Question is: do we really need this GACed for CI?

dsyme · 2015-01-20T12:33:26Z

I suspect not, though it's possible you may need a new binding redirect for one of the LKG tools if you don't have this

latkin · 2015-01-20T17:16:28Z

As it stands, yes you need that GACed or the powerpack tools won't run.

However, I have a change internally that removes the requirement for GACing FSharp.Core 2.0.50726.900, just need to get it checked in and that particular problem will go away.

Though adding fresh-built bits to the GAC, and NGen-ing them, will still be required to run tests. So these permissions issues still need to be resolved.

dsyme · 2015-01-21T13:13:38Z

@latkin @KevinRansom - Could we have a new label "Engineering Improvement" or something like that for this kind of issue and/or pull request? (I suggest that all PRs and issues to have at least one label)

latkin · 2015-01-21T18:08:26Z

Have created the "infrastructure" label.

enricosada · 2015-01-23T00:56:08Z

removed file tests\fsharpqa\testenv\bin\x86\diff.exe is used by tests\fsharp test suite

Dont delete tests\fsharpqa\testenv\bin\ files, are used by 'test/fsharp' test suites ( dont know 'tests/fsharpqa' status, i'll check ).

forki · 2015-01-25T10:56:15Z

thanks. I restored the files.

dungpa · 2015-01-28T09:12:27Z

👍

…ript that builds the main F# projects (compiler and core library).

KevinRansom · 2015-03-17T00:28:40Z

I think the appveyorcmd.bat, does a decent job of wrapping up the build. It seems as if this is not really going anywhere.

Kevin

toComposer

abstract over isMono stuff to alter toolPath by passing a function

- Add Absolute Rule dotnet#15: never push to a PR just to update from main. - Step 4 uses 'git merge-tree --write-tree' as a pre-check; if no conflicts, do nothing (no merge, no push, no comment). Only conflicted PRs trigger an actual merge + resolve + push. - Clean-mergeable PRs are left for the author to handle, avoiding a forced CI restart on every opt-in PR every 3h. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…t-plan Correctness (blocking back-compat regression): moreConcreteRule (#13, preview) ran before nullableOptionalInteropRule (#14, F#5.0 default-on) and propertyOverrideRule (#15, always-on). A resolution those default-on rules settle could be silently re-decided by #13 under preview -> overload+result-type flip. Move moreConcreteRule to the END of allTiebreakRules so it only breaks ties nothing else resolved (its intended FS0041 case). Pre-dates Phase 6 (also hit generic methods); Phase 6 widened its reach to ctors/generic-type members. Reuse: paramsMentionComparableTypeVar now takes ParamData list and uses the plural freeInTypesLeftToRight instead of List.exists over the singular walk. Compactness: shared private paramDataType accessor replaces three inlined ParamData(...) destructurings across moreConcreteRule and the FS0041 explainer. Test-plan: delete two facts that duplicated matrix rows; add instance-method-generic-type matrix row; add ORPA-beats-concreteness guard and two back-compat guards proving a later shipped rule still decides successful resolutions (static + ctor). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

forki force-pushed the Build branch from a3adf6c to 515ebc0Compare January 14, 2015 11:10

forki force-pushed the Build branch from 01eb1e0 to 1210359Compare January 15, 2015 11:44

This was referenced Jan 15, 2015
Extension for property initializers #17
Closed
Publish "F# Tools For Visual Studio 2015 Preview" releases on GitHub releases #20
Closed

sergey-tihon mentioned this pull request Jan 16, 2015
Add issue stats #25
Closed

forki force-pushed the Build branch 2 times, most recently from 9280f04 to 87a2f9fCompare January 18, 2015 09:23

dungpa mentioned this pull request Jan 18, 2015
Set up a public CI for the project #53
Closed

jack-pappas mentioned this pull request Jan 19, 2015
Optimizations for UniqueStampGenerator and MemoizationTable #62
Closed

forki force-pushed the Build branch from eec4ceb to 75aac8dCompare January 20, 2015 08:07

forki force-pushed the Build branch 3 times, most recently from b3270a1 to 567cdd9Compare January 20, 2015 08:48

forki force-pushed the Build branch from 567cdd9 to 81ec7a6Compare January 21, 2015 08:24

latkin added the infrastructure label Jan 21, 2015

forki force-pushed the Build branch from 81ec7a6 to ecf7e78Compare January 22, 2015 09:16

forki mentioned this pull request Jan 23, 2015
Migrate Cambridge test suite (tests/fsharp) runner to NUnit #90
Merged
11 tasks

forki force-pushed the Build branch from ecf7e78 to 3c489bcCompare January 25, 2015 10:56

forki force-pushed the Build branch from 3c489bc to ccb0480Compare January 28, 2015 08:24

forki force-pushed the Build branch 2 times, most recently from c680574 to 32926d5Compare January 30, 2015 10:07

jackpappasand others added 3 commits January 30, 2015 11:08

Replaced src/update.cmd with an F# script. Implemented an F# build sc…
45b88fc
…ript that builds the main F# projects (compiler and core library).

Replaced tests/BuildTestTools.cmd with tests/BuildTestTools.fsx.
e588e8c

Use NuGet, FAKE for a single build script
d945b2a

forki force-pushed the Build branch from 32926d5 to d945b2aCompare January 30, 2015 10:08

enricosada mentioned this pull request Feb 25, 2015
Fix bugs or add features? #265
Closed

KevinRansom closed this Mar 17, 2015

liboz pushed a commit to liboz/visualfsharp that referenced this pull request Oct 20, 2016
Merge pull requestdotnet#15from liboz/manofstick
2a6db25
toComposer

smoothdeveloper pushed a commit to smoothdeveloper/visualfsharp that referenced this pull request Feb 26, 2017
Merge pull requestdotnet#15from smoothdeveloper/paket-extract-ismono
3728a45
abstract over isMono stuff to alter toolPath by passing a function

nojaf added a commit to nojaf/fsharp that referenced this pull request Nov 1, 2023
Find all transitive dependent files. (dotnet#15)
eb382c6

Uh oh!

Conversation

forki commented Jan 14, 2015

Uh oh!

forki commented Jan 14, 2015

Uh oh!

forki commented Jan 18, 2015

Uh oh!

jack-pappas commented Jan 19, 2015

Uh oh!

forki commented Jan 19, 2015

Uh oh!

brodyberg commented Jan 19, 2015

Uh oh!

brodyberg commented Jan 20, 2015

Uh oh!

forki commented Jan 20, 2015

Uh oh!

forki commented Jan 20, 2015

Uh oh!

forki commented Jan 20, 2015

Uh oh!

dsyme commented Jan 20, 2015

Uh oh!

latkin commented Jan 20, 2015

Uh oh!

dsyme commented Jan 21, 2015

Uh oh!

latkin commented Jan 21, 2015

Uh oh!

enricosada commented Jan 23, 2015

Uh oh!

forki commented Jan 25, 2015

Uh oh!

dungpa commented Jan 28, 2015

Uh oh!

KevinRansom commented Mar 17, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants