Skip to content

Extension for property initializers - #17

Closed
forki wants to merge 6 commits into
dotnet:fsharp4from
forki:PropertyInit
Closed

Extension for property initializers#17
forki wants to merge 6 commits into
dotnet:fsharp4from
forki:PropertyInit

Conversation

@forki

Copy link
Copy Markdown
Contributor

This implements support for extension properties setters in initializers as described UserVoice: http://fslang.uservoice.com/forums/245727-f-language/suggestions/6200089-allow-extension-properties-setters-in-initializers

It was originally submited by Edward Paul (@xepaul) at https://visualfsharp.codeplex.com/SourceControl/network/forks/EdwardPaul/PropertyInitializationExperiments/contribution/7391

Latkin: F# 4.0 triage -- This PR is approved in principle for F# 4.0.
If remaining issues can be addressed by 1/16 it will be included in F# 4.0.
Otherwise it will be considered for the next release.
AFAIK @EdwardPaul has fixed the known issues and just needs to clean up the build.

As the deadline is tomorrow I wanted to step in and rebased this on current fsharp4 branch

match styling change.
added open module to remove fully qualified path
removed unnecessary comment "//need to hide" added during prototyping
@forkiforki changed the title Extension for property initializersWIP: Extension for property initializersJan 15, 2015
@dsyme

Copy link
Copy Markdown
Contributor

Great! I've updated the link on the status page to point to this one

@forki

Copy link
Copy Markdown
ContributorAuthor

I still need to fix the build.

@forkiforki changed the title WIP: Extension for property initializersExtension for property initializersJan 15, 2015
@forki

Copy link
Copy Markdown
ContributorAuthor

I fixed the build and tests. (verified against #15)

@xepaul could you please review cbf4d76?

@dsyme

Copy link
Copy Markdown
Contributor

@forki I've checked it - it is fine.

@latkin

Copy link
Copy Markdown
Contributor

Thanks for taking this and getting it in shape. Looks good to me, issues all seem to be resolved now.

I will merge it in a minute, hopefully I have the comment right so that it closes properly here.

@xepaul

Copy link
Copy Markdown
Contributor

Thanks, this is great, it looks good, although regrettably I'm having system setup issues at the moment so I can't see it running.

liboz pushed a commit to liboz/visualfsharp that referenced this pull request Oct 22, 2016
fix bug where unfold did not respect the Halted state on Result
KevinRansom pushed a commit to KevinRansom/fsharp that referenced this pull request May 26, 2018
nojaf pushed a commit to nojaf/fsharp that referenced this pull request Nov 14, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@forki@dsyme@latkin@xepaul