Skip to content

Parser: recover on unfinished do members - #15392

Merged
psfinaki merged 1 commit into
dotnet:mainfrom
auduchinok:lexFilter-strict6
Jun 15, 2023
Merged

Parser: recover on unfinished do members#15392
psfinaki merged 1 commit into
dotnet:mainfrom
auduchinok:lexFilter-strict6

Conversation

@auduchinok

Copy link
Copy Markdown
Member

Implements recovery for cases like this:

typeT=dodo()

Also slightly improves recovery messages for unfinished while/for expressions. Hopefully, this doesn't break the code completion again. 🙂

@auduchinok
auduchinok requested a review from a team as a code ownerJune 14, 2023 14:58
@auduchinokauduchinok changed the title Parser: recover on unfinished do members with new indentation rulesParser: recover on unfinished do membersJun 14, 2023
@auduchinok

Copy link
Copy Markdown
MemberAuthor

This is ready.

GitHub doesn't seem to see that Build Source-Build Complete is finished successfully for some reason: https://dev.azure.com/dnceng-public/public/_build/results?buildId=307022&view=results

@T-Gro
T-Gro enabled auto-merge (squash) June 14, 2023 16:46
auto-merge was automatically disabled June 15, 2023 13:36

Pull request was closed

@auduchinokauduchinok reopened this Jun 15, 2023
@auduchinok

Copy link
Copy Markdown
MemberAuthor

It's green. 🙂

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@psfinaki
psfinaki merged commit af18bf0 into dotnet:mainJun 15, 2023
@auduchinok
auduchinok deleted the lexFilter-strict6 branch June 15, 2023 14:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@auduchinok@psfinaki@T-Gro