Uh oh!
There was an error while loading. Please reload this page.
Parser: recover on unfinished type declarations - #15410
Merged
Merged
Conversation
type declarationsauduchinok
commented
Jun 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
auduchinok
commented
Jun 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
Phew, this one is ready too! 🎉 It was the most difficult to go through the CI so far due to disallowing this: typeTwithmemberthis.NoIndentation=1// breaks parsing of things belowLike in #15392, it now produces a new indentation warning with the old rules, and an error with the new ones. Deindenting union cases is still allowed as it allows subsequent things to be parsed correctly: typeU=| A // there's an existing special case allowing this for union cases() |
edgarfgp
commented
Jun 16, 2023
Contributor
Will this cover the cases unfinished code with types using the using verbose syntax ?. |
auduchinok
commented
Jun 16, 2023
MemberAuthor
@edgarfgp Could you elaborate, please? |
edgarfgp
commented
Jun 16, 2023
Contributor
Sure. I was referring to the cases with typeA=class//end --missing endtypeI=interface// --missing end |
auduchinok
commented
Jun 16, 2023
MemberAuthor
I see, thanks. |
T-Gro
approved these changes
Jun 19, 2023
vzarytovskii
approved these changes
Jun 19, 2023
edgarfgp
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various unfinished
typecases:typeUnfinished types ending with
withand=are recovered due to the new indentation rules.