Skip to content

Better error reporting for record expressions - #15846

Merged
vzarytovskii merged 11 commits into
dotnet:mainfrom
edgarfgp:better-error-reporting-for-record-expressions
Aug 25, 2023
Merged

Better error reporting for record expressions#15846
vzarytovskii merged 11 commits into
dotnet:mainfrom
edgarfgp:better-error-reporting-for-record-expressions

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Aug 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Continuation of #15824

  • Add missing tests for pattern matching on records with duplicated fields

@edgarfgp

edgarfgp commented Aug 23, 2023

Copy link
Copy Markdown
ContributorAuthor

#15836 Should be merge first :)

edgarfgp
edgarfgp commented Aug 23, 2023
View reviewed changes
Comment threadsrc/Compiler/Checking/CheckPatterns.fs
@edgarfgp
edgarfgp marked this pull request as ready for review August 23, 2023 21:51
@edgarfgp
edgarfgp requested a review from a team as a code ownerAugust 23, 2023 21:51
@edgarfgp

edgarfgp commented Aug 24, 2023

Copy link
Copy Markdown
ContributorAuthor

This is ready

@edgarfgpedgarfgp mentioned this pull request Aug 24, 2023
Closed
@vzarytovskii
vzarytovskii enabled auto-merge (squash) August 24, 2023 20:56
@vzarytovskii
vzarytovskii merged commit a93cb3f into dotnet:mainAug 25, 2023
@allisonchouallisonchou mentioned this pull request Aug 28, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskiivzarytovskiivzarytovskii approved these changes
+1 more reviewer
@010101010101 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp@0101@vzarytovskii