Skip to content

Improve error reporting for anonymous records declarations - #15824

Merged
T-Gro merged 7 commits into
dotnet:mainfrom
edgarfgp:improve-error-reporting-for-anon-records-declarations
Aug 21, 2023
Merged

Improve error reporting for anonymous records declarations#15824
T-Gro merged 7 commits into
dotnet:mainfrom
edgarfgp:improve-error-reporting-for-anon-records-declarations

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Aug 20, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Currently records and anonymous records show duplicated fields using inconsistent ranges

Screenshot 2023-08-20 144236

This PR shows consistent error ranges in records and anonymous records. See tests

@edgarfgp
edgarfgp requested a review from a team as a code ownerAugust 20, 2023 12:46
@edgarfgpedgarfgp changed the title Improve error reporting for anon records declarationsImprove error reporting for anonymous records declarationsAug 20, 2023
@edgarfgp

edgarfgp commented Aug 21, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This is ready.
One thing that noticed while working on this. In theory, we should not need the specific 3523. We could use the same diagnostic that records uses to check for duplicated fields. Not sure if removing 3523 will be an option here

abonie
abonie reviewed Aug 21, 2023
View reviewed changes
Comment threadsrc/Compiler/Checking/CheckExpressions.fs Outdated
@edgarfgp@abonie
Update src/Compiler/Checking/CheckExpressions.fs
76349fc
Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>
abonie
abonie reviewed Aug 21, 2023
View reviewed changes
Comment threadsrc/Compiler/Checking/CheckExpressions.fs Outdated
abonie
abonie reviewed Aug 21, 2023
View reviewed changes
Comment threadsrc/Compiler/Checking/CheckExpressions.fs Outdated
@T-Gro
T-Gro merged commit 3183d55 into dotnet:mainAug 21, 2023
This was referenced Aug 22, 2023
Merged
Merged
@allisonchouallisonchou mentioned this pull request Aug 25, 2023
Closed
@edgarfgpedgarfgp mentioned this pull request Aug 12, 2024
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonieabonieabonie approved these changes
@T-GroT-GroT-Gro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp@abonie@T-Gro