Skip to content

Improving ReplaceWithSuggestion code fix - #15891

Merged
psfinaki merged 1 commit into
dotnet:mainfrom
psfinaki:codefixes-28
Aug 31, 2023
Merged

Improving ReplaceWithSuggestion code fix#15891
psfinaki merged 1 commit into
dotnet:mainfrom
psfinaki:codefixes-28

Conversation

@psfinaki

@psfinakipsfinaki commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

This is basically a non-functional PR, there will be followups. In particular, it:

@psfinaki
psfinaki requested a review from a team as a code ownerAugust 28, 2023 21:45
psfinaki
psfinaki commented Aug 28, 2023
View reviewed changes
Comment threadvsintegration/src/FSharp.Editor/CodeFixes/ReplaceWithSuggestion.fs
psfinaki
psfinaki commented Aug 28, 2023
View reviewed changes
Comment threadvsintegration/src/FSharp.Editor/Options/EditorOptions.fs
psfinaki
psfinaki commented Aug 28, 2023
View reviewed changes
Comment threadvsintegration/src/FSharp.Editor/CodeFixes/ReplaceWithSuggestion.fs
@psfinaki
psfinaki enabled auto-merge (squash) August 31, 2023 11:21
@psfinaki
psfinaki merged commit 2dac712 into dotnet:mainAug 31, 2023
@psfinaki
psfinaki deleted the codefixes-28 branch August 31, 2023 11:21
@psfinakipsfinaki mentioned this pull request Sep 1, 2023
Merged
@allisonchouallisonchou mentioned this pull request Sep 4, 2023
Closed
@psfinakipsfinaki mentioned this pull request Sep 22, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@010101010101 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@psfinaki@0101@T-Gro