Skip to content

Transparent Compiler various fixes - #16643

Merged
0101 merged 19 commits into
dotnet:mainfrom
0101:tc-fixes-2
Feb 2, 2024
Merged

Transparent Compiler various fixes#16643
0101 merged 19 commits into
dotnet:mainfrom
0101:tc-fixes-2

Conversation

@0101

@01010101 commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes test failures from #16591

This includes:

  • Adding support for PEReference and ILModuleReference
  • Fixing some diagnostics reporting
  • Fixing missing format specifiers in results

The remaining failures are related to LoadClosure which should be eventually fixed by #16627

@0101
0101 requested a review from a team as a code ownerFebruary 1, 2024 19:38
@github-actions

github-actionsBot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@01010101 added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Feb 1, 2024
Comment threadsrc/Compiler/Service/FSharpProjectSnapshot.fs
@0101
0101 enabled auto-merge (squash) February 2, 2024 12:34
Comment threadtests/FSharp.Compiler.ComponentTests/FSharpChecker/TransparentCompiler.fs Outdated
@0101
0101 merged commit 589d350 into dotnet:mainFeb 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@0101@psfinaki@T-Gro