Add script support to the TransparentCompiler

[dawedawe]

Description

A naive first stab at bringing script support to the TransparentCompiler.

(No release notes needed, I think)

Checklist

• Test cases added

• Performance benchmarks added in case of performance changes

• Release notes entry updated:

  Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

  Release notes files:

  • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
  • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
  • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

  Information about the release notes entries format can be found in the documentation.
  Example:

  • More inlines for Result module. (PR #16106)
  • Correctly handle assembly imports with public key token of 0 length. (Issue #16359, PR #16363)
    *while! (Language suggestion #1038, PR #14238)

  If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

[github-actions]

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

[0101]

Looks good!

Can you try to run it in CI with this: b47ba47 (either add here on new branch) ?

It's a bit ghetto way of testing, but actually this PR should resolve the last failures there and then we can add a proper CI leg with experimental features enabled.

[dawedawe]

Seems like this is causing the last failures:
let tcDependencyFiles = [] // TODO add as a set to TcIntermediate

If we just set it to tcInfo.tcDependencyFiles we make Test project35b Dependency files for ParseAndCheckFileInProject fail because it expects ParseAndCheckFileInProject to NOT include the passed in file itself in the dependency files.

Contrary to that, GetBackgroundCheckResultsForFileInProject (and also ParseAndCheckProject) is expected to have the passed in file in the dependency files by Test project35b Dependency files for GetBackgroundCheckResultsForFileInProject

Is the old behaviour really the one we want to have in future?

[0101]

Hmm, interesting I remember I thought those failures were somehow related to the load closure, have to look at it again.

This DependencyFiles functionality might be partly deprecated by not relying on the file system for source files. Wonder if we should get rid of it altogether. Since the user knows about dependencies they themselves put into the project snapshot. It'd be good to know if/how people use this now...

Anyway, not a blocker for script support I would say, so you can revert the tests and I think we can merge this.

[dawedawe]

Great, thanks for the help and hints with this one :)

[0101]

Oh, I remember, the test is actually first complaining about notexist.dll not being in dependency files, and in incremental builder it gets there through this:

fsharp/src/Compiler/Service/IncrementalBuild.fs

Line 1492 in 3ac064e

tcConfigB.knownUnresolvedReferences <- loadClosure.UnresolvedReferences

Which now we also have, but probably are not passing it to the dependency files from there.

Edit: nevermind, it's there in the TcInfo but with all the files as you described. We'll sort this out later.

[0101]

Thanks a lot for this!

I didn't put Transparent Compiler into the release notes, since it's experimental and not officially supported, but if you want you can add this.

[dawedawe]

I didn't put Transparent Compiler into the release notes, since it's experimental and not officially supported, but if you want you can add this.

Mmh no, I think this PR is just part of the whole story and doesn't need it's own entry.
An entry about the Transparent Compiler (when it's ready) should be enough to also cover this little piece here.