Skip to content

Prefixed module nameof (#16743) - #16747

Merged
vzarytovskii merged 3 commits into
dotnet:release/dev17.9from
nojaf:gbc-port
Feb 24, 2024
Merged

Prefixed module nameof (#16743)#16747
vzarytovskii merged 3 commits into
dotnet:release/dev17.9from
nojaf:gbc-port

Conversation

@nojaf

@nojafnojaf commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

Backport of #16743

Description

Fixes # (issue, if applicable)

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@nojaf@dawedawe
Prefixed module nameof (dotnet#16743)
43266eb
* Consider prefixed module name in nameof expression.
* Consider prefixed module name in nameof pattern.
* Remove foo
* Update release notes
* Update src/Compiler/Driver/GraphChecking/FileContentMapping.fs
Co-authored-by: dawe <dawedawe@posteo.de>
---------
Co-authored-by: dawe <dawedawe@posteo.de>
@nojaf
nojaf requested a review from a team as a code ownerFebruary 22, 2024 15:29
@nojaf

nojaf commented Feb 22, 2024

Copy link
Copy Markdown
ContributorAuthor

@vzarytovskii let me know if this still needs a tweak.

@github-actions

github-actionsBot commented Feb 22, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/8.0.202.md

@vzarytovskii
vzarytovskii merged commit 86d05ef into dotnet:release/dev17.9Feb 24, 2024
@dotnet-botdotnet-bot mentioned this pull request Feb 29, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nojaf@vzarytovskii