Skip to content

Better error reporting for unions duplicated fields - #17521

Merged
vzarytovskii merged 7 commits into
dotnet:mainfrom
edgarfgp:error-reporing-for-unions-duplicated-fields
Aug 13, 2024
Merged

Better error reporting for unions duplicated fields#17521
vzarytovskii merged 7 commits into
dotnet:mainfrom
edgarfgp:error-reporing-for-unions-duplicated-fields

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Aug 12, 2024

Copy link
Copy Markdown
Contributor

Description

Continuation of

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

github-actionsBot commented Aug 12, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@edgarfgp
edgarfgp marked this pull request as ready for review August 12, 2024 15:30
@edgarfgp
edgarfgp requested a review from a team as a code ownerAugust 12, 2024 15:30
Comment threadsrc/Compiler/Checking/CheckDeclarations.fs
@vzarytovskii
vzarytovskii enabled auto-merge (squash) August 12, 2024 18:30

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edgar, this is a good addition. Internal errors are awkward!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp@vzarytovskii@psfinaki