Better CE error reporting when using use! with and!

[edgarfgp]

Description

• Improves the error range for use! may not be combined with and!
• Updates SynExprAndBangTrivia to include also AndBangKeyword range
• Uses only the and! range since it's what adds the error in the first place.

Before

After

letrun r2 r3 =
result {use! b = r2
and! c = r3
^^^^return b - c
}

Checklist

• Test cases added
• Release notes entry updated

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

[auduchinok]

@edgarfgp Could it be better to highlight the and! part, since it's what adds the error? Could it also highlight the keyword only?

[edgarfgp]

Could it be better to highlight the and! part, since it's what adds the error? Could it also highlight the keyword only?

Yeah I think that makes more sense. Thanks for the review.

Update: Unfortunately there is not a dedicated range for only the and keyword. So the best we can do for now if the expression range. See fantomas

[edgarfgp]

@auduchinok I played around with your suggestion and I was able to update SynExprAndBangTrivia to also include and! range.

[psfinaki]

Good stuff, I like this approach with adding trivia. Thanks for making diags better every week :)

[edgarfgp]

@psfinaki I have more planned for CE in the upcoming weeks