Skip to content

Better ranges for CE let! and use! error reporting. - #17712

Merged
vzarytovskii merged 9 commits into
dotnet:mainfrom
edgarfgp:better-ranges-for-ce-error-reporting
Sep 23, 2024
Merged

Better ranges for CE let! and use! error reporting.#17712
vzarytovskii merged 9 commits into
dotnet:mainfrom
edgarfgp:better-ranges-for-ce-error-reporting

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

Description

Better ranges for CE let! and use! error reporting. Continuation of #17671

Before

  • let! in an CE builder
Screenshot 2024-09-20 at 11 20 12
  • let! in a query builder
Screenshot 2024-09-20 at 11 20 49
  • use! in an CE builder
Screenshot 2024-09-20 at 11 26 03
  • use! in a query builder
Screenshot 2024-09-20 at 11 28 00

After

  • let! in an CE builder
letrun r2 r3 =
result {let!a= r2
^^^^return! a
}
  • let! in a query builder
query {let!x= failwith ""^^^^yield1}
  • use! in an CE builder
letrun r2 r3 =
result {use! a = r2
^^^^return! a
}
  • use! in a query builder
query {use! x = failwith ""^^^^yield1}

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

github-actionsBot commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgpedgarfgp reopened this Sep 19, 2024
@edgarfgpedgarfgp changed the title Better ranges for CE error reportingBetter ranges for CE let! and use! error reporting.Sep 19, 2024
Comment threadtests/fsharp/typecheck/sigs/neg61.bsl
@edgarfgp
edgarfgp marked this pull request as ready for review September 20, 2024 10:39
@edgarfgp
edgarfgp requested a review from a team as a code ownerSeptember 20, 2024 10:39
Comment threadsrc/Compiler/pars.fsy
Comment threadtests/fsharp/typecheck/sigs/neg61.bsl
@vzarytovskii
vzarytovskii enabled auto-merge (squash) September 21, 2024 00:05

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edgar, great job as usual :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp@vzarytovskii@psfinaki