Switch to new VMR control set by mmitche · Pull Request #17703 · dotnet/fsharp

mmitche · 2024-09-11T21:51:22Z

Description

Now that fsharp is on 9.0, we can switch to the new control set. Generally:

DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build.
DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build.
ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build.

Fixes # (issue, if applicable)

Checklist

Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated:
Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.
Release notes files:
- If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
- If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
- If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.
Information about the release notes entries format can be found in the documentation.
Example:
- More inlines for Result module. (PR #16106)
- Correctly handle assembly imports with public key token of 0 length. (Issue #16359, PR #16363)
  *while! (Language suggestion #1038, PR #14238)
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

…rally: - DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build. - DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build. - ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build.

github-actions · 2024-09-11T21:52:07Z

✅ No release notes required

psfinaki · 2024-09-12T11:24:20Z

@mmitche so it's MIBC again 👀

I introduced PGO to this repo a few weeks ago here, it doesn't play well with source build (see the discussion in that PR), and we shouldn't ignore the packages either, so we disabled PGO-related logic for MIBC.

Given that in this PR the optimization packages pop up again, something doesn't play well together, IgnoreMIBC is not being set. I might look at this locally later today.

psfinaki · 2024-09-12T12:42:21Z

That's really weird. It looks like as if MSBuild wasn't setting this property up internally after receiving the new flags.

mmitche · 2024-09-12T17:21:46Z

I'll take a look too.

psfinaki · 2024-09-16T10:18:38Z

/azp run

azure-pipelines · 2024-09-16T10:18:57Z

Azure Pipelines successfully started running 2 pipeline(s).

psfinaki · 2024-09-16T12:42:49Z

Alright, that seems to work - thanks @mmitche!

psfinaki · 2024-09-16T12:43:29Z

@dotnet/source-build-internal

* Now that fsharp is on 9.0, we can switch to the new control set. Generally: - DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build. - DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build. - ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build. - ExcludeFromSourceBuild -> ExcludeFromSourceOnlyBuild * Split out source build args * Split out source build args * Remove unnecessary source build env var set * Add properties to the bootstrap compiler build * BuildRepo -> BuildInnerRepo * Only build proto repo in inner build * Additional VMR properties for completeness * Rename sourcebuild.props -> dotnetbuild.props --------- Co-authored-by: Petr <psfinaki@users.noreply.github.com>

* Update azure-pipelines.yml * Refactor CE checking (#17464) (#17493) Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update azure-pipelines.yml * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 2524346 (#17610) * Fixes#17447 -MethodAccessException on equality comparison of a record with private fields (#17467) * Fix17447 * tests + readme * fixes#17541 - Equals visibility for DU's (#17548) * update version number * Switch to new VMR control set (#17703) (port from main) (#17788) * Now that fsharp is on 9.0, we can switch to the new control set. Generally: - DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build. - DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build. - ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build. - ExcludeFromSourceBuild -> ExcludeFromSourceOnlyBuild * Split out source build args * Split out source build args * Remove unnecessary source build env var set * Add properties to the bootstrap compiler build * BuildRepo -> BuildInnerRepo * Only build proto repo in inner build * Additional VMR properties for completeness * Rename sourcebuild.props -> dotnetbuild.props --------- Co-authored-by: Petr <psfinaki@users.noreply.github.com> * respect generic arity in method uniqueness * [17.12] Turn off realsig when building product and proto (#17808) * Bugfix : make sure nullness does not break XmlDoc info import for methods and types (#17741) * Remove nullness signal in string-based type encoding of a symbol (since it is used for xmldoc lookup) * release notes * Discard unused values * Rendering AllowsRefStruct for type parameters (#17706) * Update azure-pipelines.yml --------- Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Petr <psfinaki@users.noreply.github.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom <kevinr@microsoft.com> Co-authored-by: Matt Mitchell <mmitche@microsoft.com>

mmitche requested review from a team as code owners September 11, 2024 21:51

T-Gro approved these changes Sep 12, 2024
View reviewed changes

mmitche added 8 commits September 12, 2024 14:51

Split out source build args
abc01df

Merge remote-tracking branch 'upstream/main' into new-controls
cab0be1

Split out source build args
a5d032b

Remove unnecessary source build env var set
027c2a0

Add properties to the bootstrap compiler build
06bf5c7

BuildRepo -> BuildInnerRepo
fda7889

Only build proto repo in inner build
7fd4569

Additional VMR properties for completeness
fbc9ef2

Merge branch 'main' into new-controls
901aa9b

psfinaki approved these changes Sep 16, 2024
View reviewed changes

MichaelSimons approved these changes Sep 16, 2024
View reviewed changes

Comment threadeng/SourceBuild.props

mmitche added 2 commits September 16, 2024 08:00

Rename sourcebuild.props -> dotnetbuild.props
41bda43

Merge remote-tracking branch 'origin/new-controls' into new-controls
0faffec

MichaelSimons approved these changes Sep 16, 2024
View reviewed changes

psfinaki merged commit 7bfb032 into dotnet:mainSep 16, 2024

This was referenced Oct 31, 2024
[Automated] PRs inserted in VS build main-35430.72 #17943
Closed
[Automated] PRs inserted in VS build feature.debugger.main-35430.275 #17944
Closed

dotnet-bot mentioned this pull request Nov 19, 2024
[Automated] PRs inserted in VS build feature.debugger.shadowDebug-35518.109 #18027
Closed

This was referenced Sep 8, 2025
Bump FSharp.Core from 8.0.100 to 9.0.303 NicoVIII/RunHelpers#22
Closed
Bump FSharp.Core from 8.0.100 to 9.0.303 NicoVIII/SimpleOptics#10
Closed

This was referenced Oct 10, 2025
Bump FSharp.Core from 4.5.0 to 9.0.303 G-Research/TypeEquality#35
Closed
Bump FSharp.Core from 4.5.0 to 9.0.303 G-Research/TypeEquality#37
Closed

dependabotBot mentioned this pull request Oct 27, 2025
Bump FSharp.Core from 8.0.100 to 9.0.303 NicoVIII/RunHelpers#25
Closed

Navigation Menu

Uh oh!

Switch to new VMR control set - #17703

Switch to new VMR control set#17703
psfinaki merged 12 commits into
dotnet:mainfrom
mmitche:new-controls

mmitche commented Sep 11, 2024

Uh oh!

github-actionsBot commented Sep 11, 2024

Uh oh!

psfinaki commented Sep 12, 2024

Uh oh!

psfinaki commented Sep 12, 2024

Uh oh!

mmitche commented Sep 12, 2024

Uh oh!

psfinaki commented Sep 16, 2024

Uh oh!

azure-pipelinesBot commented Sep 16, 2024

Uh oh!

psfinaki commented Sep 16, 2024

Uh oh!

psfinaki commented Sep 16, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mmitche commented Sep 11, 2024

Description

Checklist

Uh oh!

github-actionsBot commented Sep 11, 2024

✅ No release notes required

Uh oh!

psfinaki commented Sep 12, 2024

Uh oh!

psfinaki commented Sep 12, 2024

Uh oh!

mmitche commented Sep 12, 2024

Uh oh!

psfinaki commented Sep 16, 2024

Uh oh!

azure-pipelinesBot commented Sep 16, 2024

Uh oh!

psfinaki commented Sep 16, 2024

Uh oh!

psfinaki commented Sep 16, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants