Uh oh!
There was an error while loading. Please reload this page.
Type checker: recover on adding constraints - #19034
Closed
auduchinok wants to merge 6 commits into
Closed
Conversation
Contributor
❗ Release notes required
|
auduchinokforce-pushed
the
tc-recover-contraints
branch
from
October 28, 2025 14:35
6bff61d to
0aef154Compareauduchinokforce-pushed
the
tc-recover-contraints
branch
7 times, most recently
from
October 31, 2025 14:20
4b5f7bd to
be79b41Compareauduchinokforce-pushed
the
tc-recover-contraints
branch
from
October 31, 2025 17:36
be79b41 to
4303465Compareauduchinok
commented
Oct 31, 2025
MemberAuthor
This is ready. |
auduchinok
commented
Nov 3, 2025
MemberAuthor
Update: I found an issue in this one, please don't merge it yet. |
T-Gro
commented
Nov 13, 2025
Member
@auduchinok : Was this PR now superseded? |
T-Gro
commented
Nov 24, 2025
Member
Closing as I understood #19046 solves this. |
auduchinok
commented
Feb 17, 2026
MemberAuthor
This PR was too aggressive with recovery, and it inadvertently changed behavior in some places. #19046 tried to recover some of the safer places only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds recovery to various cases where an error would break subsequent analysis.
In the following example
fwas not added to the environment, breaking analysis of its usages:In this example the
fargument is not analyzed at all: