Uh oh!
There was an error while loading. Please reload this page.
Type checker: recover on checking binding parameter constraints - #19046
Merged
Conversation
Contributor
❗ Release notes required
|
auduchinokforce-pushed
the
tc-recover-contraints2
branch
from
November 3, 2025 17:13
39b46c8 to
e74b246Compareauduchinok
commented
Nov 4, 2025
MemberAuthor
This is ready |
T-Gro
reviewed
Nov 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
reviewed
Nov 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
auduchinokforce-pushed
the
tc-recover-contraints2
branch
from
November 10, 2025 18:26
e04fa56 to
6b91fdfCompareauduchinok
commented
Nov 10, 2025
MemberAuthor
This is ready. |
Removed the test case for 'neg68' from MigratedTypeCheckTests.
T-Gro
approved these changes
Nov 11, 2025
T-Gro
enabled auto-merge (squash)
November 11, 2025 11:46
Uh oh!
There was an error while loading. Please reload this page.
vzarytovskii
approved these changes
Nov 11, 2025
This was referenced Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a more conservative version of #19034. The previous PR unexpectedly changes behavior in some cases where exceptions during analysis were a part of the control flow, so should be done more cautiously by going through each affected place separately. This PR adds a silent recovery for the single place where the previous PR was started.
In the following example
fwas not added to the environment, breaking analysis of its usages: