Skip to content

Remove always-on RelaxWhitespace language feature flag - #20226

Merged
T-Gro merged 3 commits into
mainfrom
fix/issue-20140
Aug 13, 2026
Merged

Remove always-on RelaxWhitespace language feature flag#20226
T-Gro merged 3 commits into
mainfrom
fix/issue-20140

Conversation

@T-Gro

@T-GroT-Gro commented Aug 6, 2026

Copy link
Copy Markdown
Member

Fixes#20140

RelaxWhitespace has been on for every accepted --langversion since F# 4.7, so its flag was dead configuration. The guard is removed and the enabled behaviour kept unconditionally; --disableLanguageFeature:RelaxWhitespace is no longer a recognised feature name.

Part of #20139

Remove always-on RelaxWhitespace language feature flag
c5e6516
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro
T-Gro requested a review from a team as a code ownerAugust 6, 2026 14:19
@github-actions

github-actionsBot commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 6, 2026
@github-actionsgithub-actionsBot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label Aug 6, 2026
@T-Gro
T-Gro requested a review from abonieAugust 10, 2026 11:24
@T-Gro
T-Gro enabled auto-merge (squash) August 10, 2026 11:24
@T-GroT-Gro mentioned this pull request Aug 10, 2026
Closed
@T-GroT-Gro added NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes and removed NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes labels Aug 10, 2026
@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingAug 11, 2026
Tomas Grosup
Merge main into fix/issue-20140 (resolve LanguageFeatures/FSComp conf…
3a27eb8
…licts)
Conflicts arose because main removed sibling always-on feature flags in the
shared enum/strings; resolved to main's content minus this PR's own removal of
RelaxWhitespace (RelaxWhitespace2 preserved). Net change vs main is unchanged
(feature removal only).
@T-Gro
T-Gro requested a review from abonieAugust 12, 2026 08:35
@T-Gro

T-Gro commented Aug 12, 2026

Copy link
Copy Markdown
MemberAuthor

@copilot resolve the merge conflicts in this pull request

@T-Gro
Merge origin/main into fix/issue-20140
ad2d7a9
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
auto-merge was automatically disabled August 12, 2026 12:19

Head branch was pushed to by a user without write access

CopilotAI commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in ad2d7a9.

The conflicts were in LanguageFeatures.fs/.fsi and FSComp.txt, all caused by the parallel flag-removal PRs touching adjacent lines: main removed SingleUnderscorePattern (#20222) while this branch removed RelaxWhitespace. Resolution keeps neither, and since the // F# 4.7 block in the feature-version table became empty, the stale comment was dropped too. Net diff against main is now exactly the RelaxWhitespace removal.

Validation: FSharp.Compiler.Service builds clean, disableLanguageFeature tests 6/6 pass, LexicalAnalysis tests 158 pass / 10 skipped, and fantomas --check is clean.

@T-Gro
T-Gro merged commit d26c842 into mainAug 13, 2026
46 checks passed
@T-Gro
T-Gro deleted the fix/issue-20140 branch August 13, 2026 15:38
This was referenced Aug 14, 2026
Closed
Closed
Closed
@dotnet-botdotnet-bot mentioned this pull request Aug 18, 2026
Closed
This was referenced Aug 18, 2026
Closed
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonieabonieabonie approved these changes

Assignees

No one assigned

Labels

AI-Tooling-Check-BypassedTooling check: non-fork PR, not diff-analyzedNO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove always-on language feature flag: RelaxWhitespace

3 participants

@T-Gro@abonie