Skip to content

Remove always-on SingleUnderscorePattern language feature flag - #20222

Merged
T-Gro merged 3 commits into
mainfrom
fix/issue-20141
Aug 12, 2026
Merged

Remove always-on SingleUnderscorePattern language feature flag#20222
T-Gro merged 3 commits into
mainfrom
fix/issue-20141

Conversation

@T-Gro

@T-GroT-Gro commented Aug 6, 2026

Copy link
Copy Markdown
Member

Fixes#20141

LanguageFeature.SingleUnderscorePattern has been enabled for every accepted --langversion since F# 4.7, so its flag was dead configuration. This collapses the guarded parser branches to their enabled behaviour; --disableLanguageFeature:SingleUnderscorePattern is no longer a recognised feature name.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actionsBot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 6, 2026
@github-actionsgithub-actionsBot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label Aug 6, 2026
Its only two consumers were the parser guards removed when the always-on SingleUnderscorePattern language feature was deleted, leaving the FSComp.txt entry and 13 xlf trans-units unreachable. Regenerated xlf via UpdateXlf.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingAug 11, 2026
…licts)
Conflicts arose because main removed sibling always-on feature flags in the
shared enum/strings; resolved to main's content minus this PR's own removal of
SingleUnderscorePattern. Net change vs main is unchanged (feature removal only).
@T-Gro
T-Gro requested a review from abonieAugust 12, 2026 08:35
@T-Gro
T-Gro merged commit 22e1934 into mainAug 12, 2026
48 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Tooling-Check-BypassedTooling check: non-fork PR, not diff-analyzedNO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove always-on language feature flag: SingleUnderscorePattern

2 participants

@T-Gro@abonie