Skip to content

Remove always-on SingleUnderscorePattern language feature flag - #20228

Closed
T-Gro wants to merge 1 commit into
dotnet:mainfrom
T-Gro:fix/issue-20141
Closed

Remove always-on SingleUnderscorePattern language feature flag#20228
T-Gro wants to merge 1 commit into
dotnet:mainfrom
T-Gro:fix/issue-20141

Conversation

@T-Gro

@T-GroT-Gro commented Aug 7, 2026

Copy link
Copy Markdown
Member

Fixes#20141

SingleUnderscorePattern has been enabled unconditionally since F# 4.7, so the version guard and its parsUnexpectedSymbolDot diagnostic were dead code. Removed the flag and always parse the _.member pattern.

@github-actions

github-actionsBot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 7, 2026
@github-actionsgithub-actionsBot added the AI-Tooling-Check-Scanned-Clean Tooling check: diff analyzed, no interesting infrastructure files label Aug 7, 2026
…t#20141)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro

Copy link
Copy Markdown
MemberAuthor

Closing as a duplicate of #20222 (same change, on a dotnet/fsharp branch). #20222 is green, has NO_RELEASE_NOTES, reviewer requested, and auto-merge armed. Consolidating there.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Tooling-Check-Scanned-CleanTooling check: diff analyzed, no interesting infrastructure filesNO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove always-on language feature flag: SingleUnderscorePattern

1 participant

@T-Gro