Reformatting Conversion, FeatureSelection and Image Analytics of Transform to Width 85 by rayankrish · Pull Request #3943 · dotnet/machinelearning

rayankrish · 2019-07-01T22:47:29Z

Guidelines followed:
-85 characters per line
-Use 4 spaces for indentation
-Dot and open parentheses stay on same line as function
-If not a preexisting line under line that we break, add an extra line after it
-Don't indent comments
-Don't break a comment if it represents output
-Don't break links
-If applicable, break right before $
-Keep math op together

Fix for issue #3478

codemzs · 2019-07-02T05:51:09Z

+ // SurvivedInt32' (Int32)
+ var convertedData = mlContext.Data.CreateEnumerable<TransformedData>(
+ transformedData, true);
 foreach (var item in convertedData)


new line between any two lines that were broken down into multiple lines but no new line between multiple breakdowns of a single line.

codemzs · 2019-07-02T05:53:56Z

+ // full map. If that parameter is left to the default 0 value, the
+ // mapping is not preserved.
+ var pipeline = mlContext.Transforms.Conversion.Hash("CategoryHashed",
+ "Category", numberOfBits: 16, maximumNumberOfInverts: -1).Append(


.Append( [](start = 73, length = 8)
I would move .Append to a new line. to be clear we are adding a new transform.

codemzs · 2019-07-02T05:54:15Z

+ "TokenizedText", nameof(DataPoint.Review)).Append(mlContext
+ .Transforms.Conversion.MapValueToKey(nameof(TransformedData.Keys),
+ "TokenizedText"));



please move .Append to a new line.

codemzs

…learning into transform85

sharwell

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

rayankrish · 2019-07-02T18:20:42Z

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

Thank you for all of your comments and suggestions. We are going to review and check-in these PRs to address the issue of the 85 character limit. We will open a new issue with subsequent improvements to implement the style guides you had suggested.

sierralee51 · 2019-07-02T22:18:36Z

- Console.WriteLine($"{featureRow.StudyTime}\t\t{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t{featureRow.CourseCategory}");
+ Console.WriteLine($"{featureRow.StudyTime}\t\t" +
+ $"{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t" +
+ $"{featureRow.CourseCategory}");


…sform to Width 85 (dotnet#3943) * samples/dynamic/transforms/conversions formatted to 85 char * samples/dynamic/transforms/featureselection formatted to 85 char * ImageAnalytics * ImageAnalytics * small corrections to formatting * minor tab and empty line changes

rayankrish · 2019-07-01T22:47:29Z

Guidelines followed:
-85 characters per line
-Use 4 spaces for indentation
-Dot and open parentheses stay on same line as function
-If not a preexisting line under line that we break, add an extra line after it
-Don't indent comments
-Don't break a comment if it represents output
-Don't break links
-If applicable, break right before $
-Keep math op together

Fix for issue #3478

codemzs · 2019-07-02T05:51:09Z

+ // SurvivedInt32' (Int32)
+ var convertedData = mlContext.Data.CreateEnumerable<TransformedData>(
+ transformedData, true);
 foreach (var item in convertedData)


new line between any two lines that were broken down into multiple lines but no new line between multiple breakdowns of a single line.

codemzs · 2019-07-02T05:53:56Z

+ // full map. If that parameter is left to the default 0 value, the
+ // mapping is not preserved.
+ var pipeline = mlContext.Transforms.Conversion.Hash("CategoryHashed",
+ "Category", numberOfBits: 16, maximumNumberOfInverts: -1).Append(


.Append( [](start = 73, length = 8)
I would move .Append to a new line. to be clear we are adding a new transform.

codemzs · 2019-07-02T05:54:15Z

+ "TokenizedText", nameof(DataPoint.Review)).Append(mlContext
+ .Transforms.Conversion.MapValueToKey(nameof(TransformedData.Keys),
+ "TokenizedText"));



please move .Append to a new line.

codemzs

…learning into transform85

sharwell

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

rayankrish · 2019-07-02T18:20:42Z

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

Thank you for all of your comments and suggestions. We are going to review and check-in these PRs to address the issue of the 85 character limit. We will open a new issue with subsequent improvements to implement the style guides you had suggested.

sierralee51 · 2019-07-02T22:18:36Z

- Console.WriteLine($"{featureRow.StudyTime}\t\t{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t{featureRow.CourseCategory}");
+ Console.WriteLine($"{featureRow.StudyTime}\t\t" +
+ $"{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t" +
+ $"{featureRow.CourseCategory}");


…sform to Width 85 (dotnet#3943) * samples/dynamic/transforms/conversions formatted to 85 char * samples/dynamic/transforms/featureselection formatted to 85 char * ImageAnalytics * ImageAnalytics * small corrections to formatting * minor tab and empty line changes

rayankrish · 2019-07-01T22:47:29Z

Guidelines followed:
-85 characters per line
-Use 4 spaces for indentation
-Dot and open parentheses stay on same line as function
-If not a preexisting line under line that we break, add an extra line after it
-Don't indent comments
-Don't break a comment if it represents output
-Don't break links
-If applicable, break right before $
-Keep math op together

Fix for issue #3478

codemzs · 2019-07-02T05:51:09Z

+ // SurvivedInt32' (Int32)
+ var convertedData = mlContext.Data.CreateEnumerable<TransformedData>(
+ transformedData, true);
 foreach (var item in convertedData)


new line between any two lines that were broken down into multiple lines but no new line between multiple breakdowns of a single line.

codemzs · 2019-07-02T05:53:56Z

+ // full map. If that parameter is left to the default 0 value, the
+ // mapping is not preserved.
+ var pipeline = mlContext.Transforms.Conversion.Hash("CategoryHashed",
+ "Category", numberOfBits: 16, maximumNumberOfInverts: -1).Append(


.Append( [](start = 73, length = 8)
I would move .Append to a new line. to be clear we are adding a new transform.

codemzs · 2019-07-02T05:54:15Z

+ "TokenizedText", nameof(DataPoint.Review)).Append(mlContext
+ .Transforms.Conversion.MapValueToKey(nameof(TransformedData.Keys),
+ "TokenizedText"));



please move .Append to a new line.

codemzs

…learning into transform85

sharwell

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

rayankrish · 2019-07-02T18:20:42Z

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

Thank you for all of your comments and suggestions. We are going to review and check-in these PRs to address the issue of the 85 character limit. We will open a new issue with subsequent improvements to implement the style guides you had suggested.

sierralee51 · 2019-07-02T22:18:36Z

- Console.WriteLine($"{featureRow.StudyTime}\t\t{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t{featureRow.CourseCategory}");
+ Console.WriteLine($"{featureRow.StudyTime}\t\t" +
+ $"{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t" +
+ $"{featureRow.CourseCategory}");


…sform to Width 85 (dotnet#3943) * samples/dynamic/transforms/conversions formatted to 85 char * samples/dynamic/transforms/featureselection formatted to 85 char * ImageAnalytics * ImageAnalytics * small corrections to formatting * minor tab and empty line changes

rayankrish · 2019-07-01T22:47:29Z

Guidelines followed:
-85 characters per line
-Use 4 spaces for indentation
-Dot and open parentheses stay on same line as function
-If not a preexisting line under line that we break, add an extra line after it
-Don't indent comments
-Don't break a comment if it represents output
-Don't break links
-If applicable, break right before $
-Keep math op together

Fix for issue #3478

codemzs · 2019-07-02T05:51:09Z

+ // SurvivedInt32' (Int32)
+ var convertedData = mlContext.Data.CreateEnumerable<TransformedData>(
+ transformedData, true);
 foreach (var item in convertedData)


new line between any two lines that were broken down into multiple lines but no new line between multiple breakdowns of a single line.

codemzs · 2019-07-02T05:53:56Z

+ // full map. If that parameter is left to the default 0 value, the
+ // mapping is not preserved.
+ var pipeline = mlContext.Transforms.Conversion.Hash("CategoryHashed",
+ "Category", numberOfBits: 16, maximumNumberOfInverts: -1).Append(


.Append( [](start = 73, length = 8)
I would move .Append to a new line. to be clear we are adding a new transform.

codemzs · 2019-07-02T05:54:15Z

+ "TokenizedText", nameof(DataPoint.Review)).Append(mlContext
+ .Transforms.Conversion.MapValueToKey(nameof(TransformedData.Keys),
+ "TokenizedText"));



please move .Append to a new line.

codemzs

…learning into transform85

sharwell

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

rayankrish · 2019-07-02T18:20:42Z

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

Thank you for all of your comments and suggestions. We are going to review and check-in these PRs to address the issue of the 85 character limit. We will open a new issue with subsequent improvements to implement the style guides you had suggested.

sierralee51 · 2019-07-02T22:18:36Z

- Console.WriteLine($"{featureRow.StudyTime}\t\t{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t{featureRow.CourseCategory}");
+ Console.WriteLine($"{featureRow.StudyTime}\t\t" +
+ $"{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t" +
+ $"{featureRow.CourseCategory}");


…sform to Width 85 (dotnet#3943) * samples/dynamic/transforms/conversions formatted to 85 char * samples/dynamic/transforms/featureselection formatted to 85 char * ImageAnalytics * ImageAnalytics * small corrections to formatting * minor tab and empty line changes

rayankrish · 2019-07-01T22:47:29Z

Guidelines followed:
-85 characters per line
-Use 4 spaces for indentation
-Dot and open parentheses stay on same line as function
-If not a preexisting line under line that we break, add an extra line after it
-Don't indent comments
-Don't break a comment if it represents output
-Don't break links
-If applicable, break right before $
-Keep math op together

Fix for issue #3478

codemzs · 2019-07-02T05:51:09Z

+ // SurvivedInt32' (Int32)
+ var convertedData = mlContext.Data.CreateEnumerable<TransformedData>(
+ transformedData, true);
 foreach (var item in convertedData)


new line between any two lines that were broken down into multiple lines but no new line between multiple breakdowns of a single line.

codemzs · 2019-07-02T05:53:56Z

+ // full map. If that parameter is left to the default 0 value, the
+ // mapping is not preserved.
+ var pipeline = mlContext.Transforms.Conversion.Hash("CategoryHashed",
+ "Category", numberOfBits: 16, maximumNumberOfInverts: -1).Append(


.Append( [](start = 73, length = 8)
I would move .Append to a new line. to be clear we are adding a new transform.

codemzs · 2019-07-02T05:54:15Z

+ "TokenizedText", nameof(DataPoint.Review)).Append(mlContext
+ .Transforms.Conversion.MapValueToKey(nameof(TransformedData.Keys),
+ "TokenizedText"));



please move .Append to a new line.

codemzs

…learning into transform85

sharwell

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

rayankrish · 2019-07-02T18:20:42Z

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

Thank you for all of your comments and suggestions. We are going to review and check-in these PRs to address the issue of the 85 character limit. We will open a new issue with subsequent improvements to implement the style guides you had suggested.

sierralee51 · 2019-07-02T22:18:36Z

- Console.WriteLine($"{featureRow.StudyTime}\t\t{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t{featureRow.CourseCategory}");
+ Console.WriteLine($"{featureRow.StudyTime}\t\t" +
+ $"{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t" +
+ $"{featureRow.CourseCategory}");


…sform to Width 85 (dotnet#3943) * samples/dynamic/transforms/conversions formatted to 85 char * samples/dynamic/transforms/featureselection formatted to 85 char * ImageAnalytics * ImageAnalytics * small corrections to formatting * minor tab and empty line changes

rayankrish · 2019-07-01T22:47:29Z

Guidelines followed:
-85 characters per line
-Use 4 spaces for indentation
-Dot and open parentheses stay on same line as function
-If not a preexisting line under line that we break, add an extra line after it
-Don't indent comments
-Don't break a comment if it represents output
-Don't break links
-If applicable, break right before $
-Keep math op together

Fix for issue #3478

codemzs · 2019-07-02T05:51:09Z

+ // SurvivedInt32' (Int32)
+ var convertedData = mlContext.Data.CreateEnumerable<TransformedData>(
+ transformedData, true);
 foreach (var item in convertedData)


new line between any two lines that were broken down into multiple lines but no new line between multiple breakdowns of a single line.

codemzs · 2019-07-02T05:53:56Z

+ // full map. If that parameter is left to the default 0 value, the
+ // mapping is not preserved.
+ var pipeline = mlContext.Transforms.Conversion.Hash("CategoryHashed",
+ "Category", numberOfBits: 16, maximumNumberOfInverts: -1).Append(


.Append( [](start = 73, length = 8)
I would move .Append to a new line. to be clear we are adding a new transform.

codemzs · 2019-07-02T05:54:15Z

+ "TokenizedText", nameof(DataPoint.Review)).Append(mlContext
+ .Transforms.Conversion.MapValueToKey(nameof(TransformedData.Keys),
+ "TokenizedText"));



please move .Append to a new line.

codemzs

…learning into transform85

sharwell

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

rayankrish · 2019-07-02T18:20:42Z

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

Thank you for all of your comments and suggestions. We are going to review and check-in these PRs to address the issue of the 85 character limit. We will open a new issue with subsequent improvements to implement the style guides you had suggested.

sierralee51 · 2019-07-02T22:18:36Z

- Console.WriteLine($"{featureRow.StudyTime}\t\t{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t{featureRow.CourseCategory}");
+ Console.WriteLine($"{featureRow.StudyTime}\t\t" +
+ $"{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t" +
+ $"{featureRow.CourseCategory}");


…sform to Width 85 (dotnet#3943) * samples/dynamic/transforms/conversions formatted to 85 char * samples/dynamic/transforms/featureselection formatted to 85 char * ImageAnalytics * ImageAnalytics * small corrections to formatting * minor tab and empty line changes

rayankrish · 2019-07-01T22:47:29Z

Guidelines followed:
-85 characters per line
-Use 4 spaces for indentation
-Dot and open parentheses stay on same line as function
-If not a preexisting line under line that we break, add an extra line after it
-Don't indent comments
-Don't break a comment if it represents output
-Don't break links
-If applicable, break right before $
-Keep math op together

Fix for issue #3478

codemzs · 2019-07-02T05:51:09Z

+ // SurvivedInt32' (Int32)
+ var convertedData = mlContext.Data.CreateEnumerable<TransformedData>(
+ transformedData, true);
 foreach (var item in convertedData)


new line between any two lines that were broken down into multiple lines but no new line between multiple breakdowns of a single line.

codemzs · 2019-07-02T05:53:56Z

+ // full map. If that parameter is left to the default 0 value, the
+ // mapping is not preserved.
+ var pipeline = mlContext.Transforms.Conversion.Hash("CategoryHashed",
+ "Category", numberOfBits: 16, maximumNumberOfInverts: -1).Append(


.Append( [](start = 73, length = 8)
I would move .Append to a new line. to be clear we are adding a new transform.

codemzs · 2019-07-02T05:54:15Z

+ "TokenizedText", nameof(DataPoint.Review)).Append(mlContext
+ .Transforms.Conversion.MapValueToKey(nameof(TransformedData.Keys),
+ "TokenizedText"));



please move .Append to a new line.

codemzs

…learning into transform85

sharwell

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

rayankrish · 2019-07-02T18:20:42Z

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

Thank you for all of your comments and suggestions. We are going to review and check-in these PRs to address the issue of the 85 character limit. We will open a new issue with subsequent improvements to implement the style guides you had suggested.

sierralee51 · 2019-07-02T22:18:36Z

- Console.WriteLine($"{featureRow.StudyTime}\t\t{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t{featureRow.CourseCategory}");
+ Console.WriteLine($"{featureRow.StudyTime}\t\t" +
+ $"{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t" +
+ $"{featureRow.CourseCategory}");


…sform to Width 85 (dotnet#3943) * samples/dynamic/transforms/conversions formatted to 85 char * samples/dynamic/transforms/featureselection formatted to 85 char * ImageAnalytics * ImageAnalytics * small corrections to formatting * minor tab and empty line changes

rayankrish · 2019-07-01T22:47:29Z

Guidelines followed:
-85 characters per line
-Use 4 spaces for indentation
-Dot and open parentheses stay on same line as function
-If not a preexisting line under line that we break, add an extra line after it
-Don't indent comments
-Don't break a comment if it represents output
-Don't break links
-If applicable, break right before $
-Keep math op together

Fix for issue #3478

codemzs · 2019-07-02T05:51:09Z

+ // SurvivedInt32' (Int32)
+ var convertedData = mlContext.Data.CreateEnumerable<TransformedData>(
+ transformedData, true);
 foreach (var item in convertedData)


new line between any two lines that were broken down into multiple lines but no new line between multiple breakdowns of a single line.

codemzs · 2019-07-02T05:53:56Z

+ // full map. If that parameter is left to the default 0 value, the
+ // mapping is not preserved.
+ var pipeline = mlContext.Transforms.Conversion.Hash("CategoryHashed",
+ "Category", numberOfBits: 16, maximumNumberOfInverts: -1).Append(


.Append( [](start = 73, length = 8)
I would move .Append to a new line. to be clear we are adding a new transform.

codemzs · 2019-07-02T05:54:15Z

+ "TokenizedText", nameof(DataPoint.Review)).Append(mlContext
+ .Transforms.Conversion.MapValueToKey(nameof(TransformedData.Keys),
+ "TokenizedText"));



please move .Append to a new line.

codemzs

…learning into transform85

sharwell

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

rayankrish · 2019-07-02T18:20:42Z

Requesting changes. The readability of these reformat pull requests is especially bad. I left a bunch of notes in one of the earlier ones, but those notes do not cover all situations where this is worse than before.

Thank you for all of your comments and suggestions. We are going to review and check-in these PRs to address the issue of the 85 character limit. We will open a new issue with subsequent improvements to implement the style guides you had suggested.

sierralee51 · 2019-07-02T22:18:36Z

- Console.WriteLine($"{featureRow.StudyTime}\t\t{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t{featureRow.CourseCategory}");
+ Console.WriteLine($"{featureRow.StudyTime}\t\t" +
+ $"{featureRow.StudyTimeCategory}\t\t\t{featureRow.Course}\t\t" +
+ $"{featureRow.CourseCategory}");


…sform to Width 85 (dotnet#3943) * samples/dynamic/transforms/conversions formatted to 85 char * samples/dynamic/transforms/featureselection formatted to 85 char * ImageAnalytics * ImageAnalytics * small corrections to formatting * minor tab and empty line changes

Rayan Krishnan added 3 commits July 1, 2019 15:08

samples/dynamic/transforms/conversions formatted to 85 char
9267d02

samples/dynamic/transforms/featureselection formatted to 85 char
f2a18ed

ImageAnalytics
38c8938

rayankrish requested review from artidoro, codemzs, natke and wschin July 1, 2019 22:47

codemzs reviewed Jul 2, 2019
View reviewed changes

codemzs approved these changes Jul 2, 2019
View reviewed changes

Rayan Krishnan added 3 commits July 2, 2019 00:19

ImageAnalytics
67080d1

small corrections to formatting
ecd2738

Merge branch 'transform85' ofhttps://github.com/RadicalRayan/machine…
91532b0
…learning into transform85

sharwell suggested changes Jul 2, 2019
View reviewed changes

sierralee51 reviewed Jul 2, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Transforms/ImageAnalytics/ResizeImages.cs

sierralee51 approved these changes Jul 2, 2019
View reviewed changes

minor tab and empty line changes
3deb533

rayankrish merged commit 882a6d9 into dotnet:masterJul 3, 2019

rayankrish deleted the transform85 branch July 3, 2019 00:11

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

Rayan Krishnan added 3 commits July 1, 2019 15:08

samples/dynamic/transforms/conversions formatted to 85 char
9267d02

samples/dynamic/transforms/featureselection formatted to 85 char
f2a18ed

ImageAnalytics
38c8938

rayankrish requested review from artidoro, codemzs, natke and wschin July 1, 2019 22:47

codemzs reviewed Jul 2, 2019
View reviewed changes

codemzs approved these changes Jul 2, 2019
View reviewed changes

Rayan Krishnan added 3 commits July 2, 2019 00:19

ImageAnalytics
67080d1

small corrections to formatting
ecd2738

Merge branch 'transform85' ofhttps://github.com/RadicalRayan/machine…
91532b0
…learning into transform85

sharwell suggested changes Jul 2, 2019
View reviewed changes

sierralee51 reviewed Jul 2, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Transforms/ImageAnalytics/ResizeImages.cs

sierralee51 approved these changes Jul 2, 2019
View reviewed changes

minor tab and empty line changes
3deb533

rayankrish merged commit 882a6d9 into dotnet:masterJul 3, 2019

rayankrish deleted the transform85 branch July 3, 2019 00:11

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

Rayan Krishnan added 3 commits July 1, 2019 15:08

samples/dynamic/transforms/conversions formatted to 85 char
9267d02

samples/dynamic/transforms/featureselection formatted to 85 char
f2a18ed

ImageAnalytics
38c8938

rayankrish requested review from artidoro, codemzs, natke and wschin July 1, 2019 22:47

codemzs reviewed Jul 2, 2019
View reviewed changes

codemzs approved these changes Jul 2, 2019
View reviewed changes

Rayan Krishnan added 3 commits July 2, 2019 00:19

ImageAnalytics
67080d1

small corrections to formatting
ecd2738

Merge branch 'transform85' ofhttps://github.com/RadicalRayan/machine…
91532b0
…learning into transform85

sharwell suggested changes Jul 2, 2019
View reviewed changes

sierralee51 reviewed Jul 2, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Transforms/ImageAnalytics/ResizeImages.cs

sierralee51 approved these changes Jul 2, 2019
View reviewed changes

minor tab and empty line changes
3deb533

rayankrish merged commit 882a6d9 into dotnet:masterJul 3, 2019

rayankrish deleted the transform85 branch July 3, 2019 00:11

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

Rayan Krishnan added 3 commits July 1, 2019 15:08

samples/dynamic/transforms/conversions formatted to 85 char
9267d02

samples/dynamic/transforms/featureselection formatted to 85 char
f2a18ed

ImageAnalytics
38c8938

rayankrish requested review from artidoro, codemzs, natke and wschin July 1, 2019 22:47

codemzs reviewed Jul 2, 2019
View reviewed changes

codemzs approved these changes Jul 2, 2019
View reviewed changes

Rayan Krishnan added 3 commits July 2, 2019 00:19

ImageAnalytics
67080d1

small corrections to formatting
ecd2738

Merge branch 'transform85' ofhttps://github.com/RadicalRayan/machine…
91532b0
…learning into transform85

sharwell suggested changes Jul 2, 2019
View reviewed changes

sierralee51 reviewed Jul 2, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Transforms/ImageAnalytics/ResizeImages.cs

sierralee51 approved these changes Jul 2, 2019
View reviewed changes

minor tab and empty line changes
3deb533

rayankrish merged commit 882a6d9 into dotnet:masterJul 3, 2019

rayankrish deleted the transform85 branch July 3, 2019 00:11

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

Rayan Krishnan added 3 commits July 1, 2019 15:08

samples/dynamic/transforms/conversions formatted to 85 char
9267d02

samples/dynamic/transforms/featureselection formatted to 85 char
f2a18ed

ImageAnalytics
38c8938

rayankrish requested review from artidoro, codemzs, natke and wschin July 1, 2019 22:47

codemzs reviewed Jul 2, 2019
View reviewed changes

codemzs approved these changes Jul 2, 2019
View reviewed changes

Rayan Krishnan added 3 commits July 2, 2019 00:19

ImageAnalytics
67080d1

small corrections to formatting
ecd2738

Merge branch 'transform85' ofhttps://github.com/RadicalRayan/machine…
91532b0
…learning into transform85

sharwell suggested changes Jul 2, 2019
View reviewed changes

sierralee51 reviewed Jul 2, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Transforms/ImageAnalytics/ResizeImages.cs

sierralee51 approved these changes Jul 2, 2019
View reviewed changes

minor tab and empty line changes
3deb533

rayankrish merged commit 882a6d9 into dotnet:masterJul 3, 2019

rayankrish deleted the transform85 branch July 3, 2019 00:11

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

Rayan Krishnan added 3 commits July 1, 2019 15:08

samples/dynamic/transforms/conversions formatted to 85 char
9267d02

samples/dynamic/transforms/featureselection formatted to 85 char
f2a18ed

ImageAnalytics
38c8938

rayankrish requested review from artidoro, codemzs, natke and wschin July 1, 2019 22:47

codemzs reviewed Jul 2, 2019
View reviewed changes

codemzs approved these changes Jul 2, 2019
View reviewed changes

Rayan Krishnan added 3 commits July 2, 2019 00:19

ImageAnalytics
67080d1

small corrections to formatting
ecd2738

Merge branch 'transform85' ofhttps://github.com/RadicalRayan/machine…
91532b0
…learning into transform85

sharwell suggested changes Jul 2, 2019
View reviewed changes

sierralee51 reviewed Jul 2, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Transforms/ImageAnalytics/ResizeImages.cs

sierralee51 approved these changes Jul 2, 2019
View reviewed changes

minor tab and empty line changes
3deb533

rayankrish merged commit 882a6d9 into dotnet:masterJul 3, 2019

rayankrish deleted the transform85 branch July 3, 2019 00:11

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

Rayan Krishnan added 3 commits July 1, 2019 15:08

samples/dynamic/transforms/conversions formatted to 85 char
9267d02

samples/dynamic/transforms/featureselection formatted to 85 char
f2a18ed

ImageAnalytics
38c8938

rayankrish requested review from artidoro, codemzs, natke and wschin July 1, 2019 22:47

codemzs reviewed Jul 2, 2019
View reviewed changes

codemzs approved these changes Jul 2, 2019
View reviewed changes

Rayan Krishnan added 3 commits July 2, 2019 00:19

ImageAnalytics
67080d1

small corrections to formatting
ecd2738

Merge branch 'transform85' ofhttps://github.com/RadicalRayan/machine…
91532b0
…learning into transform85

sharwell suggested changes Jul 2, 2019
View reviewed changes

sierralee51 reviewed Jul 2, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Transforms/ImageAnalytics/ResizeImages.cs

sierralee51 approved these changes Jul 2, 2019
View reviewed changes

minor tab and empty line changes
3deb533

rayankrish merged commit 882a6d9 into dotnet:masterJul 3, 2019

rayankrish deleted the transform85 branch July 3, 2019 00:11

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

Rayan Krishnan added 3 commits July 1, 2019 15:08

samples/dynamic/transforms/conversions formatted to 85 char
9267d02

samples/dynamic/transforms/featureselection formatted to 85 char
f2a18ed

ImageAnalytics
38c8938

rayankrish requested review from artidoro, codemzs, natke and wschin July 1, 2019 22:47

codemzs reviewed Jul 2, 2019
View reviewed changes

codemzs approved these changes Jul 2, 2019
View reviewed changes

Rayan Krishnan added 3 commits July 2, 2019 00:19

ImageAnalytics
67080d1

small corrections to formatting
ecd2738

Merge branch 'transform85' ofhttps://github.com/RadicalRayan/machine…
91532b0
…learning into transform85

sharwell suggested changes Jul 2, 2019
View reviewed changes

sierralee51 reviewed Jul 2, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Transforms/ImageAnalytics/ResizeImages.cs

sierralee51 approved these changes Jul 2, 2019
View reviewed changes

minor tab and empty line changes
3deb533

rayankrish merged commit 882a6d9 into dotnet:masterJul 3, 2019

rayankrish deleted the transform85 branch July 3, 2019 00:11

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

Uh oh!

Conversation

rayankrish commented Jul 1, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codemzs left a comment

Choose a reason for hiding this comment

Uh oh!

sharwell left a comment

Choose a reason for hiding this comment

Uh oh!

rayankrish commented Jul 2, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

rayankrish commented Jul 1, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codemzs left a comment

Choose a reason for hiding this comment

Uh oh!

sharwell left a comment

Choose a reason for hiding this comment

Uh oh!

rayankrish commented Jul 2, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

rayankrish commented Jul 1, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codemzs left a comment

Choose a reason for hiding this comment

Uh oh!

sharwell left a comment

Choose a reason for hiding this comment

Uh oh!

rayankrish commented Jul 2, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers