Remove Extra Code Comments and unused InternalStreams project - #514

Merged
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom
dan-drews:Remove_Extra_Comments
Jul 13, 2018
Merged

Remove Extra Code Comments and unused InternalStreams project#514
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom
dan-drews:Remove_Extra_Comments

Conversation

@dan-drews

@dan-drewsdan-drews commented Jul 10, 2018

Copy link
Copy Markdown
Contributor

Fixes#513

This is the first go-around at finding extra commented code sitting around. I'll circle back on more when I have a chance.

TomFinley
TomFinley reviewed Jul 10, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
Done();
}

//[Fact]

@TomFinleyTomFinleyJul 10, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dan-drews thanks for looking at this. One thing I wonder about is, should this be uncommented and turn into a fact-skip? Or is the code just too far gone for that? (I might suspect some of the names may have changed.)

@dan-drewsdan-drewsJul 10, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomFinley I'll take a look. Should my rule of thumb be that if it compiles, I leave it as fact-skip, otherwise I remove it? I could try to see what things are renamed to, but I'm still not super familiar with this project yet

Edit: Upon further review, there are references to a class called Dv1. That appears not to exist anymore.

@TomFinleyTomFinleyJul 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately some classes have been renamed in the leadup to the public release a couple months ago. If it's not obvious how to do it, I would prefer that you leave the commented out code there, rather than destroy the test, since I think I know how "reanimate" this test. (E.g., Dv1 I think is DvInt1, etc. etc.) So while the main codebase I think could use with cleaning, something like this I might prefer to review more carefully. Maybe not cut this one?

@TomFinleyTomFinleyJul 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be that it's appropriate to remove it, but I'd prefer to do so in a more deliberative way.

In reply to: 201912980 [](ancestors = 201912980)

@dan-drewsdan-drewsJul 13, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-added those tests, and just left them commented out. I tried to simply change Dv1 to DvInt1, but the parameters are different. I'd rather somebody with a greater understanding of what is going on here dig through it. Thanks for the feedback!

@TomFinley

TomFinley commented Jul 10, 2018

Copy link
Copy Markdown
Contributor
 public uint /*ulong*/ /*IntPtr*/ /*NTSTATUS*/ Status;

I think this and the other line are some things we may consider removing.

Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:271 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)

@TomFinley

TomFinley commented Jul 10, 2018

Copy link
Copy Markdown
Contributor
 Status = 0; //IntPtr.Zero;

As is this.

Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:276 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)

@dan-drewsdan-drews changed the title WIP Remove Extra Code CommentsRemove Extra Code CommentsJul 10, 2018
@dan-drews

dan-drews commented Jul 10, 2018

Copy link
Copy Markdown
ContributorAuthor

Removed WIP tag. I'm sure there are more comments to be removed, but I think this was a pretty good sweep.

Ivanidzo4ka
Ivanidzo4ka reviewed Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.FastTree/Application/LogLossApplication.cs Outdated
_gradient[d2] -= 0.01 * labelDiff;
}
*/
_gradient[d2] -= delta;

@Ivanidzo4kaIvanidzo4kaJul 11, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 [](start = 43, length = 20)

can you format this file in VS? or at least remove all extra spaces here. #Resolved

@Ivanidzo4ka

Ivanidzo4ka commented Jul 11, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor
 private ParameterSet[] TreeOrderedCandidatesSearch(FastForestRegressionPredictor forest, int numOfCandidates, IEnumerable<IRunResult> previousRuns)

Feel free to delete whole function, no one calls it anyway. #Closed

Refers to: src/Microsoft.ML.Sweeper/Algorithms/SmacSweeper.cs:185 in 97290b2. [](commit_id = 97290b2, deletion_comment = False)

Ivanidzo4ka
Ivanidzo4ka reviewed Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/FactorizationMachine/FactorizationMachineInterface.cs Outdated
[DllImport(NativePath), SuppressUnmanagedCodeSecurity]
public static extern void CalculateGradientAndUpdateNative(float lambdaLinear, float lambdaLatent, float learningRate, int fieldCount, int latentDim, float weight,
int count, int* /*const*/ fieldIndices, int* /*const*/ featureIndices, float* /*const*/ featureValues, float* /*const*/ latentSum, float slope,
int count, int* fieldIndices, int* featureIndices, float* featureValues, float* latentSum, float slope,

@Ivanidzo4kaIvanidzo4kaJul 11, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#383 (comment)
See @wschin comment.
I agree this is not the best solution, but I would prefer to preserve this information until we figure out better one.
Same states for Thunk.cs.

We have them for a reason.
#Resolved

@Ivanidzo4ka

Ivanidzo4ka commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Thank you for your work @dan-drews !
Can we slightly change name of this PR to address removal of InternalStreams project?

@dan-drewsdan-drews changed the title Remove Extra Code CommentsRemove Extra Code Comments and unused InternalStreams projectJul 11, 2018
TomFinley
TomFinley reviewed Jul 12, 2018
View reviewed changes
Comment threadMicrosoft.ML.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.TestFramework", "test\Microsoft.ML.TestFramework\Microsoft.ML.TestFramework.csproj", "{B5989C06-4FFA-46C1-9D85-9366B34AB0A2}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.InternalStreams", "src\Microsoft.ML.InternalStreams\Microsoft.ML.InternalStreams.csproj", "{C4F7938F-7109-43C8-92A5-9BE47C7FF7D9}"

@TomFinleyTomFinleyJul 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆 🍾 😆 Good riddance!!

TomFinley
TomFinley reviewed Jul 12, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.Core/Utilities/MathUtils.cs Outdated
// return SoftMax(inputs[0], inputs[1]);
//}


@TomFinleyTomFinleyJul 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line with space on it introduced.

@dan-drewsdan-drewsJul 13, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the blank line okay as long as the whitespace is removed?That matches the if statement above.

Also, for my own reference, how can you tell there is whitespace? Is it through Visual Studio? Or is there also a way to know through github?

TomFinley
TomFinley reviewed Jul 12, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
}

//[Fact]
//public void EntryPointArrayOfVariables()

@TomFinleyTomFinleyJul 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//public void EntryPointArrayOfVariables() [](start = 8, length = 42)

Similar with this.

@shauheen
shauheen requested a review from codemzsJuly 12, 2018 09:39
@dan-drewsdan-drews changed the title Remove Extra Code Comments and unused InternalStreams project[WIP] Remove Extra Code Comments and unused InternalStreams projectJul 13, 2018
@dan-drewsdan-drews changed the title [WIP] Remove Extra Code Comments and unused InternalStreams projectRemove Extra Code Comments and unused InternalStreams projectJul 13, 2018
TomFinley
TomFinley approved these changes Jul 13, 2018
View reviewed changes

@TomFinleyTomFinley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-drews ! I think the builds are failing due to #428 commit, but once #527 goes in we can request a rebuild...

@Ivanidzo4ka

Ivanidzo4ka commented Jul 13, 2018

Copy link
Copy Markdown
Contributor

@dotnet-bot test Windows_NT Debug
@dotnet-bot test Windows_NT Release
@dotnet-bot test OSX10.13 Debug
@dotnet-bot test OSX10.13 Release
@dotnet-bot test Linux Debug
@dotnet-bot test Linux Release

Ivanidzo4ka
Ivanidzo4ka approved these changes Jul 13, 2018
View reviewed changes

@Ivanidzo4kaIvanidzo4ka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka
Ivanidzo4ka merged commit 669f4fa into dotnet:masterJul 13, 2018
eerhardt pushed a commit to eerhardt/machinelearning that referenced this pull request Jul 27, 2018
@dan-drews@eerhardt
Remove Extra Code Comments and unused InternalStreams project (dotnet…
3a37b4e
…#514)
* First attempt at removing extra code comments
* Round #2
* Removing Microsoft.ML.InternalStreams per comment on dotnet#513
* Address notes from @Ivanidzo4ka
* Remove TreeOrderedCandidatesSearch
* Remove whitespace and reinstate commented out tests
@ghostghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@codemzscodemzsAwaiting requested review from codemzs
2 more reviewers
@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dan-drews@TomFinley@Ivanidzo4ka
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Remove Extra Code Comments and unused InternalStreams project - #514
Merged
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Jul 13, 2018
Merged
Remove Extra Code Comments and unused InternalStreams project#514
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Conversation
@dan-drews
@dan-drewsdan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
Fixes#513
This is the first go-around at finding extra commented code sitting around. I'll circle back on more when I have a chance.
TomFinley
TomFinley
reviewed
Jul 10, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 Done();
 }

 //[Fact]
@TomFinleyTomFinleyJul 10, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dan-drews thanks for looking at this. One thing I wonder about is, should this be uncommented and turn into a fact-skip? Or is the code just too far gone for that? (I might suspect some of the names may have changed.)
@dan-drewsdan-drewsJul 10, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomFinley I'll take a look. Should my rule of thumb be that if it compiles, I leave it as fact-skip, otherwise I remove it? I could try to see what things are renamed to, but I'm still not super familiar with this project yet
Edit: Upon further review, there are references to a class called Dv1. That appears not to exist anymore.
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately some classes have been renamed in the leadup to the public release a couple months ago. If it's not obvious how to do it, I would prefer that you leave the commented out code there, rather than destroy the test, since I think I know how "reanimate" this test. (E.g., Dv1 I think is DvInt1, etc. etc.) So while the main codebase I think could use with cleaning, something like this I might prefer to review more carefully. Maybe not cut this one?
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be that it's appropriate to remove it, but I'd prefer to do so in a more deliberative way.
In reply to: 201912980 [](ancestors = 201912980)
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-added those tests, and just left them commented out. I tried to simply change Dv1 to DvInt1, but the parameters are different. I'd rather somebody with a greater understanding of what is going on here dig through it. Thanks for the feedback!
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 public uint /*ulong*/ /*IntPtr*/ /*NTSTATUS*/ Status;

I think this and the other line are some things we may consider removing.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:271 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 Status = 0; //IntPtr.Zero;

As is this.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:276 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@dan-drewsdan-drews
changed the title
WIP Remove Extra Code CommentsRemove Extra Code CommentsJul 10, 2018
@dan-drews
dan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Removed WIP tag. I'm sure there are more comments to be removed, but I think this was a pretty good sweep.
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.FastTree/Application/LogLossApplication.cs
Outdated

 _gradient[d2] -= 0.01 * labelDiff;
 }
 */
 _gradient[d2] -= delta; 
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 [](start = 43, length = 20)

can you format this file in VS? or at least remove all extra spaces here. #Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 private ParameterSet[] TreeOrderedCandidatesSearch(FastForestRegressionPredictor forest, int numOfCandidates, IEnumerable<IRunResult> previousRuns)

Feel free to delete whole function, no one calls it anyway. #Closed
Refers to: src/Microsoft.ML.Sweeper/Algorithms/SmacSweeper.cs:185 in 97290b2. [](commit_id = 97290b2, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/FactorizationMachine/FactorizationMachineInterface.cs
Outdated

 [DllImport(NativePath), SuppressUnmanagedCodeSecurity]
 public static extern void CalculateGradientAndUpdateNative(float lambdaLinear, float lambdaLatent, float learningRate, int fieldCount, int latentDim, float weight,
 int count, int* /*const*/ fieldIndices, int* /*const*/ featureIndices, float* /*const*/ featureValues, float* /*const*/ latentSum, float slope,
 int count, int* fieldIndices, int* featureIndices, float* featureValues, float* latentSum, float slope,
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#383 (comment)

See @wschin comment.

I agree this is not the best solution, but I would prefer to preserve this information until we figure out better one.

Same states for Thunk.cs.
We have them for a reason.

#Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018

Copy link


Copy Markdown

Contributor
Thank you for your work @dan-drews !

Can we slightly change name of this PR to address removal of InternalStreams project?
@dan-drewsdan-drews
changed the title
Remove Extra Code CommentsRemove Extra Code Comments and unused InternalStreams projectJul 11, 2018
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadMicrosoft.ML.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.TestFramework", "test\Microsoft.ML.TestFramework\Microsoft.ML.TestFramework.csproj", "{B5989C06-4FFA-46C1-9D85-9366B34AB0A2}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.InternalStreams", "src\Microsoft.ML.InternalStreams\Microsoft.ML.InternalStreams.csproj", "{C4F7938F-7109-43C8-92A5-9BE47C7FF7D9}"
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆 🍾 😆 Good riddance!!
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.Core/Utilities/MathUtils.cs
Outdated

 // return SoftMax(inputs[0], inputs[1]);
 //}


@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line with space on it introduced.
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the blank line okay as long as the whitespace is removed?That matches the if statement above.
Also, for my own reference, how can you tell there is whitespace? Is it through Visual Studio? Or is there also a way to know through github?
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 }

 //[Fact]
 //public void EntryPointArrayOfVariables()
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//public void EntryPointArrayOfVariables() [](start = 8, length = 42)
Similar with this.
@shauheen
shauheen
requested a review
from codemzsJuly 12, 2018 09:39
@dan-drewsdan-drews
changed the title
Remove Extra Code Comments and unused InternalStreams project[WIP] Remove Extra Code Comments and unused InternalStreams projectJul 13, 2018
@dan-drewsdan-drews
changed the title
[WIP] Remove Extra Code Comments and unused InternalStreams projectRemove Extra Code Comments and unused InternalStreams projectJul 13, 2018
TomFinley
TomFinley
approved these changes
Jul 13, 2018
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-drews ! I think the builds are failing due to #428 commit, but once #527 goes in we can request a rebuild...
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 13, 2018

Copy link


Copy Markdown

Contributor
@dotnet-bot test Windows_NT Debug
@dotnet-bot test Windows_NT Release
@dotnet-bot test OSX10.13 Debug
@dotnet-bot test OSX10.13 Release
@dotnet-bot test Linux Debug
@dotnet-bot test Linux Release
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Jul 13, 2018
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit 669f4fa
into
dotnet:masterJul 13, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@dan-drews@eerhardt
Remove Extra Code Comments and unused InternalStreams project (dotnet…
3a37b4e
…#514)
* First attempt at removing extra code comments
* Round #2
* Removing Microsoft.ML.InternalStreams per comment on dotnet#513
* Address notes from @Ivanidzo4ka
* Remove TreeOrderedCandidatesSearch
* Remove whitespace and reinstate commented out tests
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzsAwaiting requested review from codemzs

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dan-drews@TomFinley@Ivanidzo4ka

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove Extra Code Comments and unused InternalStreams project - #514
Merged
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Jul 13, 2018
Merged
Remove Extra Code Comments and unused InternalStreams project#514
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Conversation
@dan-drews
@dan-drewsdan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
Fixes#513
This is the first go-around at finding extra commented code sitting around. I'll circle back on more when I have a chance.
TomFinley
TomFinley
reviewed
Jul 10, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 Done();
 }

 //[Fact]
@TomFinleyTomFinleyJul 10, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dan-drews thanks for looking at this. One thing I wonder about is, should this be uncommented and turn into a fact-skip? Or is the code just too far gone for that? (I might suspect some of the names may have changed.)
@dan-drewsdan-drewsJul 10, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomFinley I'll take a look. Should my rule of thumb be that if it compiles, I leave it as fact-skip, otherwise I remove it? I could try to see what things are renamed to, but I'm still not super familiar with this project yet
Edit: Upon further review, there are references to a class called Dv1. That appears not to exist anymore.
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately some classes have been renamed in the leadup to the public release a couple months ago. If it's not obvious how to do it, I would prefer that you leave the commented out code there, rather than destroy the test, since I think I know how "reanimate" this test. (E.g., Dv1 I think is DvInt1, etc. etc.) So while the main codebase I think could use with cleaning, something like this I might prefer to review more carefully. Maybe not cut this one?
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be that it's appropriate to remove it, but I'd prefer to do so in a more deliberative way.
In reply to: 201912980 [](ancestors = 201912980)
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-added those tests, and just left them commented out. I tried to simply change Dv1 to DvInt1, but the parameters are different. I'd rather somebody with a greater understanding of what is going on here dig through it. Thanks for the feedback!
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 public uint /*ulong*/ /*IntPtr*/ /*NTSTATUS*/ Status;

I think this and the other line are some things we may consider removing.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:271 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 Status = 0; //IntPtr.Zero;

As is this.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:276 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@dan-drewsdan-drews
changed the title
WIP Remove Extra Code CommentsRemove Extra Code CommentsJul 10, 2018
@dan-drews
dan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Removed WIP tag. I'm sure there are more comments to be removed, but I think this was a pretty good sweep.
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.FastTree/Application/LogLossApplication.cs
Outdated

 _gradient[d2] -= 0.01 * labelDiff;
 }
 */
 _gradient[d2] -= delta; 
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 [](start = 43, length = 20)

can you format this file in VS? or at least remove all extra spaces here. #Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 private ParameterSet[] TreeOrderedCandidatesSearch(FastForestRegressionPredictor forest, int numOfCandidates, IEnumerable<IRunResult> previousRuns)

Feel free to delete whole function, no one calls it anyway. #Closed
Refers to: src/Microsoft.ML.Sweeper/Algorithms/SmacSweeper.cs:185 in 97290b2. [](commit_id = 97290b2, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/FactorizationMachine/FactorizationMachineInterface.cs
Outdated

 [DllImport(NativePath), SuppressUnmanagedCodeSecurity]
 public static extern void CalculateGradientAndUpdateNative(float lambdaLinear, float lambdaLatent, float learningRate, int fieldCount, int latentDim, float weight,
 int count, int* /*const*/ fieldIndices, int* /*const*/ featureIndices, float* /*const*/ featureValues, float* /*const*/ latentSum, float slope,
 int count, int* fieldIndices, int* featureIndices, float* featureValues, float* latentSum, float slope,
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#383 (comment)

See @wschin comment.

I agree this is not the best solution, but I would prefer to preserve this information until we figure out better one.

Same states for Thunk.cs.
We have them for a reason.

#Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018

Copy link


Copy Markdown

Contributor
Thank you for your work @dan-drews !

Can we slightly change name of this PR to address removal of InternalStreams project?
@dan-drewsdan-drews
changed the title
Remove Extra Code CommentsRemove Extra Code Comments and unused InternalStreams projectJul 11, 2018
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadMicrosoft.ML.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.TestFramework", "test\Microsoft.ML.TestFramework\Microsoft.ML.TestFramework.csproj", "{B5989C06-4FFA-46C1-9D85-9366B34AB0A2}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.InternalStreams", "src\Microsoft.ML.InternalStreams\Microsoft.ML.InternalStreams.csproj", "{C4F7938F-7109-43C8-92A5-9BE47C7FF7D9}"
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆 🍾 😆 Good riddance!!
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.Core/Utilities/MathUtils.cs
Outdated

 // return SoftMax(inputs[0], inputs[1]);
 //}


@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line with space on it introduced.
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the blank line okay as long as the whitespace is removed?That matches the if statement above.
Also, for my own reference, how can you tell there is whitespace? Is it through Visual Studio? Or is there also a way to know through github?
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 }

 //[Fact]
 //public void EntryPointArrayOfVariables()
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//public void EntryPointArrayOfVariables() [](start = 8, length = 42)
Similar with this.
@shauheen
shauheen
requested a review
from codemzsJuly 12, 2018 09:39
@dan-drewsdan-drews
changed the title
Remove Extra Code Comments and unused InternalStreams project[WIP] Remove Extra Code Comments and unused InternalStreams projectJul 13, 2018
@dan-drewsdan-drews
changed the title
[WIP] Remove Extra Code Comments and unused InternalStreams projectRemove Extra Code Comments and unused InternalStreams projectJul 13, 2018
TomFinley
TomFinley
approved these changes
Jul 13, 2018
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-drews ! I think the builds are failing due to #428 commit, but once #527 goes in we can request a rebuild...
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 13, 2018

Copy link


Copy Markdown

Contributor
@dotnet-bot test Windows_NT Debug
@dotnet-bot test Windows_NT Release
@dotnet-bot test OSX10.13 Debug
@dotnet-bot test OSX10.13 Release
@dotnet-bot test Linux Debug
@dotnet-bot test Linux Release
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Jul 13, 2018
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit 669f4fa
into
dotnet:masterJul 13, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@dan-drews@eerhardt
Remove Extra Code Comments and unused InternalStreams project (dotnet…
3a37b4e
…#514)
* First attempt at removing extra code comments
* Round #2
* Removing Microsoft.ML.InternalStreams per comment on dotnet#513
* Address notes from @Ivanidzo4ka
* Remove TreeOrderedCandidatesSearch
* Remove whitespace and reinstate commented out tests
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzsAwaiting requested review from codemzs

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dan-drews@TomFinley@Ivanidzo4ka

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove Extra Code Comments and unused InternalStreams project - #514
Merged
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Jul 13, 2018
Merged
Remove Extra Code Comments and unused InternalStreams project#514
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Conversation
@dan-drews
@dan-drewsdan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
Fixes#513
This is the first go-around at finding extra commented code sitting around. I'll circle back on more when I have a chance.
TomFinley
TomFinley
reviewed
Jul 10, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 Done();
 }

 //[Fact]
@TomFinleyTomFinleyJul 10, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dan-drews thanks for looking at this. One thing I wonder about is, should this be uncommented and turn into a fact-skip? Or is the code just too far gone for that? (I might suspect some of the names may have changed.)
@dan-drewsdan-drewsJul 10, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomFinley I'll take a look. Should my rule of thumb be that if it compiles, I leave it as fact-skip, otherwise I remove it? I could try to see what things are renamed to, but I'm still not super familiar with this project yet
Edit: Upon further review, there are references to a class called Dv1. That appears not to exist anymore.
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately some classes have been renamed in the leadup to the public release a couple months ago. If it's not obvious how to do it, I would prefer that you leave the commented out code there, rather than destroy the test, since I think I know how "reanimate" this test. (E.g., Dv1 I think is DvInt1, etc. etc.) So while the main codebase I think could use with cleaning, something like this I might prefer to review more carefully. Maybe not cut this one?
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be that it's appropriate to remove it, but I'd prefer to do so in a more deliberative way.
In reply to: 201912980 [](ancestors = 201912980)
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-added those tests, and just left them commented out. I tried to simply change Dv1 to DvInt1, but the parameters are different. I'd rather somebody with a greater understanding of what is going on here dig through it. Thanks for the feedback!
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 public uint /*ulong*/ /*IntPtr*/ /*NTSTATUS*/ Status;

I think this and the other line are some things we may consider removing.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:271 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 Status = 0; //IntPtr.Zero;

As is this.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:276 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@dan-drewsdan-drews
changed the title
WIP Remove Extra Code CommentsRemove Extra Code CommentsJul 10, 2018
@dan-drews
dan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Removed WIP tag. I'm sure there are more comments to be removed, but I think this was a pretty good sweep.
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.FastTree/Application/LogLossApplication.cs
Outdated

 _gradient[d2] -= 0.01 * labelDiff;
 }
 */
 _gradient[d2] -= delta; 
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 [](start = 43, length = 20)

can you format this file in VS? or at least remove all extra spaces here. #Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 private ParameterSet[] TreeOrderedCandidatesSearch(FastForestRegressionPredictor forest, int numOfCandidates, IEnumerable<IRunResult> previousRuns)

Feel free to delete whole function, no one calls it anyway. #Closed
Refers to: src/Microsoft.ML.Sweeper/Algorithms/SmacSweeper.cs:185 in 97290b2. [](commit_id = 97290b2, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/FactorizationMachine/FactorizationMachineInterface.cs
Outdated

 [DllImport(NativePath), SuppressUnmanagedCodeSecurity]
 public static extern void CalculateGradientAndUpdateNative(float lambdaLinear, float lambdaLatent, float learningRate, int fieldCount, int latentDim, float weight,
 int count, int* /*const*/ fieldIndices, int* /*const*/ featureIndices, float* /*const*/ featureValues, float* /*const*/ latentSum, float slope,
 int count, int* fieldIndices, int* featureIndices, float* featureValues, float* latentSum, float slope,
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#383 (comment)

See @wschin comment.

I agree this is not the best solution, but I would prefer to preserve this information until we figure out better one.

Same states for Thunk.cs.
We have them for a reason.

#Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018

Copy link


Copy Markdown

Contributor
Thank you for your work @dan-drews !

Can we slightly change name of this PR to address removal of InternalStreams project?
@dan-drewsdan-drews
changed the title
Remove Extra Code CommentsRemove Extra Code Comments and unused InternalStreams projectJul 11, 2018
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadMicrosoft.ML.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.TestFramework", "test\Microsoft.ML.TestFramework\Microsoft.ML.TestFramework.csproj", "{B5989C06-4FFA-46C1-9D85-9366B34AB0A2}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.InternalStreams", "src\Microsoft.ML.InternalStreams\Microsoft.ML.InternalStreams.csproj", "{C4F7938F-7109-43C8-92A5-9BE47C7FF7D9}"
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆 🍾 😆 Good riddance!!
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.Core/Utilities/MathUtils.cs
Outdated

 // return SoftMax(inputs[0], inputs[1]);
 //}


@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line with space on it introduced.
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the blank line okay as long as the whitespace is removed?That matches the if statement above.
Also, for my own reference, how can you tell there is whitespace? Is it through Visual Studio? Or is there also a way to know through github?
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 }

 //[Fact]
 //public void EntryPointArrayOfVariables()
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//public void EntryPointArrayOfVariables() [](start = 8, length = 42)
Similar with this.
@shauheen
shauheen
requested a review
from codemzsJuly 12, 2018 09:39
@dan-drewsdan-drews
changed the title
Remove Extra Code Comments and unused InternalStreams project[WIP] Remove Extra Code Comments and unused InternalStreams projectJul 13, 2018
@dan-drewsdan-drews
changed the title
[WIP] Remove Extra Code Comments and unused InternalStreams projectRemove Extra Code Comments and unused InternalStreams projectJul 13, 2018
TomFinley
TomFinley
approved these changes
Jul 13, 2018
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-drews ! I think the builds are failing due to #428 commit, but once #527 goes in we can request a rebuild...
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 13, 2018

Copy link


Copy Markdown

Contributor
@dotnet-bot test Windows_NT Debug
@dotnet-bot test Windows_NT Release
@dotnet-bot test OSX10.13 Debug
@dotnet-bot test OSX10.13 Release
@dotnet-bot test Linux Debug
@dotnet-bot test Linux Release
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Jul 13, 2018
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit 669f4fa
into
dotnet:masterJul 13, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@dan-drews@eerhardt
Remove Extra Code Comments and unused InternalStreams project (dotnet…
3a37b4e
…#514)
* First attempt at removing extra code comments
* Round #2
* Removing Microsoft.ML.InternalStreams per comment on dotnet#513
* Address notes from @Ivanidzo4ka
* Remove TreeOrderedCandidatesSearch
* Remove whitespace and reinstate commented out tests
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzsAwaiting requested review from codemzs

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dan-drews@TomFinley@Ivanidzo4ka

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Remove Extra Code Comments and unused InternalStreams project - #514
Merged
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Jul 13, 2018
Merged
Remove Extra Code Comments and unused InternalStreams project#514
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Conversation
@dan-drews
@dan-drewsdan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
Fixes#513
This is the first go-around at finding extra commented code sitting around. I'll circle back on more when I have a chance.
TomFinley
TomFinley
reviewed
Jul 10, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 Done();
 }

 //[Fact]
@TomFinleyTomFinleyJul 10, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dan-drews thanks for looking at this. One thing I wonder about is, should this be uncommented and turn into a fact-skip? Or is the code just too far gone for that? (I might suspect some of the names may have changed.)
@dan-drewsdan-drewsJul 10, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomFinley I'll take a look. Should my rule of thumb be that if it compiles, I leave it as fact-skip, otherwise I remove it? I could try to see what things are renamed to, but I'm still not super familiar with this project yet
Edit: Upon further review, there are references to a class called Dv1. That appears not to exist anymore.
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately some classes have been renamed in the leadup to the public release a couple months ago. If it's not obvious how to do it, I would prefer that you leave the commented out code there, rather than destroy the test, since I think I know how "reanimate" this test. (E.g., Dv1 I think is DvInt1, etc. etc.) So while the main codebase I think could use with cleaning, something like this I might prefer to review more carefully. Maybe not cut this one?
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be that it's appropriate to remove it, but I'd prefer to do so in a more deliberative way.
In reply to: 201912980 [](ancestors = 201912980)
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-added those tests, and just left them commented out. I tried to simply change Dv1 to DvInt1, but the parameters are different. I'd rather somebody with a greater understanding of what is going on here dig through it. Thanks for the feedback!
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 public uint /*ulong*/ /*IntPtr*/ /*NTSTATUS*/ Status;

I think this and the other line are some things we may consider removing.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:271 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 Status = 0; //IntPtr.Zero;

As is this.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:276 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@dan-drewsdan-drews
changed the title
WIP Remove Extra Code CommentsRemove Extra Code CommentsJul 10, 2018
@dan-drews
dan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Removed WIP tag. I'm sure there are more comments to be removed, but I think this was a pretty good sweep.
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.FastTree/Application/LogLossApplication.cs
Outdated

 _gradient[d2] -= 0.01 * labelDiff;
 }
 */
 _gradient[d2] -= delta; 
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 [](start = 43, length = 20)

can you format this file in VS? or at least remove all extra spaces here. #Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 private ParameterSet[] TreeOrderedCandidatesSearch(FastForestRegressionPredictor forest, int numOfCandidates, IEnumerable<IRunResult> previousRuns)

Feel free to delete whole function, no one calls it anyway. #Closed
Refers to: src/Microsoft.ML.Sweeper/Algorithms/SmacSweeper.cs:185 in 97290b2. [](commit_id = 97290b2, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/FactorizationMachine/FactorizationMachineInterface.cs
Outdated

 [DllImport(NativePath), SuppressUnmanagedCodeSecurity]
 public static extern void CalculateGradientAndUpdateNative(float lambdaLinear, float lambdaLatent, float learningRate, int fieldCount, int latentDim, float weight,
 int count, int* /*const*/ fieldIndices, int* /*const*/ featureIndices, float* /*const*/ featureValues, float* /*const*/ latentSum, float slope,
 int count, int* fieldIndices, int* featureIndices, float* featureValues, float* latentSum, float slope,
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#383 (comment)

See @wschin comment.

I agree this is not the best solution, but I would prefer to preserve this information until we figure out better one.

Same states for Thunk.cs.
We have them for a reason.

#Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018

Copy link


Copy Markdown

Contributor
Thank you for your work @dan-drews !

Can we slightly change name of this PR to address removal of InternalStreams project?
@dan-drewsdan-drews
changed the title
Remove Extra Code CommentsRemove Extra Code Comments and unused InternalStreams projectJul 11, 2018
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadMicrosoft.ML.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.TestFramework", "test\Microsoft.ML.TestFramework\Microsoft.ML.TestFramework.csproj", "{B5989C06-4FFA-46C1-9D85-9366B34AB0A2}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.InternalStreams", "src\Microsoft.ML.InternalStreams\Microsoft.ML.InternalStreams.csproj", "{C4F7938F-7109-43C8-92A5-9BE47C7FF7D9}"
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆 🍾 😆 Good riddance!!
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.Core/Utilities/MathUtils.cs
Outdated

 // return SoftMax(inputs[0], inputs[1]);
 //}


@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line with space on it introduced.
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the blank line okay as long as the whitespace is removed?That matches the if statement above.
Also, for my own reference, how can you tell there is whitespace? Is it through Visual Studio? Or is there also a way to know through github?
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 }

 //[Fact]
 //public void EntryPointArrayOfVariables()
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//public void EntryPointArrayOfVariables() [](start = 8, length = 42)
Similar with this.
@shauheen
shauheen
requested a review
from codemzsJuly 12, 2018 09:39
@dan-drewsdan-drews
changed the title
Remove Extra Code Comments and unused InternalStreams project[WIP] Remove Extra Code Comments and unused InternalStreams projectJul 13, 2018
@dan-drewsdan-drews
changed the title
[WIP] Remove Extra Code Comments and unused InternalStreams projectRemove Extra Code Comments and unused InternalStreams projectJul 13, 2018
TomFinley
TomFinley
approved these changes
Jul 13, 2018
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-drews ! I think the builds are failing due to #428 commit, but once #527 goes in we can request a rebuild...
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 13, 2018

Copy link


Copy Markdown

Contributor
@dotnet-bot test Windows_NT Debug
@dotnet-bot test Windows_NT Release
@dotnet-bot test OSX10.13 Debug
@dotnet-bot test OSX10.13 Release
@dotnet-bot test Linux Debug
@dotnet-bot test Linux Release
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Jul 13, 2018
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit 669f4fa
into
dotnet:masterJul 13, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@dan-drews@eerhardt
Remove Extra Code Comments and unused InternalStreams project (dotnet…
3a37b4e
…#514)
* First attempt at removing extra code comments
* Round #2
* Removing Microsoft.ML.InternalStreams per comment on dotnet#513
* Address notes from @Ivanidzo4ka
* Remove TreeOrderedCandidatesSearch
* Remove whitespace and reinstate commented out tests
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzsAwaiting requested review from codemzs

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dan-drews@TomFinley@Ivanidzo4ka

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove Extra Code Comments and unused InternalStreams project - #514
Merged
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Jul 13, 2018
Merged
Remove Extra Code Comments and unused InternalStreams project#514
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Conversation
@dan-drews
@dan-drewsdan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
Fixes#513
This is the first go-around at finding extra commented code sitting around. I'll circle back on more when I have a chance.
TomFinley
TomFinley
reviewed
Jul 10, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 Done();
 }

 //[Fact]
@TomFinleyTomFinleyJul 10, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dan-drews thanks for looking at this. One thing I wonder about is, should this be uncommented and turn into a fact-skip? Or is the code just too far gone for that? (I might suspect some of the names may have changed.)
@dan-drewsdan-drewsJul 10, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomFinley I'll take a look. Should my rule of thumb be that if it compiles, I leave it as fact-skip, otherwise I remove it? I could try to see what things are renamed to, but I'm still not super familiar with this project yet
Edit: Upon further review, there are references to a class called Dv1. That appears not to exist anymore.
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately some classes have been renamed in the leadup to the public release a couple months ago. If it's not obvious how to do it, I would prefer that you leave the commented out code there, rather than destroy the test, since I think I know how "reanimate" this test. (E.g., Dv1 I think is DvInt1, etc. etc.) So while the main codebase I think could use with cleaning, something like this I might prefer to review more carefully. Maybe not cut this one?
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be that it's appropriate to remove it, but I'd prefer to do so in a more deliberative way.
In reply to: 201912980 [](ancestors = 201912980)
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-added those tests, and just left them commented out. I tried to simply change Dv1 to DvInt1, but the parameters are different. I'd rather somebody with a greater understanding of what is going on here dig through it. Thanks for the feedback!
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 public uint /*ulong*/ /*IntPtr*/ /*NTSTATUS*/ Status;

I think this and the other line are some things we may consider removing.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:271 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 Status = 0; //IntPtr.Zero;

As is this.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:276 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@dan-drewsdan-drews
changed the title
WIP Remove Extra Code CommentsRemove Extra Code CommentsJul 10, 2018
@dan-drews
dan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Removed WIP tag. I'm sure there are more comments to be removed, but I think this was a pretty good sweep.
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.FastTree/Application/LogLossApplication.cs
Outdated

 _gradient[d2] -= 0.01 * labelDiff;
 }
 */
 _gradient[d2] -= delta; 
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 [](start = 43, length = 20)

can you format this file in VS? or at least remove all extra spaces here. #Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 private ParameterSet[] TreeOrderedCandidatesSearch(FastForestRegressionPredictor forest, int numOfCandidates, IEnumerable<IRunResult> previousRuns)

Feel free to delete whole function, no one calls it anyway. #Closed
Refers to: src/Microsoft.ML.Sweeper/Algorithms/SmacSweeper.cs:185 in 97290b2. [](commit_id = 97290b2, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/FactorizationMachine/FactorizationMachineInterface.cs
Outdated

 [DllImport(NativePath), SuppressUnmanagedCodeSecurity]
 public static extern void CalculateGradientAndUpdateNative(float lambdaLinear, float lambdaLatent, float learningRate, int fieldCount, int latentDim, float weight,
 int count, int* /*const*/ fieldIndices, int* /*const*/ featureIndices, float* /*const*/ featureValues, float* /*const*/ latentSum, float slope,
 int count, int* fieldIndices, int* featureIndices, float* featureValues, float* latentSum, float slope,
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#383 (comment)

See @wschin comment.

I agree this is not the best solution, but I would prefer to preserve this information until we figure out better one.

Same states for Thunk.cs.
We have them for a reason.

#Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018

Copy link


Copy Markdown

Contributor
Thank you for your work @dan-drews !

Can we slightly change name of this PR to address removal of InternalStreams project?
@dan-drewsdan-drews
changed the title
Remove Extra Code CommentsRemove Extra Code Comments and unused InternalStreams projectJul 11, 2018
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadMicrosoft.ML.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.TestFramework", "test\Microsoft.ML.TestFramework\Microsoft.ML.TestFramework.csproj", "{B5989C06-4FFA-46C1-9D85-9366B34AB0A2}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.InternalStreams", "src\Microsoft.ML.InternalStreams\Microsoft.ML.InternalStreams.csproj", "{C4F7938F-7109-43C8-92A5-9BE47C7FF7D9}"
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆 🍾 😆 Good riddance!!
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.Core/Utilities/MathUtils.cs
Outdated

 // return SoftMax(inputs[0], inputs[1]);
 //}


@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line with space on it introduced.
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the blank line okay as long as the whitespace is removed?That matches the if statement above.
Also, for my own reference, how can you tell there is whitespace? Is it through Visual Studio? Or is there also a way to know through github?
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 }

 //[Fact]
 //public void EntryPointArrayOfVariables()
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//public void EntryPointArrayOfVariables() [](start = 8, length = 42)
Similar with this.
@shauheen
shauheen
requested a review
from codemzsJuly 12, 2018 09:39
@dan-drewsdan-drews
changed the title
Remove Extra Code Comments and unused InternalStreams project[WIP] Remove Extra Code Comments and unused InternalStreams projectJul 13, 2018
@dan-drewsdan-drews
changed the title
[WIP] Remove Extra Code Comments and unused InternalStreams projectRemove Extra Code Comments and unused InternalStreams projectJul 13, 2018
TomFinley
TomFinley
approved these changes
Jul 13, 2018
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-drews ! I think the builds are failing due to #428 commit, but once #527 goes in we can request a rebuild...
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 13, 2018

Copy link


Copy Markdown

Contributor
@dotnet-bot test Windows_NT Debug
@dotnet-bot test Windows_NT Release
@dotnet-bot test OSX10.13 Debug
@dotnet-bot test OSX10.13 Release
@dotnet-bot test Linux Debug
@dotnet-bot test Linux Release
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Jul 13, 2018
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit 669f4fa
into
dotnet:masterJul 13, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@dan-drews@eerhardt
Remove Extra Code Comments and unused InternalStreams project (dotnet…
3a37b4e
…#514)
* First attempt at removing extra code comments
* Round #2
* Removing Microsoft.ML.InternalStreams per comment on dotnet#513
* Address notes from @Ivanidzo4ka
* Remove TreeOrderedCandidatesSearch
* Remove whitespace and reinstate commented out tests
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzsAwaiting requested review from codemzs

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dan-drews@TomFinley@Ivanidzo4ka

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove Extra Code Comments and unused InternalStreams project - #514
Merged
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Jul 13, 2018
Merged
Remove Extra Code Comments and unused InternalStreams project#514
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Conversation
@dan-drews
@dan-drewsdan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
Fixes#513
This is the first go-around at finding extra commented code sitting around. I'll circle back on more when I have a chance.
TomFinley
TomFinley
reviewed
Jul 10, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 Done();
 }

 //[Fact]
@TomFinleyTomFinleyJul 10, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dan-drews thanks for looking at this. One thing I wonder about is, should this be uncommented and turn into a fact-skip? Or is the code just too far gone for that? (I might suspect some of the names may have changed.)
@dan-drewsdan-drewsJul 10, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomFinley I'll take a look. Should my rule of thumb be that if it compiles, I leave it as fact-skip, otherwise I remove it? I could try to see what things are renamed to, but I'm still not super familiar with this project yet
Edit: Upon further review, there are references to a class called Dv1. That appears not to exist anymore.
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately some classes have been renamed in the leadup to the public release a couple months ago. If it's not obvious how to do it, I would prefer that you leave the commented out code there, rather than destroy the test, since I think I know how "reanimate" this test. (E.g., Dv1 I think is DvInt1, etc. etc.) So while the main codebase I think could use with cleaning, something like this I might prefer to review more carefully. Maybe not cut this one?
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be that it's appropriate to remove it, but I'd prefer to do so in a more deliberative way.
In reply to: 201912980 [](ancestors = 201912980)
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-added those tests, and just left them commented out. I tried to simply change Dv1 to DvInt1, but the parameters are different. I'd rather somebody with a greater understanding of what is going on here dig through it. Thanks for the feedback!
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 public uint /*ulong*/ /*IntPtr*/ /*NTSTATUS*/ Status;

I think this and the other line are some things we may consider removing.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:271 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 Status = 0; //IntPtr.Zero;

As is this.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:276 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@dan-drewsdan-drews
changed the title
WIP Remove Extra Code CommentsRemove Extra Code CommentsJul 10, 2018
@dan-drews
dan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Removed WIP tag. I'm sure there are more comments to be removed, but I think this was a pretty good sweep.
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.FastTree/Application/LogLossApplication.cs
Outdated

 _gradient[d2] -= 0.01 * labelDiff;
 }
 */
 _gradient[d2] -= delta; 
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 [](start = 43, length = 20)

can you format this file in VS? or at least remove all extra spaces here. #Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 private ParameterSet[] TreeOrderedCandidatesSearch(FastForestRegressionPredictor forest, int numOfCandidates, IEnumerable<IRunResult> previousRuns)

Feel free to delete whole function, no one calls it anyway. #Closed
Refers to: src/Microsoft.ML.Sweeper/Algorithms/SmacSweeper.cs:185 in 97290b2. [](commit_id = 97290b2, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/FactorizationMachine/FactorizationMachineInterface.cs
Outdated

 [DllImport(NativePath), SuppressUnmanagedCodeSecurity]
 public static extern void CalculateGradientAndUpdateNative(float lambdaLinear, float lambdaLatent, float learningRate, int fieldCount, int latentDim, float weight,
 int count, int* /*const*/ fieldIndices, int* /*const*/ featureIndices, float* /*const*/ featureValues, float* /*const*/ latentSum, float slope,
 int count, int* fieldIndices, int* featureIndices, float* featureValues, float* latentSum, float slope,
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#383 (comment)

See @wschin comment.

I agree this is not the best solution, but I would prefer to preserve this information until we figure out better one.

Same states for Thunk.cs.
We have them for a reason.

#Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018

Copy link


Copy Markdown

Contributor
Thank you for your work @dan-drews !

Can we slightly change name of this PR to address removal of InternalStreams project?
@dan-drewsdan-drews
changed the title
Remove Extra Code CommentsRemove Extra Code Comments and unused InternalStreams projectJul 11, 2018
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadMicrosoft.ML.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.TestFramework", "test\Microsoft.ML.TestFramework\Microsoft.ML.TestFramework.csproj", "{B5989C06-4FFA-46C1-9D85-9366B34AB0A2}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.InternalStreams", "src\Microsoft.ML.InternalStreams\Microsoft.ML.InternalStreams.csproj", "{C4F7938F-7109-43C8-92A5-9BE47C7FF7D9}"
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆 🍾 😆 Good riddance!!
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.Core/Utilities/MathUtils.cs
Outdated

 // return SoftMax(inputs[0], inputs[1]);
 //}


@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line with space on it introduced.
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the blank line okay as long as the whitespace is removed?That matches the if statement above.
Also, for my own reference, how can you tell there is whitespace? Is it through Visual Studio? Or is there also a way to know through github?
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 }

 //[Fact]
 //public void EntryPointArrayOfVariables()
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//public void EntryPointArrayOfVariables() [](start = 8, length = 42)
Similar with this.
@shauheen
shauheen
requested a review
from codemzsJuly 12, 2018 09:39
@dan-drewsdan-drews
changed the title
Remove Extra Code Comments and unused InternalStreams project[WIP] Remove Extra Code Comments and unused InternalStreams projectJul 13, 2018
@dan-drewsdan-drews
changed the title
[WIP] Remove Extra Code Comments and unused InternalStreams projectRemove Extra Code Comments and unused InternalStreams projectJul 13, 2018
TomFinley
TomFinley
approved these changes
Jul 13, 2018
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-drews ! I think the builds are failing due to #428 commit, but once #527 goes in we can request a rebuild...
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 13, 2018

Copy link


Copy Markdown

Contributor
@dotnet-bot test Windows_NT Debug
@dotnet-bot test Windows_NT Release
@dotnet-bot test OSX10.13 Debug
@dotnet-bot test OSX10.13 Release
@dotnet-bot test Linux Debug
@dotnet-bot test Linux Release
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Jul 13, 2018
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit 669f4fa
into
dotnet:masterJul 13, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@dan-drews@eerhardt
Remove Extra Code Comments and unused InternalStreams project (dotnet…
3a37b4e
…#514)
* First attempt at removing extra code comments
* Round #2
* Removing Microsoft.ML.InternalStreams per comment on dotnet#513
* Address notes from @Ivanidzo4ka
* Remove TreeOrderedCandidatesSearch
* Remove whitespace and reinstate commented out tests
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzsAwaiting requested review from codemzs

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dan-drews@TomFinley@Ivanidzo4ka

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Remove Extra Code Comments and unused InternalStreams project - #514
Merged
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Jul 13, 2018
Merged
Remove Extra Code Comments and unused InternalStreams project#514
Ivanidzo4ka merged 6 commits into
dotnet:masterfrom 
dan-drews:Remove_Extra_Comments
Conversation
@dan-drews
@dan-drewsdan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
Fixes#513
This is the first go-around at finding extra commented code sitting around. I'll circle back on more when I have a chance.
TomFinley
TomFinley
reviewed
Jul 10, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 Done();
 }

 //[Fact]
@TomFinleyTomFinleyJul 10, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dan-drews thanks for looking at this. One thing I wonder about is, should this be uncommented and turn into a fact-skip? Or is the code just too far gone for that? (I might suspect some of the names may have changed.)
@dan-drewsdan-drewsJul 10, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomFinley I'll take a look. Should my rule of thumb be that if it compiles, I leave it as fact-skip, otherwise I remove it? I could try to see what things are renamed to, but I'm still not super familiar with this project yet
Edit: Upon further review, there are references to a class called Dv1. That appears not to exist anymore.
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately some classes have been renamed in the leadup to the public release a couple months ago. If it's not obvious how to do it, I would prefer that you leave the commented out code there, rather than destroy the test, since I think I know how "reanimate" this test. (E.g., Dv1 I think is DvInt1, etc. etc.) So while the main codebase I think could use with cleaning, something like this I might prefer to review more carefully. Maybe not cut this one?
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be that it's appropriate to remove it, but I'd prefer to do so in a more deliberative way.
In reply to: 201912980 [](ancestors = 201912980)
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-added those tests, and just left them commented out. I tried to simply change Dv1 to DvInt1, but the parameters are different. I'd rather somebody with a greater understanding of what is going on here dig through it. Thanks for the feedback!
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 public uint /*ulong*/ /*IntPtr*/ /*NTSTATUS*/ Status;

I think this and the other line are some things we may consider removing.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:271 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@TomFinley
TomFinley
commented
Jul 10, 2018

Copy link


Copy Markdown

Contributor
 Status = 0; //IntPtr.Zero;

As is this.
Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:276 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)
@dan-drewsdan-drews
changed the title
WIP Remove Extra Code CommentsRemove Extra Code CommentsJul 10, 2018
@dan-drews
dan-drews
commented
Jul 10, 2018

Copy link


Copy Markdown

ContributorAuthor
Removed WIP tag. I'm sure there are more comments to be removed, but I think this was a pretty good sweep.
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.FastTree/Application/LogLossApplication.cs
Outdated

 _gradient[d2] -= 0.01 * labelDiff;
 }
 */
 _gradient[d2] -= delta; 
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 [](start = 43, length = 20)

can you format this file in VS? or at least remove all extra spaces here. #Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 private ParameterSet[] TreeOrderedCandidatesSearch(FastForestRegressionPredictor forest, int numOfCandidates, IEnumerable<IRunResult> previousRuns)

Feel free to delete whole function, no one calls it anyway. #Closed
Refers to: src/Microsoft.ML.Sweeper/Algorithms/SmacSweeper.cs:185 in 97290b2. [](commit_id = 97290b2, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
reviewed
Jul 11, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/FactorizationMachine/FactorizationMachineInterface.cs
Outdated

 [DllImport(NativePath), SuppressUnmanagedCodeSecurity]
 public static extern void CalculateGradientAndUpdateNative(float lambdaLinear, float lambdaLatent, float learningRate, int fieldCount, int latentDim, float weight,
 int count, int* /*const*/ fieldIndices, int* /*const*/ featureIndices, float* /*const*/ featureValues, float* /*const*/ latentSum, float slope,
 int count, int* fieldIndices, int* featureIndices, float* featureValues, float* latentSum, float slope,
@Ivanidzo4kaIvanidzo4kaJul 11, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#383 (comment)

See @wschin comment.

I agree this is not the best solution, but I would prefer to preserve this information until we figure out better one.

Same states for Thunk.cs.
We have them for a reason.

#Resolved
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 11, 2018

Copy link


Copy Markdown

Contributor
Thank you for your work @dan-drews !

Can we slightly change name of this PR to address removal of InternalStreams project?
@dan-drewsdan-drews
changed the title
Remove Extra Code CommentsRemove Extra Code Comments and unused InternalStreams projectJul 11, 2018
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadMicrosoft.ML.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.TestFramework", "test\Microsoft.ML.TestFramework\Microsoft.ML.TestFramework.csproj", "{B5989C06-4FFA-46C1-9D85-9366B34AB0A2}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.InternalStreams", "src\Microsoft.ML.InternalStreams\Microsoft.ML.InternalStreams.csproj", "{C4F7938F-7109-43C8-92A5-9BE47C7FF7D9}"
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆 🍾 😆 Good riddance!!
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadsrc/Microsoft.ML.Core/Utilities/MathUtils.cs
Outdated

 // return SoftMax(inputs[0], inputs[1]);
 //}


@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line with space on it introduced.
@dan-drewsdan-drewsJul 13, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the blank line okay as long as the whitespace is removed?That matches the if statement above.
Also, for my own reference, how can you tell there is whitespace? Is it through Visual Studio? Or is there also a way to know through github?
TomFinley
TomFinley
reviewed
Jul 12, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
 }

 //[Fact]
 //public void EntryPointArrayOfVariables()
@TomFinleyTomFinleyJul 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//public void EntryPointArrayOfVariables() [](start = 8, length = 42)
Similar with this.
@shauheen
shauheen
requested a review
from codemzsJuly 12, 2018 09:39
@dan-drewsdan-drews
changed the title
Remove Extra Code Comments and unused InternalStreams project[WIP] Remove Extra Code Comments and unused InternalStreams projectJul 13, 2018
@dan-drewsdan-drews
changed the title
[WIP] Remove Extra Code Comments and unused InternalStreams projectRemove Extra Code Comments and unused InternalStreams projectJul 13, 2018
TomFinley
TomFinley
approved these changes
Jul 13, 2018
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-drews ! I think the builds are failing due to #428 commit, but once #527 goes in we can request a rebuild...
@Ivanidzo4ka
Ivanidzo4ka
commented
Jul 13, 2018

Copy link


Copy Markdown

Contributor
@dotnet-bot test Windows_NT Debug
@dotnet-bot test Windows_NT Release
@dotnet-bot test OSX10.13 Debug
@dotnet-bot test OSX10.13 Release
@dotnet-bot test Linux Debug
@dotnet-bot test Linux Release
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Jul 13, 2018
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit 669f4fa
into
dotnet:masterJul 13, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@dan-drews@eerhardt
Remove Extra Code Comments and unused InternalStreams project (dotnet…
3a37b4e
…#514)
* First attempt at removing extra code comments
* Round #2
* Removing Microsoft.ML.InternalStreams per comment on dotnet#513
* Address notes from @Ivanidzo4ka
* Remove TreeOrderedCandidatesSearch
* Remove whitespace and reinstate commented out tests
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzsAwaiting requested review from codemzs

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dan-drews@TomFinley@Ivanidzo4ka