Adding the MlNetMklDeps package, adding the entry point, tests and docs for OLS. by sfilipi · Pull Request #578 · dotnet/machinelearning

sfilipi · 2018-07-24T17:20:45Z

MKL package has been published

Ivanidzo4ka · 2018-07-24T17:26:03Z

@@ -0,0 +1,5 @@
+<Project DefaultTargets="Pack">
+
+ <Import Project="Microsoft.ML.Parquet.nupkgproj" />


Parquet [](start = 32, length = 7)
nope #Resolved

codemzs · 2018-07-24T17:29:30Z

Have you tested MKL works as expected? #Resolved

Ivanidzo4ka · 2018-07-24T17:33:33Z

+ </PropertyGroup>
+
+ <ItemGroup>
+ <ProjectReference Include="../Microsoft.ML/Microsoft.ML.nupkgproj" />


Can we write down how exactly it's gonna work?
How it looks in my head based on conversations (can be far away from reality)
Have a internal repo with pre build custom dlls for each OS.
Publish them to nuget.org
Reference them in Microsoft.ML nuget as dependency
this steps have nothing to do with this package file, so I obviously don't understand something.
#Resolved

Ivanidzo4ka · 2018-07-24T17:33:57Z

 <SystemReflectionEmitLightweightPackageVersion>4.3.0</SystemReflectionEmitLightweightPackageVersion>
 <PublishSymbolsPackageVersion>1.0.0-beta-62824-02</PublishSymbolsPackageVersion>
 	<LightGBMPackageVersion>2.1.2.2</LightGBMPackageVersion>
+	<MlNetMklDepsPackageVersion>0.0.0.1</MlNetMklDepsPackageVersion>


[](start = 0, length = 1)
ze evil tabs! #Resolved

TomFinley · 2018-07-24T20:10:53Z

Hi @sfilipi thanks for getting this started.

I see we have a package definition added, I think. But I might have expected the package definition to live somewhere else in a different repository somehow (since it cannot be part of the build here), and for components in ML.Net that need it to simply reference that externally defined nuget. Is that unfair?

I also feel like I might understand this better if we saw how existing component (like OLS) or upcoming ones (like #556) will actually consume this. #Resolved

codemzs · 2018-07-24T22:59:57Z

Hi @tfinley@gmail.com ,I have tested MKL binaries by linking them with native SymSGD code in PR556 (that iteration is not posted yet) using CMAKE. The way we would do is by restoring MKL nuget before CMAKE is called by adding an external project to the sln file that package references MKL nuget, this step fetches the binaries to a known location on the drive and then we can link against the binaries in our CMAKE file.

machinelearning/build.proj

Line 23 in 8cfa2ed

<ProjectInclude="Microsoft.ML.sln" />

(this line is executed before BuildNative is called)

In reply to: 407535938 [](ancestors = 407535938)

Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

sfilipi · 2018-07-26T17:08:24Z

+ </remarks>
+ <example>
+ <code language="csharp">
+ new StochasticDualCoordinateAscentRegressor


new StochasticDualCoordinateAscentRegressor [](start = 9, length = 44)
I'll fix this. #Resolved

…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

sfilipi · 2018-07-30T17:26:44Z

The changes went in through the other PR.

sfilipi · 2018-07-24T17:20:45Z

MKL package has been published

Ivanidzo4ka · 2018-07-24T17:26:03Z

@@ -0,0 +1,5 @@
+<Project DefaultTargets="Pack">
+
+ <Import Project="Microsoft.ML.Parquet.nupkgproj" />


Parquet [](start = 32, length = 7)
nope #Resolved

codemzs · 2018-07-24T17:29:30Z

Have you tested MKL works as expected? #Resolved

Ivanidzo4ka · 2018-07-24T17:33:33Z

+ </PropertyGroup>
+
+ <ItemGroup>
+ <ProjectReference Include="../Microsoft.ML/Microsoft.ML.nupkgproj" />


Can we write down how exactly it's gonna work?
How it looks in my head based on conversations (can be far away from reality)
Have a internal repo with pre build custom dlls for each OS.
Publish them to nuget.org
Reference them in Microsoft.ML nuget as dependency
this steps have nothing to do with this package file, so I obviously don't understand something.
#Resolved

Ivanidzo4ka · 2018-07-24T17:33:57Z

 <SystemReflectionEmitLightweightPackageVersion>4.3.0</SystemReflectionEmitLightweightPackageVersion>
 <PublishSymbolsPackageVersion>1.0.0-beta-62824-02</PublishSymbolsPackageVersion>
 	<LightGBMPackageVersion>2.1.2.2</LightGBMPackageVersion>
+	<MlNetMklDepsPackageVersion>0.0.0.1</MlNetMklDepsPackageVersion>


[](start = 0, length = 1)
ze evil tabs! #Resolved

TomFinley · 2018-07-24T20:10:53Z

Hi @sfilipi thanks for getting this started.

I see we have a package definition added, I think. But I might have expected the package definition to live somewhere else in a different repository somehow (since it cannot be part of the build here), and for components in ML.Net that need it to simply reference that externally defined nuget. Is that unfair?

I also feel like I might understand this better if we saw how existing component (like OLS) or upcoming ones (like #556) will actually consume this. #Resolved

codemzs · 2018-07-24T22:59:57Z

Hi @tfinley@gmail.com ,I have tested MKL binaries by linking them with native SymSGD code in PR556 (that iteration is not posted yet) using CMAKE. The way we would do is by restoring MKL nuget before CMAKE is called by adding an external project to the sln file that package references MKL nuget, this step fetches the binaries to a known location on the drive and then we can link against the binaries in our CMAKE file.

machinelearning/build.proj

Line 23 in 8cfa2ed

<ProjectInclude="Microsoft.ML.sln" />

(this line is executed before BuildNative is called)

In reply to: 407535938 [](ancestors = 407535938)

Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

sfilipi · 2018-07-26T17:08:24Z

+ </remarks>
+ <example>
+ <code language="csharp">
+ new StochasticDualCoordinateAscentRegressor


new StochasticDualCoordinateAscentRegressor [](start = 9, length = 44)
I'll fix this. #Resolved

…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

sfilipi · 2018-07-30T17:26:44Z

The changes went in through the other PR.

sfilipi · 2018-07-24T17:20:45Z

MKL package has been published

Ivanidzo4ka · 2018-07-24T17:26:03Z

@@ -0,0 +1,5 @@
+<Project DefaultTargets="Pack">
+
+ <Import Project="Microsoft.ML.Parquet.nupkgproj" />


Parquet [](start = 32, length = 7)
nope #Resolved

codemzs · 2018-07-24T17:29:30Z

Have you tested MKL works as expected? #Resolved

Ivanidzo4ka · 2018-07-24T17:33:33Z

+ </PropertyGroup>
+
+ <ItemGroup>
+ <ProjectReference Include="../Microsoft.ML/Microsoft.ML.nupkgproj" />


Can we write down how exactly it's gonna work?
How it looks in my head based on conversations (can be far away from reality)
Have a internal repo with pre build custom dlls for each OS.
Publish them to nuget.org
Reference them in Microsoft.ML nuget as dependency
this steps have nothing to do with this package file, so I obviously don't understand something.
#Resolved

Ivanidzo4ka · 2018-07-24T17:33:57Z

 <SystemReflectionEmitLightweightPackageVersion>4.3.0</SystemReflectionEmitLightweightPackageVersion>
 <PublishSymbolsPackageVersion>1.0.0-beta-62824-02</PublishSymbolsPackageVersion>
 	<LightGBMPackageVersion>2.1.2.2</LightGBMPackageVersion>
+	<MlNetMklDepsPackageVersion>0.0.0.1</MlNetMklDepsPackageVersion>


[](start = 0, length = 1)
ze evil tabs! #Resolved

TomFinley · 2018-07-24T20:10:53Z

Hi @sfilipi thanks for getting this started.

I see we have a package definition added, I think. But I might have expected the package definition to live somewhere else in a different repository somehow (since it cannot be part of the build here), and for components in ML.Net that need it to simply reference that externally defined nuget. Is that unfair?

I also feel like I might understand this better if we saw how existing component (like OLS) or upcoming ones (like #556) will actually consume this. #Resolved

codemzs · 2018-07-24T22:59:57Z

Hi @tfinley@gmail.com ,I have tested MKL binaries by linking them with native SymSGD code in PR556 (that iteration is not posted yet) using CMAKE. The way we would do is by restoring MKL nuget before CMAKE is called by adding an external project to the sln file that package references MKL nuget, this step fetches the binaries to a known location on the drive and then we can link against the binaries in our CMAKE file.

machinelearning/build.proj

Line 23 in 8cfa2ed

<ProjectInclude="Microsoft.ML.sln" />

(this line is executed before BuildNative is called)

In reply to: 407535938 [](ancestors = 407535938)

Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

sfilipi · 2018-07-26T17:08:24Z

+ </remarks>
+ <example>
+ <code language="csharp">
+ new StochasticDualCoordinateAscentRegressor


new StochasticDualCoordinateAscentRegressor [](start = 9, length = 44)
I'll fix this. #Resolved

…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

sfilipi · 2018-07-30T17:26:44Z

The changes went in through the other PR.

sfilipi · 2018-07-24T17:20:45Z

MKL package has been published

Ivanidzo4ka · 2018-07-24T17:26:03Z

@@ -0,0 +1,5 @@
+<Project DefaultTargets="Pack">
+
+ <Import Project="Microsoft.ML.Parquet.nupkgproj" />


Parquet [](start = 32, length = 7)
nope #Resolved

codemzs · 2018-07-24T17:29:30Z

Have you tested MKL works as expected? #Resolved

Ivanidzo4ka · 2018-07-24T17:33:33Z

+ </PropertyGroup>
+
+ <ItemGroup>
+ <ProjectReference Include="../Microsoft.ML/Microsoft.ML.nupkgproj" />


Can we write down how exactly it's gonna work?
How it looks in my head based on conversations (can be far away from reality)
Have a internal repo with pre build custom dlls for each OS.
Publish them to nuget.org
Reference them in Microsoft.ML nuget as dependency
this steps have nothing to do with this package file, so I obviously don't understand something.
#Resolved

Ivanidzo4ka · 2018-07-24T17:33:57Z

 <SystemReflectionEmitLightweightPackageVersion>4.3.0</SystemReflectionEmitLightweightPackageVersion>
 <PublishSymbolsPackageVersion>1.0.0-beta-62824-02</PublishSymbolsPackageVersion>
 	<LightGBMPackageVersion>2.1.2.2</LightGBMPackageVersion>
+	<MlNetMklDepsPackageVersion>0.0.0.1</MlNetMklDepsPackageVersion>


[](start = 0, length = 1)
ze evil tabs! #Resolved

TomFinley · 2018-07-24T20:10:53Z

Hi @sfilipi thanks for getting this started.

I see we have a package definition added, I think. But I might have expected the package definition to live somewhere else in a different repository somehow (since it cannot be part of the build here), and for components in ML.Net that need it to simply reference that externally defined nuget. Is that unfair?

I also feel like I might understand this better if we saw how existing component (like OLS) or upcoming ones (like #556) will actually consume this. #Resolved

codemzs · 2018-07-24T22:59:57Z

Hi @tfinley@gmail.com ,I have tested MKL binaries by linking them with native SymSGD code in PR556 (that iteration is not posted yet) using CMAKE. The way we would do is by restoring MKL nuget before CMAKE is called by adding an external project to the sln file that package references MKL nuget, this step fetches the binaries to a known location on the drive and then we can link against the binaries in our CMAKE file.

machinelearning/build.proj

Line 23 in 8cfa2ed

<ProjectInclude="Microsoft.ML.sln" />

(this line is executed before BuildNative is called)

In reply to: 407535938 [](ancestors = 407535938)

Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

sfilipi · 2018-07-26T17:08:24Z

+ </remarks>
+ <example>
+ <code language="csharp">
+ new StochasticDualCoordinateAscentRegressor


new StochasticDualCoordinateAscentRegressor [](start = 9, length = 44)
I'll fix this. #Resolved

…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

sfilipi · 2018-07-30T17:26:44Z

The changes went in through the other PR.

sfilipi · 2018-07-24T17:20:45Z

MKL package has been published

Ivanidzo4ka · 2018-07-24T17:26:03Z

@@ -0,0 +1,5 @@
+<Project DefaultTargets="Pack">
+
+ <Import Project="Microsoft.ML.Parquet.nupkgproj" />


Parquet [](start = 32, length = 7)
nope #Resolved

codemzs · 2018-07-24T17:29:30Z

Have you tested MKL works as expected? #Resolved

Ivanidzo4ka · 2018-07-24T17:33:33Z

+ </PropertyGroup>
+
+ <ItemGroup>
+ <ProjectReference Include="../Microsoft.ML/Microsoft.ML.nupkgproj" />


Can we write down how exactly it's gonna work?
How it looks in my head based on conversations (can be far away from reality)
Have a internal repo with pre build custom dlls for each OS.
Publish them to nuget.org
Reference them in Microsoft.ML nuget as dependency
this steps have nothing to do with this package file, so I obviously don't understand something.
#Resolved

Ivanidzo4ka · 2018-07-24T17:33:57Z

 <SystemReflectionEmitLightweightPackageVersion>4.3.0</SystemReflectionEmitLightweightPackageVersion>
 <PublishSymbolsPackageVersion>1.0.0-beta-62824-02</PublishSymbolsPackageVersion>
 	<LightGBMPackageVersion>2.1.2.2</LightGBMPackageVersion>
+	<MlNetMklDepsPackageVersion>0.0.0.1</MlNetMklDepsPackageVersion>


[](start = 0, length = 1)
ze evil tabs! #Resolved

TomFinley · 2018-07-24T20:10:53Z

Hi @sfilipi thanks for getting this started.

I see we have a package definition added, I think. But I might have expected the package definition to live somewhere else in a different repository somehow (since it cannot be part of the build here), and for components in ML.Net that need it to simply reference that externally defined nuget. Is that unfair?

I also feel like I might understand this better if we saw how existing component (like OLS) or upcoming ones (like #556) will actually consume this. #Resolved

codemzs · 2018-07-24T22:59:57Z

Hi @tfinley@gmail.com ,I have tested MKL binaries by linking them with native SymSGD code in PR556 (that iteration is not posted yet) using CMAKE. The way we would do is by restoring MKL nuget before CMAKE is called by adding an external project to the sln file that package references MKL nuget, this step fetches the binaries to a known location on the drive and then we can link against the binaries in our CMAKE file.

machinelearning/build.proj

Line 23 in 8cfa2ed

<ProjectInclude="Microsoft.ML.sln" />

(this line is executed before BuildNative is called)

In reply to: 407535938 [](ancestors = 407535938)

Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

sfilipi · 2018-07-26T17:08:24Z

+ </remarks>
+ <example>
+ <code language="csharp">
+ new StochasticDualCoordinateAscentRegressor


new StochasticDualCoordinateAscentRegressor [](start = 9, length = 44)
I'll fix this. #Resolved

…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

sfilipi · 2018-07-30T17:26:44Z

The changes went in through the other PR.

sfilipi · 2018-07-24T17:20:45Z

MKL package has been published

Ivanidzo4ka · 2018-07-24T17:26:03Z

@@ -0,0 +1,5 @@
+<Project DefaultTargets="Pack">
+
+ <Import Project="Microsoft.ML.Parquet.nupkgproj" />


Parquet [](start = 32, length = 7)
nope #Resolved

codemzs · 2018-07-24T17:29:30Z

Have you tested MKL works as expected? #Resolved

Ivanidzo4ka · 2018-07-24T17:33:33Z

+ </PropertyGroup>
+
+ <ItemGroup>
+ <ProjectReference Include="../Microsoft.ML/Microsoft.ML.nupkgproj" />


Can we write down how exactly it's gonna work?
How it looks in my head based on conversations (can be far away from reality)
Have a internal repo with pre build custom dlls for each OS.
Publish them to nuget.org
Reference them in Microsoft.ML nuget as dependency
this steps have nothing to do with this package file, so I obviously don't understand something.
#Resolved

Ivanidzo4ka · 2018-07-24T17:33:57Z

 <SystemReflectionEmitLightweightPackageVersion>4.3.0</SystemReflectionEmitLightweightPackageVersion>
 <PublishSymbolsPackageVersion>1.0.0-beta-62824-02</PublishSymbolsPackageVersion>
 	<LightGBMPackageVersion>2.1.2.2</LightGBMPackageVersion>
+	<MlNetMklDepsPackageVersion>0.0.0.1</MlNetMklDepsPackageVersion>


[](start = 0, length = 1)
ze evil tabs! #Resolved

TomFinley · 2018-07-24T20:10:53Z

Hi @sfilipi thanks for getting this started.

I see we have a package definition added, I think. But I might have expected the package definition to live somewhere else in a different repository somehow (since it cannot be part of the build here), and for components in ML.Net that need it to simply reference that externally defined nuget. Is that unfair?

I also feel like I might understand this better if we saw how existing component (like OLS) or upcoming ones (like #556) will actually consume this. #Resolved

codemzs · 2018-07-24T22:59:57Z

Hi @tfinley@gmail.com ,I have tested MKL binaries by linking them with native SymSGD code in PR556 (that iteration is not posted yet) using CMAKE. The way we would do is by restoring MKL nuget before CMAKE is called by adding an external project to the sln file that package references MKL nuget, this step fetches the binaries to a known location on the drive and then we can link against the binaries in our CMAKE file.

machinelearning/build.proj

Line 23 in 8cfa2ed

<ProjectInclude="Microsoft.ML.sln" />

(this line is executed before BuildNative is called)

In reply to: 407535938 [](ancestors = 407535938)

Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

sfilipi · 2018-07-26T17:08:24Z

+ </remarks>
+ <example>
+ <code language="csharp">
+ new StochasticDualCoordinateAscentRegressor


new StochasticDualCoordinateAscentRegressor [](start = 9, length = 44)
I'll fix this. #Resolved

…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

sfilipi · 2018-07-30T17:26:44Z

The changes went in through the other PR.

sfilipi · 2018-07-24T17:20:45Z

MKL package has been published

Ivanidzo4ka · 2018-07-24T17:26:03Z

@@ -0,0 +1,5 @@
+<Project DefaultTargets="Pack">
+
+ <Import Project="Microsoft.ML.Parquet.nupkgproj" />


Parquet [](start = 32, length = 7)
nope #Resolved

codemzs · 2018-07-24T17:29:30Z

Have you tested MKL works as expected? #Resolved

Ivanidzo4ka · 2018-07-24T17:33:33Z

+ </PropertyGroup>
+
+ <ItemGroup>
+ <ProjectReference Include="../Microsoft.ML/Microsoft.ML.nupkgproj" />


Can we write down how exactly it's gonna work?
How it looks in my head based on conversations (can be far away from reality)
Have a internal repo with pre build custom dlls for each OS.
Publish them to nuget.org
Reference them in Microsoft.ML nuget as dependency
this steps have nothing to do with this package file, so I obviously don't understand something.
#Resolved

Ivanidzo4ka · 2018-07-24T17:33:57Z

 <SystemReflectionEmitLightweightPackageVersion>4.3.0</SystemReflectionEmitLightweightPackageVersion>
 <PublishSymbolsPackageVersion>1.0.0-beta-62824-02</PublishSymbolsPackageVersion>
 	<LightGBMPackageVersion>2.1.2.2</LightGBMPackageVersion>
+	<MlNetMklDepsPackageVersion>0.0.0.1</MlNetMklDepsPackageVersion>


[](start = 0, length = 1)
ze evil tabs! #Resolved

TomFinley · 2018-07-24T20:10:53Z

Hi @sfilipi thanks for getting this started.

I see we have a package definition added, I think. But I might have expected the package definition to live somewhere else in a different repository somehow (since it cannot be part of the build here), and for components in ML.Net that need it to simply reference that externally defined nuget. Is that unfair?

I also feel like I might understand this better if we saw how existing component (like OLS) or upcoming ones (like #556) will actually consume this. #Resolved

codemzs · 2018-07-24T22:59:57Z

Hi @tfinley@gmail.com ,I have tested MKL binaries by linking them with native SymSGD code in PR556 (that iteration is not posted yet) using CMAKE. The way we would do is by restoring MKL nuget before CMAKE is called by adding an external project to the sln file that package references MKL nuget, this step fetches the binaries to a known location on the drive and then we can link against the binaries in our CMAKE file.

machinelearning/build.proj

Line 23 in 8cfa2ed

<ProjectInclude="Microsoft.ML.sln" />

(this line is executed before BuildNative is called)

In reply to: 407535938 [](ancestors = 407535938)

Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

sfilipi · 2018-07-26T17:08:24Z

+ </remarks>
+ <example>
+ <code language="csharp">
+ new StochasticDualCoordinateAscentRegressor


new StochasticDualCoordinateAscentRegressor [](start = 9, length = 44)
I'll fix this. #Resolved

…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

sfilipi · 2018-07-30T17:26:44Z

The changes went in through the other PR.

sfilipi · 2018-07-24T17:20:45Z

MKL package has been published

Ivanidzo4ka · 2018-07-24T17:26:03Z

@@ -0,0 +1,5 @@
+<Project DefaultTargets="Pack">
+
+ <Import Project="Microsoft.ML.Parquet.nupkgproj" />


Parquet [](start = 32, length = 7)
nope #Resolved

codemzs · 2018-07-24T17:29:30Z

Have you tested MKL works as expected? #Resolved

Ivanidzo4ka · 2018-07-24T17:33:33Z

+ </PropertyGroup>
+
+ <ItemGroup>
+ <ProjectReference Include="../Microsoft.ML/Microsoft.ML.nupkgproj" />


Can we write down how exactly it's gonna work?
How it looks in my head based on conversations (can be far away from reality)
Have a internal repo with pre build custom dlls for each OS.
Publish them to nuget.org
Reference them in Microsoft.ML nuget as dependency
this steps have nothing to do with this package file, so I obviously don't understand something.
#Resolved

Ivanidzo4ka · 2018-07-24T17:33:57Z

 <SystemReflectionEmitLightweightPackageVersion>4.3.0</SystemReflectionEmitLightweightPackageVersion>
 <PublishSymbolsPackageVersion>1.0.0-beta-62824-02</PublishSymbolsPackageVersion>
 	<LightGBMPackageVersion>2.1.2.2</LightGBMPackageVersion>
+	<MlNetMklDepsPackageVersion>0.0.0.1</MlNetMklDepsPackageVersion>


[](start = 0, length = 1)
ze evil tabs! #Resolved

TomFinley · 2018-07-24T20:10:53Z

Hi @sfilipi thanks for getting this started.

I see we have a package definition added, I think. But I might have expected the package definition to live somewhere else in a different repository somehow (since it cannot be part of the build here), and for components in ML.Net that need it to simply reference that externally defined nuget. Is that unfair?

I also feel like I might understand this better if we saw how existing component (like OLS) or upcoming ones (like #556) will actually consume this. #Resolved

codemzs · 2018-07-24T22:59:57Z

Hi @tfinley@gmail.com ,I have tested MKL binaries by linking them with native SymSGD code in PR556 (that iteration is not posted yet) using CMAKE. The way we would do is by restoring MKL nuget before CMAKE is called by adding an external project to the sln file that package references MKL nuget, this step fetches the binaries to a known location on the drive and then we can link against the binaries in our CMAKE file.

machinelearning/build.proj

Line 23 in 8cfa2ed

<ProjectInclude="Microsoft.ML.sln" />

(this line is executed before BuildNative is called)

In reply to: 407535938 [](ancestors = 407535938)

Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

sfilipi · 2018-07-26T17:08:24Z

+ </remarks>
+ <example>
+ <code language="csharp">
+ new StochasticDualCoordinateAscentRegressor


new StochasticDualCoordinateAscentRegressor [](start = 9, length = 44)
I'll fix this. #Resolved

…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

sfilipi · 2018-07-30T17:26:44Z

The changes went in through the other PR.

WIP: adding the MlNetMklDeps package
9e96175

sfilipi requested review from Ivanidzo4ka and eerhardt July 24, 2018 17:24

Ivanidzo4ka reviewed Jul 24, 2018
View reviewed changes

codemzs mentioned this pull request Jul 26, 2018
Port SymSGD #556
Closed

sfilipi added 2 commits July 26, 2018 09:31

Fixing the MlNetMklDeps nukpproj
fa519e8
Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

reverting test changes to the CSharpCodeGen
19779fe

sfilipi commented Jul 26, 2018
View reviewed changes

sfilipi added 3 commits July 26, 2018 14:08

Adding the LoadableClass assembly attribute with the signature:Signat…
94ff6d3
…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

merging from master
dfc2b35

following the same naming convention for the doc attributes in tags
cd18b74

sfilipi changed the title ~~WIP: adding the MlNetMklDeps package~~Adding the MlNetMklDeps package, adding the entry point, tests and docs for OLS.Jul 27, 2018

sfilipi added 3 commits July 27, 2018 14:13

Fixing the path in the OLS doc include
80f7bd6

removing unecessary packing
f910923

In Mac, release only, one of the OLS tests is failing because the act…
2965477
…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

TomFinley mentioned this pull request Jul 28, 2018
adding a dependency to the MlNetMklDeps package #594
Merged

sfilipi closed this Jul 30, 2018

sfilipi deleted the mkldeps branch July 30, 2018 17:26

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

WIP: adding the MlNetMklDeps package
9e96175

sfilipi requested review from Ivanidzo4ka and eerhardt July 24, 2018 17:24

Ivanidzo4ka reviewed Jul 24, 2018
View reviewed changes

codemzs mentioned this pull request Jul 26, 2018
Port SymSGD #556
Closed

sfilipi added 2 commits July 26, 2018 09:31

Fixing the MlNetMklDeps nukpproj
fa519e8
Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

reverting test changes to the CSharpCodeGen
19779fe

sfilipi commented Jul 26, 2018
View reviewed changes

sfilipi added 3 commits July 26, 2018 14:08

Adding the LoadableClass assembly attribute with the signature:Signat…
94ff6d3
…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

merging from master
dfc2b35

following the same naming convention for the doc attributes in tags
cd18b74

sfilipi changed the title ~~WIP: adding the MlNetMklDeps package~~Adding the MlNetMklDeps package, adding the entry point, tests and docs for OLS.Jul 27, 2018

sfilipi added 3 commits July 27, 2018 14:13

Fixing the path in the OLS doc include
80f7bd6

removing unecessary packing
f910923

In Mac, release only, one of the OLS tests is failing because the act…
2965477
…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

TomFinley mentioned this pull request Jul 28, 2018
adding a dependency to the MlNetMklDeps package #594
Merged

sfilipi closed this Jul 30, 2018

sfilipi deleted the mkldeps branch July 30, 2018 17:26

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

WIP: adding the MlNetMklDeps package
9e96175

sfilipi requested review from Ivanidzo4ka and eerhardt July 24, 2018 17:24

Ivanidzo4ka reviewed Jul 24, 2018
View reviewed changes

codemzs mentioned this pull request Jul 26, 2018
Port SymSGD #556
Closed

sfilipi added 2 commits July 26, 2018 09:31

Fixing the MlNetMklDeps nukpproj
fa519e8
Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

reverting test changes to the CSharpCodeGen
19779fe

sfilipi commented Jul 26, 2018
View reviewed changes

sfilipi added 3 commits July 26, 2018 14:08

Adding the LoadableClass assembly attribute with the signature:Signat…
94ff6d3
…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

merging from master
dfc2b35

following the same naming convention for the doc attributes in tags
cd18b74

sfilipi changed the title ~~WIP: adding the MlNetMklDeps package~~Adding the MlNetMklDeps package, adding the entry point, tests and docs for OLS.Jul 27, 2018

sfilipi added 3 commits July 27, 2018 14:13

Fixing the path in the OLS doc include
80f7bd6

removing unecessary packing
f910923

In Mac, release only, one of the OLS tests is failing because the act…
2965477
…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

TomFinley mentioned this pull request Jul 28, 2018
adding a dependency to the MlNetMklDeps package #594
Merged

sfilipi closed this Jul 30, 2018

sfilipi deleted the mkldeps branch July 30, 2018 17:26

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

WIP: adding the MlNetMklDeps package
9e96175

sfilipi requested review from Ivanidzo4ka and eerhardt July 24, 2018 17:24

Ivanidzo4ka reviewed Jul 24, 2018
View reviewed changes

codemzs mentioned this pull request Jul 26, 2018
Port SymSGD #556
Closed

sfilipi added 2 commits July 26, 2018 09:31

Fixing the MlNetMklDeps nukpproj
fa519e8
Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

reverting test changes to the CSharpCodeGen
19779fe

sfilipi commented Jul 26, 2018
View reviewed changes

sfilipi added 3 commits July 26, 2018 14:08

Adding the LoadableClass assembly attribute with the signature:Signat…
94ff6d3
…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

merging from master
dfc2b35

following the same naming convention for the doc attributes in tags
cd18b74

sfilipi changed the title ~~WIP: adding the MlNetMklDeps package~~Adding the MlNetMklDeps package, adding the entry point, tests and docs for OLS.Jul 27, 2018

sfilipi added 3 commits July 27, 2018 14:13

Fixing the path in the OLS doc include
80f7bd6

removing unecessary packing
f910923

In Mac, release only, one of the OLS tests is failing because the act…
2965477
…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

TomFinley mentioned this pull request Jul 28, 2018
adding a dependency to the MlNetMklDeps package #594
Merged

sfilipi closed this Jul 30, 2018

sfilipi deleted the mkldeps branch July 30, 2018 17:26

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

WIP: adding the MlNetMklDeps package
9e96175

sfilipi requested review from Ivanidzo4ka and eerhardt July 24, 2018 17:24

Ivanidzo4ka reviewed Jul 24, 2018
View reviewed changes

codemzs mentioned this pull request Jul 26, 2018
Port SymSGD #556
Closed

sfilipi added 2 commits July 26, 2018 09:31

Fixing the MlNetMklDeps nukpproj
fa519e8
Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

reverting test changes to the CSharpCodeGen
19779fe

sfilipi commented Jul 26, 2018
View reviewed changes

sfilipi added 3 commits July 26, 2018 14:08

Adding the LoadableClass assembly attribute with the signature:Signat…
94ff6d3
…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

merging from master
dfc2b35

following the same naming convention for the doc attributes in tags
cd18b74

sfilipi changed the title ~~WIP: adding the MlNetMklDeps package~~Adding the MlNetMklDeps package, adding the entry point, tests and docs for OLS.Jul 27, 2018

sfilipi added 3 commits July 27, 2018 14:13

Fixing the path in the OLS doc include
80f7bd6

removing unecessary packing
f910923

In Mac, release only, one of the OLS tests is failing because the act…
2965477
…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

TomFinley mentioned this pull request Jul 28, 2018
adding a dependency to the MlNetMklDeps package #594
Merged

sfilipi closed this Jul 30, 2018

sfilipi deleted the mkldeps branch July 30, 2018 17:26

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

WIP: adding the MlNetMklDeps package
9e96175

sfilipi requested review from Ivanidzo4ka and eerhardt July 24, 2018 17:24

Ivanidzo4ka reviewed Jul 24, 2018
View reviewed changes

codemzs mentioned this pull request Jul 26, 2018
Port SymSGD #556
Closed

sfilipi added 2 commits July 26, 2018 09:31

Fixing the MlNetMklDeps nukpproj
fa519e8
Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

reverting test changes to the CSharpCodeGen
19779fe

sfilipi commented Jul 26, 2018
View reviewed changes

sfilipi added 3 commits July 26, 2018 14:08

Adding the LoadableClass assembly attribute with the signature:Signat…
94ff6d3
…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

merging from master
dfc2b35

following the same naming convention for the doc attributes in tags
cd18b74

sfilipi changed the title ~~WIP: adding the MlNetMklDeps package~~Adding the MlNetMklDeps package, adding the entry point, tests and docs for OLS.Jul 27, 2018

sfilipi added 3 commits July 27, 2018 14:13

Fixing the path in the OLS doc include
80f7bd6

removing unecessary packing
f910923

In Mac, release only, one of the OLS tests is failing because the act…
2965477
…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

TomFinley mentioned this pull request Jul 28, 2018
adding a dependency to the MlNetMklDeps package #594
Merged

sfilipi closed this Jul 30, 2018

sfilipi deleted the mkldeps branch July 30, 2018 17:26

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

WIP: adding the MlNetMklDeps package
9e96175

sfilipi requested review from Ivanidzo4ka and eerhardt July 24, 2018 17:24

Ivanidzo4ka reviewed Jul 24, 2018
View reviewed changes

codemzs mentioned this pull request Jul 26, 2018
Port SymSGD #556
Closed

sfilipi added 2 commits July 26, 2018 09:31

Fixing the MlNetMklDeps nukpproj
fa519e8
Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

reverting test changes to the CSharpCodeGen
19779fe

sfilipi commented Jul 26, 2018
View reviewed changes

sfilipi added 3 commits July 26, 2018 14:08

Adding the LoadableClass assembly attribute with the signature:Signat…
94ff6d3
…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

merging from master
dfc2b35

following the same naming convention for the doc attributes in tags
cd18b74

sfilipi changed the title ~~WIP: adding the MlNetMklDeps package~~Adding the MlNetMklDeps package, adding the entry point, tests and docs for OLS.Jul 27, 2018

sfilipi added 3 commits July 27, 2018 14:13

Fixing the path in the OLS doc include
80f7bd6

removing unecessary packing
f910923

In Mac, release only, one of the OLS tests is failing because the act…
2965477
…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

TomFinley mentioned this pull request Jul 28, 2018
adding a dependency to the MlNetMklDeps package #594
Merged

sfilipi closed this Jul 30, 2018

sfilipi deleted the mkldeps branch July 30, 2018 17:26

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

WIP: adding the MlNetMklDeps package
9e96175

sfilipi requested review from Ivanidzo4ka and eerhardt July 24, 2018 17:24

Ivanidzo4ka reviewed Jul 24, 2018
View reviewed changes

codemzs mentioned this pull request Jul 26, 2018
Port SymSGD #556
Closed

sfilipi added 2 commits July 26, 2018 09:31

Fixing the MlNetMklDeps nukpproj
fa519e8
Adding Mkl dependency to the StandartLearners project Enabling the Ols tests, adding its EntryPoint, and documentation.

reverting test changes to the CSharpCodeGen
19779fe

sfilipi commented Jul 26, 2018
View reviewed changes

sfilipi added 3 commits July 26, 2018 14:08

Adding the LoadableClass assembly attribute with the signature:Signat…
94ff6d3
…ureEntryPointModule so that the OLS EntryPoint is visible to the Module Catalog. Updating the CSharpApi and the ep-list and manifest. Fixing the test in the documentation

merging from master
dfc2b35

following the same naming convention for the doc attributes in tags
cd18b74

sfilipi changed the title ~~WIP: adding the MlNetMklDeps package~~Adding the MlNetMklDeps package, adding the entry point, tests and docs for OLS.Jul 27, 2018

sfilipi added 3 commits July 27, 2018 14:13

Fixing the path in the OLS doc include
80f7bd6

removing unecessary packing
f910923

In Mac, release only, one of the OLS tests is failing because the act…
2965477
…ual prediction is outside of the calculated range. since we have seen quite a bit of those, set a minimum threeshold, and ignore fluctuations after the 5th decimal point.

TomFinley mentioned this pull request Jul 28, 2018
adding a dependency to the MlNetMklDeps package #594
Merged

sfilipi closed this Jul 30, 2018

sfilipi deleted the mkldeps branch July 30, 2018 17:26

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

		@@ -0,0 +1,5 @@
		<Project DefaultTargets="Pack">

		<Import Project="Microsoft.ML.Parquet.nupkgproj" />

Uh oh!

Conversation

sfilipi commented Jul 24, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ivanidzo4kaJul 24, 2018• edited by sfilipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codemzs commented Jul 24, 2018• edited by sfilipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ivanidzo4kaJul 24, 2018• edited by sfilipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ivanidzo4kaJul 24, 2018• edited by sfilipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomFinley commented Jul 24, 2018• edited by sfilipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codemzs commented Jul 24, 2018

Uh oh!

sfilipiJul 26, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sfilipi commented Jul 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

sfilipi commented Jul 24, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ivanidzo4kaJul 24, 2018• edited by sfilipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codemzs commented Jul 24, 2018• edited by sfilipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ivanidzo4kaJul 24, 2018• edited by sfilipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ivanidzo4kaJul 24, 2018• edited by sfilipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomFinley commented Jul 24, 2018• edited by sfilipi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codemzs commented Jul 24, 2018

Uh oh!

sfilipiJul 26, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sfilipi commented Jul 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

sfilipi commented Jul 24, 2018•
edited
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading

codemzs commented Jul 24, 2018•
edited by sfilipi
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading

TomFinley commented Jul 24, 2018•
edited by sfilipi
Loading

sfilipiJul 26, 2018•
edited
Loading

sfilipi commented Jul 24, 2018•
edited
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading

codemzs commented Jul 24, 2018•
edited by sfilipi
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading

TomFinley commented Jul 24, 2018•
edited by sfilipi
Loading

sfilipiJul 26, 2018•
edited
Loading

sfilipi commented Jul 24, 2018•
edited
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading

codemzs commented Jul 24, 2018•
edited by sfilipi
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading

TomFinley commented Jul 24, 2018•
edited by sfilipi
Loading

sfilipiJul 26, 2018•
edited
Loading

sfilipi commented Jul 24, 2018•
edited
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading

codemzs commented Jul 24, 2018•
edited by sfilipi
Loading

Ivanidzo4kaJul 24, 2018•
edited by sfilipi
Loading