Uh oh!
There was an error while loading. Please reload this page.
Try forcing wasm to use 7.0 channel. - #2696
Merged
LoopedBard3 merged 1 commit intoNov 5, 2022
Merged
Conversation
LoopedBard3
marked this pull request as ready for review
November 5, 2022 03:07
caaavik-msft
approved these changes
Nov 5, 2022
LoopedBard3
commented
Nov 5, 2022
MemberAuthor
cc @radical, here is the test run that seems to show this fixing the wasm issue: https://dev.azure.com/dnceng/internal/_build/results?buildId=2037728&view=results. Please ping if this is the incorrect run or the fix did not work like it did in the test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A less impactful replacement for #2695. Fixes a wasm build issue by forcing wasm to target net7.0 instead of net8.0, while leaving the rest of the runs to use net8.0.