Uh oh!
There was an error while loading. Please reload this page.
Set main to run net7.0 until sdk+runtime are supported - #2695
Set main to run net7.0 until sdk+runtime are supported #2695LoopedBard3 wants to merge 1 commit into
Conversation
radical
commented
Nov 4, 2022
Honestly, I'm not sure what the correct fix would be, and there might not be one for now. AFAIU, we are not quite there with net8.0 project support, w.r.t the SDK, and runtime. What would be the impact of this change? Wouldn't we also need to change the tfm being passed to the command line? |
radical
commented
Nov 4, 2022
Also, before merging this one do make sure to run a |
LoopedBard3
commented
Nov 4, 2022
Yup, got a run going atm: https://dev.azure.com/dnceng/internal/_build/results?buildId=2037521&view=results |
LoopedBard3
commented
Nov 4, 2022
Changing the main branch runs back to net7.0 and 7.0 branch will cause things to build with net7.0. |
LoopedBard3
commented
Nov 4, 2022
It looks like this fixed the wasm runs. Waiting for the rest of the test runs to finish and a review. |
LoopedBard3
commented
Nov 4, 2022
One wasm run succeeded and one had a handful of failures. |
LoopedBard3
commented
Nov 4, 2022
@radical Do you know the ETA for having net8.0 packages for wasm? |
radical
commented
Nov 5, 2022
AFAIK, we are waiting for other things to be in place, like a PR that would change the default TFM in |
caaavik-msft
left a comment
There was a problem hiding this comment.
Approving in the case that the alternative solution to use net7.0 for just wasm is not suitable
| 'main': { | ||
| 'tfm': 'net8.0', | ||
| 'branch': '8.0', | ||
| 'tfm': 'net7.0', |
There was a problem hiding this comment.
Is this used only to decide which tfm to use on dotnet/runtimemain branch?
Uh oh!
There was an error while loading. Please reload this page.
LoopedBard3
commented
Nov 5, 2022
Closing to merge #2696 as a fix instead. This will allow wasm to build targeting net7 while the rest of the builds target net8.0. |
carlossanlop
commented
Nov 7, 2022
It seems this issue is related to dotnet/runtime#77899 . FYI, I merged it. |
Set main to run net7.0 until sdk+runtime are supported per: dotnet/runtime#77913 (comment).
@radical is this the fix you had in mind from the above comment?