Arm64/Sve: Implement ConditionalSelect API by kunalspathak · Pull Request #100718 · dotnet/runtime

kunalspathak · 2024-04-06T00:30:50Z

ghost · 2024-04-06T00:30:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

kunalspathak · 2024-04-06T00:31:03Z

@dotnet/arm64-contrib

dotnet-policy-service · 2024-04-06T00:35:15Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

a74nh · 2024-04-08T14:10:34Z

@@ -0,0 +1,362 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+


Is this template based on an existing template?
Can we just use a generic 3 op template here? I don't think I see anthing specific to conditionalselect

tannergooding · 2024-04-08T15:17:25Z


+ /// ConditionalSelect : Conditionally select elements

+ /// <summary>


nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)

@a74nh - do you mind fixing the tool to generate these alphabetically?

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.

tannergooding · 2024-04-08T15:19:55Z

 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
-
+ public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }


If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.

kunalspathak · 2024-04-24T18:20:47Z

Replaced with #100743

kunalspathak · 2024-04-06T00:30:50Z

ghost · 2024-04-06T00:30:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

kunalspathak · 2024-04-06T00:31:03Z

@dotnet/arm64-contrib

dotnet-policy-service · 2024-04-06T00:35:15Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

a74nh · 2024-04-08T14:10:34Z

@@ -0,0 +1,362 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+


Is this template based on an existing template?
Can we just use a generic 3 op template here? I don't think I see anthing specific to conditionalselect

tannergooding · 2024-04-08T15:17:25Z


+ /// ConditionalSelect : Conditionally select elements

+ /// <summary>


nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)

@a74nh - do you mind fixing the tool to generate these alphabetically?

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.

tannergooding · 2024-04-08T15:19:55Z

 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
-
+ public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }


If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.

kunalspathak · 2024-04-24T18:20:47Z

Replaced with #100743

kunalspathak · 2024-04-06T00:30:50Z

ghost · 2024-04-06T00:30:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

kunalspathak · 2024-04-06T00:31:03Z

@dotnet/arm64-contrib

dotnet-policy-service · 2024-04-06T00:35:15Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

a74nh · 2024-04-08T14:10:34Z

@@ -0,0 +1,362 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+


Is this template based on an existing template?
Can we just use a generic 3 op template here? I don't think I see anthing specific to conditionalselect

tannergooding · 2024-04-08T15:17:25Z


+ /// ConditionalSelect : Conditionally select elements

+ /// <summary>


nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)

@a74nh - do you mind fixing the tool to generate these alphabetically?

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.

tannergooding · 2024-04-08T15:19:55Z

 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
-
+ public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }


If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.

kunalspathak · 2024-04-24T18:20:47Z

Replaced with #100743

kunalspathak · 2024-04-06T00:30:50Z

ghost · 2024-04-06T00:30:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

kunalspathak · 2024-04-06T00:31:03Z

@dotnet/arm64-contrib

dotnet-policy-service · 2024-04-06T00:35:15Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

a74nh · 2024-04-08T14:10:34Z

@@ -0,0 +1,362 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+


Is this template based on an existing template?
Can we just use a generic 3 op template here? I don't think I see anthing specific to conditionalselect

tannergooding · 2024-04-08T15:17:25Z


+ /// ConditionalSelect : Conditionally select elements

+ /// <summary>


nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)

@a74nh - do you mind fixing the tool to generate these alphabetically?

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.

tannergooding · 2024-04-08T15:19:55Z

 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
-
+ public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }


If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.

kunalspathak · 2024-04-24T18:20:47Z

Replaced with #100743

kunalspathak · 2024-04-06T00:30:50Z

ghost · 2024-04-06T00:30:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

kunalspathak · 2024-04-06T00:31:03Z

@dotnet/arm64-contrib

dotnet-policy-service · 2024-04-06T00:35:15Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

a74nh · 2024-04-08T14:10:34Z

@@ -0,0 +1,362 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+


Is this template based on an existing template?
Can we just use a generic 3 op template here? I don't think I see anthing specific to conditionalselect

tannergooding · 2024-04-08T15:17:25Z


+ /// ConditionalSelect : Conditionally select elements

+ /// <summary>


nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)

@a74nh - do you mind fixing the tool to generate these alphabetically?

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.

tannergooding · 2024-04-08T15:19:55Z

 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
-
+ public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }


If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.

kunalspathak · 2024-04-24T18:20:47Z

Replaced with #100743

kunalspathak · 2024-04-06T00:30:50Z

ghost · 2024-04-06T00:30:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

kunalspathak · 2024-04-06T00:31:03Z

@dotnet/arm64-contrib

dotnet-policy-service · 2024-04-06T00:35:15Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

a74nh · 2024-04-08T14:10:34Z

@@ -0,0 +1,362 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+


Is this template based on an existing template?
Can we just use a generic 3 op template here? I don't think I see anthing specific to conditionalselect

tannergooding · 2024-04-08T15:17:25Z


+ /// ConditionalSelect : Conditionally select elements

+ /// <summary>


nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)

@a74nh - do you mind fixing the tool to generate these alphabetically?

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.

tannergooding · 2024-04-08T15:19:55Z

 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
-
+ public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }


If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.

kunalspathak · 2024-04-24T18:20:47Z

Replaced with #100743

kunalspathak · 2024-04-06T00:30:50Z

ghost · 2024-04-06T00:30:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

kunalspathak · 2024-04-06T00:31:03Z

@dotnet/arm64-contrib

dotnet-policy-service · 2024-04-06T00:35:15Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

a74nh · 2024-04-08T14:10:34Z

@@ -0,0 +1,362 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+


Is this template based on an existing template?
Can we just use a generic 3 op template here? I don't think I see anthing specific to conditionalselect

tannergooding · 2024-04-08T15:17:25Z


+ /// ConditionalSelect : Conditionally select elements

+ /// <summary>


nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)

@a74nh - do you mind fixing the tool to generate these alphabetically?

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.

tannergooding · 2024-04-08T15:19:55Z

 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
-
+ public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }


If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.

kunalspathak · 2024-04-24T18:20:47Z

Replaced with #100743

kunalspathak · 2024-04-06T00:30:50Z

ghost · 2024-04-06T00:30:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

kunalspathak · 2024-04-06T00:31:03Z

@dotnet/arm64-contrib

dotnet-policy-service · 2024-04-06T00:35:15Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

a74nh · 2024-04-08T14:10:34Z

@@ -0,0 +1,362 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+


Is this template based on an existing template?
Can we just use a generic 3 op template here? I don't think I see anthing specific to conditionalselect

tannergooding · 2024-04-08T15:17:25Z


+ /// ConditionalSelect : Conditionally select elements

+ /// <summary>


nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)

@a74nh - do you mind fixing the tool to generate these alphabetically?

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.

tannergooding · 2024-04-08T15:19:55Z

 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
-
+ public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }


If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.

kunalspathak · 2024-04-24T18:20:47Z

Replaced with #100743

kunalspathak added 4 commits April 4, 2024 01:28

Add ConditionalSelect() APIs
20defbd

Handle ConditionalSelect in JIT
c70367f

Add test coverage
1896b21

Update the test cases
2e0d022

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels Apr 6, 2024

kunalspathak mentioned this pull request Apr 6, 2024
Arm64: Implement SVE APIs #99957
Closed

dotnet-policy-serviceBot assigned kunalspathak Apr 6, 2024

This was referenced Apr 6, 2024
[browser] RuntimeError: memory access out of bounds #96546
Closed
[browser] Process terminated assert handling at icall.c:6162 #100249
Closed
System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu #100715
Closed

kunalspathak mentioned this pull request Apr 7, 2024
Arm64/Sve: Predicated Abs, Predicated/UnPredicated Add, Conditional Select #100743
Merged

a74nh reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

a74nh reviewed Apr 8, 2024
View reviewed changes

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

tannergooding reviewed Apr 8, 2024
View reviewed changes

kunalspathak added arm-sve Work related to arm64 SVE/SVE2 support NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 12, 2024

kunalspathak closed this Apr 24, 2024

github-actionsBot locked and limited conversation to collaborators May 25, 2024

kunalspathak added 4 commits April 4, 2024 01:28

Add ConditionalSelect() APIs
20defbd

Handle ConditionalSelect in JIT
c70367f

Add test coverage
1896b21

Update the test cases
2e0d022

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels Apr 6, 2024

kunalspathak mentioned this pull request Apr 6, 2024
Arm64: Implement SVE APIs #99957
Closed

dotnet-policy-serviceBot assigned kunalspathak Apr 6, 2024

This was referenced Apr 6, 2024
[browser] RuntimeError: memory access out of bounds #96546
Closed
[browser] Process terminated assert handling at icall.c:6162 #100249
Closed
System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu #100715
Closed

kunalspathak mentioned this pull request Apr 7, 2024
Arm64/Sve: Predicated Abs, Predicated/UnPredicated Add, Conditional Select #100743
Merged

a74nh reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

a74nh reviewed Apr 8, 2024
View reviewed changes

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

tannergooding reviewed Apr 8, 2024
View reviewed changes

kunalspathak added arm-sve Work related to arm64 SVE/SVE2 support NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 12, 2024

kunalspathak closed this Apr 24, 2024

github-actionsBot locked and limited conversation to collaborators May 25, 2024

kunalspathak added 4 commits April 4, 2024 01:28

Add ConditionalSelect() APIs
20defbd

Handle ConditionalSelect in JIT
c70367f

Add test coverage
1896b21

Update the test cases
2e0d022

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels Apr 6, 2024

kunalspathak mentioned this pull request Apr 6, 2024
Arm64: Implement SVE APIs #99957
Closed

dotnet-policy-serviceBot assigned kunalspathak Apr 6, 2024

This was referenced Apr 6, 2024
[browser] RuntimeError: memory access out of bounds #96546
Closed
[browser] Process terminated assert handling at icall.c:6162 #100249
Closed
System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu #100715
Closed

kunalspathak mentioned this pull request Apr 7, 2024
Arm64/Sve: Predicated Abs, Predicated/UnPredicated Add, Conditional Select #100743
Merged

a74nh reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

a74nh reviewed Apr 8, 2024
View reviewed changes

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

tannergooding reviewed Apr 8, 2024
View reviewed changes

kunalspathak added arm-sve Work related to arm64 SVE/SVE2 support NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 12, 2024

kunalspathak closed this Apr 24, 2024

github-actionsBot locked and limited conversation to collaborators May 25, 2024

kunalspathak added 4 commits April 4, 2024 01:28

Add ConditionalSelect() APIs
20defbd

Handle ConditionalSelect in JIT
c70367f

Add test coverage
1896b21

Update the test cases
2e0d022

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels Apr 6, 2024

kunalspathak mentioned this pull request Apr 6, 2024
Arm64: Implement SVE APIs #99957
Closed

dotnet-policy-serviceBot assigned kunalspathak Apr 6, 2024

This was referenced Apr 6, 2024
[browser] RuntimeError: memory access out of bounds #96546
Closed
[browser] Process terminated assert handling at icall.c:6162 #100249
Closed
System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu #100715
Closed

kunalspathak mentioned this pull request Apr 7, 2024
Arm64/Sve: Predicated Abs, Predicated/UnPredicated Add, Conditional Select #100743
Merged

a74nh reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

a74nh reviewed Apr 8, 2024
View reviewed changes

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

tannergooding reviewed Apr 8, 2024
View reviewed changes

kunalspathak added arm-sve Work related to arm64 SVE/SVE2 support NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 12, 2024

kunalspathak closed this Apr 24, 2024

github-actionsBot locked and limited conversation to collaborators May 25, 2024

kunalspathak added 4 commits April 4, 2024 01:28

Add ConditionalSelect() APIs
20defbd

Handle ConditionalSelect in JIT
c70367f

Add test coverage
1896b21

Update the test cases
2e0d022

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels Apr 6, 2024

kunalspathak mentioned this pull request Apr 6, 2024
Arm64: Implement SVE APIs #99957
Closed

dotnet-policy-serviceBot assigned kunalspathak Apr 6, 2024

This was referenced Apr 6, 2024
[browser] RuntimeError: memory access out of bounds #96546
Closed
[browser] Process terminated assert handling at icall.c:6162 #100249
Closed
System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu #100715
Closed

kunalspathak mentioned this pull request Apr 7, 2024
Arm64/Sve: Predicated Abs, Predicated/UnPredicated Add, Conditional Select #100743
Merged

a74nh reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

a74nh reviewed Apr 8, 2024
View reviewed changes

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

tannergooding reviewed Apr 8, 2024
View reviewed changes

kunalspathak added arm-sve Work related to arm64 SVE/SVE2 support NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 12, 2024

kunalspathak closed this Apr 24, 2024

github-actionsBot locked and limited conversation to collaborators May 25, 2024

kunalspathak added 4 commits April 4, 2024 01:28

Add ConditionalSelect() APIs
20defbd

Handle ConditionalSelect in JIT
c70367f

Add test coverage
1896b21

Update the test cases
2e0d022

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels Apr 6, 2024

kunalspathak mentioned this pull request Apr 6, 2024
Arm64: Implement SVE APIs #99957
Closed

dotnet-policy-serviceBot assigned kunalspathak Apr 6, 2024

This was referenced Apr 6, 2024
[browser] RuntimeError: memory access out of bounds #96546
Closed
[browser] Process terminated assert handling at icall.c:6162 #100249
Closed
System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu #100715
Closed

kunalspathak mentioned this pull request Apr 7, 2024
Arm64/Sve: Predicated Abs, Predicated/UnPredicated Add, Conditional Select #100743
Merged

a74nh reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

a74nh reviewed Apr 8, 2024
View reviewed changes

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

tannergooding reviewed Apr 8, 2024
View reviewed changes

kunalspathak added arm-sve Work related to arm64 SVE/SVE2 support NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 12, 2024

kunalspathak closed this Apr 24, 2024

github-actionsBot locked and limited conversation to collaborators May 25, 2024

kunalspathak added 4 commits April 4, 2024 01:28

Add ConditionalSelect() APIs
20defbd

Handle ConditionalSelect in JIT
c70367f

Add test coverage
1896b21

Update the test cases
2e0d022

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels Apr 6, 2024

kunalspathak mentioned this pull request Apr 6, 2024
Arm64: Implement SVE APIs #99957
Closed

dotnet-policy-serviceBot assigned kunalspathak Apr 6, 2024

This was referenced Apr 6, 2024
[browser] RuntimeError: memory access out of bounds #96546
Closed
[browser] Process terminated assert handling at icall.c:6162 #100249
Closed
System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu #100715
Closed

kunalspathak mentioned this pull request Apr 7, 2024
Arm64/Sve: Predicated Abs, Predicated/UnPredicated Add, Conditional Select #100743
Merged

a74nh reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

a74nh reviewed Apr 8, 2024
View reviewed changes

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

tannergooding reviewed Apr 8, 2024
View reviewed changes

kunalspathak added arm-sve Work related to arm64 SVE/SVE2 support NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 12, 2024

kunalspathak closed this Apr 24, 2024

github-actionsBot locked and limited conversation to collaborators May 25, 2024

kunalspathak added 4 commits April 4, 2024 01:28

Add ConditionalSelect() APIs
20defbd

Handle ConditionalSelect in JIT
c70367f

Add test coverage
1896b21

Update the test cases
2e0d022

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels Apr 6, 2024

kunalspathak mentioned this pull request Apr 6, 2024
Arm64: Implement SVE APIs #99957
Closed

dotnet-policy-serviceBot assigned kunalspathak Apr 6, 2024

This was referenced Apr 6, 2024
[browser] RuntimeError: memory access out of bounds #96546
Closed
[browser] Process terminated assert handling at icall.c:6162 #100249
Closed
System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu #100715
Closed

kunalspathak mentioned this pull request Apr 7, 2024
Arm64/Sve: Predicated Abs, Predicated/UnPredicated Add, Conditional Select #100743
Merged

a74nh reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

a74nh reviewed Apr 8, 2024
View reviewed changes

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp

tannergooding reviewed Apr 8, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h

tannergooding reviewed Apr 8, 2024
View reviewed changes

kunalspathak added arm-sve Work related to arm64 SVE/SVE2 support NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 12, 2024

kunalspathak closed this Apr 24, 2024

github-actionsBot locked and limited conversation to collaborators May 25, 2024

		@@ -0,0 +1,362 @@
		// Licensed to the .NET Foundation under one or more agreements.
		// The .NET Foundation licenses this file to you under the MIT license.


		/// ConditionalSelect : Conditionally select elements

		/// <summary>

Uh oh!

Conversation

kunalspathak commented Apr 6, 2024

Uh oh!

ghost commented Apr 6, 2024

Uh oh!

kunalspathak commented Apr 6, 2024

Uh oh!

dotnet-policy-serviceBot commented Apr 6, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kunalspathak commented Apr 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kunalspathak commented Apr 6, 2024

Uh oh!

ghost commented Apr 6, 2024

Uh oh!

kunalspathak commented Apr 6, 2024

Uh oh!

dotnet-policy-serviceBot commented Apr 6, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kunalspathak commented Apr 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kunalspathak commented Apr 6, 2024

Uh oh!

ghost commented Apr 6, 2024

Uh oh!

kunalspathak commented Apr 6, 2024

Uh oh!

dotnet-policy-serviceBot commented Apr 6, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!