Arm64/Sve: Implement ConditionalSelect API#100718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kunalspathak wants to merge 4 commits into from
Closed

Arm64/Sve: Implement ConditionalSelect API #100718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20defbd
Add ConditionalSelect() APIs
kunalspathak Apr 4, 2024
c70367f
Handle ConditionalSelect in JIT
kunalspathak Apr 4, 2024
1896b21
Add test coverage
kunalspathak Apr 4, 2024
2e0d022
Update the test cases
kunalspathak Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/coreclr/jit/hwintrinsiccodegenarm64.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -434,15 +434,23 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
break;

case 3:
assert(isRMW);
if (targetReg != op1Reg)
if (isRMW)
{
assert(targetReg != op2Reg);
assert(targetReg != op3Reg);
if (targetReg != op1Reg)
{
assert(targetReg != op2Reg);
assert(targetReg != op3Reg);

GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg, /* canSkip */ true);
GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg,
/* canSkip */ true);
}
GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
}
else
{
GetEmitter()->emitIns_R_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, op3Reg,
opt, INS_SCALABLE_OPTS_UNPREDICATED);
Comment thread
kunalspathak marked this conversation as resolved.
}
GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
break;

default:
Expand Down
3 changes: 2 additions & 1 deletion src/coreclr/jit/hwintrinsiclistarm64sve.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,10 +38,11 @@ HARDWARE_INTRINSIC(Sve, LoadVector,
// ***************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
// Special intrinsics that are generated during importing or lowering

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)
Comment thread
kunalspathak marked this conversation as resolved.
HARDWARE_INTRINSIC(Sve, ConditionalSelect, -1, 3, true, {INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_MaskedOperation)
Comment thread
kunalspathak marked this conversation as resolved.
HARDWARE_INTRINSIC(Sve, ConvertMaskToVector, -1, 1, true, {INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_MaskedOperation)
HARDWARE_INTRINSIC(Sve, ConvertVectorToMask, -1, 2, true, {INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask|HW_Flag_LowMaskedOperation)

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)

#endif // FEATURE_HW_INTRINSIC

Expand Down
58 changes: 58 additions & 0 deletions ...ries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,65 @@ internal Arm64() { }
/// </summary>
public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw new PlatformNotSupportedException(); }

/// ConditionalSelect : Conditionally select elements

/// <summary>

@tannergoodingtannergoodingApr 8, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.

This is done based on the type name, not the language keyword:

  • byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)

@kunalspathakkunalspathakApr 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?

@a74nha74nhApr 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?

Done. The branch with the autogenerated files should now be in order for all the .cs files.

/// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// </summary>
public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// </summary>
public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// </summary>
public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// </summary>
public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// </summary>
public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// </summary>
public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// </summary>
public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// </summary>
public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
/// </summary>
public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
/// </summary>
public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) { throw new PlatformNotSupportedException(); }

/// LoadVector : Unextended load

Expand Down
86 changes: 86 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -118,7 +118,93 @@ internal Arm64() { }
/// </summary>
public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) => CreateTrueMaskUInt64(pattern);

/// ConditionalSelect : Conditionally select elements

/// <summary>
/// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
/// SEL Zresult.B, Pg, Zop1.B, Zop2.B
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// SEL Presult.B, Pg, Pop1.B, Pop2.B
///
/// </summary>
public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) => ConditionalSelect(mask, left, right);

/// <summary>
/// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
/// SEL Zresult.H, Pg, Zop1.H, Zop2.H
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// SEL Presult.B, Pg, Pop1.B, Pop2.B
///
/// </summary>
public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) => ConditionalSelect(mask, left, right);

/// <summary>
/// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
/// SEL Zresult.S, Pg, Zop1.S, Zop2.S
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// SEL Presult.B, Pg, Pop1.B, Pop2.B
///
/// </summary>
public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) => ConditionalSelect(mask, left, right);

/// <summary>
/// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
/// SEL Zresult.D, Pg, Zop1.D, Zop2.D
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// SEL Presult.B, Pg, Pop1.B, Pop2.B
///
/// </summary>
public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) => ConditionalSelect(mask, left, right);

/// <summary>
/// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
/// SEL Zresult.B, Pg, Zop1.B, Zop2.B
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// SEL Presult.B, Pg, Pop1.B, Pop2.B
///
/// </summary>
public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) => ConditionalSelect(mask, left, right);

/// <summary>
/// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
/// SEL Zresult.H, Pg, Zop1.H, Zop2.H
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// SEL Presult.B, Pg, Pop1.B, Pop2.B
///
/// </summary>
public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) => ConditionalSelect(mask, left, right);

/// <summary>
/// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
/// SEL Zresult.S, Pg, Zop1.S, Zop2.S
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// SEL Presult.B, Pg, Pop1.B, Pop2.B
///
/// </summary>
public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) => ConditionalSelect(mask, left, right);

/// <summary>
/// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
/// SEL Zresult.D, Pg, Zop1.D, Zop2.D
/// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
/// SEL Presult.B, Pg, Pop1.B, Pop2.B
///
/// </summary>
public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) => ConditionalSelect(mask, left, right);

/// <summary>
/// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
/// SEL Zresult.S, Pg, Zop1.S, Zop2.S
///
/// </summary>
public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) => ConditionalSelect(mask, left, right);

/// <summary>
/// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
/// SEL Zresult.D, Pg, Zop1.D, Zop2.D
///
/// </summary>
public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) => ConditionalSelect(mask, left, right);

/// LoadVector : Unextended load

Expand Down
11 changes: 10 additions & 1 deletion src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4149,7 +4149,16 @@ internal Arm64() { }
public static System.Numerics.Vector<ushort> CreateTrueMaskUInt16([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }

public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }

@tannergoodingtannergoodingApr 8, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.

public static System.Numerics.Vector<short> ConditionalSelect(System.Numerics.Vector<short> mask, System.Numerics.Vector<short> left, System.Numerics.Vector<short> right) { throw null; }
public static System.Numerics.Vector<int> ConditionalSelect(System.Numerics.Vector<int> mask, System.Numerics.Vector<int> left, System.Numerics.Vector<int> right) { throw null; }
public static System.Numerics.Vector<long> ConditionalSelect(System.Numerics.Vector<long> mask, System.Numerics.Vector<long> left, System.Numerics.Vector<long> right) { throw null; }
public static System.Numerics.Vector<byte> ConditionalSelect(System.Numerics.Vector<byte> mask, System.Numerics.Vector<byte> left, System.Numerics.Vector<byte> right) { throw null; }
public static System.Numerics.Vector<ushort> ConditionalSelect(System.Numerics.Vector<ushort> mask, System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right) { throw null; }
public static System.Numerics.Vector<uint> ConditionalSelect(System.Numerics.Vector<uint> mask, System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right) { throw null; }
public static System.Numerics.Vector<ulong> ConditionalSelect(System.Numerics.Vector<ulong> mask, System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right) { throw null; }
public static System.Numerics.Vector<float> ConditionalSelect(System.Numerics.Vector<float> mask, System.Numerics.Vector<float> left, System.Numerics.Vector<float> right) { throw null; }
public static System.Numerics.Vector<double> ConditionalSelect(System.Numerics.Vector<double> mask, System.Numerics.Vector<double> left, System.Numerics.Vector<double> right) { throw null; }
public static unsafe System.Numerics.Vector<sbyte> LoadVector(System.Numerics.Vector<sbyte> mask, sbyte* address) { throw null; }
public static unsafe System.Numerics.Vector<short> LoadVector(System.Numerics.Vector<short> mask, short* address) { throw null; }
public static unsafe System.Numerics.Vector<int> LoadVector(System.Numerics.Vector<int> mask, int* address) { throw null; }
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Arm64/Sve: Implement ConditionalSelect API#100718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

kunalspathak
wants to merge
4
commits into

from

 Closed


Arm64/Sve: Implement ConditionalSelect API
#100718
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
20defbd

Add ConditionalSelect() APIs


kunalspathak Apr 4, 2024
c70367f

Handle ConditionalSelect in JIT


kunalspathak Apr 4, 2024
1896b21

Add test coverage


kunalspathak Apr 4, 2024
2e0d022

Update the test cases


kunalspathak Apr 6, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 14 additions & 6 deletions
src/coreclr/jit/hwintrinsiccodegenarm64.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -434,15 +434,23 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
 break;

 case 3:
 assert(isRMW);
 if (targetReg != op1Reg)
 if (isRMW)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);
 if (targetReg != op1Reg)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);

 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg, /* canSkip */ true);
 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg,
 /* canSkip */ true);
 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 }
 else
 {
 GetEmitter()->emitIns_R_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, op3Reg,
 opt, INS_SCALABLE_OPTS_UNPREDICATED);
Comment thread
kunalspathak marked this conversation as resolved.

 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 break;

 default:
Expand Down

3 changes: 2 additions & 1 deletion
src/coreclr/jit/hwintrinsiclistarm64sve.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,10 +38,11 @@ HARDWARE_INTRINSIC(Sve, LoadVector,
// ***************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
// Special intrinsics that are generated during importing or lowering

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConditionalSelect, -1, 3, true, {INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_MaskedOperation)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConvertMaskToVector, -1, 1, true, {INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_MaskedOperation)
HARDWARE_INTRINSIC(Sve, ConvertVectorToMask, -1, 2, true, {INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask|HW_Flag_LowMaskedOperation)

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)

#endif // FEATURE_HW_INTRINSIC

Expand Down

58 changes: 58 additions & 0 deletions
...ries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,65 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw new PlatformNotSupportedException(); }

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
  • byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)
@kunalspathakkunalspathakApr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
@a74nha74nhApr 16, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) { throw new PlatformNotSupportedException(); }

 /// LoadVector : Unextended load

Expand Down

86 changes: 86 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -118,7 +118,93 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) => CreateTrueMaskUInt64(pattern);

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 ///
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 ///
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) => ConditionalSelect(mask, left, right);

 /// LoadVector : Unextended load

Expand Down

11 changes: 10 additions & 1 deletion
src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4149,7 +4149,16 @@ internal Arm64() { }
 public static System.Numerics.Vector<ushort> CreateTrueMaskUInt16([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }

 public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.
 public static System.Numerics.Vector<short> ConditionalSelect(System.Numerics.Vector<short> mask, System.Numerics.Vector<short> left, System.Numerics.Vector<short> right) { throw null; }
 public static System.Numerics.Vector<int> ConditionalSelect(System.Numerics.Vector<int> mask, System.Numerics.Vector<int> left, System.Numerics.Vector<int> right) { throw null; }
 public static System.Numerics.Vector<long> ConditionalSelect(System.Numerics.Vector<long> mask, System.Numerics.Vector<long> left, System.Numerics.Vector<long> right) { throw null; }
 public static System.Numerics.Vector<byte> ConditionalSelect(System.Numerics.Vector<byte> mask, System.Numerics.Vector<byte> left, System.Numerics.Vector<byte> right) { throw null; }
 public static System.Numerics.Vector<ushort> ConditionalSelect(System.Numerics.Vector<ushort> mask, System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right) { throw null; }
 public static System.Numerics.Vector<uint> ConditionalSelect(System.Numerics.Vector<uint> mask, System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right) { throw null; }
 public static System.Numerics.Vector<ulong> ConditionalSelect(System.Numerics.Vector<ulong> mask, System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right) { throw null; }
 public static System.Numerics.Vector<float> ConditionalSelect(System.Numerics.Vector<float> mask, System.Numerics.Vector<float> left, System.Numerics.Vector<float> right) { throw null; }
 public static System.Numerics.Vector<double> ConditionalSelect(System.Numerics.Vector<double> mask, System.Numerics.Vector<double> left, System.Numerics.Vector<double> right) { throw null; } 
 public static unsafe System.Numerics.Vector<sbyte> LoadVector(System.Numerics.Vector<sbyte> mask, sbyte* address) { throw null; }
 public static unsafe System.Numerics.Vector<short> LoadVector(System.Numerics.Vector<short> mask, short* address) { throw null; }
 public static unsafe System.Numerics.Vector<int> LoadVector(System.Numerics.Vector<int> mask, int* address) { throw null; }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Arm64/Sve: Implement ConditionalSelect API#100718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

kunalspathak
wants to merge
4
commits into

from

 Closed


Arm64/Sve: Implement ConditionalSelect API
#100718
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
20defbd

Add ConditionalSelect() APIs


kunalspathak Apr 4, 2024
c70367f

Handle ConditionalSelect in JIT


kunalspathak Apr 4, 2024
1896b21

Add test coverage


kunalspathak Apr 4, 2024
2e0d022

Update the test cases


kunalspathak Apr 6, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 14 additions & 6 deletions
src/coreclr/jit/hwintrinsiccodegenarm64.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -434,15 +434,23 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
 break;

 case 3:
 assert(isRMW);
 if (targetReg != op1Reg)
 if (isRMW)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);
 if (targetReg != op1Reg)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);

 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg, /* canSkip */ true);
 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg,
 /* canSkip */ true);
 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 }
 else
 {
 GetEmitter()->emitIns_R_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, op3Reg,
 opt, INS_SCALABLE_OPTS_UNPREDICATED);
Comment thread
kunalspathak marked this conversation as resolved.

 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 break;

 default:
Expand Down

3 changes: 2 additions & 1 deletion
src/coreclr/jit/hwintrinsiclistarm64sve.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,10 +38,11 @@ HARDWARE_INTRINSIC(Sve, LoadVector,
// ***************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
// Special intrinsics that are generated during importing or lowering

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConditionalSelect, -1, 3, true, {INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_MaskedOperation)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConvertMaskToVector, -1, 1, true, {INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_MaskedOperation)
HARDWARE_INTRINSIC(Sve, ConvertVectorToMask, -1, 2, true, {INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask|HW_Flag_LowMaskedOperation)

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)

#endif // FEATURE_HW_INTRINSIC

Expand Down

58 changes: 58 additions & 0 deletions
...ries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,65 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw new PlatformNotSupportedException(); }

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
  • byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)
@kunalspathakkunalspathakApr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
@a74nha74nhApr 16, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) { throw new PlatformNotSupportedException(); }

 /// LoadVector : Unextended load

Expand Down

86 changes: 86 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -118,7 +118,93 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) => CreateTrueMaskUInt64(pattern);

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 ///
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 ///
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) => ConditionalSelect(mask, left, right);

 /// LoadVector : Unextended load

Expand Down

11 changes: 10 additions & 1 deletion
src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4149,7 +4149,16 @@ internal Arm64() { }
 public static System.Numerics.Vector<ushort> CreateTrueMaskUInt16([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }

 public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.
 public static System.Numerics.Vector<short> ConditionalSelect(System.Numerics.Vector<short> mask, System.Numerics.Vector<short> left, System.Numerics.Vector<short> right) { throw null; }
 public static System.Numerics.Vector<int> ConditionalSelect(System.Numerics.Vector<int> mask, System.Numerics.Vector<int> left, System.Numerics.Vector<int> right) { throw null; }
 public static System.Numerics.Vector<long> ConditionalSelect(System.Numerics.Vector<long> mask, System.Numerics.Vector<long> left, System.Numerics.Vector<long> right) { throw null; }
 public static System.Numerics.Vector<byte> ConditionalSelect(System.Numerics.Vector<byte> mask, System.Numerics.Vector<byte> left, System.Numerics.Vector<byte> right) { throw null; }
 public static System.Numerics.Vector<ushort> ConditionalSelect(System.Numerics.Vector<ushort> mask, System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right) { throw null; }
 public static System.Numerics.Vector<uint> ConditionalSelect(System.Numerics.Vector<uint> mask, System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right) { throw null; }
 public static System.Numerics.Vector<ulong> ConditionalSelect(System.Numerics.Vector<ulong> mask, System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right) { throw null; }
 public static System.Numerics.Vector<float> ConditionalSelect(System.Numerics.Vector<float> mask, System.Numerics.Vector<float> left, System.Numerics.Vector<float> right) { throw null; }
 public static System.Numerics.Vector<double> ConditionalSelect(System.Numerics.Vector<double> mask, System.Numerics.Vector<double> left, System.Numerics.Vector<double> right) { throw null; } 
 public static unsafe System.Numerics.Vector<sbyte> LoadVector(System.Numerics.Vector<sbyte> mask, sbyte* address) { throw null; }
 public static unsafe System.Numerics.Vector<short> LoadVector(System.Numerics.Vector<short> mask, short* address) { throw null; }
 public static unsafe System.Numerics.Vector<int> LoadVector(System.Numerics.Vector<int> mask, int* address) { throw null; }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Arm64/Sve: Implement ConditionalSelect API#100718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

kunalspathak
wants to merge
4
commits into

from

 Closed


Arm64/Sve: Implement ConditionalSelect API
#100718
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
20defbd

Add ConditionalSelect() APIs


kunalspathak Apr 4, 2024
c70367f

Handle ConditionalSelect in JIT


kunalspathak Apr 4, 2024
1896b21

Add test coverage


kunalspathak Apr 4, 2024
2e0d022

Update the test cases


kunalspathak Apr 6, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 14 additions & 6 deletions
src/coreclr/jit/hwintrinsiccodegenarm64.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -434,15 +434,23 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
 break;

 case 3:
 assert(isRMW);
 if (targetReg != op1Reg)
 if (isRMW)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);
 if (targetReg != op1Reg)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);

 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg, /* canSkip */ true);
 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg,
 /* canSkip */ true);
 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 }
 else
 {
 GetEmitter()->emitIns_R_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, op3Reg,
 opt, INS_SCALABLE_OPTS_UNPREDICATED);
Comment thread
kunalspathak marked this conversation as resolved.

 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 break;

 default:
Expand Down

3 changes: 2 additions & 1 deletion
src/coreclr/jit/hwintrinsiclistarm64sve.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,10 +38,11 @@ HARDWARE_INTRINSIC(Sve, LoadVector,
// ***************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
// Special intrinsics that are generated during importing or lowering

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConditionalSelect, -1, 3, true, {INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_MaskedOperation)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConvertMaskToVector, -1, 1, true, {INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_MaskedOperation)
HARDWARE_INTRINSIC(Sve, ConvertVectorToMask, -1, 2, true, {INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask|HW_Flag_LowMaskedOperation)

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)

#endif // FEATURE_HW_INTRINSIC

Expand Down

58 changes: 58 additions & 0 deletions
...ries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,65 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw new PlatformNotSupportedException(); }

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
  • byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)
@kunalspathakkunalspathakApr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
@a74nha74nhApr 16, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) { throw new PlatformNotSupportedException(); }

 /// LoadVector : Unextended load

Expand Down

86 changes: 86 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -118,7 +118,93 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) => CreateTrueMaskUInt64(pattern);

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 ///
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 ///
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) => ConditionalSelect(mask, left, right);

 /// LoadVector : Unextended load

Expand Down

11 changes: 10 additions & 1 deletion
src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4149,7 +4149,16 @@ internal Arm64() { }
 public static System.Numerics.Vector<ushort> CreateTrueMaskUInt16([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }

 public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.
 public static System.Numerics.Vector<short> ConditionalSelect(System.Numerics.Vector<short> mask, System.Numerics.Vector<short> left, System.Numerics.Vector<short> right) { throw null; }
 public static System.Numerics.Vector<int> ConditionalSelect(System.Numerics.Vector<int> mask, System.Numerics.Vector<int> left, System.Numerics.Vector<int> right) { throw null; }
 public static System.Numerics.Vector<long> ConditionalSelect(System.Numerics.Vector<long> mask, System.Numerics.Vector<long> left, System.Numerics.Vector<long> right) { throw null; }
 public static System.Numerics.Vector<byte> ConditionalSelect(System.Numerics.Vector<byte> mask, System.Numerics.Vector<byte> left, System.Numerics.Vector<byte> right) { throw null; }
 public static System.Numerics.Vector<ushort> ConditionalSelect(System.Numerics.Vector<ushort> mask, System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right) { throw null; }
 public static System.Numerics.Vector<uint> ConditionalSelect(System.Numerics.Vector<uint> mask, System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right) { throw null; }
 public static System.Numerics.Vector<ulong> ConditionalSelect(System.Numerics.Vector<ulong> mask, System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right) { throw null; }
 public static System.Numerics.Vector<float> ConditionalSelect(System.Numerics.Vector<float> mask, System.Numerics.Vector<float> left, System.Numerics.Vector<float> right) { throw null; }
 public static System.Numerics.Vector<double> ConditionalSelect(System.Numerics.Vector<double> mask, System.Numerics.Vector<double> left, System.Numerics.Vector<double> right) { throw null; } 
 public static unsafe System.Numerics.Vector<sbyte> LoadVector(System.Numerics.Vector<sbyte> mask, sbyte* address) { throw null; }
 public static unsafe System.Numerics.Vector<short> LoadVector(System.Numerics.Vector<short> mask, short* address) { throw null; }
 public static unsafe System.Numerics.Vector<int> LoadVector(System.Numerics.Vector<int> mask, int* address) { throw null; }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Arm64/Sve: Implement ConditionalSelect API#100718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

kunalspathak
wants to merge
4
commits into

from

 Closed


Arm64/Sve: Implement ConditionalSelect API
#100718
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
20defbd

Add ConditionalSelect() APIs


kunalspathak Apr 4, 2024
c70367f

Handle ConditionalSelect in JIT


kunalspathak Apr 4, 2024
1896b21

Add test coverage


kunalspathak Apr 4, 2024
2e0d022

Update the test cases


kunalspathak Apr 6, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 14 additions & 6 deletions
src/coreclr/jit/hwintrinsiccodegenarm64.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -434,15 +434,23 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
 break;

 case 3:
 assert(isRMW);
 if (targetReg != op1Reg)
 if (isRMW)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);
 if (targetReg != op1Reg)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);

 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg, /* canSkip */ true);
 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg,
 /* canSkip */ true);
 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 }
 else
 {
 GetEmitter()->emitIns_R_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, op3Reg,
 opt, INS_SCALABLE_OPTS_UNPREDICATED);
Comment thread
kunalspathak marked this conversation as resolved.

 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 break;

 default:
Expand Down

3 changes: 2 additions & 1 deletion
src/coreclr/jit/hwintrinsiclistarm64sve.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,10 +38,11 @@ HARDWARE_INTRINSIC(Sve, LoadVector,
// ***************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
// Special intrinsics that are generated during importing or lowering

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConditionalSelect, -1, 3, true, {INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_MaskedOperation)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConvertMaskToVector, -1, 1, true, {INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_MaskedOperation)
HARDWARE_INTRINSIC(Sve, ConvertVectorToMask, -1, 2, true, {INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask|HW_Flag_LowMaskedOperation)

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)

#endif // FEATURE_HW_INTRINSIC

Expand Down

58 changes: 58 additions & 0 deletions
...ries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,65 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw new PlatformNotSupportedException(); }

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
  • byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)
@kunalspathakkunalspathakApr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
@a74nha74nhApr 16, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) { throw new PlatformNotSupportedException(); }

 /// LoadVector : Unextended load

Expand Down

86 changes: 86 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -118,7 +118,93 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) => CreateTrueMaskUInt64(pattern);

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 ///
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 ///
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) => ConditionalSelect(mask, left, right);

 /// LoadVector : Unextended load

Expand Down

11 changes: 10 additions & 1 deletion
src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4149,7 +4149,16 @@ internal Arm64() { }
 public static System.Numerics.Vector<ushort> CreateTrueMaskUInt16([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }

 public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.
 public static System.Numerics.Vector<short> ConditionalSelect(System.Numerics.Vector<short> mask, System.Numerics.Vector<short> left, System.Numerics.Vector<short> right) { throw null; }
 public static System.Numerics.Vector<int> ConditionalSelect(System.Numerics.Vector<int> mask, System.Numerics.Vector<int> left, System.Numerics.Vector<int> right) { throw null; }
 public static System.Numerics.Vector<long> ConditionalSelect(System.Numerics.Vector<long> mask, System.Numerics.Vector<long> left, System.Numerics.Vector<long> right) { throw null; }
 public static System.Numerics.Vector<byte> ConditionalSelect(System.Numerics.Vector<byte> mask, System.Numerics.Vector<byte> left, System.Numerics.Vector<byte> right) { throw null; }
 public static System.Numerics.Vector<ushort> ConditionalSelect(System.Numerics.Vector<ushort> mask, System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right) { throw null; }
 public static System.Numerics.Vector<uint> ConditionalSelect(System.Numerics.Vector<uint> mask, System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right) { throw null; }
 public static System.Numerics.Vector<ulong> ConditionalSelect(System.Numerics.Vector<ulong> mask, System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right) { throw null; }
 public static System.Numerics.Vector<float> ConditionalSelect(System.Numerics.Vector<float> mask, System.Numerics.Vector<float> left, System.Numerics.Vector<float> right) { throw null; }
 public static System.Numerics.Vector<double> ConditionalSelect(System.Numerics.Vector<double> mask, System.Numerics.Vector<double> left, System.Numerics.Vector<double> right) { throw null; } 
 public static unsafe System.Numerics.Vector<sbyte> LoadVector(System.Numerics.Vector<sbyte> mask, sbyte* address) { throw null; }
 public static unsafe System.Numerics.Vector<short> LoadVector(System.Numerics.Vector<short> mask, short* address) { throw null; }
 public static unsafe System.Numerics.Vector<int> LoadVector(System.Numerics.Vector<int> mask, int* address) { throw null; }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Arm64/Sve: Implement ConditionalSelect API#100718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

kunalspathak
wants to merge
4
commits into

from

 Closed


Arm64/Sve: Implement ConditionalSelect API
#100718
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
20defbd

Add ConditionalSelect() APIs


kunalspathak Apr 4, 2024
c70367f

Handle ConditionalSelect in JIT


kunalspathak Apr 4, 2024
1896b21

Add test coverage


kunalspathak Apr 4, 2024
2e0d022

Update the test cases


kunalspathak Apr 6, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 14 additions & 6 deletions
src/coreclr/jit/hwintrinsiccodegenarm64.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -434,15 +434,23 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
 break;

 case 3:
 assert(isRMW);
 if (targetReg != op1Reg)
 if (isRMW)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);
 if (targetReg != op1Reg)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);

 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg, /* canSkip */ true);
 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg,
 /* canSkip */ true);
 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 }
 else
 {
 GetEmitter()->emitIns_R_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, op3Reg,
 opt, INS_SCALABLE_OPTS_UNPREDICATED);
Comment thread
kunalspathak marked this conversation as resolved.

 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 break;

 default:
Expand Down

3 changes: 2 additions & 1 deletion
src/coreclr/jit/hwintrinsiclistarm64sve.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,10 +38,11 @@ HARDWARE_INTRINSIC(Sve, LoadVector,
// ***************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
// Special intrinsics that are generated during importing or lowering

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConditionalSelect, -1, 3, true, {INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_MaskedOperation)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConvertMaskToVector, -1, 1, true, {INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_MaskedOperation)
HARDWARE_INTRINSIC(Sve, ConvertVectorToMask, -1, 2, true, {INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask|HW_Flag_LowMaskedOperation)

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)

#endif // FEATURE_HW_INTRINSIC

Expand Down

58 changes: 58 additions & 0 deletions
...ries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,65 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw new PlatformNotSupportedException(); }

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
  • byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)
@kunalspathakkunalspathakApr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
@a74nha74nhApr 16, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) { throw new PlatformNotSupportedException(); }

 /// LoadVector : Unextended load

Expand Down

86 changes: 86 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -118,7 +118,93 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) => CreateTrueMaskUInt64(pattern);

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 ///
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 ///
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) => ConditionalSelect(mask, left, right);

 /// LoadVector : Unextended load

Expand Down

11 changes: 10 additions & 1 deletion
src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4149,7 +4149,16 @@ internal Arm64() { }
 public static System.Numerics.Vector<ushort> CreateTrueMaskUInt16([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }

 public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.
 public static System.Numerics.Vector<short> ConditionalSelect(System.Numerics.Vector<short> mask, System.Numerics.Vector<short> left, System.Numerics.Vector<short> right) { throw null; }
 public static System.Numerics.Vector<int> ConditionalSelect(System.Numerics.Vector<int> mask, System.Numerics.Vector<int> left, System.Numerics.Vector<int> right) { throw null; }
 public static System.Numerics.Vector<long> ConditionalSelect(System.Numerics.Vector<long> mask, System.Numerics.Vector<long> left, System.Numerics.Vector<long> right) { throw null; }
 public static System.Numerics.Vector<byte> ConditionalSelect(System.Numerics.Vector<byte> mask, System.Numerics.Vector<byte> left, System.Numerics.Vector<byte> right) { throw null; }
 public static System.Numerics.Vector<ushort> ConditionalSelect(System.Numerics.Vector<ushort> mask, System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right) { throw null; }
 public static System.Numerics.Vector<uint> ConditionalSelect(System.Numerics.Vector<uint> mask, System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right) { throw null; }
 public static System.Numerics.Vector<ulong> ConditionalSelect(System.Numerics.Vector<ulong> mask, System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right) { throw null; }
 public static System.Numerics.Vector<float> ConditionalSelect(System.Numerics.Vector<float> mask, System.Numerics.Vector<float> left, System.Numerics.Vector<float> right) { throw null; }
 public static System.Numerics.Vector<double> ConditionalSelect(System.Numerics.Vector<double> mask, System.Numerics.Vector<double> left, System.Numerics.Vector<double> right) { throw null; } 
 public static unsafe System.Numerics.Vector<sbyte> LoadVector(System.Numerics.Vector<sbyte> mask, sbyte* address) { throw null; }
 public static unsafe System.Numerics.Vector<short> LoadVector(System.Numerics.Vector<short> mask, short* address) { throw null; }
 public static unsafe System.Numerics.Vector<int> LoadVector(System.Numerics.Vector<int> mask, int* address) { throw null; }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Arm64/Sve: Implement ConditionalSelect API#100718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

kunalspathak
wants to merge
4
commits into

from

 Closed


Arm64/Sve: Implement ConditionalSelect API
#100718
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
20defbd

Add ConditionalSelect() APIs


kunalspathak Apr 4, 2024
c70367f

Handle ConditionalSelect in JIT


kunalspathak Apr 4, 2024
1896b21

Add test coverage


kunalspathak Apr 4, 2024
2e0d022

Update the test cases


kunalspathak Apr 6, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 14 additions & 6 deletions
src/coreclr/jit/hwintrinsiccodegenarm64.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -434,15 +434,23 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
 break;

 case 3:
 assert(isRMW);
 if (targetReg != op1Reg)
 if (isRMW)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);
 if (targetReg != op1Reg)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);

 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg, /* canSkip */ true);
 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg,
 /* canSkip */ true);
 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 }
 else
 {
 GetEmitter()->emitIns_R_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, op3Reg,
 opt, INS_SCALABLE_OPTS_UNPREDICATED);
Comment thread
kunalspathak marked this conversation as resolved.

 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 break;

 default:
Expand Down

3 changes: 2 additions & 1 deletion
src/coreclr/jit/hwintrinsiclistarm64sve.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,10 +38,11 @@ HARDWARE_INTRINSIC(Sve, LoadVector,
// ***************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
// Special intrinsics that are generated during importing or lowering

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConditionalSelect, -1, 3, true, {INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_MaskedOperation)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConvertMaskToVector, -1, 1, true, {INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_MaskedOperation)
HARDWARE_INTRINSIC(Sve, ConvertVectorToMask, -1, 2, true, {INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask|HW_Flag_LowMaskedOperation)

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)

#endif // FEATURE_HW_INTRINSIC

Expand Down

58 changes: 58 additions & 0 deletions
...ries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,65 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw new PlatformNotSupportedException(); }

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
  • byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)
@kunalspathakkunalspathakApr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
@a74nha74nhApr 16, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) { throw new PlatformNotSupportedException(); }

 /// LoadVector : Unextended load

Expand Down

86 changes: 86 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -118,7 +118,93 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) => CreateTrueMaskUInt64(pattern);

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 ///
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 ///
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) => ConditionalSelect(mask, left, right);

 /// LoadVector : Unextended load

Expand Down

11 changes: 10 additions & 1 deletion
src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4149,7 +4149,16 @@ internal Arm64() { }
 public static System.Numerics.Vector<ushort> CreateTrueMaskUInt16([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }

 public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.
 public static System.Numerics.Vector<short> ConditionalSelect(System.Numerics.Vector<short> mask, System.Numerics.Vector<short> left, System.Numerics.Vector<short> right) { throw null; }
 public static System.Numerics.Vector<int> ConditionalSelect(System.Numerics.Vector<int> mask, System.Numerics.Vector<int> left, System.Numerics.Vector<int> right) { throw null; }
 public static System.Numerics.Vector<long> ConditionalSelect(System.Numerics.Vector<long> mask, System.Numerics.Vector<long> left, System.Numerics.Vector<long> right) { throw null; }
 public static System.Numerics.Vector<byte> ConditionalSelect(System.Numerics.Vector<byte> mask, System.Numerics.Vector<byte> left, System.Numerics.Vector<byte> right) { throw null; }
 public static System.Numerics.Vector<ushort> ConditionalSelect(System.Numerics.Vector<ushort> mask, System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right) { throw null; }
 public static System.Numerics.Vector<uint> ConditionalSelect(System.Numerics.Vector<uint> mask, System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right) { throw null; }
 public static System.Numerics.Vector<ulong> ConditionalSelect(System.Numerics.Vector<ulong> mask, System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right) { throw null; }
 public static System.Numerics.Vector<float> ConditionalSelect(System.Numerics.Vector<float> mask, System.Numerics.Vector<float> left, System.Numerics.Vector<float> right) { throw null; }
 public static System.Numerics.Vector<double> ConditionalSelect(System.Numerics.Vector<double> mask, System.Numerics.Vector<double> left, System.Numerics.Vector<double> right) { throw null; } 
 public static unsafe System.Numerics.Vector<sbyte> LoadVector(System.Numerics.Vector<sbyte> mask, sbyte* address) { throw null; }
 public static unsafe System.Numerics.Vector<short> LoadVector(System.Numerics.Vector<short> mask, short* address) { throw null; }
 public static unsafe System.Numerics.Vector<int> LoadVector(System.Numerics.Vector<int> mask, int* address) { throw null; }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Arm64/Sve: Implement ConditionalSelect API#100718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

kunalspathak
wants to merge
4
commits into

from

 Closed


Arm64/Sve: Implement ConditionalSelect API
#100718
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
20defbd

Add ConditionalSelect() APIs


kunalspathak Apr 4, 2024
c70367f

Handle ConditionalSelect in JIT


kunalspathak Apr 4, 2024
1896b21

Add test coverage


kunalspathak Apr 4, 2024
2e0d022

Update the test cases


kunalspathak Apr 6, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 14 additions & 6 deletions
src/coreclr/jit/hwintrinsiccodegenarm64.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -434,15 +434,23 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
 break;

 case 3:
 assert(isRMW);
 if (targetReg != op1Reg)
 if (isRMW)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);
 if (targetReg != op1Reg)
 {
 assert(targetReg != op2Reg);
 assert(targetReg != op3Reg);

 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg, /* canSkip */ true);
 GetEmitter()->emitIns_Mov(INS_mov, emitTypeSize(node), targetReg, op1Reg,
 /* canSkip */ true);
 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 }
 else
 {
 GetEmitter()->emitIns_R_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, op3Reg,
 opt, INS_SCALABLE_OPTS_UNPREDICATED);
Comment thread
kunalspathak marked this conversation as resolved.

 }
 GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op2Reg, op3Reg, opt);
 break;

 default:
Expand Down

3 changes: 2 additions & 1 deletion
src/coreclr/jit/hwintrinsiclistarm64sve.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,10 +38,11 @@ HARDWARE_INTRINSIC(Sve, LoadVector,
// ***************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
// Special intrinsics that are generated during importing or lowering

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConditionalSelect, -1, 3, true, {INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel, INS_sve_sel}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_MaskedOperation)
Comment thread
kunalspathak marked this conversation as resolved.

HARDWARE_INTRINSIC(Sve, ConvertMaskToVector, -1, 1, true, {INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov, INS_sve_mov}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_MaskedOperation)
HARDWARE_INTRINSIC(Sve, ConvertVectorToMask, -1, 2, true, {INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne, INS_sve_cmpne}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask|HW_Flag_LowMaskedOperation)

HARDWARE_INTRINSIC(Sve, CreateTrueMaskAll, -1, -1, false, {INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue, INS_sve_ptrue}, HW_Category_Helper, HW_Flag_Scalable|HW_Flag_ReturnsPerElementMask)

#endif // FEATURE_HW_INTRINSIC

Expand Down

58 changes: 58 additions & 0 deletions
...ries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,65 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw new PlatformNotSupportedException(); }

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's preferred to order these "alphabetically" as well, since that's what tooling will do in various places.
This is done based on the type name, not the language keyword:
  • byte (Byte), double (Double), short (Int16), int (Int32), long (Int64), nint (IntPtr), sbyte (SByte), float (Single), ushort (UInt16), uint (UInt32), ulong (UInt64), nuint (UIntPtr)
@kunalspathakkunalspathakApr 9, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
@a74nha74nhApr 16, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a74nh - do you mind fixing the tool to generate these alphabetically?
Done. The branch with the autogenerated files should now be in order for all the .cs files.
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) { throw new PlatformNotSupportedException(); }

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) { throw new PlatformNotSupportedException(); }

 /// LoadVector : Unextended load

Expand Down

86 changes: 86 additions & 0 deletions
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -118,7 +118,93 @@ internal Arm64() { }
 /// </summary>
 public static unsafe Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) => CreateTrueMaskUInt64(pattern);

 /// ConditionalSelect : Conditionally select elements

 /// <summary>
 /// svint8_t svsel[_s8](svbool_t pg, svint8_t op1, svint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<sbyte> ConditionalSelect(Vector<sbyte> mask, Vector<sbyte> left, Vector<sbyte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint16_t svsel[_s16](svbool_t pg, svint16_t op1, svint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<short> ConditionalSelect(Vector<short> mask, Vector<short> left, Vector<short> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint32_t svsel[_s32](svbool_t pg, svint32_t op1, svint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<int> ConditionalSelect(Vector<int> mask, Vector<int> left, Vector<int> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svint64_t svsel[_s64](svbool_t pg, svint64_t op1, svint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<long> ConditionalSelect(Vector<long> mask, Vector<long> left, Vector<long> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint8_t svsel[_u8](svbool_t pg, svuint8_t op1, svuint8_t op2)
 /// SEL Zresult.B, Pg, Zop1.B, Zop2.B
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<byte> ConditionalSelect(Vector<byte> mask, Vector<byte> left, Vector<byte> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint16_t svsel[_u16](svbool_t pg, svuint16_t op1, svuint16_t op2)
 /// SEL Zresult.H, Pg, Zop1.H, Zop2.H
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ushort> ConditionalSelect(Vector<ushort> mask, Vector<ushort> left, Vector<ushort> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint32_t svsel[_u32](svbool_t pg, svuint32_t op1, svuint32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<uint> ConditionalSelect(Vector<uint> mask, Vector<uint> left, Vector<uint> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svuint64_t svsel[_u64](svbool_t pg, svuint64_t op1, svuint64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 /// svbool_t svsel[_b](svbool_t pg, svbool_t op1, svbool_t op2)
 /// SEL Presult.B, Pg, Pop1.B, Pop2.B
 ///
 /// </summary>
 public static unsafe Vector<ulong> ConditionalSelect(Vector<ulong> mask, Vector<ulong> left, Vector<ulong> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat32_t svsel[_f32](svbool_t pg, svfloat32_t op1, svfloat32_t op2)
 /// SEL Zresult.S, Pg, Zop1.S, Zop2.S
 ///
 /// </summary>
 public static unsafe Vector<float> ConditionalSelect(Vector<float> mask, Vector<float> left, Vector<float> right) => ConditionalSelect(mask, left, right);

 /// <summary>
 /// svfloat64_t svsel[_f64](svbool_t pg, svfloat64_t op1, svfloat64_t op2)
 /// SEL Zresult.D, Pg, Zop1.D, Zop2.D
 ///
 /// </summary>
 public static unsafe Vector<double> ConditionalSelect(Vector<double> mask, Vector<double> left, Vector<double> right) => ConditionalSelect(mask, left, right);

 /// LoadVector : Unextended load

Expand Down

11 changes: 10 additions & 1 deletion
src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4149,7 +4149,16 @@ internal Arm64() { }
 public static System.Numerics.Vector<ushort> CreateTrueMaskUInt16([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<uint> CreateTrueMaskUInt32([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }
 public static System.Numerics.Vector<ulong> CreateTrueMaskUInt64([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) { throw null; }

 public static System.Numerics.Vector<sbyte> ConditionalSelect(System.Numerics.Vector<sbyte> mask, System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right) { throw null; }
@tannergoodingtannergoodingApr 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ever generated by the tooling, it's going to change all this to be done alphabetically, hence the comment above.
 public static System.Numerics.Vector<short> ConditionalSelect(System.Numerics.Vector<short> mask, System.Numerics.Vector<short> left, System.Numerics.Vector<short> right) { throw null; }
 public static System.Numerics.Vector<int> ConditionalSelect(System.Numerics.Vector<int> mask, System.Numerics.Vector<int> left, System.Numerics.Vector<int> right) { throw null; }
 public static System.Numerics.Vector<long> ConditionalSelect(System.Numerics.Vector<long> mask, System.Numerics.Vector<long> left, System.Numerics.Vector<long> right) { throw null; }
 public static System.Numerics.Vector<byte> ConditionalSelect(System.Numerics.Vector<byte> mask, System.Numerics.Vector<byte> left, System.Numerics.Vector<byte> right) { throw null; }
 public static System.Numerics.Vector<ushort> ConditionalSelect(System.Numerics.Vector<ushort> mask, System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right) { throw null; }
 public static System.Numerics.Vector<uint> ConditionalSelect(System.Numerics.Vector<uint> mask, System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right) { throw null; }
 public static System.Numerics.Vector<ulong> ConditionalSelect(System.Numerics.Vector<ulong> mask, System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right) { throw null; }
 public static System.Numerics.Vector<float> ConditionalSelect(System.Numerics.Vector<float> mask, System.Numerics.Vector<float> left, System.Numerics.Vector<float> right) { throw null; }
 public static System.Numerics.Vector<double> ConditionalSelect(System.Numerics.Vector<double> mask, System.Numerics.Vector<double> left, System.Numerics.Vector<double> right) { throw null; } 
 public static unsafe System.Numerics.Vector<sbyte> LoadVector(System.Numerics.Vector<sbyte> mask, sbyte* address) { throw null; }
 public static unsafe System.Numerics.Vector<short> LoadVector(System.Numerics.Vector<short> mask, short* address) { throw null; }
 public static unsafe System.Numerics.Vector<int> LoadVector(System.Numerics.Vector<int> mask, int* address) { throw null; }
Expand Down
Loading