[release/8.0-staging] Transition to 1ES templates work (Backport crossgen2 changes) by eduardo-vp · Pull Request #101869 · dotnet/runtime

…n the crossgen2 that we are shipping (dotnet#92677)

ghost · 2024-05-04T02:06:17Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-04T02:10:15Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

eduardo-vp · 2024-05-04T02:22:10Z

Official build (f834323): https://dev.azure.com/dnceng/internal/_build/results?buildId=2444879&view=results

…e packs for all possible targets. Use the local targeting and runtime packs explicitly to make sure we're publishing crossgen2 with the local build. Extracted from dotnet#92826

eduardo-vp · 2024-05-06T19:26:45Z

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

agocke · 2024-05-09T17:05:10Z

Could you elaborate a bit on what's required here? It's not clear to me why we need crossgen2 changes.

jkoritzinsky · 2024-05-09T17:18:28Z

The crossgen2 changes are needed to avoid the build/restore for publishing crossgen2 while also building it in the repo related to finding host artifacts correctly (there's conflicts around finding hosting artifacts when NativeAOT is supported).

The test official build for backporting #92901 exposed these issues, and @eduardo-vp and I feel that backporting the criossgen2 changes will fix those problems.

agocke · 2024-05-09T17:34:21Z

Makes sense. I will review to try to ensure that all the pieces we've changed are backported.

eduardo-vp · 2024-05-09T19:42:21Z

I just checked that the issues exposed in the test official build @jkoritzinsky mentioned are effectively solved by applying these commits (Official build before https://dev.azure.com/dnceng/internal/_build/results?buildId=2445418&view=results and after https://dev.azure.com/dnceng/internal/_build/results?buildId=2448441&view=results)

agocke

LGTM

jeffschwMSFT

lgtm. let's consider this tell mode. please merge when ready

eduardo-vp · 2024-05-04T02:05:47Z

This is part of the work to transition to the 1ES templates in servicing branches.

These crossgen2 changes are required to eventually backport #92901.

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

…n the crossgen2 that we are shipping (dotnet#92677)

ghost · 2024-05-04T02:06:17Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-04T02:10:15Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

eduardo-vp · 2024-05-04T02:22:10Z

Official build (f834323): https://dev.azure.com/dnceng/internal/_build/results?buildId=2444879&view=results

…e packs for all possible targets. Use the local targeting and runtime packs explicitly to make sure we're publishing crossgen2 with the local build. Extracted from dotnet#92826

eduardo-vp · 2024-05-06T19:26:45Z

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

agocke · 2024-05-09T17:05:10Z

Could you elaborate a bit on what's required here? It's not clear to me why we need crossgen2 changes.

jkoritzinsky · 2024-05-09T17:18:28Z

The crossgen2 changes are needed to avoid the build/restore for publishing crossgen2 while also building it in the repo related to finding host artifacts correctly (there's conflicts around finding hosting artifacts when NativeAOT is supported).

The test official build for backporting #92901 exposed these issues, and @eduardo-vp and I feel that backporting the criossgen2 changes will fix those problems.

agocke · 2024-05-09T17:34:21Z

Makes sense. I will review to try to ensure that all the pieces we've changed are backported.

eduardo-vp · 2024-05-09T19:42:21Z

I just checked that the issues exposed in the test official build @jkoritzinsky mentioned are effectively solved by applying these commits (Official build before https://dev.azure.com/dnceng/internal/_build/results?buildId=2445418&view=results and after https://dev.azure.com/dnceng/internal/_build/results?buildId=2448441&view=results)

agocke

LGTM

jeffschwMSFT

lgtm. let's consider this tell mode. please merge when ready

eduardo-vp · 2024-05-04T02:05:47Z

This is part of the work to transition to the 1ES templates in servicing branches.

These crossgen2 changes are required to eventually backport #92901.

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

…n the crossgen2 that we are shipping (dotnet#92677)

ghost · 2024-05-04T02:06:17Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-04T02:10:15Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

eduardo-vp · 2024-05-04T02:22:10Z

Official build (f834323): https://dev.azure.com/dnceng/internal/_build/results?buildId=2444879&view=results

…e packs for all possible targets. Use the local targeting and runtime packs explicitly to make sure we're publishing crossgen2 with the local build. Extracted from dotnet#92826

eduardo-vp · 2024-05-06T19:26:45Z

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

agocke · 2024-05-09T17:05:10Z

Could you elaborate a bit on what's required here? It's not clear to me why we need crossgen2 changes.

jkoritzinsky · 2024-05-09T17:18:28Z

The crossgen2 changes are needed to avoid the build/restore for publishing crossgen2 while also building it in the repo related to finding host artifacts correctly (there's conflicts around finding hosting artifacts when NativeAOT is supported).

The test official build for backporting #92901 exposed these issues, and @eduardo-vp and I feel that backporting the criossgen2 changes will fix those problems.

agocke · 2024-05-09T17:34:21Z

Makes sense. I will review to try to ensure that all the pieces we've changed are backported.

eduardo-vp · 2024-05-09T19:42:21Z

I just checked that the issues exposed in the test official build @jkoritzinsky mentioned are effectively solved by applying these commits (Official build before https://dev.azure.com/dnceng/internal/_build/results?buildId=2445418&view=results and after https://dev.azure.com/dnceng/internal/_build/results?buildId=2448441&view=results)

agocke

LGTM

jeffschwMSFT

lgtm. let's consider this tell mode. please merge when ready

eduardo-vp · 2024-05-04T02:05:47Z

This is part of the work to transition to the 1ES templates in servicing branches.

These crossgen2 changes are required to eventually backport #92901.

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

…n the crossgen2 that we are shipping (dotnet#92677)

ghost · 2024-05-04T02:06:17Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-04T02:10:15Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

eduardo-vp · 2024-05-04T02:22:10Z

Official build (f834323): https://dev.azure.com/dnceng/internal/_build/results?buildId=2444879&view=results

…e packs for all possible targets. Use the local targeting and runtime packs explicitly to make sure we're publishing crossgen2 with the local build. Extracted from dotnet#92826

eduardo-vp · 2024-05-06T19:26:45Z

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

agocke · 2024-05-09T17:05:10Z

Could you elaborate a bit on what's required here? It's not clear to me why we need crossgen2 changes.

jkoritzinsky · 2024-05-09T17:18:28Z

The crossgen2 changes are needed to avoid the build/restore for publishing crossgen2 while also building it in the repo related to finding host artifacts correctly (there's conflicts around finding hosting artifacts when NativeAOT is supported).

The test official build for backporting #92901 exposed these issues, and @eduardo-vp and I feel that backporting the criossgen2 changes will fix those problems.

agocke · 2024-05-09T17:34:21Z

Makes sense. I will review to try to ensure that all the pieces we've changed are backported.

eduardo-vp · 2024-05-09T19:42:21Z

I just checked that the issues exposed in the test official build @jkoritzinsky mentioned are effectively solved by applying these commits (Official build before https://dev.azure.com/dnceng/internal/_build/results?buildId=2445418&view=results and after https://dev.azure.com/dnceng/internal/_build/results?buildId=2448441&view=results)

agocke

LGTM

jeffschwMSFT

lgtm. let's consider this tell mode. please merge when ready

eduardo-vp · 2024-05-04T02:05:47Z

This is part of the work to transition to the 1ES templates in servicing branches.

These crossgen2 changes are required to eventually backport #92901.

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

…n the crossgen2 that we are shipping (dotnet#92677)

ghost · 2024-05-04T02:06:17Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-04T02:10:15Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

eduardo-vp · 2024-05-04T02:22:10Z

Official build (f834323): https://dev.azure.com/dnceng/internal/_build/results?buildId=2444879&view=results

…e packs for all possible targets. Use the local targeting and runtime packs explicitly to make sure we're publishing crossgen2 with the local build. Extracted from dotnet#92826

eduardo-vp · 2024-05-06T19:26:45Z

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

agocke · 2024-05-09T17:05:10Z

Could you elaborate a bit on what's required here? It's not clear to me why we need crossgen2 changes.

jkoritzinsky · 2024-05-09T17:18:28Z

The crossgen2 changes are needed to avoid the build/restore for publishing crossgen2 while also building it in the repo related to finding host artifacts correctly (there's conflicts around finding hosting artifacts when NativeAOT is supported).

The test official build for backporting #92901 exposed these issues, and @eduardo-vp and I feel that backporting the criossgen2 changes will fix those problems.

agocke · 2024-05-09T17:34:21Z

Makes sense. I will review to try to ensure that all the pieces we've changed are backported.

eduardo-vp · 2024-05-09T19:42:21Z

I just checked that the issues exposed in the test official build @jkoritzinsky mentioned are effectively solved by applying these commits (Official build before https://dev.azure.com/dnceng/internal/_build/results?buildId=2445418&view=results and after https://dev.azure.com/dnceng/internal/_build/results?buildId=2448441&view=results)

agocke

LGTM

jeffschwMSFT

lgtm. let's consider this tell mode. please merge when ready

eduardo-vp · 2024-05-04T02:05:47Z

This is part of the work to transition to the 1ES templates in servicing branches.

These crossgen2 changes are required to eventually backport #92901.

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

…n the crossgen2 that we are shipping (dotnet#92677)

ghost · 2024-05-04T02:06:17Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-04T02:10:15Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

eduardo-vp · 2024-05-04T02:22:10Z

Official build (f834323): https://dev.azure.com/dnceng/internal/_build/results?buildId=2444879&view=results

…e packs for all possible targets. Use the local targeting and runtime packs explicitly to make sure we're publishing crossgen2 with the local build. Extracted from dotnet#92826

eduardo-vp · 2024-05-06T19:26:45Z

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

agocke · 2024-05-09T17:05:10Z

Could you elaborate a bit on what's required here? It's not clear to me why we need crossgen2 changes.

jkoritzinsky · 2024-05-09T17:18:28Z

The crossgen2 changes are needed to avoid the build/restore for publishing crossgen2 while also building it in the repo related to finding host artifacts correctly (there's conflicts around finding hosting artifacts when NativeAOT is supported).

The test official build for backporting #92901 exposed these issues, and @eduardo-vp and I feel that backporting the criossgen2 changes will fix those problems.

agocke · 2024-05-09T17:34:21Z

Makes sense. I will review to try to ensure that all the pieces we've changed are backported.

eduardo-vp · 2024-05-09T19:42:21Z

I just checked that the issues exposed in the test official build @jkoritzinsky mentioned are effectively solved by applying these commits (Official build before https://dev.azure.com/dnceng/internal/_build/results?buildId=2445418&view=results and after https://dev.azure.com/dnceng/internal/_build/results?buildId=2448441&view=results)

agocke

LGTM

jeffschwMSFT

lgtm. let's consider this tell mode. please merge when ready

eduardo-vp · 2024-05-04T02:05:47Z

This is part of the work to transition to the 1ES templates in servicing branches.

These crossgen2 changes are required to eventually backport #92901.

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

…n the crossgen2 that we are shipping (dotnet#92677)

ghost · 2024-05-04T02:06:17Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-04T02:10:15Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

eduardo-vp · 2024-05-04T02:22:10Z

Official build (f834323): https://dev.azure.com/dnceng/internal/_build/results?buildId=2444879&view=results

…e packs for all possible targets. Use the local targeting and runtime packs explicitly to make sure we're publishing crossgen2 with the local build. Extracted from dotnet#92826

eduardo-vp · 2024-05-06T19:26:45Z

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

agocke · 2024-05-09T17:05:10Z

Could you elaborate a bit on what's required here? It's not clear to me why we need crossgen2 changes.

jkoritzinsky · 2024-05-09T17:18:28Z

The crossgen2 changes are needed to avoid the build/restore for publishing crossgen2 while also building it in the repo related to finding host artifacts correctly (there's conflicts around finding hosting artifacts when NativeAOT is supported).

The test official build for backporting #92901 exposed these issues, and @eduardo-vp and I feel that backporting the criossgen2 changes will fix those problems.

agocke · 2024-05-09T17:34:21Z

Makes sense. I will review to try to ensure that all the pieces we've changed are backported.

eduardo-vp · 2024-05-09T19:42:21Z

I just checked that the issues exposed in the test official build @jkoritzinsky mentioned are effectively solved by applying these commits (Official build before https://dev.azure.com/dnceng/internal/_build/results?buildId=2445418&view=results and after https://dev.azure.com/dnceng/internal/_build/results?buildId=2448441&view=results)

agocke

LGTM

jeffschwMSFT

lgtm. let's consider this tell mode. please merge when ready

eduardo-vp · 2024-05-04T02:05:47Z

This is part of the work to transition to the 1ES templates in servicing branches.

These crossgen2 changes are required to eventually backport #92901.

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

…n the crossgen2 that we are shipping (dotnet#92677)

ghost · 2024-05-04T02:06:17Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-04T02:10:15Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

eduardo-vp · 2024-05-04T02:22:10Z

Official build (f834323): https://dev.azure.com/dnceng/internal/_build/results?buildId=2444879&view=results

…e packs for all possible targets. Use the local targeting and runtime packs explicitly to make sure we're publishing crossgen2 with the local build. Extracted from dotnet#92826

eduardo-vp · 2024-05-06T19:26:45Z

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

agocke · 2024-05-09T17:05:10Z

Could you elaborate a bit on what's required here? It's not clear to me why we need crossgen2 changes.

jkoritzinsky · 2024-05-09T17:18:28Z

The crossgen2 changes are needed to avoid the build/restore for publishing crossgen2 while also building it in the repo related to finding host artifacts correctly (there's conflicts around finding hosting artifacts when NativeAOT is supported).

The test official build for backporting #92901 exposed these issues, and @eduardo-vp and I feel that backporting the criossgen2 changes will fix those problems.

agocke · 2024-05-09T17:34:21Z

Makes sense. I will review to try to ensure that all the pieces we've changed are backported.

eduardo-vp · 2024-05-09T19:42:21Z

I just checked that the issues exposed in the test official build @jkoritzinsky mentioned are effectively solved by applying these commits (Official build before https://dev.azure.com/dnceng/internal/_build/results?buildId=2445418&view=results and after https://dev.azure.com/dnceng/internal/_build/results?buildId=2448441&view=results)

agocke

LGTM

jeffschwMSFT

lgtm. let's consider this tell mode. please merge when ready