Skip to content

Enable repackaging of NETStandard 2.1 Targeting Pack - #102081

Merged
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom
NikolaMilosavljevic:net.21
May 16, 2024
Merged

Enable repackaging of NETStandard 2.1 Targeting Pack#102081
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom
NikolaMilosavljevic:net.21

Conversation

@NikolaMilosavljevic

@NikolaMilosavljevicNikolaMilosavljevic commented May 10, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #99610

This PR has the same changes as #101518, with the additional small change, to fix the issue with official CI. Original PR was reverted. This is now targeting 8.0.7 release. Validation build was successful: https://dev.azure.com/dnceng/internal/_build/results?buildId=2447965&view=results

Current NETStandard 2.1 targeting pack package does not support installation on FIPS-enabled systems. Original repo and branch (core-setup, release/3.1) have been deprecated and cannot be used for building this package anymore.

The solution is to repackage it. Extraction is done using rpm2cpio <original-package> | cpio -idmv which preserves original content and file modification time. Packaging is done with FPM, using regular tooling for RPM package creation. This tooling supports FIPS, by enabling sha256 package digest.

There are some small differences in metadata - description and packager fields, as well as copyright. Details are available in the appropriate sections.

Naming and versioning

Old package name was netstandard-targeting-pack-2.1.0-x64.rpm as it did not get renamed during publishing to PMC. New packages will get renamed to follow common naming schema. New package name will be: netstandard-targeting-pack-2.1-8.0.6-1.x86_64.rpm

Copyright differences

There is a minor difference in the comment section of the copyright file that ships with this package. It is picked up from new packaging infra. I've attached old and new copyright files, for review. I've outlined the differences.

Old copyrightNew copyright
CommentLicensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information.Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.

Package metadata differences

Version difference is intentional as a result of building in 8.0 servicing branch. This can likely be tweaked if needed, but it is a correct model as this is how distros version the same package, in their servicing releases.

Packager and Description values are coming from new package infra - shared with all packages produced in 8.0 release. This can likely be tweaked if needed. I've outlined the differences.

Old packageNew package
Version2.1.08.0.6
Release11
Packager.NET Core Team dotnetpackages@dotnetfoundation.org.NET Team dotnetpackages@dotnetfoundation.org
Description.NET Core is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs..NET is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs.

I've attached the full metadata content as files, for review.

Testing

  • Verified installation on FIPS-enabled system.
  • Verified package upgrade.
  • Verified that applications targeting NETStandard 2.1 can build against new package content.

metadata.new.txt
metadata.original.txt
copyright.new.txt
copyright.original.txt

@NikolaMilosavljevicNikolaMilosavljevic added Servicing-approved Approved for servicing release area-Setup labels May 10, 2024
@NikolaMilosavljevicNikolaMilosavljevic mentioned this pull request May 10, 2024
Closed
This was referenced May 10, 2024
Closed
Closed
carlossanlop
carlossanlop approved these changes May 16, 2024
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).

@NikolaMilosavljevic

NikolaMilosavljevic commented May 16, 2024

Copy link
Copy Markdown
ContributorAuthor

CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).

Thanks. Yes, I have verified this with a full internal pipeline run.

@NikolaMilosavljevic
NikolaMilosavljevic merged commit 0abb510 into dotnet:release/8.0-stagingMay 16, 2024
@NikolaMilosavljevicNikolaMilosavljevic mentioned this pull request May 21, 2024
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
@leecowleecowAwaiting requested review from leecow
@ViktorHoferViktorHoferAwaiting requested review from ViktorHofer
@MichaelSimonsMichaelSimonsAwaiting requested review from MichaelSimons
1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@NikolaMilosavljevicNikolaMilosavljevic

Labels

area-SetupServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NikolaMilosavljevic@carlossanlop
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Enable repackaging of NETStandard 2.1 Targeting Pack by NikolaMilosavljevic · Pull Request #102081 · dotnet/runtime · GitHub
Skip to content
Enable repackaging of NETStandard 2.1 Targeting Pack - #102081
Merged
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
May 16, 2024
Merged
Enable repackaging of NETStandard 2.1 Targeting Pack#102081
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
Conversation
@NikolaMilosavljevic
@NikolaMilosavljevicNikolaMilosavljevic
commented
May 10, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #99610
This PR has the same changes as #101518, with the additional small change, to fix the issue with official CI. Original PR was reverted. This is now targeting 8.0.7 release. Validation build was successful: https://dev.azure.com/dnceng/internal/_build/results?buildId=2447965&view=results
Current NETStandard 2.1 targeting pack package does not support installation on FIPS-enabled systems. Original repo and branch (core-setup, release/3.1) have been deprecated and cannot be used for building this package anymore.
The solution is to repackage it. Extraction is done using rpm2cpio <original-package> | cpio -idmv which preserves original content and file modification time. Packaging is done with FPM, using regular tooling for RPM package creation. This tooling supports FIPS, by enabling sha256 package digest.
There are some small differences in metadata - description and packager fields, as well as copyright. Details are available in the appropriate sections.
Naming and versioning
Old package name was netstandard-targeting-pack-2.1.0-x64.rpm as it did not get renamed during publishing to PMC. New packages will get renamed to follow common naming schema. New package name will be: netstandard-targeting-pack-2.1-8.0.6-1.x86_64.rpm
Copyright differences
There is a minor difference in the comment section of the copyright file that ships with this package. It is picked up from new packaging infra. I've attached old and new copyright files, for review. I've outlined the differences.
Old copyrightNew copyright
CommentLicensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information.Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.
Package metadata differences
Version difference is intentional as a result of building in 8.0 servicing branch. This can likely be tweaked if needed, but it is a correct model as this is how distros version the same package, in their servicing releases.
Packager and Description values are coming from new package infra - shared with all packages produced in 8.0 release. This can likely be tweaked if needed. I've outlined the differences.
Old packageNew package
Version2.1.08.0.6
Release11
Packager.NET Core Team dotnetpackages@dotnetfoundation.org.NET Team dotnetpackages@dotnetfoundation.org
Description.NET Core is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs..NET is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs.
I've attached the full metadata content as files, for review.
Testing
  • Verified installation on FIPS-enabled system.
  • Verified package upgrade.
  • Verified that applications targeting NETStandard 2.1 can build against new package content.
metadata.new.txt
metadata.original.txt
copyright.new.txt
copyright.original.txt
@NikolaMilosavljevicNikolaMilosavljevic
added

Servicing-approved
Approved for servicing release
area-Setup

labels
May 10, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 10, 2024

Closed


This was referenced May 10, 2024

Closed


Closed

carlossanlop
carlossanlop
approved these changes
May 16, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
@NikolaMilosavljevic
NikolaMilosavljevic
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
Thanks. Yes, I have verified this with a full internal pipeline run.
@NikolaMilosavljevic
NikolaMilosavljevic
merged commit 0abb510
into
dotnet:release/8.0-stagingMay 16, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 21, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
@leecowleecowAwaiting requested review from leecow
@ViktorHoferViktorHoferAwaiting requested review from ViktorHofer
@MichaelSimonsMichaelSimonsAwaiting requested review from MichaelSimons

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@NikolaMilosavljevicNikolaMilosavljevic

Labels

area-SetupServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@NikolaMilosavljevic@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable repackaging of NETStandard 2.1 Targeting Pack by NikolaMilosavljevic · Pull Request #102081 · dotnet/runtime · GitHub
Skip to content
Enable repackaging of NETStandard 2.1 Targeting Pack - #102081
Merged
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
May 16, 2024
Merged
Enable repackaging of NETStandard 2.1 Targeting Pack#102081
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
Conversation
@NikolaMilosavljevic
@NikolaMilosavljevicNikolaMilosavljevic
commented
May 10, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #99610
This PR has the same changes as #101518, with the additional small change, to fix the issue with official CI. Original PR was reverted. This is now targeting 8.0.7 release. Validation build was successful: https://dev.azure.com/dnceng/internal/_build/results?buildId=2447965&view=results
Current NETStandard 2.1 targeting pack package does not support installation on FIPS-enabled systems. Original repo and branch (core-setup, release/3.1) have been deprecated and cannot be used for building this package anymore.
The solution is to repackage it. Extraction is done using rpm2cpio <original-package> | cpio -idmv which preserves original content and file modification time. Packaging is done with FPM, using regular tooling for RPM package creation. This tooling supports FIPS, by enabling sha256 package digest.
There are some small differences in metadata - description and packager fields, as well as copyright. Details are available in the appropriate sections.
Naming and versioning
Old package name was netstandard-targeting-pack-2.1.0-x64.rpm as it did not get renamed during publishing to PMC. New packages will get renamed to follow common naming schema. New package name will be: netstandard-targeting-pack-2.1-8.0.6-1.x86_64.rpm
Copyright differences
There is a minor difference in the comment section of the copyright file that ships with this package. It is picked up from new packaging infra. I've attached old and new copyright files, for review. I've outlined the differences.
Old copyrightNew copyright
CommentLicensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information.Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.
Package metadata differences
Version difference is intentional as a result of building in 8.0 servicing branch. This can likely be tweaked if needed, but it is a correct model as this is how distros version the same package, in their servicing releases.
Packager and Description values are coming from new package infra - shared with all packages produced in 8.0 release. This can likely be tweaked if needed. I've outlined the differences.
Old packageNew package
Version2.1.08.0.6
Release11
Packager.NET Core Team dotnetpackages@dotnetfoundation.org.NET Team dotnetpackages@dotnetfoundation.org
Description.NET Core is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs..NET is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs.
I've attached the full metadata content as files, for review.
Testing
  • Verified installation on FIPS-enabled system.
  • Verified package upgrade.
  • Verified that applications targeting NETStandard 2.1 can build against new package content.
metadata.new.txt
metadata.original.txt
copyright.new.txt
copyright.original.txt
@NikolaMilosavljevicNikolaMilosavljevic
added

Servicing-approved
Approved for servicing release
area-Setup

labels
May 10, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 10, 2024

Closed


This was referenced May 10, 2024

Closed


Closed

carlossanlop
carlossanlop
approved these changes
May 16, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
@NikolaMilosavljevic
NikolaMilosavljevic
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
Thanks. Yes, I have verified this with a full internal pipeline run.
@NikolaMilosavljevic
NikolaMilosavljevic
merged commit 0abb510
into
dotnet:release/8.0-stagingMay 16, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 21, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
@leecowleecowAwaiting requested review from leecow
@ViktorHoferViktorHoferAwaiting requested review from ViktorHofer
@MichaelSimonsMichaelSimonsAwaiting requested review from MichaelSimons

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@NikolaMilosavljevicNikolaMilosavljevic

Labels

area-SetupServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@NikolaMilosavljevic@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable repackaging of NETStandard 2.1 Targeting Pack by NikolaMilosavljevic · Pull Request #102081 · dotnet/runtime · GitHub
Skip to content
Enable repackaging of NETStandard 2.1 Targeting Pack - #102081
Merged
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
May 16, 2024
Merged
Enable repackaging of NETStandard 2.1 Targeting Pack#102081
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
Conversation
@NikolaMilosavljevic
@NikolaMilosavljevicNikolaMilosavljevic
commented
May 10, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #99610
This PR has the same changes as #101518, with the additional small change, to fix the issue with official CI. Original PR was reverted. This is now targeting 8.0.7 release. Validation build was successful: https://dev.azure.com/dnceng/internal/_build/results?buildId=2447965&view=results
Current NETStandard 2.1 targeting pack package does not support installation on FIPS-enabled systems. Original repo and branch (core-setup, release/3.1) have been deprecated and cannot be used for building this package anymore.
The solution is to repackage it. Extraction is done using rpm2cpio <original-package> | cpio -idmv which preserves original content and file modification time. Packaging is done with FPM, using regular tooling for RPM package creation. This tooling supports FIPS, by enabling sha256 package digest.
There are some small differences in metadata - description and packager fields, as well as copyright. Details are available in the appropriate sections.
Naming and versioning
Old package name was netstandard-targeting-pack-2.1.0-x64.rpm as it did not get renamed during publishing to PMC. New packages will get renamed to follow common naming schema. New package name will be: netstandard-targeting-pack-2.1-8.0.6-1.x86_64.rpm
Copyright differences
There is a minor difference in the comment section of the copyright file that ships with this package. It is picked up from new packaging infra. I've attached old and new copyright files, for review. I've outlined the differences.
Old copyrightNew copyright
CommentLicensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information.Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.
Package metadata differences
Version difference is intentional as a result of building in 8.0 servicing branch. This can likely be tweaked if needed, but it is a correct model as this is how distros version the same package, in their servicing releases.
Packager and Description values are coming from new package infra - shared with all packages produced in 8.0 release. This can likely be tweaked if needed. I've outlined the differences.
Old packageNew package
Version2.1.08.0.6
Release11
Packager.NET Core Team dotnetpackages@dotnetfoundation.org.NET Team dotnetpackages@dotnetfoundation.org
Description.NET Core is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs..NET is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs.
I've attached the full metadata content as files, for review.
Testing
  • Verified installation on FIPS-enabled system.
  • Verified package upgrade.
  • Verified that applications targeting NETStandard 2.1 can build against new package content.
metadata.new.txt
metadata.original.txt
copyright.new.txt
copyright.original.txt
@NikolaMilosavljevicNikolaMilosavljevic
added

Servicing-approved
Approved for servicing release
area-Setup

labels
May 10, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 10, 2024

Closed


This was referenced May 10, 2024

Closed


Closed

carlossanlop
carlossanlop
approved these changes
May 16, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
@NikolaMilosavljevic
NikolaMilosavljevic
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
Thanks. Yes, I have verified this with a full internal pipeline run.
@NikolaMilosavljevic
NikolaMilosavljevic
merged commit 0abb510
into
dotnet:release/8.0-stagingMay 16, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 21, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
@leecowleecowAwaiting requested review from leecow
@ViktorHoferViktorHoferAwaiting requested review from ViktorHofer
@MichaelSimonsMichaelSimonsAwaiting requested review from MichaelSimons

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@NikolaMilosavljevicNikolaMilosavljevic

Labels

area-SetupServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@NikolaMilosavljevic@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Enable repackaging of NETStandard 2.1 Targeting Pack by NikolaMilosavljevic · Pull Request #102081 · dotnet/runtime · GitHub
Skip to content
Enable repackaging of NETStandard 2.1 Targeting Pack - #102081
Merged
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
May 16, 2024
Merged
Enable repackaging of NETStandard 2.1 Targeting Pack#102081
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
Conversation
@NikolaMilosavljevic
@NikolaMilosavljevicNikolaMilosavljevic
commented
May 10, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #99610
This PR has the same changes as #101518, with the additional small change, to fix the issue with official CI. Original PR was reverted. This is now targeting 8.0.7 release. Validation build was successful: https://dev.azure.com/dnceng/internal/_build/results?buildId=2447965&view=results
Current NETStandard 2.1 targeting pack package does not support installation on FIPS-enabled systems. Original repo and branch (core-setup, release/3.1) have been deprecated and cannot be used for building this package anymore.
The solution is to repackage it. Extraction is done using rpm2cpio <original-package> | cpio -idmv which preserves original content and file modification time. Packaging is done with FPM, using regular tooling for RPM package creation. This tooling supports FIPS, by enabling sha256 package digest.
There are some small differences in metadata - description and packager fields, as well as copyright. Details are available in the appropriate sections.
Naming and versioning
Old package name was netstandard-targeting-pack-2.1.0-x64.rpm as it did not get renamed during publishing to PMC. New packages will get renamed to follow common naming schema. New package name will be: netstandard-targeting-pack-2.1-8.0.6-1.x86_64.rpm
Copyright differences
There is a minor difference in the comment section of the copyright file that ships with this package. It is picked up from new packaging infra. I've attached old and new copyright files, for review. I've outlined the differences.
Old copyrightNew copyright
CommentLicensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information.Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.
Package metadata differences
Version difference is intentional as a result of building in 8.0 servicing branch. This can likely be tweaked if needed, but it is a correct model as this is how distros version the same package, in their servicing releases.
Packager and Description values are coming from new package infra - shared with all packages produced in 8.0 release. This can likely be tweaked if needed. I've outlined the differences.
Old packageNew package
Version2.1.08.0.6
Release11
Packager.NET Core Team dotnetpackages@dotnetfoundation.org.NET Team dotnetpackages@dotnetfoundation.org
Description.NET Core is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs..NET is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs.
I've attached the full metadata content as files, for review.
Testing
  • Verified installation on FIPS-enabled system.
  • Verified package upgrade.
  • Verified that applications targeting NETStandard 2.1 can build against new package content.
metadata.new.txt
metadata.original.txt
copyright.new.txt
copyright.original.txt
@NikolaMilosavljevicNikolaMilosavljevic
added

Servicing-approved
Approved for servicing release
area-Setup

labels
May 10, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 10, 2024

Closed


This was referenced May 10, 2024

Closed


Closed

carlossanlop
carlossanlop
approved these changes
May 16, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
@NikolaMilosavljevic
NikolaMilosavljevic
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
Thanks. Yes, I have verified this with a full internal pipeline run.
@NikolaMilosavljevic
NikolaMilosavljevic
merged commit 0abb510
into
dotnet:release/8.0-stagingMay 16, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 21, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
@leecowleecowAwaiting requested review from leecow
@ViktorHoferViktorHoferAwaiting requested review from ViktorHofer
@MichaelSimonsMichaelSimonsAwaiting requested review from MichaelSimons

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@NikolaMilosavljevicNikolaMilosavljevic

Labels

area-SetupServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@NikolaMilosavljevic@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable repackaging of NETStandard 2.1 Targeting Pack by NikolaMilosavljevic · Pull Request #102081 · dotnet/runtime · GitHub
Skip to content
Enable repackaging of NETStandard 2.1 Targeting Pack - #102081
Merged
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
May 16, 2024
Merged
Enable repackaging of NETStandard 2.1 Targeting Pack#102081
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
Conversation
@NikolaMilosavljevic
@NikolaMilosavljevicNikolaMilosavljevic
commented
May 10, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #99610
This PR has the same changes as #101518, with the additional small change, to fix the issue with official CI. Original PR was reverted. This is now targeting 8.0.7 release. Validation build was successful: https://dev.azure.com/dnceng/internal/_build/results?buildId=2447965&view=results
Current NETStandard 2.1 targeting pack package does not support installation on FIPS-enabled systems. Original repo and branch (core-setup, release/3.1) have been deprecated and cannot be used for building this package anymore.
The solution is to repackage it. Extraction is done using rpm2cpio <original-package> | cpio -idmv which preserves original content and file modification time. Packaging is done with FPM, using regular tooling for RPM package creation. This tooling supports FIPS, by enabling sha256 package digest.
There are some small differences in metadata - description and packager fields, as well as copyright. Details are available in the appropriate sections.
Naming and versioning
Old package name was netstandard-targeting-pack-2.1.0-x64.rpm as it did not get renamed during publishing to PMC. New packages will get renamed to follow common naming schema. New package name will be: netstandard-targeting-pack-2.1-8.0.6-1.x86_64.rpm
Copyright differences
There is a minor difference in the comment section of the copyright file that ships with this package. It is picked up from new packaging infra. I've attached old and new copyright files, for review. I've outlined the differences.
Old copyrightNew copyright
CommentLicensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information.Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.
Package metadata differences
Version difference is intentional as a result of building in 8.0 servicing branch. This can likely be tweaked if needed, but it is a correct model as this is how distros version the same package, in their servicing releases.
Packager and Description values are coming from new package infra - shared with all packages produced in 8.0 release. This can likely be tweaked if needed. I've outlined the differences.
Old packageNew package
Version2.1.08.0.6
Release11
Packager.NET Core Team dotnetpackages@dotnetfoundation.org.NET Team dotnetpackages@dotnetfoundation.org
Description.NET Core is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs..NET is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs.
I've attached the full metadata content as files, for review.
Testing
  • Verified installation on FIPS-enabled system.
  • Verified package upgrade.
  • Verified that applications targeting NETStandard 2.1 can build against new package content.
metadata.new.txt
metadata.original.txt
copyright.new.txt
copyright.original.txt
@NikolaMilosavljevicNikolaMilosavljevic
added

Servicing-approved
Approved for servicing release
area-Setup

labels
May 10, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 10, 2024

Closed


This was referenced May 10, 2024

Closed


Closed

carlossanlop
carlossanlop
approved these changes
May 16, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
@NikolaMilosavljevic
NikolaMilosavljevic
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
Thanks. Yes, I have verified this with a full internal pipeline run.
@NikolaMilosavljevic
NikolaMilosavljevic
merged commit 0abb510
into
dotnet:release/8.0-stagingMay 16, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 21, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
@leecowleecowAwaiting requested review from leecow
@ViktorHoferViktorHoferAwaiting requested review from ViktorHofer
@MichaelSimonsMichaelSimonsAwaiting requested review from MichaelSimons

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@NikolaMilosavljevicNikolaMilosavljevic

Labels

area-SetupServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@NikolaMilosavljevic@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Enable repackaging of NETStandard 2.1 Targeting Pack by NikolaMilosavljevic · Pull Request #102081 · dotnet/runtime · GitHub
Skip to content
Enable repackaging of NETStandard 2.1 Targeting Pack - #102081
Merged
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
May 16, 2024
Merged
Enable repackaging of NETStandard 2.1 Targeting Pack#102081
NikolaMilosavljevic merged 5 commits into
dotnet:release/8.0-stagingfrom 
NikolaMilosavljevic:net.21
Conversation
@NikolaMilosavljevic
@NikolaMilosavljevicNikolaMilosavljevic
commented
May 10, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #99610
This PR has the same changes as #101518, with the additional small change, to fix the issue with official CI. Original PR was reverted. This is now targeting 8.0.7 release. Validation build was successful: https://dev.azure.com/dnceng/internal/_build/results?buildId=2447965&view=results
Current NETStandard 2.1 targeting pack package does not support installation on FIPS-enabled systems. Original repo and branch (core-setup, release/3.1) have been deprecated and cannot be used for building this package anymore.
The solution is to repackage it. Extraction is done using rpm2cpio <original-package> | cpio -idmv which preserves original content and file modification time. Packaging is done with FPM, using regular tooling for RPM package creation. This tooling supports FIPS, by enabling sha256 package digest.
There are some small differences in metadata - description and packager fields, as well as copyright. Details are available in the appropriate sections.
Naming and versioning
Old package name was netstandard-targeting-pack-2.1.0-x64.rpm as it did not get renamed during publishing to PMC. New packages will get renamed to follow common naming schema. New package name will be: netstandard-targeting-pack-2.1-8.0.6-1.x86_64.rpm
Copyright differences
There is a minor difference in the comment section of the copyright file that ships with this package. It is picked up from new packaging infra. I've attached old and new copyright files, for review. I've outlined the differences.
Old copyrightNew copyright
CommentLicensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information.Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.
Package metadata differences
Version difference is intentional as a result of building in 8.0 servicing branch. This can likely be tweaked if needed, but it is a correct model as this is how distros version the same package, in their servicing releases.
Packager and Description values are coming from new package infra - shared with all packages produced in 8.0 release. This can likely be tweaked if needed. I've outlined the differences.
Old packageNew package
Version2.1.08.0.6
Release11
Packager.NET Core Team dotnetpackages@dotnetfoundation.org.NET Team dotnetpackages@dotnetfoundation.org
Description.NET Core is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs..NET is a development platform that you can use to build command-line applications, microservices and modern websites. It is open source, cross-platform and is supported by Microsoft. We hope you enjoy using it! If you do, please consider joining the active community of developers that are contributing to the project on GitHub (https://github.com/dotnet/core). We happily accept issues and PRs.
I've attached the full metadata content as files, for review.
Testing
  • Verified installation on FIPS-enabled system.
  • Verified package upgrade.
  • Verified that applications targeting NETStandard 2.1 can build against new package content.
metadata.new.txt
metadata.original.txt
copyright.new.txt
copyright.original.txt
@NikolaMilosavljevicNikolaMilosavljevic
added

Servicing-approved
Approved for servicing release
area-Setup

labels
May 10, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 10, 2024

Closed


This was referenced May 10, 2024

Closed


Closed

carlossanlop
carlossanlop
approved these changes
May 16, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
@NikolaMilosavljevic
NikolaMilosavljevic
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
CI is green. If you're confident of this change, feel free to merge anytime (tell-mode).
Thanks. Yes, I have verified this with a full internal pipeline run.
@NikolaMilosavljevic
NikolaMilosavljevic
merged commit 0abb510
into
dotnet:release/8.0-stagingMay 16, 2024
@NikolaMilosavljevicNikolaMilosavljevic
mentioned this pull request
May 21, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
@leecowleecowAwaiting requested review from leecow
@ViktorHoferViktorHoferAwaiting requested review from ViktorHofer
@MichaelSimonsMichaelSimonsAwaiting requested review from MichaelSimons

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@NikolaMilosavljevicNikolaMilosavljevic

Labels

area-SetupServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@NikolaMilosavljevic@carlossanlop