Add SetEntryAssembly() API to System.Reflection - #102271

Merged
ivdiazsa merged 14 commits into
dotnet:mainfrom
ivdiazsa:managed-contract-facade
May 21, 2024
Merged

Add SetEntryAssembly() API to System.Reflection#102271
ivdiazsa merged 14 commits into
dotnet:mainfrom
ivdiazsa:managed-contract-facade

Conversation

@ivdiazsa

@ivdiazsaivdiazsa commented May 15, 2024

Copy link
Copy Markdown
Contributor

Implements the API proposal detailed and approved in issue #101616. This new API will allow developers to change the entry assembly of their .NET apps on the fly, should they require it. One important scenario is app launchers. With the usage of this API, then functions like GetEntryAssembly() will return the right value, and thus we will be able to ensure the information is consistent and correct.

@ivdiazsaivdiazsa added this to the 9.0.0 milestone May 15, 2024
@ghost

ghost commented May 15, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service

dotnet-policy-serviceBot commented May 15, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

kg
kg reviewed May 15, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml Outdated
jkotas
jkotas reviewed May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated
jkotas
jkotas reviewed May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated
jkotas
jkotas reviewed May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated
MichalStrehovsky
MichalStrehovsky reviewed May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated
@ivdiazsa
Merge branch 'main' into managed-contract-facade
3bea613
@ivdiazsa
Reverted the compatibility suppressions added by the build script.
7fc6c77
@ivdiazsa
Forgot to revert also the nativeaot part of the suppressions.
2caf450
@ivdiazsa
Addressed PR comments: Updated the tests to use the new
a2f86a5
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
jkotas
jkotas reviewed May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated
jkotas
jkotas reviewed May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
@jkotas

jkotas commented May 15, 2024•
edited
Loading

Copy link
Copy Markdown
Member

This needs some tests (

runtime/src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

Line 182 in 1ee61b8

}
is a good place to add them)

jkotas
jkotas reviewed May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
jkotas
jkotas reviewed May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs Outdated
@build-analysisbuild-analysisBot mentioned this pull request May 16, 2024
Closed
@ivdiazsa@jkotas
Update src/libraries/System.Private.CoreLib/src/System/Reflection/Ass…
d574dad
…embly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@ivdiazsa

ivdiazsa commented May 16, 2024

Copy link
Copy Markdown
ContributorAuthor

Seems I got an import wrong. Will look into it.

jkotas
jkotas reviewed May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated
jkotas
jkotas reviewed May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs Outdated
jkotas
jkotas reviewed May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs Outdated
jkotas
jkotas reviewed May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs Outdated
@ivdiazsa@jkotas
Apply Jan's suggestions
aac56b3
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas approved these changes May 17, 2024
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ivdiazsa

ivdiazsa commented May 17, 2024

Copy link
Copy Markdown
ContributorAuthor

I wonder where that trailing whitespace came from... Let me fix it so we can merge. Thanks a lot for your guidance with this @jkotas!

@ivdiazsa

ivdiazsa commented May 17, 2024

Copy link
Copy Markdown
ContributorAuthor

Might be just my ptsd of breaking the outerloop with a PR I did last year, so I'll kick off an outerloop run just to be safe we can merge this.

@ivdiazsa

ivdiazsa commented May 17, 2024

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented May 17, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 17, 2024
Open
Closed
This was referenced May 21, 2024
Closed
Closed
@ivdiazsa
ivdiazsa merged commit 362a95d into dotnet:mainMay 21, 2024
@jkotasjkotas mentioned this pull request May 29, 2024
Closed
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@ivdiazsa@jkotas@Ruihan-Yin
AddSetEntryAssembly()API toSystem.Reflection(dotnet#102271)
5442384
* Trying out JanK's approach to override the entry assembly...
* Fixed what was missing for this reflection scenario to work correctly.
* Reverted the compatibility suppressions added by the build script.
* Forgot to revert also the nativeaot part of the suppressions.
* Addressed PR comments: Updated the tests to use the new
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
* Added tests and addressed more comments on the PR.
* Added exception test case for SetEntryAssembly, and wrapped all its
test cases in a RemoteExecutor.Invoke() call, in order to avoid
potentially interferring with the GetEntryAssembly tests.
* Update src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Refactored further the tests that force a null entry assembly, and
fixed the issue with the remote executor.
* Apply Jan's suggestions
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Fixed a sneaky trailing whitespace that was messing up with the code analyzers.
* Changed ConditionalTheory to ConditionalFact in the tests because we're not passing parameters to it.
* Disabled building the CustomHostTests test file when .NET Framework
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@elinor-fungelinor-fung mentioned this pull request Jun 7, 2024
Closed
@jkotasjkotas mentioned this pull request Jun 14, 2024
Closed
@steveisoksteveisok mentioned this pull request Jun 19, 2024
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 21, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@jkotasjkotasjkotas approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lambdageeklambdageekAwaiting requested review from lambdageek
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono
+1 more reviewer
@kgkgkg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ivdiazsaivdiazsa

Labels

area-System.Reflectionnew-api-needs-documentation

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ivdiazsa@jkotas@kg@MichalStrehovsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add SetEntryAssembly() API to System.Reflection - #102271
Merged
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
May 21, 2024
Merged
Add SetEntryAssembly() API to System.Reflection#102271
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Implements the API proposal detailed and approved in issue #101616. This new API will allow developers to change the entry assembly of their .NET apps on the fly, should they require it. One important scenario is app launchers. With the usage of this API, then functions like GetEntryAssembly() will return the right value, and thus we will be able to ensure the information is consistent and correct.
@ivdiazsaivdiazsa
added this to the 9.0.0 milestone
May 15, 2024
@ghost
ghost
commented
May 15, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
kg
kg
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

MichalStrehovsky
MichalStrehovsky
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

@ivdiazsa
Merge branch 'main' into managed-contract-facade
3bea613
@ivdiazsa
Reverted the compatibility suppressions added by the build script.
7fc6c77
@ivdiazsa
Forgot to revert also the nativeaot part of the suppressions.
2caf450
@ivdiazsa
Addressed PR comments: Updated the tests to use the new
a2f86a5
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
@jkotas
jkotas
commented
May 15, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This needs some tests ( 
runtime/src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

Line 182
in
1ee61b8
}

is a good place to add them)
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 16, 2024

Closed

@ivdiazsa@jkotas
Update src/libraries/System.Private.CoreLib/src/System/Reflection/Ass…
d574dad
…embly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@ivdiazsa
ivdiazsa
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
Seems I got an import wrong. Will look into it.
jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@ivdiazsa@jkotas
Apply Jan's suggestions
aac56b3
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas
approved these changes
May 17, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
I wonder where that trailing whitespace came from... Let me fix it so we can merge. Thanks a lot for your guidance with this @jkotas!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Might be just my ptsd of breaking the outerloop with a PR I did last year, so I'll kick off an outerloop run just to be safe we can merge this.
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
May 17, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 17, 2024

Open


Closed


This was referenced May 21, 2024

Closed


Closed

@ivdiazsa
ivdiazsa
merged commit 362a95d
into
dotnet:mainMay 21, 2024
@jkotasjkotas
mentioned this pull request
May 29, 2024

Closed

Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@ivdiazsa@jkotas@Ruihan-Yin
AddSetEntryAssembly()API toSystem.Reflection(dotnet#102271)
5442384
* Trying out JanK's approach to override the entry assembly...
* Fixed what was missing for this reflection scenario to work correctly.
* Reverted the compatibility suppressions added by the build script.
* Forgot to revert also the nativeaot part of the suppressions.
* Addressed PR comments: Updated the tests to use the new
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
* Added tests and addressed more comments on the PR.
* Added exception test case for SetEntryAssembly, and wrapped all its
test cases in a RemoteExecutor.Invoke() call, in order to avoid
potentially interferring with the GetEntryAssembly tests.
* Update src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Refactored further the tests that force a null entry assembly, and
fixed the issue with the remote executor.
* Apply Jan's suggestions
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Fixed a sneaky trailing whitespace that was messing up with the code analyzers.
* Changed ConditionalTheory to ConditionalFact in the tests because we're not passing parameters to it.
* Disabled building the CustomHostTests test file when .NET Framework
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@elinor-fungelinor-fung
mentioned this pull request
Jun 7, 2024

Closed

@jkotasjkotas
mentioned this pull request
Jun 14, 2024

Closed

@steveisoksteveisok
mentioned this pull request
Jun 19, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@jkotasjkotasjkotas approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lambdageeklambdageekAwaiting requested review from lambdageek
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono

+1 more reviewer

@kgkgkg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ivdiazsaivdiazsa

Labels

area-System.Reflectionnew-api-needs-documentation

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ivdiazsa@jkotas@kg@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add SetEntryAssembly() API to System.Reflection - #102271
Merged
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
May 21, 2024
Merged
Add SetEntryAssembly() API to System.Reflection#102271
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Implements the API proposal detailed and approved in issue #101616. This new API will allow developers to change the entry assembly of their .NET apps on the fly, should they require it. One important scenario is app launchers. With the usage of this API, then functions like GetEntryAssembly() will return the right value, and thus we will be able to ensure the information is consistent and correct.
@ivdiazsaivdiazsa
added this to the 9.0.0 milestone
May 15, 2024
@ghost
ghost
commented
May 15, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
kg
kg
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

MichalStrehovsky
MichalStrehovsky
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

@ivdiazsa
Merge branch 'main' into managed-contract-facade
3bea613
@ivdiazsa
Reverted the compatibility suppressions added by the build script.
7fc6c77
@ivdiazsa
Forgot to revert also the nativeaot part of the suppressions.
2caf450
@ivdiazsa
Addressed PR comments: Updated the tests to use the new
a2f86a5
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
@jkotas
jkotas
commented
May 15, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This needs some tests ( 
runtime/src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

Line 182
in
1ee61b8
}

is a good place to add them)
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 16, 2024

Closed

@ivdiazsa@jkotas
Update src/libraries/System.Private.CoreLib/src/System/Reflection/Ass…
d574dad
…embly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@ivdiazsa
ivdiazsa
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
Seems I got an import wrong. Will look into it.
jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@ivdiazsa@jkotas
Apply Jan's suggestions
aac56b3
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas
approved these changes
May 17, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
I wonder where that trailing whitespace came from... Let me fix it so we can merge. Thanks a lot for your guidance with this @jkotas!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Might be just my ptsd of breaking the outerloop with a PR I did last year, so I'll kick off an outerloop run just to be safe we can merge this.
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
May 17, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 17, 2024

Open


Closed


This was referenced May 21, 2024

Closed


Closed

@ivdiazsa
ivdiazsa
merged commit 362a95d
into
dotnet:mainMay 21, 2024
@jkotasjkotas
mentioned this pull request
May 29, 2024

Closed

Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@ivdiazsa@jkotas@Ruihan-Yin
AddSetEntryAssembly()API toSystem.Reflection(dotnet#102271)
5442384
* Trying out JanK's approach to override the entry assembly...
* Fixed what was missing for this reflection scenario to work correctly.
* Reverted the compatibility suppressions added by the build script.
* Forgot to revert also the nativeaot part of the suppressions.
* Addressed PR comments: Updated the tests to use the new
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
* Added tests and addressed more comments on the PR.
* Added exception test case for SetEntryAssembly, and wrapped all its
test cases in a RemoteExecutor.Invoke() call, in order to avoid
potentially interferring with the GetEntryAssembly tests.
* Update src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Refactored further the tests that force a null entry assembly, and
fixed the issue with the remote executor.
* Apply Jan's suggestions
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Fixed a sneaky trailing whitespace that was messing up with the code analyzers.
* Changed ConditionalTheory to ConditionalFact in the tests because we're not passing parameters to it.
* Disabled building the CustomHostTests test file when .NET Framework
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@elinor-fungelinor-fung
mentioned this pull request
Jun 7, 2024

Closed

@jkotasjkotas
mentioned this pull request
Jun 14, 2024

Closed

@steveisoksteveisok
mentioned this pull request
Jun 19, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@jkotasjkotasjkotas approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lambdageeklambdageekAwaiting requested review from lambdageek
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono

+1 more reviewer

@kgkgkg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ivdiazsaivdiazsa

Labels

area-System.Reflectionnew-api-needs-documentation

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ivdiazsa@jkotas@kg@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add SetEntryAssembly() API to System.Reflection - #102271
Merged
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
May 21, 2024
Merged
Add SetEntryAssembly() API to System.Reflection#102271
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Implements the API proposal detailed and approved in issue #101616. This new API will allow developers to change the entry assembly of their .NET apps on the fly, should they require it. One important scenario is app launchers. With the usage of this API, then functions like GetEntryAssembly() will return the right value, and thus we will be able to ensure the information is consistent and correct.
@ivdiazsaivdiazsa
added this to the 9.0.0 milestone
May 15, 2024
@ghost
ghost
commented
May 15, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
kg
kg
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

MichalStrehovsky
MichalStrehovsky
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

@ivdiazsa
Merge branch 'main' into managed-contract-facade
3bea613
@ivdiazsa
Reverted the compatibility suppressions added by the build script.
7fc6c77
@ivdiazsa
Forgot to revert also the nativeaot part of the suppressions.
2caf450
@ivdiazsa
Addressed PR comments: Updated the tests to use the new
a2f86a5
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
@jkotas
jkotas
commented
May 15, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This needs some tests ( 
runtime/src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

Line 182
in
1ee61b8
}

is a good place to add them)
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 16, 2024

Closed

@ivdiazsa@jkotas
Update src/libraries/System.Private.CoreLib/src/System/Reflection/Ass…
d574dad
…embly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@ivdiazsa
ivdiazsa
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
Seems I got an import wrong. Will look into it.
jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@ivdiazsa@jkotas
Apply Jan's suggestions
aac56b3
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas
approved these changes
May 17, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
I wonder where that trailing whitespace came from... Let me fix it so we can merge. Thanks a lot for your guidance with this @jkotas!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Might be just my ptsd of breaking the outerloop with a PR I did last year, so I'll kick off an outerloop run just to be safe we can merge this.
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
May 17, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 17, 2024

Open


Closed


This was referenced May 21, 2024

Closed


Closed

@ivdiazsa
ivdiazsa
merged commit 362a95d
into
dotnet:mainMay 21, 2024
@jkotasjkotas
mentioned this pull request
May 29, 2024

Closed

Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@ivdiazsa@jkotas@Ruihan-Yin
AddSetEntryAssembly()API toSystem.Reflection(dotnet#102271)
5442384
* Trying out JanK's approach to override the entry assembly...
* Fixed what was missing for this reflection scenario to work correctly.
* Reverted the compatibility suppressions added by the build script.
* Forgot to revert also the nativeaot part of the suppressions.
* Addressed PR comments: Updated the tests to use the new
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
* Added tests and addressed more comments on the PR.
* Added exception test case for SetEntryAssembly, and wrapped all its
test cases in a RemoteExecutor.Invoke() call, in order to avoid
potentially interferring with the GetEntryAssembly tests.
* Update src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Refactored further the tests that force a null entry assembly, and
fixed the issue with the remote executor.
* Apply Jan's suggestions
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Fixed a sneaky trailing whitespace that was messing up with the code analyzers.
* Changed ConditionalTheory to ConditionalFact in the tests because we're not passing parameters to it.
* Disabled building the CustomHostTests test file when .NET Framework
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@elinor-fungelinor-fung
mentioned this pull request
Jun 7, 2024

Closed

@jkotasjkotas
mentioned this pull request
Jun 14, 2024

Closed

@steveisoksteveisok
mentioned this pull request
Jun 19, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@jkotasjkotasjkotas approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lambdageeklambdageekAwaiting requested review from lambdageek
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono

+1 more reviewer

@kgkgkg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ivdiazsaivdiazsa

Labels

area-System.Reflectionnew-api-needs-documentation

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ivdiazsa@jkotas@kg@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add SetEntryAssembly() API to System.Reflection - #102271
Merged
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
May 21, 2024
Merged
Add SetEntryAssembly() API to System.Reflection#102271
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Implements the API proposal detailed and approved in issue #101616. This new API will allow developers to change the entry assembly of their .NET apps on the fly, should they require it. One important scenario is app launchers. With the usage of this API, then functions like GetEntryAssembly() will return the right value, and thus we will be able to ensure the information is consistent and correct.
@ivdiazsaivdiazsa
added this to the 9.0.0 milestone
May 15, 2024
@ghost
ghost
commented
May 15, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
kg
kg
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

MichalStrehovsky
MichalStrehovsky
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

@ivdiazsa
Merge branch 'main' into managed-contract-facade
3bea613
@ivdiazsa
Reverted the compatibility suppressions added by the build script.
7fc6c77
@ivdiazsa
Forgot to revert also the nativeaot part of the suppressions.
2caf450
@ivdiazsa
Addressed PR comments: Updated the tests to use the new
a2f86a5
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
@jkotas
jkotas
commented
May 15, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This needs some tests ( 
runtime/src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

Line 182
in
1ee61b8
}

is a good place to add them)
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 16, 2024

Closed

@ivdiazsa@jkotas
Update src/libraries/System.Private.CoreLib/src/System/Reflection/Ass…
d574dad
…embly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@ivdiazsa
ivdiazsa
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
Seems I got an import wrong. Will look into it.
jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@ivdiazsa@jkotas
Apply Jan's suggestions
aac56b3
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas
approved these changes
May 17, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
I wonder where that trailing whitespace came from... Let me fix it so we can merge. Thanks a lot for your guidance with this @jkotas!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Might be just my ptsd of breaking the outerloop with a PR I did last year, so I'll kick off an outerloop run just to be safe we can merge this.
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
May 17, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 17, 2024

Open


Closed


This was referenced May 21, 2024

Closed


Closed

@ivdiazsa
ivdiazsa
merged commit 362a95d
into
dotnet:mainMay 21, 2024
@jkotasjkotas
mentioned this pull request
May 29, 2024

Closed

Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@ivdiazsa@jkotas@Ruihan-Yin
AddSetEntryAssembly()API toSystem.Reflection(dotnet#102271)
5442384
* Trying out JanK's approach to override the entry assembly...
* Fixed what was missing for this reflection scenario to work correctly.
* Reverted the compatibility suppressions added by the build script.
* Forgot to revert also the nativeaot part of the suppressions.
* Addressed PR comments: Updated the tests to use the new
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
* Added tests and addressed more comments on the PR.
* Added exception test case for SetEntryAssembly, and wrapped all its
test cases in a RemoteExecutor.Invoke() call, in order to avoid
potentially interferring with the GetEntryAssembly tests.
* Update src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Refactored further the tests that force a null entry assembly, and
fixed the issue with the remote executor.
* Apply Jan's suggestions
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Fixed a sneaky trailing whitespace that was messing up with the code analyzers.
* Changed ConditionalTheory to ConditionalFact in the tests because we're not passing parameters to it.
* Disabled building the CustomHostTests test file when .NET Framework
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@elinor-fungelinor-fung
mentioned this pull request
Jun 7, 2024

Closed

@jkotasjkotas
mentioned this pull request
Jun 14, 2024

Closed

@steveisoksteveisok
mentioned this pull request
Jun 19, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@jkotasjkotasjkotas approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lambdageeklambdageekAwaiting requested review from lambdageek
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono

+1 more reviewer

@kgkgkg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ivdiazsaivdiazsa

Labels

area-System.Reflectionnew-api-needs-documentation

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ivdiazsa@jkotas@kg@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add SetEntryAssembly() API to System.Reflection - #102271
Merged
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
May 21, 2024
Merged
Add SetEntryAssembly() API to System.Reflection#102271
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Implements the API proposal detailed and approved in issue #101616. This new API will allow developers to change the entry assembly of their .NET apps on the fly, should they require it. One important scenario is app launchers. With the usage of this API, then functions like GetEntryAssembly() will return the right value, and thus we will be able to ensure the information is consistent and correct.
@ivdiazsaivdiazsa
added this to the 9.0.0 milestone
May 15, 2024
@ghost
ghost
commented
May 15, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
kg
kg
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

MichalStrehovsky
MichalStrehovsky
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

@ivdiazsa
Merge branch 'main' into managed-contract-facade
3bea613
@ivdiazsa
Reverted the compatibility suppressions added by the build script.
7fc6c77
@ivdiazsa
Forgot to revert also the nativeaot part of the suppressions.
2caf450
@ivdiazsa
Addressed PR comments: Updated the tests to use the new
a2f86a5
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
@jkotas
jkotas
commented
May 15, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This needs some tests ( 
runtime/src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

Line 182
in
1ee61b8
}

is a good place to add them)
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 16, 2024

Closed

@ivdiazsa@jkotas
Update src/libraries/System.Private.CoreLib/src/System/Reflection/Ass…
d574dad
…embly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@ivdiazsa
ivdiazsa
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
Seems I got an import wrong. Will look into it.
jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@ivdiazsa@jkotas
Apply Jan's suggestions
aac56b3
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas
approved these changes
May 17, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
I wonder where that trailing whitespace came from... Let me fix it so we can merge. Thanks a lot for your guidance with this @jkotas!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Might be just my ptsd of breaking the outerloop with a PR I did last year, so I'll kick off an outerloop run just to be safe we can merge this.
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
May 17, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 17, 2024

Open


Closed


This was referenced May 21, 2024

Closed


Closed

@ivdiazsa
ivdiazsa
merged commit 362a95d
into
dotnet:mainMay 21, 2024
@jkotasjkotas
mentioned this pull request
May 29, 2024

Closed

Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@ivdiazsa@jkotas@Ruihan-Yin
AddSetEntryAssembly()API toSystem.Reflection(dotnet#102271)
5442384
* Trying out JanK's approach to override the entry assembly...
* Fixed what was missing for this reflection scenario to work correctly.
* Reverted the compatibility suppressions added by the build script.
* Forgot to revert also the nativeaot part of the suppressions.
* Addressed PR comments: Updated the tests to use the new
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
* Added tests and addressed more comments on the PR.
* Added exception test case for SetEntryAssembly, and wrapped all its
test cases in a RemoteExecutor.Invoke() call, in order to avoid
potentially interferring with the GetEntryAssembly tests.
* Update src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Refactored further the tests that force a null entry assembly, and
fixed the issue with the remote executor.
* Apply Jan's suggestions
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Fixed a sneaky trailing whitespace that was messing up with the code analyzers.
* Changed ConditionalTheory to ConditionalFact in the tests because we're not passing parameters to it.
* Disabled building the CustomHostTests test file when .NET Framework
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@elinor-fungelinor-fung
mentioned this pull request
Jun 7, 2024

Closed

@jkotasjkotas
mentioned this pull request
Jun 14, 2024

Closed

@steveisoksteveisok
mentioned this pull request
Jun 19, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@jkotasjkotasjkotas approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lambdageeklambdageekAwaiting requested review from lambdageek
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono

+1 more reviewer

@kgkgkg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ivdiazsaivdiazsa

Labels

area-System.Reflectionnew-api-needs-documentation

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ivdiazsa@jkotas@kg@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add SetEntryAssembly() API to System.Reflection - #102271
Merged
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
May 21, 2024
Merged
Add SetEntryAssembly() API to System.Reflection#102271
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Implements the API proposal detailed and approved in issue #101616. This new API will allow developers to change the entry assembly of their .NET apps on the fly, should they require it. One important scenario is app launchers. With the usage of this API, then functions like GetEntryAssembly() will return the right value, and thus we will be able to ensure the information is consistent and correct.
@ivdiazsaivdiazsa
added this to the 9.0.0 milestone
May 15, 2024
@ghost
ghost
commented
May 15, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
kg
kg
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

MichalStrehovsky
MichalStrehovsky
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

@ivdiazsa
Merge branch 'main' into managed-contract-facade
3bea613
@ivdiazsa
Reverted the compatibility suppressions added by the build script.
7fc6c77
@ivdiazsa
Forgot to revert also the nativeaot part of the suppressions.
2caf450
@ivdiazsa
Addressed PR comments: Updated the tests to use the new
a2f86a5
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
@jkotas
jkotas
commented
May 15, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This needs some tests ( 
runtime/src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

Line 182
in
1ee61b8
}

is a good place to add them)
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 16, 2024

Closed

@ivdiazsa@jkotas
Update src/libraries/System.Private.CoreLib/src/System/Reflection/Ass…
d574dad
…embly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@ivdiazsa
ivdiazsa
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
Seems I got an import wrong. Will look into it.
jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@ivdiazsa@jkotas
Apply Jan's suggestions
aac56b3
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas
approved these changes
May 17, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
I wonder where that trailing whitespace came from... Let me fix it so we can merge. Thanks a lot for your guidance with this @jkotas!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Might be just my ptsd of breaking the outerloop with a PR I did last year, so I'll kick off an outerloop run just to be safe we can merge this.
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
May 17, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 17, 2024

Open


Closed


This was referenced May 21, 2024

Closed


Closed

@ivdiazsa
ivdiazsa
merged commit 362a95d
into
dotnet:mainMay 21, 2024
@jkotasjkotas
mentioned this pull request
May 29, 2024

Closed

Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@ivdiazsa@jkotas@Ruihan-Yin
AddSetEntryAssembly()API toSystem.Reflection(dotnet#102271)
5442384
* Trying out JanK's approach to override the entry assembly...
* Fixed what was missing for this reflection scenario to work correctly.
* Reverted the compatibility suppressions added by the build script.
* Forgot to revert also the nativeaot part of the suppressions.
* Addressed PR comments: Updated the tests to use the new
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
* Added tests and addressed more comments on the PR.
* Added exception test case for SetEntryAssembly, and wrapped all its
test cases in a RemoteExecutor.Invoke() call, in order to avoid
potentially interferring with the GetEntryAssembly tests.
* Update src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Refactored further the tests that force a null entry assembly, and
fixed the issue with the remote executor.
* Apply Jan's suggestions
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Fixed a sneaky trailing whitespace that was messing up with the code analyzers.
* Changed ConditionalTheory to ConditionalFact in the tests because we're not passing parameters to it.
* Disabled building the CustomHostTests test file when .NET Framework
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@elinor-fungelinor-fung
mentioned this pull request
Jun 7, 2024

Closed

@jkotasjkotas
mentioned this pull request
Jun 14, 2024

Closed

@steveisoksteveisok
mentioned this pull request
Jun 19, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@jkotasjkotasjkotas approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lambdageeklambdageekAwaiting requested review from lambdageek
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono

+1 more reviewer

@kgkgkg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ivdiazsaivdiazsa

Labels

area-System.Reflectionnew-api-needs-documentation

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ivdiazsa@jkotas@kg@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add SetEntryAssembly() API to System.Reflection - #102271
Merged
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
May 21, 2024
Merged
Add SetEntryAssembly() API to System.Reflection#102271
ivdiazsa merged 14 commits into
dotnet:mainfrom 
ivdiazsa:managed-contract-facade
Conversation
@ivdiazsa
@ivdiazsaivdiazsa
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Implements the API proposal detailed and approved in issue #101616. This new API will allow developers to change the entry assembly of their .NET apps on the fly, should they require it. One important scenario is app launchers. With the usage of this API, then functions like GetEntryAssembly() will return the right value, and thus we will be able to ensure the information is consistent and correct.
@ivdiazsaivdiazsa
added this to the 9.0.0 milestone
May 15, 2024
@ghost
ghost
commented
May 15, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 15, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-reflection

See info in area-owners.md if you want to be subscribed.
kg
kg
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

MichalStrehovsky
MichalStrehovsky
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

@ivdiazsa
Merge branch 'main' into managed-contract-facade
3bea613
@ivdiazsa
Reverted the compatibility suppressions added by the build script.
7fc6c77
@ivdiazsa
Forgot to revert also the nativeaot part of the suppressions.
2caf450
@ivdiazsa
Addressed PR comments: Updated the tests to use the new
a2f86a5
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
@jkotas
jkotas
commented
May 15, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This needs some tests ( 
runtime/src/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs

Line 182
in
1ee61b8
}

is a good place to add them)
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
jkotas
jkotas
reviewed
May 15, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
May 16, 2024

Closed

@ivdiazsa@jkotas
Update src/libraries/System.Private.CoreLib/src/System/Reflection/Ass…
d574dad
…embly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@ivdiazsa
ivdiazsa
commented
May 16, 2024

Copy link


Copy Markdown

ContributorAuthor
Seems I got an import wrong. Will look into it.
jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

jkotas
jkotas
reviewed
May 17, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System.Reflection.Tests/AssemblyTests.cs
Outdated

@ivdiazsa@jkotas
Apply Jan's suggestions
aac56b3
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas
approved these changes
May 17, 2024
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
I wonder where that trailing whitespace came from... Let me fix it so we can merge. Thanks a lot for your guidance with this @jkotas!
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Might be just my ptsd of breaking the outerloop with a PR I did last year, so I'll kick off an outerloop run just to be safe we can merge this.
@ivdiazsa
ivdiazsa
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
May 17, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 17, 2024

Open


Closed


This was referenced May 21, 2024

Closed


Closed

@ivdiazsa
ivdiazsa
merged commit 362a95d
into
dotnet:mainMay 21, 2024
@jkotasjkotas
mentioned this pull request
May 29, 2024

Closed

Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@ivdiazsa@jkotas@Ruihan-Yin
AddSetEntryAssembly()API toSystem.Reflection(dotnet#102271)
5442384
* Trying out JanK's approach to override the entry assembly...
* Fixed what was missing for this reflection scenario to work correctly.
* Reverted the compatibility suppressions added by the build script.
* Forgot to revert also the nativeaot part of the suppressions.
* Addressed PR comments: Updated the tests to use the new
"s_overriddenEntryAssembly", added an API doc to SetEntryAssembly(),
added validation for it to be a Runtime Assembly, and changed the type
to allow a null entry assembly.
* Added tests and addressed more comments on the PR.
* Added exception test case for SetEntryAssembly, and wrapped all its
test cases in a RemoteExecutor.Invoke() call, in order to avoid
potentially interferring with the GetEntryAssembly tests.
* Update src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Refactored further the tests that force a null entry assembly, and
fixed the issue with the remote executor.
* Apply Jan's suggestions
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Fixed a sneaky trailing whitespace that was messing up with the code analyzers.
* Changed ConditionalTheory to ConditionalFact in the tests because we're not passing parameters to it.
* Disabled building the CustomHostTests test file when .NET Framework
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@elinor-fungelinor-fung
mentioned this pull request
Jun 7, 2024

Closed

@jkotasjkotas
mentioned this pull request
Jun 14, 2024

Closed

@steveisoksteveisok
mentioned this pull request
Jun 19, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 21, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@jkotasjkotasjkotas approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lambdageeklambdageekAwaiting requested review from lambdageek
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono

+1 more reviewer

@kgkgkg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ivdiazsaivdiazsa

Labels

area-System.Reflectionnew-api-needs-documentation

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ivdiazsa@jkotas@kg@MichalStrehovsky