Handle more than 64 registers - Part 2 - #102297

Merged
kunalspathak merged 8 commits into
dotnet:mainfrom
kunalspathak:regMaskTP-nonarm64
May 22, 2024
Merged

Handle more than 64 registers - Part 2#102297
kunalspathak merged 8 commits into
dotnet:mainfrom
kunalspathak:regMaskTP-nonarm64

Conversation

@kunalspathak

@kunalspathakkunalspathak commented May 16, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR, I have extended the support of struct regMaskTP to non-arm64 platforms. The reason being that when I start adding code to convert 64-bits mask back and forth between regMaskTP, I will not have to add #ifdef TARGET_ARM64 in LSRA code to handle the struct regMaskTP vs. uint64_t regMaskTP separately.

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 16, 2024
@kunalspathak
kunalspathak marked this pull request as ready for review May 17, 2024 12:50
@kunalspathak

kunalspathak commented May 17, 2024

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib @jakobbotsch

@kunalspathak

kunalspathak commented May 17, 2024

Copy link
Copy Markdown
ContributorAuthor

Diffs:

image
image

I will double check the reason for arm regression.

@kunalspathak

kunalspathak commented May 20, 2024

Copy link
Copy Markdown
ContributorAuthor

I will double check the reason for arm regression.

For some reason, I am not able to use the local pin tool to produce the individual method instruction count difference. I looked at vtune data for benchmarks.run_tiered and I don't see anything standing out. I am guessing the conversion of uint64 to struct might stop certain native optimizations.

image

@kunalspathak

kunalspathak commented May 20, 2024

Copy link
Copy Markdown
ContributorAuthor

ping @dotnet/jit-contrib

@JulieLeeMSFTJulieLeeMSFT added the Priority:2 Work that is important, but not critical for the release label May 20, 2024
@kunalspathakkunalspathak mentioned this pull request May 21, 2024
Closed
jakobbotsch
jakobbotsch reviewed May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/codegenarm.cpp Outdated
jakobbotsch
jakobbotsch reviewed May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lsraxarch.cpp Outdated
jakobbotsch
jakobbotsch reviewed May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch reviewed May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch approved these changes May 21, 2024
View reviewed changes

@jakobbotschjakobbotsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor clean up that we should do in the future.

This was referenced May 21, 2024
Closed
Closed
@kunalspathak

kunalspathak commented May 21, 2024

Copy link
Copy Markdown
ContributorAuthor

/ba-g failure is related to #102479

@kunalspathak
kunalspathak merged commit 761c9a5 into dotnet:mainMay 22, 2024
@kunalspathak
kunalspathak deleted the regMaskTP-nonarm64 branch May 22, 2024 00:01
@am11

am11 commented May 23, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@kunalspathak, osx-arm64 build is failing locally. If I revert this change, or checkout the previous commit 0709995, it works. Possible build regression.

[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdashwintrinsic.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedOsrIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/targetarm.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdcodegenxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/codegenarm64test.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x64_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x64_arm64.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/targetx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/unwindx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/unwindarmarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/dllmain.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsicxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64sve.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/targetamd64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/unwindamd64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsiccodegenxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lowerarmarch.cpp.o
^[[C[ 97%] Linking CXX shared library libclrjit_universal_arm_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsicxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsiccodegenxarch.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_universal_arm_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_universal_arm_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/dllmain.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarm64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/dllmain.cpp.o
[ 97%] Linking CXX shared library libclrjit_win_x86_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simd.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simdashwintrinsic.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/targetarm64.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x86_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x86_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarm64.cpp.o

@kunalspathak

kunalspathak commented May 23, 2024

Copy link
Copy Markdown
ContributorAuthor

@am11 - What machine are you building this on? can you share the command you are using and possibly the clang version?

@am11

am11 commented May 23, 2024

Copy link
Copy Markdown
Member
$ uname -ms
Darwin arm64
$ clang --version | head -1
Apple clang version 15.0.0 (clang-1500.3.9.4)

@kunalspathak

kunalspathak commented May 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks. I realized that this fails only if building Debug. Checked and Release should build fine.

@kunalspathakkunalspathak mentioned this pull request May 23, 2024
Merged
@LuckyXu-HFLuckyXu-HF mentioned this pull request May 24, 2024
Merged
steveharter pushed a commit to steveharter/runtime that referenced this pull request May 28, 2024
@kunalspathak@steveharter
Handle more than 64 registers - Part 2 (dotnet#102297)
480d371
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@kunalspathak@Ruihan-Yin
Handle more than 64 registers - Part 2 (dotnet#102297)
0cf4db0
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback
This was referenced Jun 13, 2024
Merged
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIPriority:2Work that is important, but not critical for the release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@am11@jakobbotsch@JulieLeeMSFT
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Handle more than 64 registers - Part 2 - #102297
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
May 22, 2024
Merged
Handle more than 64 registers - Part 2#102297
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
May 16, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
In this PR, I have extended the support of struct regMaskTP to non-arm64 platforms. The reason being that when I start adding code to convert 64-bits mask back and forth between regMaskTP, I will not have to add #ifdef TARGET_ARM64 in LSRA code to handle the struct regMaskTP vs. uint64_t regMaskTP separately.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 16, 2024
@kunalspathak
kunalspathak
marked this pull request as ready for review
May 17, 2024 12:50
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Diffs:
image
image
I will double check the reason for arm regression.
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
I will double check the reason for arm regression.
For some reason, I am not able to use the local pin tool to produce the individual method instruction count difference. I looked at vtune data for benchmarks.run_tiered and I don't see anything standing out. I am guessing the conversion of uint64 to struct might stop certain native optimizations.
image
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
ping @dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added
the 
Priority:2
Work that is important, but not critical for the release
label
May 20, 2024
@kunalspathakkunalspathak
mentioned this pull request
May 21, 2024
 Closed

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/codegenarm.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lsraxarch.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
approved these changes
May 21, 2024
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor clean up that we should do in the future.

This was referenced May 21, 2024

Closed


Closed

@kunalspathak
kunalspathak
commented
May 21, 2024

Copy link


Copy Markdown

ContributorAuthor
/ba-g failure is related to #102479
@kunalspathak
kunalspathak
merged commit 761c9a5
into
dotnet:mainMay 22, 2024
@kunalspathak
kunalspathak
deleted the

regMaskTP-nonarm64

branch
May 22, 2024 00:01
@am11
am11
commented
May 23, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak, osx-arm64 build is failing locally. If I revert this change, or checkout the previous commit 0709995, it works. Possible build regression.
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdashwintrinsic.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedOsrIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/targetarm.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdcodegenxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/codegenarm64test.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x64_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x64_arm64.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/targetx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/unwindx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/unwindarmarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/dllmain.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsicxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64sve.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/targetamd64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/unwindamd64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsiccodegenxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lowerarmarch.cpp.o
^[[C[ 97%] Linking CXX shared library libclrjit_universal_arm_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsicxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsiccodegenxarch.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_universal_arm_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_universal_arm_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/dllmain.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarm64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/dllmain.cpp.o
[ 97%] Linking CXX shared library libclrjit_win_x86_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simd.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simdashwintrinsic.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/targetarm64.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x86_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x86_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarm64.cpp.o
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
@am11 - What machine are you building this on? can you share the command you are using and possibly the clang version?
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
$ uname -ms
Darwin arm64
$ clang --version | head -1
Apple clang version 15.0.0 (clang-1500.3.9.4)
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks. I realized that this fails only if building Debug. Checked and Release should build fine.
@kunalspathakkunalspathak
mentioned this pull request
May 23, 2024
 Merged

@LuckyXu-HFLuckyXu-HF
mentioned this pull request
May 24, 2024
 Merged

steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@kunalspathak@steveharter
Handle more than 64 registers - Part 2 (dotnet#102297)
480d371
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@kunalspathak@Ruihan-Yin
Handle more than 64 registers - Part 2 (dotnet#102297)
0cf4db0
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback

This was referenced Jun 13, 2024
 Merged

 Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIPriority:2Work that is important, but not critical for the release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@am11@jakobbotsch@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Handle more than 64 registers - Part 2 - #102297
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
May 22, 2024
Merged
Handle more than 64 registers - Part 2#102297
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
May 16, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
In this PR, I have extended the support of struct regMaskTP to non-arm64 platforms. The reason being that when I start adding code to convert 64-bits mask back and forth between regMaskTP, I will not have to add #ifdef TARGET_ARM64 in LSRA code to handle the struct regMaskTP vs. uint64_t regMaskTP separately.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 16, 2024
@kunalspathak
kunalspathak
marked this pull request as ready for review
May 17, 2024 12:50
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Diffs:
image
image
I will double check the reason for arm regression.
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
I will double check the reason for arm regression.
For some reason, I am not able to use the local pin tool to produce the individual method instruction count difference. I looked at vtune data for benchmarks.run_tiered and I don't see anything standing out. I am guessing the conversion of uint64 to struct might stop certain native optimizations.
image
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
ping @dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added
the 
Priority:2
Work that is important, but not critical for the release
label
May 20, 2024
@kunalspathakkunalspathak
mentioned this pull request
May 21, 2024
 Closed

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/codegenarm.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lsraxarch.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
approved these changes
May 21, 2024
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor clean up that we should do in the future.

This was referenced May 21, 2024

Closed


Closed

@kunalspathak
kunalspathak
commented
May 21, 2024

Copy link


Copy Markdown

ContributorAuthor
/ba-g failure is related to #102479
@kunalspathak
kunalspathak
merged commit 761c9a5
into
dotnet:mainMay 22, 2024
@kunalspathak
kunalspathak
deleted the

regMaskTP-nonarm64

branch
May 22, 2024 00:01
@am11
am11
commented
May 23, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak, osx-arm64 build is failing locally. If I revert this change, or checkout the previous commit 0709995, it works. Possible build regression.
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdashwintrinsic.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedOsrIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/targetarm.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdcodegenxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/codegenarm64test.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x64_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x64_arm64.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/targetx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/unwindx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/unwindarmarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/dllmain.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsicxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64sve.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/targetamd64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/unwindamd64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsiccodegenxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lowerarmarch.cpp.o
^[[C[ 97%] Linking CXX shared library libclrjit_universal_arm_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsicxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsiccodegenxarch.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_universal_arm_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_universal_arm_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/dllmain.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarm64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/dllmain.cpp.o
[ 97%] Linking CXX shared library libclrjit_win_x86_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simd.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simdashwintrinsic.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/targetarm64.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x86_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x86_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarm64.cpp.o
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
@am11 - What machine are you building this on? can you share the command you are using and possibly the clang version?
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
$ uname -ms
Darwin arm64
$ clang --version | head -1
Apple clang version 15.0.0 (clang-1500.3.9.4)
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks. I realized that this fails only if building Debug. Checked and Release should build fine.
@kunalspathakkunalspathak
mentioned this pull request
May 23, 2024
 Merged

@LuckyXu-HFLuckyXu-HF
mentioned this pull request
May 24, 2024
 Merged

steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@kunalspathak@steveharter
Handle more than 64 registers - Part 2 (dotnet#102297)
480d371
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@kunalspathak@Ruihan-Yin
Handle more than 64 registers - Part 2 (dotnet#102297)
0cf4db0
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback

This was referenced Jun 13, 2024
 Merged

 Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIPriority:2Work that is important, but not critical for the release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@am11@jakobbotsch@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Handle more than 64 registers - Part 2 - #102297
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
May 22, 2024
Merged
Handle more than 64 registers - Part 2#102297
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
May 16, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
In this PR, I have extended the support of struct regMaskTP to non-arm64 platforms. The reason being that when I start adding code to convert 64-bits mask back and forth between regMaskTP, I will not have to add #ifdef TARGET_ARM64 in LSRA code to handle the struct regMaskTP vs. uint64_t regMaskTP separately.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 16, 2024
@kunalspathak
kunalspathak
marked this pull request as ready for review
May 17, 2024 12:50
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Diffs:
image
image
I will double check the reason for arm regression.
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
I will double check the reason for arm regression.
For some reason, I am not able to use the local pin tool to produce the individual method instruction count difference. I looked at vtune data for benchmarks.run_tiered and I don't see anything standing out. I am guessing the conversion of uint64 to struct might stop certain native optimizations.
image
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
ping @dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added
the 
Priority:2
Work that is important, but not critical for the release
label
May 20, 2024
@kunalspathakkunalspathak
mentioned this pull request
May 21, 2024
 Closed

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/codegenarm.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lsraxarch.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
approved these changes
May 21, 2024
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor clean up that we should do in the future.

This was referenced May 21, 2024

Closed


Closed

@kunalspathak
kunalspathak
commented
May 21, 2024

Copy link


Copy Markdown

ContributorAuthor
/ba-g failure is related to #102479
@kunalspathak
kunalspathak
merged commit 761c9a5
into
dotnet:mainMay 22, 2024
@kunalspathak
kunalspathak
deleted the

regMaskTP-nonarm64

branch
May 22, 2024 00:01
@am11
am11
commented
May 23, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak, osx-arm64 build is failing locally. If I revert this change, or checkout the previous commit 0709995, it works. Possible build regression.
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdashwintrinsic.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedOsrIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/targetarm.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdcodegenxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/codegenarm64test.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x64_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x64_arm64.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/targetx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/unwindx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/unwindarmarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/dllmain.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsicxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64sve.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/targetamd64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/unwindamd64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsiccodegenxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lowerarmarch.cpp.o
^[[C[ 97%] Linking CXX shared library libclrjit_universal_arm_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsicxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsiccodegenxarch.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_universal_arm_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_universal_arm_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/dllmain.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarm64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/dllmain.cpp.o
[ 97%] Linking CXX shared library libclrjit_win_x86_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simd.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simdashwintrinsic.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/targetarm64.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x86_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x86_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarm64.cpp.o
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
@am11 - What machine are you building this on? can you share the command you are using and possibly the clang version?
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
$ uname -ms
Darwin arm64
$ clang --version | head -1
Apple clang version 15.0.0 (clang-1500.3.9.4)
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks. I realized that this fails only if building Debug. Checked and Release should build fine.
@kunalspathakkunalspathak
mentioned this pull request
May 23, 2024
 Merged

@LuckyXu-HFLuckyXu-HF
mentioned this pull request
May 24, 2024
 Merged

steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@kunalspathak@steveharter
Handle more than 64 registers - Part 2 (dotnet#102297)
480d371
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@kunalspathak@Ruihan-Yin
Handle more than 64 registers - Part 2 (dotnet#102297)
0cf4db0
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback

This was referenced Jun 13, 2024
 Merged

 Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIPriority:2Work that is important, but not critical for the release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@am11@jakobbotsch@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Handle more than 64 registers - Part 2 - #102297
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
May 22, 2024
Merged
Handle more than 64 registers - Part 2#102297
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
May 16, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
In this PR, I have extended the support of struct regMaskTP to non-arm64 platforms. The reason being that when I start adding code to convert 64-bits mask back and forth between regMaskTP, I will not have to add #ifdef TARGET_ARM64 in LSRA code to handle the struct regMaskTP vs. uint64_t regMaskTP separately.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 16, 2024
@kunalspathak
kunalspathak
marked this pull request as ready for review
May 17, 2024 12:50
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Diffs:
image
image
I will double check the reason for arm regression.
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
I will double check the reason for arm regression.
For some reason, I am not able to use the local pin tool to produce the individual method instruction count difference. I looked at vtune data for benchmarks.run_tiered and I don't see anything standing out. I am guessing the conversion of uint64 to struct might stop certain native optimizations.
image
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
ping @dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added
the 
Priority:2
Work that is important, but not critical for the release
label
May 20, 2024
@kunalspathakkunalspathak
mentioned this pull request
May 21, 2024
 Closed

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/codegenarm.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lsraxarch.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
approved these changes
May 21, 2024
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor clean up that we should do in the future.

This was referenced May 21, 2024

Closed


Closed

@kunalspathak
kunalspathak
commented
May 21, 2024

Copy link


Copy Markdown

ContributorAuthor
/ba-g failure is related to #102479
@kunalspathak
kunalspathak
merged commit 761c9a5
into
dotnet:mainMay 22, 2024
@kunalspathak
kunalspathak
deleted the

regMaskTP-nonarm64

branch
May 22, 2024 00:01
@am11
am11
commented
May 23, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak, osx-arm64 build is failing locally. If I revert this change, or checkout the previous commit 0709995, it works. Possible build regression.
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdashwintrinsic.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedOsrIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/targetarm.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdcodegenxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/codegenarm64test.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x64_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x64_arm64.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/targetx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/unwindx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/unwindarmarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/dllmain.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsicxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64sve.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/targetamd64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/unwindamd64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsiccodegenxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lowerarmarch.cpp.o
^[[C[ 97%] Linking CXX shared library libclrjit_universal_arm_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsicxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsiccodegenxarch.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_universal_arm_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_universal_arm_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/dllmain.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarm64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/dllmain.cpp.o
[ 97%] Linking CXX shared library libclrjit_win_x86_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simd.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simdashwintrinsic.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/targetarm64.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x86_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x86_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarm64.cpp.o
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
@am11 - What machine are you building this on? can you share the command you are using and possibly the clang version?
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
$ uname -ms
Darwin arm64
$ clang --version | head -1
Apple clang version 15.0.0 (clang-1500.3.9.4)
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks. I realized that this fails only if building Debug. Checked and Release should build fine.
@kunalspathakkunalspathak
mentioned this pull request
May 23, 2024
 Merged

@LuckyXu-HFLuckyXu-HF
mentioned this pull request
May 24, 2024
 Merged

steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@kunalspathak@steveharter
Handle more than 64 registers - Part 2 (dotnet#102297)
480d371
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@kunalspathak@Ruihan-Yin
Handle more than 64 registers - Part 2 (dotnet#102297)
0cf4db0
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback

This was referenced Jun 13, 2024
 Merged

 Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIPriority:2Work that is important, but not critical for the release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@am11@jakobbotsch@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Handle more than 64 registers - Part 2 - #102297
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
May 22, 2024
Merged
Handle more than 64 registers - Part 2#102297
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
May 16, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
In this PR, I have extended the support of struct regMaskTP to non-arm64 platforms. The reason being that when I start adding code to convert 64-bits mask back and forth between regMaskTP, I will not have to add #ifdef TARGET_ARM64 in LSRA code to handle the struct regMaskTP vs. uint64_t regMaskTP separately.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 16, 2024
@kunalspathak
kunalspathak
marked this pull request as ready for review
May 17, 2024 12:50
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Diffs:
image
image
I will double check the reason for arm regression.
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
I will double check the reason for arm regression.
For some reason, I am not able to use the local pin tool to produce the individual method instruction count difference. I looked at vtune data for benchmarks.run_tiered and I don't see anything standing out. I am guessing the conversion of uint64 to struct might stop certain native optimizations.
image
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
ping @dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added
the 
Priority:2
Work that is important, but not critical for the release
label
May 20, 2024
@kunalspathakkunalspathak
mentioned this pull request
May 21, 2024
 Closed

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/codegenarm.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lsraxarch.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
approved these changes
May 21, 2024
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor clean up that we should do in the future.

This was referenced May 21, 2024

Closed


Closed

@kunalspathak
kunalspathak
commented
May 21, 2024

Copy link


Copy Markdown

ContributorAuthor
/ba-g failure is related to #102479
@kunalspathak
kunalspathak
merged commit 761c9a5
into
dotnet:mainMay 22, 2024
@kunalspathak
kunalspathak
deleted the

regMaskTP-nonarm64

branch
May 22, 2024 00:01
@am11
am11
commented
May 23, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak, osx-arm64 build is failing locally. If I revert this change, or checkout the previous commit 0709995, it works. Possible build regression.
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdashwintrinsic.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedOsrIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/targetarm.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdcodegenxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/codegenarm64test.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x64_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x64_arm64.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/targetx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/unwindx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/unwindarmarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/dllmain.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsicxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64sve.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/targetamd64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/unwindamd64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsiccodegenxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lowerarmarch.cpp.o
^[[C[ 97%] Linking CXX shared library libclrjit_universal_arm_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsicxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsiccodegenxarch.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_universal_arm_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_universal_arm_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/dllmain.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarm64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/dllmain.cpp.o
[ 97%] Linking CXX shared library libclrjit_win_x86_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simd.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simdashwintrinsic.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/targetarm64.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x86_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x86_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarm64.cpp.o
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
@am11 - What machine are you building this on? can you share the command you are using and possibly the clang version?
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
$ uname -ms
Darwin arm64
$ clang --version | head -1
Apple clang version 15.0.0 (clang-1500.3.9.4)
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks. I realized that this fails only if building Debug. Checked and Release should build fine.
@kunalspathakkunalspathak
mentioned this pull request
May 23, 2024
 Merged

@LuckyXu-HFLuckyXu-HF
mentioned this pull request
May 24, 2024
 Merged

steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@kunalspathak@steveharter
Handle more than 64 registers - Part 2 (dotnet#102297)
480d371
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@kunalspathak@Ruihan-Yin
Handle more than 64 registers - Part 2 (dotnet#102297)
0cf4db0
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback

This was referenced Jun 13, 2024
 Merged

 Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIPriority:2Work that is important, but not critical for the release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@am11@jakobbotsch@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Handle more than 64 registers - Part 2 - #102297
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
May 22, 2024
Merged
Handle more than 64 registers - Part 2#102297
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
May 16, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
In this PR, I have extended the support of struct regMaskTP to non-arm64 platforms. The reason being that when I start adding code to convert 64-bits mask back and forth between regMaskTP, I will not have to add #ifdef TARGET_ARM64 in LSRA code to handle the struct regMaskTP vs. uint64_t regMaskTP separately.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 16, 2024
@kunalspathak
kunalspathak
marked this pull request as ready for review
May 17, 2024 12:50
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Diffs:
image
image
I will double check the reason for arm regression.
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
I will double check the reason for arm regression.
For some reason, I am not able to use the local pin tool to produce the individual method instruction count difference. I looked at vtune data for benchmarks.run_tiered and I don't see anything standing out. I am guessing the conversion of uint64 to struct might stop certain native optimizations.
image
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
ping @dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added
the 
Priority:2
Work that is important, but not critical for the release
label
May 20, 2024
@kunalspathakkunalspathak
mentioned this pull request
May 21, 2024
 Closed

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/codegenarm.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lsraxarch.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
approved these changes
May 21, 2024
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor clean up that we should do in the future.

This was referenced May 21, 2024

Closed


Closed

@kunalspathak
kunalspathak
commented
May 21, 2024

Copy link


Copy Markdown

ContributorAuthor
/ba-g failure is related to #102479
@kunalspathak
kunalspathak
merged commit 761c9a5
into
dotnet:mainMay 22, 2024
@kunalspathak
kunalspathak
deleted the

regMaskTP-nonarm64

branch
May 22, 2024 00:01
@am11
am11
commented
May 23, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak, osx-arm64 build is failing locally. If I revert this change, or checkout the previous commit 0709995, it works. Possible build regression.
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdashwintrinsic.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedOsrIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/targetarm.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdcodegenxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/codegenarm64test.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x64_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x64_arm64.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/targetx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/unwindx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/unwindarmarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/dllmain.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsicxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64sve.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/targetamd64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/unwindamd64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsiccodegenxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lowerarmarch.cpp.o
^[[C[ 97%] Linking CXX shared library libclrjit_universal_arm_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsicxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsiccodegenxarch.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_universal_arm_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_universal_arm_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/dllmain.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarm64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/dllmain.cpp.o
[ 97%] Linking CXX shared library libclrjit_win_x86_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simd.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simdashwintrinsic.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/targetarm64.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x86_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x86_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarm64.cpp.o
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
@am11 - What machine are you building this on? can you share the command you are using and possibly the clang version?
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
$ uname -ms
Darwin arm64
$ clang --version | head -1
Apple clang version 15.0.0 (clang-1500.3.9.4)
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks. I realized that this fails only if building Debug. Checked and Release should build fine.
@kunalspathakkunalspathak
mentioned this pull request
May 23, 2024
 Merged

@LuckyXu-HFLuckyXu-HF
mentioned this pull request
May 24, 2024
 Merged

steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@kunalspathak@steveharter
Handle more than 64 registers - Part 2 (dotnet#102297)
480d371
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@kunalspathak@Ruihan-Yin
Handle more than 64 registers - Part 2 (dotnet#102297)
0cf4db0
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback

This was referenced Jun 13, 2024
 Merged

 Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIPriority:2Work that is important, but not critical for the release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@am11@jakobbotsch@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Handle more than 64 registers - Part 2 - #102297
Merged
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
May 22, 2024
Merged
Handle more than 64 registers - Part 2#102297
kunalspathak merged 8 commits into
dotnet:mainfrom 
kunalspathak:regMaskTP-nonarm64
Conversation
@kunalspathak
@kunalspathakkunalspathak
commented
May 16, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
In this PR, I have extended the support of struct regMaskTP to non-arm64 platforms. The reason being that when I start adding code to convert 64-bits mask back and forth between regMaskTP, I will not have to add #ifdef TARGET_ARM64 in LSRA code to handle the struct regMaskTP vs. uint64_t regMaskTP separately.
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 16, 2024
@kunalspathak
kunalspathak
marked this pull request as ready for review
May 17, 2024 12:50
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch
@kunalspathak
kunalspathak
commented
May 17, 2024

Copy link


Copy Markdown

ContributorAuthor
Diffs:
image
image
I will double check the reason for arm regression.
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
I will double check the reason for arm regression.
For some reason, I am not able to use the local pin tool to produce the individual method instruction count difference. I looked at vtune data for benchmarks.run_tiered and I don't see anything standing out. I am guessing the conversion of uint64 to struct might stop certain native optimizations.
image
@kunalspathak
kunalspathak
commented
May 20, 2024

Copy link


Copy Markdown

ContributorAuthor
ping @dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added
the 
Priority:2
Work that is important, but not critical for the release
label
May 20, 2024
@kunalspathakkunalspathak
mentioned this pull request
May 21, 2024
 Closed

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/codegenarm.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/lsraxarch.cpp
Outdated

jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
reviewed
May 21, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/target.h
jakobbotsch
jakobbotsch
approved these changes
May 21, 2024
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor clean up that we should do in the future.

This was referenced May 21, 2024

Closed


Closed

@kunalspathak
kunalspathak
commented
May 21, 2024

Copy link


Copy Markdown

ContributorAuthor
/ba-g failure is related to #102479
@kunalspathak
kunalspathak
merged commit 761c9a5
into
dotnet:mainMay 22, 2024
@kunalspathak
kunalspathak
deleted the

regMaskTP-nonarm64

branch
May 22, 2024 00:01
@am11
am11
commented
May 23, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@kunalspathak, osx-arm64 build is failing locally. If I revert this change, or checkout the previous commit 0709995, it works. Possible build regression.
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdashwintrinsic.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedOsrIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/targetarm.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/simdcodegenxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/codegenarm64test.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x64_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x64_arm64.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/targetx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/unwindx86.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/unwindarmarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_universal_arm_arm64.dir/dllmain.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsicxarch.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64sve.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/targetamd64.cpp.o
[ 96%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/unwindamd64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/hwintrinsiccodegenxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lowerarmarch.cpp.o
^[[C[ 97%] Linking CXX shared library libclrjit_universal_arm_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsicxarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/hwintrinsiccodegenxarch.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_universal_arm_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_universal_arm_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit_win_x86_arm64.dir/dllmain.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/lsraarm64.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/dllmain.cpp.o
[ 97%] Linking CXX shared library libclrjit_win_x86_arm64.dylib
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simd.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/simdashwintrinsic.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/targetarm64.cpp.o
Undefined symbols for architecture arm64:
"RegSet::rsAllCalleeSavedMask", referenced from:
RegSet::rsGetModifiedCalleeSavedRegsMask() const in codegencommon.cpp.o
"RegSet::rsIntCalleeSavedMask", referenced from:
RegSet::rsGetModifiedIntCalleeSavedRegsMask() const in codegenxarch.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [jit/libclrjit_win_x86_arm64.dylib] Error 1
make[1]: *** [jit/CMakeFiles/clrjit_win_x86_arm64.dir/all] Error 2
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarmarch.cpp.o
[ 97%] Building CXX object jit/CMakeFiles/clrjit.dir/unwindarm64.cpp.o
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
@am11 - What machine are you building this on? can you share the command you are using and possibly the clang version?
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
$ uname -ms
Darwin arm64
$ clang --version | head -1
Apple clang version 15.0.0 (clang-1500.3.9.4)
@kunalspathak
kunalspathak
commented
May 23, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks. I realized that this fails only if building Debug. Checked and Release should build fine.
@kunalspathakkunalspathak
mentioned this pull request
May 23, 2024
 Merged

@LuckyXu-HFLuckyXu-HF
mentioned this pull request
May 24, 2024
 Merged

steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@kunalspathak@steveharter
Handle more than 64 registers - Part 2 (dotnet#102297)
480d371
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@kunalspathak@Ruihan-Yin
Handle more than 64 registers - Part 2 (dotnet#102297)
0cf4db0
* Make regMaskTP struct for non-arm64 platforms
* some refactoring
* jit format
* fix missing paranethesis in arm
* fix riscv64 and loongarch build
* minor change
* review feedback

This was referenced Jun 13, 2024
 Merged

 Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIPriority:2Work that is important, but not critical for the release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak@am11@jakobbotsch@JulieLeeMSFT