Skip to content

[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness - #102489

Merged
ericstj merged 10 commits into
mainfrom
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
May 23, 2024
Merged

[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness#102489
ericstj merged 10 commits into
mainfrom
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented May 21, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20240520.4
  • Date Produced: May 20, 2024 1:23:39 PM UTC
  • Commit: 8478d1a9a531e6b1cd26fb8c86400e2efbb8f2f3
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20240521.1
  • Date Produced: May 21, 2024 1:20:32 PM UTC
  • Commit: c185f58a7f75bd824a3cd820634cddf27e791d91
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20240521.3
  • Date Produced: May 21, 2024 1:08:46 PM UTC
  • Commit: 0f56bcca4c73d208ff8c21055fbb16dbb27a3d8a
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20240522.3
  • Date Produced: May 22, 2024 7:23:10 PM UTC
  • Commit: b83186a
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20240522.2
  • Date Produced: May 22, 2024 1:55:54 PM UTC
  • Commit: 68279e320a4b3156693b16ee23be942ed61e9412
  • Branch: refs/heads/dotnet/main

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
7415747
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@ghostghost added the area-codeflow for labeling automated codeflow label May 21, 2024
This was referenced May 21, 2024
Closed
Closed
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
cd8f624
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
015c6fb
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
54303e8
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024
This was referenced May 22, 2024
Open
Closed
Closed
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2024…
2d54626
…0522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024
@ericstj

ericstj commented May 22, 2024

Copy link
Copy Markdown
Member

We need this PR to merge to fix an issue if the latest Preview4 SDK is installed - projects will fail to compile because they cannot find AssemblyNameInfo and other types which were recently added to System.Reflection.Metadata. The problem is due to Preview4 having newer FileVersions than the preview5 System.Refelection.Metadata package currently referenced by the repository. A lovely side effect of rebuilding Preview4 and not encoding preview version in the file version - conflict resolution picks the newer file that has less API.

@ericstj

ericstj commented May 22, 2024

Copy link
Copy Markdown
Member

@sbomer @dotnet/illink can you help have a look at these new build errors:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=684773&view=logs&j=593e9dd6-bcc8-50e3-9fc7-5ded467090f9&t=c83b20c4-ec43-5271-6d5f-0f42a52778aa&l=4748

/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/__w/1/s/.packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error].packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1.

I see this change - but that was already consumed. 700d724

So perhaps this is due to the new MicrosoftDotNetILCompilerVersion?

@sbomer

sbomer commented May 22, 2024

Copy link
Copy Markdown
Member

Taking a look.

sbomerand others added 2 commits May 22, 2024 22:11
@sbomer
Disable _ComObjectDescriptorSupport in ILCompiler.csproj
a9b00ce
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20240522.2
67d851b
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 23, 2024
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
6fe578c
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
10dcb72
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
cfd84eb
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@akoeplingerakoeplinger mentioned this pull request May 23, 2024
Merged
@ericstj

ericstj commented May 23, 2024

Copy link
Copy Markdown
Member

@lewing@akoeplinger - a new WASM failure here:

[14:54:36] info: Initializing dotnet version 9.0.0-ci commit hash f13f27bfc5841b5ed10b67162c35d7bfd4856dfb
[14:54:36] info: Running in parallel with 8 threads.
[14:54:36] fail: [14:54:36] fail: Unhandled Exception:
[14:54:36] fail: System.TypeLoadException: Could not load type of field 'Mono.Options.OptionSet:ValueOption' (3) due to: Could not resolve type with token 0100002f from typeref (expected class 'System.Text.RegularExpressions.Regex' in assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51') assembly:netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 type:System.Text.RegularExpressions.Regex member:(null)
[14:54:36] fail: at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions..cctor()
[14:54:36] info: [0x000fb43c--UI- 14:54:36.940] MONO_WASM: Dumping web worker info as seen by UI thread, it could be stale:
[14:54:36] info: 000 | 0x000fb43c--UI-: isRunning: true isAttached: true isEventLoop:false reuseCount: 0 - UI Thread
[14:54:36] info: 001 | 0x01785ae8-dpty: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 002 | 0x03249620--IO-: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 003 | 0x037518d8-norm: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - Finalizer
[14:54:36] info: 004 | 0x03ca1860-pool: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Worker
[14:54:36] info: 005 | 0x03eaa7c8-gate: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Gate
[14:54:36] info: 006 | - : isRunning:false isAttached:false isEventLoop:false reuseCount: 0 - emscripten-pool
[14:54:36] fail: [0x000fb43c--UI- 14:54:36.997] MONO_WASM: The type initializer for 'Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions' threw an exception.
at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync()
at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
at WasmTestRunner.Main(String[] args)

Does that look like a flaky failure we can known issue or does it need investigation? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-102489-merge-d6bd7ef2134d48ce84/WasmTestOnFirefox-MT-Microsoft.Extensions.FileSystemGlobbing.Tests/1/console.2b559dea.log?helixlogtype=result

@akoeplinger

akoeplinger commented May 23, 2024

Copy link
Copy Markdown
Member

This seems unrelated.

@lewinglewing mentioned this pull request May 23, 2024
Open
@lewing

lewing commented May 23, 2024

Copy link
Copy Markdown
Member

I opened an KBE that should match

@ericstj

ericstj commented May 23, 2024

Copy link
Copy Markdown
Member

/ba-g #102615 should apply to the one test failure here. It didn't have the correct message query, I updated it, but it doesn't seem to be running. Merging this since it's blocking folks from using Preview4 + building runtime

@ericstj
ericstj merged commit 76367ca into mainMay 23, 2024
@dotnet-maestro
dotnet-maestroBot deleted the darc-main-36b1ef06-422d-448b-b4d2-2f186c062948 branch May 23, 2024 17:33
steveharter pushed a commit to steveharter/runtime that referenced this pull request May 28, 2024
@dotnet-maestro@sbomer@steveharter
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
327bb82
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@dotnet-maestro@sbomer@Ruihan-Yin
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
fe47590
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

No one assigned

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@sbomer@akoeplinger@lewing@stephentoub
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness by dotnet-maestro[bot] · Pull Request #102489 · dotnet/runtime · GitHub
Skip to content
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness - #102489
Merged
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
May 23, 2024
Merged
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness#102489
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20240520.4
  • Date Produced: May 20, 2024 1:23:39 PM UTC
  • Commit: 8478d1a9a531e6b1cd26fb8c86400e2efbb8f2f3
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20240521.1
  • Date Produced: May 21, 2024 1:20:32 PM UTC
  • Commit: c185f58a7f75bd824a3cd820634cddf27e791d91
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20240521.3
  • Date Produced: May 21, 2024 1:08:46 PM UTC
  • Commit: 0f56bcca4c73d208ff8c21055fbb16dbb27a3d8a
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20240522.3
  • Date Produced: May 22, 2024 7:23:10 PM UTC
  • Commit: b83186a
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20240522.2
  • Date Produced: May 22, 2024 1:55:54 PM UTC
  • Commit: 68279e320a4b3156693b16ee23be942ed61e9412
  • Branch: refs/heads/dotnet/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
7415747
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 21, 2024

This was referenced May 21, 2024

Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
cd8f624
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
015c6fb
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
54303e8
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024

This was referenced May 22, 2024

Open


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2024…
2d54626
…0522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
We need this PR to merge to fix an issue if the latest Preview4 SDK is installed - projects will fail to compile because they cannot find AssemblyNameInfo and other types which were recently added to System.Reflection.Metadata. The problem is due to Preview4 having newer FileVersions than the preview5 System.Refelection.Metadata package currently referenced by the repository. A lovely side effect of rebuilding Preview4 and not encoding preview version in the file version - conflict resolution picks the newer file that has less API.
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
@sbomer @dotnet/illink can you help have a look at these new build errors:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=684773&view=logs&j=593e9dd6-bcc8-50e3-9fc7-5ded467090f9&t=c83b20c4-ec43-5271-6d5f-0f42a52778aa&l=4748
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/__w/1/s/.packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error].packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1.

I see this change - but that was already consumed. 700d724
So perhaps this is due to the new MicrosoftDotNetILCompilerVersion?
@sbomer
sbomer
commented
May 22, 2024

Copy link


Copy Markdown

Member
Taking a look.
sbomerand others
added 2 commits
May 22, 2024 22:11
@sbomer
Disable _ComObjectDescriptorSupport in ILCompiler.csproj
a9b00ce
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20240522.2
67d851b
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 23, 2024
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
6fe578c
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
10dcb72
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
cfd84eb
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@akoeplingerakoeplinger
mentioned this pull request
May 23, 2024
 Merged

@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
@lewing@akoeplinger - a new WASM failure here:
[14:54:36] info: Initializing dotnet version 9.0.0-ci commit hash f13f27bfc5841b5ed10b67162c35d7bfd4856dfb
[14:54:36] info: Running in parallel with 8 threads.
[14:54:36] fail: [14:54:36] fail: Unhandled Exception:
[14:54:36] fail: System.TypeLoadException: Could not load type of field 'Mono.Options.OptionSet:ValueOption' (3) due to: Could not resolve type with token 0100002f from typeref (expected class 'System.Text.RegularExpressions.Regex' in assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51') assembly:netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 type:System.Text.RegularExpressions.Regex member:(null)
[14:54:36] fail: at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions..cctor()
[14:54:36] info: [0x000fb43c--UI- 14:54:36.940] MONO_WASM: Dumping web worker info as seen by UI thread, it could be stale:
[14:54:36] info: 000 | 0x000fb43c--UI-: isRunning: true isAttached: true isEventLoop:false reuseCount: 0 - UI Thread
[14:54:36] info: 001 | 0x01785ae8-dpty: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 002 | 0x03249620--IO-: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 003 | 0x037518d8-norm: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - Finalizer
[14:54:36] info: 004 | 0x03ca1860-pool: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Worker
[14:54:36] info: 005 | 0x03eaa7c8-gate: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Gate
[14:54:36] info: 006 | - : isRunning:false isAttached:false isEventLoop:false reuseCount: 0 - emscripten-pool
[14:54:36] fail: [0x000fb43c--UI- 14:54:36.997] MONO_WASM: The type initializer for 'Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions' threw an exception.
at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync()
at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
at WasmTestRunner.Main(String[] args)

Does that look like a flaky failure we can known issue or does it need investigation? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-102489-merge-d6bd7ef2134d48ce84/WasmTestOnFirefox-MT-Microsoft.Extensions.FileSystemGlobbing.Tests/1/console.2b559dea.log?helixlogtype=result
@akoeplinger
akoeplinger
commented
May 23, 2024

Copy link


Copy Markdown

Member
This seems unrelated.
@lewinglewing
mentioned this pull request
May 23, 2024

Open

@lewing
lewing
commented
May 23, 2024

Copy link


Copy Markdown

Member
I opened an KBE that should match
@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
/ba-g #102615 should apply to the one test failure here. It didn't have the correct message query, I updated it, but it doesn't seem to be running. Merging this since it's blocking folks from using Preview4 + building runtime
@ericstj
ericstj
merged commit 76367ca
into
mainMay 23, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-36b1ef06-422d-448b-b4d2-2f186c062948

branch
May 23, 2024 17:33
steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@dotnet-maestro@sbomer@steveharter
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
327bb82
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@dotnet-maestro@sbomer@Ruihan-Yin
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
fe47590
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@sbomer@akoeplinger@lewing@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness by dotnet-maestro[bot] · Pull Request #102489 · dotnet/runtime · GitHub
Skip to content
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness - #102489
Merged
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
May 23, 2024
Merged
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness#102489
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20240520.4
  • Date Produced: May 20, 2024 1:23:39 PM UTC
  • Commit: 8478d1a9a531e6b1cd26fb8c86400e2efbb8f2f3
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20240521.1
  • Date Produced: May 21, 2024 1:20:32 PM UTC
  • Commit: c185f58a7f75bd824a3cd820634cddf27e791d91
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20240521.3
  • Date Produced: May 21, 2024 1:08:46 PM UTC
  • Commit: 0f56bcca4c73d208ff8c21055fbb16dbb27a3d8a
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20240522.3
  • Date Produced: May 22, 2024 7:23:10 PM UTC
  • Commit: b83186a
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20240522.2
  • Date Produced: May 22, 2024 1:55:54 PM UTC
  • Commit: 68279e320a4b3156693b16ee23be942ed61e9412
  • Branch: refs/heads/dotnet/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
7415747
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 21, 2024

This was referenced May 21, 2024

Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
cd8f624
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
015c6fb
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
54303e8
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024

This was referenced May 22, 2024

Open


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2024…
2d54626
…0522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
We need this PR to merge to fix an issue if the latest Preview4 SDK is installed - projects will fail to compile because they cannot find AssemblyNameInfo and other types which were recently added to System.Reflection.Metadata. The problem is due to Preview4 having newer FileVersions than the preview5 System.Refelection.Metadata package currently referenced by the repository. A lovely side effect of rebuilding Preview4 and not encoding preview version in the file version - conflict resolution picks the newer file that has less API.
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
@sbomer @dotnet/illink can you help have a look at these new build errors:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=684773&view=logs&j=593e9dd6-bcc8-50e3-9fc7-5ded467090f9&t=c83b20c4-ec43-5271-6d5f-0f42a52778aa&l=4748
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/__w/1/s/.packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error].packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1.

I see this change - but that was already consumed. 700d724
So perhaps this is due to the new MicrosoftDotNetILCompilerVersion?
@sbomer
sbomer
commented
May 22, 2024

Copy link


Copy Markdown

Member
Taking a look.
sbomerand others
added 2 commits
May 22, 2024 22:11
@sbomer
Disable _ComObjectDescriptorSupport in ILCompiler.csproj
a9b00ce
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20240522.2
67d851b
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 23, 2024
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
6fe578c
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
10dcb72
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
cfd84eb
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@akoeplingerakoeplinger
mentioned this pull request
May 23, 2024
 Merged

@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
@lewing@akoeplinger - a new WASM failure here:
[14:54:36] info: Initializing dotnet version 9.0.0-ci commit hash f13f27bfc5841b5ed10b67162c35d7bfd4856dfb
[14:54:36] info: Running in parallel with 8 threads.
[14:54:36] fail: [14:54:36] fail: Unhandled Exception:
[14:54:36] fail: System.TypeLoadException: Could not load type of field 'Mono.Options.OptionSet:ValueOption' (3) due to: Could not resolve type with token 0100002f from typeref (expected class 'System.Text.RegularExpressions.Regex' in assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51') assembly:netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 type:System.Text.RegularExpressions.Regex member:(null)
[14:54:36] fail: at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions..cctor()
[14:54:36] info: [0x000fb43c--UI- 14:54:36.940] MONO_WASM: Dumping web worker info as seen by UI thread, it could be stale:
[14:54:36] info: 000 | 0x000fb43c--UI-: isRunning: true isAttached: true isEventLoop:false reuseCount: 0 - UI Thread
[14:54:36] info: 001 | 0x01785ae8-dpty: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 002 | 0x03249620--IO-: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 003 | 0x037518d8-norm: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - Finalizer
[14:54:36] info: 004 | 0x03ca1860-pool: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Worker
[14:54:36] info: 005 | 0x03eaa7c8-gate: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Gate
[14:54:36] info: 006 | - : isRunning:false isAttached:false isEventLoop:false reuseCount: 0 - emscripten-pool
[14:54:36] fail: [0x000fb43c--UI- 14:54:36.997] MONO_WASM: The type initializer for 'Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions' threw an exception.
at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync()
at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
at WasmTestRunner.Main(String[] args)

Does that look like a flaky failure we can known issue or does it need investigation? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-102489-merge-d6bd7ef2134d48ce84/WasmTestOnFirefox-MT-Microsoft.Extensions.FileSystemGlobbing.Tests/1/console.2b559dea.log?helixlogtype=result
@akoeplinger
akoeplinger
commented
May 23, 2024

Copy link


Copy Markdown

Member
This seems unrelated.
@lewinglewing
mentioned this pull request
May 23, 2024

Open

@lewing
lewing
commented
May 23, 2024

Copy link


Copy Markdown

Member
I opened an KBE that should match
@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
/ba-g #102615 should apply to the one test failure here. It didn't have the correct message query, I updated it, but it doesn't seem to be running. Merging this since it's blocking folks from using Preview4 + building runtime
@ericstj
ericstj
merged commit 76367ca
into
mainMay 23, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-36b1ef06-422d-448b-b4d2-2f186c062948

branch
May 23, 2024 17:33
steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@dotnet-maestro@sbomer@steveharter
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
327bb82
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@dotnet-maestro@sbomer@Ruihan-Yin
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
fe47590
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@sbomer@akoeplinger@lewing@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness by dotnet-maestro[bot] · Pull Request #102489 · dotnet/runtime · GitHub
Skip to content
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness - #102489
Merged
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
May 23, 2024
Merged
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness#102489
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20240520.4
  • Date Produced: May 20, 2024 1:23:39 PM UTC
  • Commit: 8478d1a9a531e6b1cd26fb8c86400e2efbb8f2f3
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20240521.1
  • Date Produced: May 21, 2024 1:20:32 PM UTC
  • Commit: c185f58a7f75bd824a3cd820634cddf27e791d91
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20240521.3
  • Date Produced: May 21, 2024 1:08:46 PM UTC
  • Commit: 0f56bcca4c73d208ff8c21055fbb16dbb27a3d8a
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20240522.3
  • Date Produced: May 22, 2024 7:23:10 PM UTC
  • Commit: b83186a
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20240522.2
  • Date Produced: May 22, 2024 1:55:54 PM UTC
  • Commit: 68279e320a4b3156693b16ee23be942ed61e9412
  • Branch: refs/heads/dotnet/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
7415747
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 21, 2024

This was referenced May 21, 2024

Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
cd8f624
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
015c6fb
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
54303e8
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024

This was referenced May 22, 2024

Open


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2024…
2d54626
…0522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
We need this PR to merge to fix an issue if the latest Preview4 SDK is installed - projects will fail to compile because they cannot find AssemblyNameInfo and other types which were recently added to System.Reflection.Metadata. The problem is due to Preview4 having newer FileVersions than the preview5 System.Refelection.Metadata package currently referenced by the repository. A lovely side effect of rebuilding Preview4 and not encoding preview version in the file version - conflict resolution picks the newer file that has less API.
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
@sbomer @dotnet/illink can you help have a look at these new build errors:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=684773&view=logs&j=593e9dd6-bcc8-50e3-9fc7-5ded467090f9&t=c83b20c4-ec43-5271-6d5f-0f42a52778aa&l=4748
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/__w/1/s/.packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error].packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1.

I see this change - but that was already consumed. 700d724
So perhaps this is due to the new MicrosoftDotNetILCompilerVersion?
@sbomer
sbomer
commented
May 22, 2024

Copy link


Copy Markdown

Member
Taking a look.
sbomerand others
added 2 commits
May 22, 2024 22:11
@sbomer
Disable _ComObjectDescriptorSupport in ILCompiler.csproj
a9b00ce
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20240522.2
67d851b
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 23, 2024
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
6fe578c
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
10dcb72
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
cfd84eb
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@akoeplingerakoeplinger
mentioned this pull request
May 23, 2024
 Merged

@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
@lewing@akoeplinger - a new WASM failure here:
[14:54:36] info: Initializing dotnet version 9.0.0-ci commit hash f13f27bfc5841b5ed10b67162c35d7bfd4856dfb
[14:54:36] info: Running in parallel with 8 threads.
[14:54:36] fail: [14:54:36] fail: Unhandled Exception:
[14:54:36] fail: System.TypeLoadException: Could not load type of field 'Mono.Options.OptionSet:ValueOption' (3) due to: Could not resolve type with token 0100002f from typeref (expected class 'System.Text.RegularExpressions.Regex' in assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51') assembly:netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 type:System.Text.RegularExpressions.Regex member:(null)
[14:54:36] fail: at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions..cctor()
[14:54:36] info: [0x000fb43c--UI- 14:54:36.940] MONO_WASM: Dumping web worker info as seen by UI thread, it could be stale:
[14:54:36] info: 000 | 0x000fb43c--UI-: isRunning: true isAttached: true isEventLoop:false reuseCount: 0 - UI Thread
[14:54:36] info: 001 | 0x01785ae8-dpty: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 002 | 0x03249620--IO-: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 003 | 0x037518d8-norm: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - Finalizer
[14:54:36] info: 004 | 0x03ca1860-pool: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Worker
[14:54:36] info: 005 | 0x03eaa7c8-gate: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Gate
[14:54:36] info: 006 | - : isRunning:false isAttached:false isEventLoop:false reuseCount: 0 - emscripten-pool
[14:54:36] fail: [0x000fb43c--UI- 14:54:36.997] MONO_WASM: The type initializer for 'Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions' threw an exception.
at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync()
at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
at WasmTestRunner.Main(String[] args)

Does that look like a flaky failure we can known issue or does it need investigation? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-102489-merge-d6bd7ef2134d48ce84/WasmTestOnFirefox-MT-Microsoft.Extensions.FileSystemGlobbing.Tests/1/console.2b559dea.log?helixlogtype=result
@akoeplinger
akoeplinger
commented
May 23, 2024

Copy link


Copy Markdown

Member
This seems unrelated.
@lewinglewing
mentioned this pull request
May 23, 2024

Open

@lewing
lewing
commented
May 23, 2024

Copy link


Copy Markdown

Member
I opened an KBE that should match
@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
/ba-g #102615 should apply to the one test failure here. It didn't have the correct message query, I updated it, but it doesn't seem to be running. Merging this since it's blocking folks from using Preview4 + building runtime
@ericstj
ericstj
merged commit 76367ca
into
mainMay 23, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-36b1ef06-422d-448b-b4d2-2f186c062948

branch
May 23, 2024 17:33
steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@dotnet-maestro@sbomer@steveharter
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
327bb82
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@dotnet-maestro@sbomer@Ruihan-Yin
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
fe47590
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@sbomer@akoeplinger@lewing@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness by dotnet-maestro[bot] · Pull Request #102489 · dotnet/runtime · GitHub
Skip to content
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness - #102489
Merged
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
May 23, 2024
Merged
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness#102489
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20240520.4
  • Date Produced: May 20, 2024 1:23:39 PM UTC
  • Commit: 8478d1a9a531e6b1cd26fb8c86400e2efbb8f2f3
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20240521.1
  • Date Produced: May 21, 2024 1:20:32 PM UTC
  • Commit: c185f58a7f75bd824a3cd820634cddf27e791d91
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20240521.3
  • Date Produced: May 21, 2024 1:08:46 PM UTC
  • Commit: 0f56bcca4c73d208ff8c21055fbb16dbb27a3d8a
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20240522.3
  • Date Produced: May 22, 2024 7:23:10 PM UTC
  • Commit: b83186a
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20240522.2
  • Date Produced: May 22, 2024 1:55:54 PM UTC
  • Commit: 68279e320a4b3156693b16ee23be942ed61e9412
  • Branch: refs/heads/dotnet/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
7415747
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 21, 2024

This was referenced May 21, 2024

Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
cd8f624
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
015c6fb
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
54303e8
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024

This was referenced May 22, 2024

Open


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2024…
2d54626
…0522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
We need this PR to merge to fix an issue if the latest Preview4 SDK is installed - projects will fail to compile because they cannot find AssemblyNameInfo and other types which were recently added to System.Reflection.Metadata. The problem is due to Preview4 having newer FileVersions than the preview5 System.Refelection.Metadata package currently referenced by the repository. A lovely side effect of rebuilding Preview4 and not encoding preview version in the file version - conflict resolution picks the newer file that has less API.
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
@sbomer @dotnet/illink can you help have a look at these new build errors:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=684773&view=logs&j=593e9dd6-bcc8-50e3-9fc7-5ded467090f9&t=c83b20c4-ec43-5271-6d5f-0f42a52778aa&l=4748
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/__w/1/s/.packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error].packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1.

I see this change - but that was already consumed. 700d724
So perhaps this is due to the new MicrosoftDotNetILCompilerVersion?
@sbomer
sbomer
commented
May 22, 2024

Copy link


Copy Markdown

Member
Taking a look.
sbomerand others
added 2 commits
May 22, 2024 22:11
@sbomer
Disable _ComObjectDescriptorSupport in ILCompiler.csproj
a9b00ce
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20240522.2
67d851b
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 23, 2024
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
6fe578c
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
10dcb72
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
cfd84eb
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@akoeplingerakoeplinger
mentioned this pull request
May 23, 2024
 Merged

@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
@lewing@akoeplinger - a new WASM failure here:
[14:54:36] info: Initializing dotnet version 9.0.0-ci commit hash f13f27bfc5841b5ed10b67162c35d7bfd4856dfb
[14:54:36] info: Running in parallel with 8 threads.
[14:54:36] fail: [14:54:36] fail: Unhandled Exception:
[14:54:36] fail: System.TypeLoadException: Could not load type of field 'Mono.Options.OptionSet:ValueOption' (3) due to: Could not resolve type with token 0100002f from typeref (expected class 'System.Text.RegularExpressions.Regex' in assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51') assembly:netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 type:System.Text.RegularExpressions.Regex member:(null)
[14:54:36] fail: at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions..cctor()
[14:54:36] info: [0x000fb43c--UI- 14:54:36.940] MONO_WASM: Dumping web worker info as seen by UI thread, it could be stale:
[14:54:36] info: 000 | 0x000fb43c--UI-: isRunning: true isAttached: true isEventLoop:false reuseCount: 0 - UI Thread
[14:54:36] info: 001 | 0x01785ae8-dpty: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 002 | 0x03249620--IO-: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 003 | 0x037518d8-norm: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - Finalizer
[14:54:36] info: 004 | 0x03ca1860-pool: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Worker
[14:54:36] info: 005 | 0x03eaa7c8-gate: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Gate
[14:54:36] info: 006 | - : isRunning:false isAttached:false isEventLoop:false reuseCount: 0 - emscripten-pool
[14:54:36] fail: [0x000fb43c--UI- 14:54:36.997] MONO_WASM: The type initializer for 'Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions' threw an exception.
at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync()
at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
at WasmTestRunner.Main(String[] args)

Does that look like a flaky failure we can known issue or does it need investigation? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-102489-merge-d6bd7ef2134d48ce84/WasmTestOnFirefox-MT-Microsoft.Extensions.FileSystemGlobbing.Tests/1/console.2b559dea.log?helixlogtype=result
@akoeplinger
akoeplinger
commented
May 23, 2024

Copy link


Copy Markdown

Member
This seems unrelated.
@lewinglewing
mentioned this pull request
May 23, 2024

Open

@lewing
lewing
commented
May 23, 2024

Copy link


Copy Markdown

Member
I opened an KBE that should match
@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
/ba-g #102615 should apply to the one test failure here. It didn't have the correct message query, I updated it, but it doesn't seem to be running. Merging this since it's blocking folks from using Preview4 + building runtime
@ericstj
ericstj
merged commit 76367ca
into
mainMay 23, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-36b1ef06-422d-448b-b4d2-2f186c062948

branch
May 23, 2024 17:33
steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@dotnet-maestro@sbomer@steveharter
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
327bb82
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@dotnet-maestro@sbomer@Ruihan-Yin
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
fe47590
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@sbomer@akoeplinger@lewing@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness by dotnet-maestro[bot] · Pull Request #102489 · dotnet/runtime · GitHub
Skip to content
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness - #102489
Merged
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
May 23, 2024
Merged
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness#102489
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20240520.4
  • Date Produced: May 20, 2024 1:23:39 PM UTC
  • Commit: 8478d1a9a531e6b1cd26fb8c86400e2efbb8f2f3
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20240521.1
  • Date Produced: May 21, 2024 1:20:32 PM UTC
  • Commit: c185f58a7f75bd824a3cd820634cddf27e791d91
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20240521.3
  • Date Produced: May 21, 2024 1:08:46 PM UTC
  • Commit: 0f56bcca4c73d208ff8c21055fbb16dbb27a3d8a
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20240522.3
  • Date Produced: May 22, 2024 7:23:10 PM UTC
  • Commit: b83186a
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20240522.2
  • Date Produced: May 22, 2024 1:55:54 PM UTC
  • Commit: 68279e320a4b3156693b16ee23be942ed61e9412
  • Branch: refs/heads/dotnet/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
7415747
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 21, 2024

This was referenced May 21, 2024

Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
cd8f624
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
015c6fb
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
54303e8
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024

This was referenced May 22, 2024

Open


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2024…
2d54626
…0522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
We need this PR to merge to fix an issue if the latest Preview4 SDK is installed - projects will fail to compile because they cannot find AssemblyNameInfo and other types which were recently added to System.Reflection.Metadata. The problem is due to Preview4 having newer FileVersions than the preview5 System.Refelection.Metadata package currently referenced by the repository. A lovely side effect of rebuilding Preview4 and not encoding preview version in the file version - conflict resolution picks the newer file that has less API.
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
@sbomer @dotnet/illink can you help have a look at these new build errors:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=684773&view=logs&j=593e9dd6-bcc8-50e3-9fc7-5ded467090f9&t=c83b20c4-ec43-5271-6d5f-0f42a52778aa&l=4748
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/__w/1/s/.packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error].packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1.

I see this change - but that was already consumed. 700d724
So perhaps this is due to the new MicrosoftDotNetILCompilerVersion?
@sbomer
sbomer
commented
May 22, 2024

Copy link


Copy Markdown

Member
Taking a look.
sbomerand others
added 2 commits
May 22, 2024 22:11
@sbomer
Disable _ComObjectDescriptorSupport in ILCompiler.csproj
a9b00ce
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20240522.2
67d851b
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 23, 2024
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
6fe578c
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
10dcb72
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
cfd84eb
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@akoeplingerakoeplinger
mentioned this pull request
May 23, 2024
 Merged

@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
@lewing@akoeplinger - a new WASM failure here:
[14:54:36] info: Initializing dotnet version 9.0.0-ci commit hash f13f27bfc5841b5ed10b67162c35d7bfd4856dfb
[14:54:36] info: Running in parallel with 8 threads.
[14:54:36] fail: [14:54:36] fail: Unhandled Exception:
[14:54:36] fail: System.TypeLoadException: Could not load type of field 'Mono.Options.OptionSet:ValueOption' (3) due to: Could not resolve type with token 0100002f from typeref (expected class 'System.Text.RegularExpressions.Regex' in assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51') assembly:netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 type:System.Text.RegularExpressions.Regex member:(null)
[14:54:36] fail: at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions..cctor()
[14:54:36] info: [0x000fb43c--UI- 14:54:36.940] MONO_WASM: Dumping web worker info as seen by UI thread, it could be stale:
[14:54:36] info: 000 | 0x000fb43c--UI-: isRunning: true isAttached: true isEventLoop:false reuseCount: 0 - UI Thread
[14:54:36] info: 001 | 0x01785ae8-dpty: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 002 | 0x03249620--IO-: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 003 | 0x037518d8-norm: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - Finalizer
[14:54:36] info: 004 | 0x03ca1860-pool: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Worker
[14:54:36] info: 005 | 0x03eaa7c8-gate: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Gate
[14:54:36] info: 006 | - : isRunning:false isAttached:false isEventLoop:false reuseCount: 0 - emscripten-pool
[14:54:36] fail: [0x000fb43c--UI- 14:54:36.997] MONO_WASM: The type initializer for 'Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions' threw an exception.
at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync()
at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
at WasmTestRunner.Main(String[] args)

Does that look like a flaky failure we can known issue or does it need investigation? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-102489-merge-d6bd7ef2134d48ce84/WasmTestOnFirefox-MT-Microsoft.Extensions.FileSystemGlobbing.Tests/1/console.2b559dea.log?helixlogtype=result
@akoeplinger
akoeplinger
commented
May 23, 2024

Copy link


Copy Markdown

Member
This seems unrelated.
@lewinglewing
mentioned this pull request
May 23, 2024

Open

@lewing
lewing
commented
May 23, 2024

Copy link


Copy Markdown

Member
I opened an KBE that should match
@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
/ba-g #102615 should apply to the one test failure here. It didn't have the correct message query, I updated it, but it doesn't seem to be running. Merging this since it's blocking folks from using Preview4 + building runtime
@ericstj
ericstj
merged commit 76367ca
into
mainMay 23, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-36b1ef06-422d-448b-b4d2-2f186c062948

branch
May 23, 2024 17:33
steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@dotnet-maestro@sbomer@steveharter
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
327bb82
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@dotnet-maestro@sbomer@Ruihan-Yin
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
fe47590
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@sbomer@akoeplinger@lewing@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness by dotnet-maestro[bot] · Pull Request #102489 · dotnet/runtime · GitHub
Skip to content
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness - #102489
Merged
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
May 23, 2024
Merged
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness#102489
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20240520.4
  • Date Produced: May 20, 2024 1:23:39 PM UTC
  • Commit: 8478d1a9a531e6b1cd26fb8c86400e2efbb8f2f3
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20240521.1
  • Date Produced: May 21, 2024 1:20:32 PM UTC
  • Commit: c185f58a7f75bd824a3cd820634cddf27e791d91
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20240521.3
  • Date Produced: May 21, 2024 1:08:46 PM UTC
  • Commit: 0f56bcca4c73d208ff8c21055fbb16dbb27a3d8a
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20240522.3
  • Date Produced: May 22, 2024 7:23:10 PM UTC
  • Commit: b83186a
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20240522.2
  • Date Produced: May 22, 2024 1:55:54 PM UTC
  • Commit: 68279e320a4b3156693b16ee23be942ed61e9412
  • Branch: refs/heads/dotnet/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
7415747
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 21, 2024

This was referenced May 21, 2024

Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
cd8f624
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
015c6fb
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
54303e8
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024

This was referenced May 22, 2024

Open


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2024…
2d54626
…0522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
We need this PR to merge to fix an issue if the latest Preview4 SDK is installed - projects will fail to compile because they cannot find AssemblyNameInfo and other types which were recently added to System.Reflection.Metadata. The problem is due to Preview4 having newer FileVersions than the preview5 System.Refelection.Metadata package currently referenced by the repository. A lovely side effect of rebuilding Preview4 and not encoding preview version in the file version - conflict resolution picks the newer file that has less API.
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
@sbomer @dotnet/illink can you help have a look at these new build errors:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=684773&view=logs&j=593e9dd6-bcc8-50e3-9fc7-5ded467090f9&t=c83b20c4-ec43-5271-6d5f-0f42a52778aa&l=4748
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/__w/1/s/.packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error].packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1.

I see this change - but that was already consumed. 700d724
So perhaps this is due to the new MicrosoftDotNetILCompilerVersion?
@sbomer
sbomer
commented
May 22, 2024

Copy link


Copy Markdown

Member
Taking a look.
sbomerand others
added 2 commits
May 22, 2024 22:11
@sbomer
Disable _ComObjectDescriptorSupport in ILCompiler.csproj
a9b00ce
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20240522.2
67d851b
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 23, 2024
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
6fe578c
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
10dcb72
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
cfd84eb
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@akoeplingerakoeplinger
mentioned this pull request
May 23, 2024
 Merged

@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
@lewing@akoeplinger - a new WASM failure here:
[14:54:36] info: Initializing dotnet version 9.0.0-ci commit hash f13f27bfc5841b5ed10b67162c35d7bfd4856dfb
[14:54:36] info: Running in parallel with 8 threads.
[14:54:36] fail: [14:54:36] fail: Unhandled Exception:
[14:54:36] fail: System.TypeLoadException: Could not load type of field 'Mono.Options.OptionSet:ValueOption' (3) due to: Could not resolve type with token 0100002f from typeref (expected class 'System.Text.RegularExpressions.Regex' in assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51') assembly:netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 type:System.Text.RegularExpressions.Regex member:(null)
[14:54:36] fail: at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions..cctor()
[14:54:36] info: [0x000fb43c--UI- 14:54:36.940] MONO_WASM: Dumping web worker info as seen by UI thread, it could be stale:
[14:54:36] info: 000 | 0x000fb43c--UI-: isRunning: true isAttached: true isEventLoop:false reuseCount: 0 - UI Thread
[14:54:36] info: 001 | 0x01785ae8-dpty: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 002 | 0x03249620--IO-: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 003 | 0x037518d8-norm: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - Finalizer
[14:54:36] info: 004 | 0x03ca1860-pool: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Worker
[14:54:36] info: 005 | 0x03eaa7c8-gate: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Gate
[14:54:36] info: 006 | - : isRunning:false isAttached:false isEventLoop:false reuseCount: 0 - emscripten-pool
[14:54:36] fail: [0x000fb43c--UI- 14:54:36.997] MONO_WASM: The type initializer for 'Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions' threw an exception.
at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync()
at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
at WasmTestRunner.Main(String[] args)

Does that look like a flaky failure we can known issue or does it need investigation? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-102489-merge-d6bd7ef2134d48ce84/WasmTestOnFirefox-MT-Microsoft.Extensions.FileSystemGlobbing.Tests/1/console.2b559dea.log?helixlogtype=result
@akoeplinger
akoeplinger
commented
May 23, 2024

Copy link


Copy Markdown

Member
This seems unrelated.
@lewinglewing
mentioned this pull request
May 23, 2024

Open

@lewing
lewing
commented
May 23, 2024

Copy link


Copy Markdown

Member
I opened an KBE that should match
@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
/ba-g #102615 should apply to the one test failure here. It didn't have the correct message query, I updated it, but it doesn't seem to be running. Merging this since it's blocking folks from using Preview4 + building runtime
@ericstj
ericstj
merged commit 76367ca
into
mainMay 23, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-36b1ef06-422d-448b-b4d2-2f186c062948

branch
May 23, 2024 17:33
steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@dotnet-maestro@sbomer@steveharter
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
327bb82
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@dotnet-maestro@sbomer@Ruihan-Yin
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
fe47590
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@sbomer@akoeplinger@lewing@stephentoub

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness by dotnet-maestro[bot] · Pull Request #102489 · dotnet/runtime · GitHub
Skip to content
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness - #102489
Merged
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
May 23, 2024
Merged
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness#102489
ericstj merged 10 commits into
mainfrom 
darc-main-36b1ef06-422d-448b-b4d2-2f186c062948
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 21, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/xharness
  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20240520.4
  • Date Produced: May 20, 2024 1:23:39 PM UTC
  • Commit: 8478d1a9a531e6b1cd26fb8c86400e2efbb8f2f3
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime-assets
  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20240521.1
  • Date Produced: May 21, 2024 1:20:32 PM UTC
  • Commit: c185f58a7f75bd824a3cd820634cddf27e791d91
  • Branch: refs/heads/main
From https://github.com/dotnet/hotreload-utils
  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20240521.3
  • Date Produced: May 21, 2024 1:08:46 PM UTC
  • Commit: 0f56bcca4c73d208ff8c21055fbb16dbb27a3d8a
  • Branch: refs/heads/main
From https://github.com/dotnet/runtime
  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20240522.3
  • Date Produced: May 22, 2024 7:23:10 PM UTC
  • Commit: b83186a
  • Branch: refs/heads/main
From https://github.com/dotnet/icu
  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20240522.2
  • Date Produced: May 22, 2024 1:55:54 PM UTC
  • Commit: 68279e320a4b3156693b16ee23be942ed61e9412
  • Branch: refs/heads/dotnet/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
7415747
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 21, 2024

This was referenced May 21, 2024

Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
cd8f624
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
015c6fb
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
54303e8
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024

This was referenced May 22, 2024

Open


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtimebuild 2024…
2d54626
…0522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 22, 2024
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
We need this PR to merge to fix an issue if the latest Preview4 SDK is installed - projects will fail to compile because they cannot find AssemblyNameInfo and other types which were recently added to System.Reflection.Metadata. The problem is due to Preview4 having newer FileVersions than the preview5 System.Refelection.Metadata package currently referenced by the repository. A lovely side effect of rebuilding Preview4 and not encoding preview version in the file version - conflict resolution picks the newer file that has less API.
@ericstj
ericstj
commented
May 22, 2024

Copy link


Copy Markdown

Member
@sbomer @dotnet/illink can you help have a look at these new build errors:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=684773&view=logs&j=593e9dd6-bcc8-50e3-9fc7-5ded467090f9&t=c83b20c4-ec43-5271-6d5f-0f42a52778aa&l=4748
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1745,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760): Trim analysis error IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error]/_/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs(1760,0): error IL2026: (NETCORE_ENGINEERING_TELEMETRY=Build) System.ComponentModel.TypeDescriptor.NodeFor(Object,Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.
/__w/1/s/.packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1. [/__w/1/s/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj]
##[error].packages/microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/build/Microsoft.NETCore.Native.targets(310,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/__w/1/s/.packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.5.24272.3/tools/ilc" @"/__w/1/s/artifacts/obj/coreclr/ILCompiler/linux.arm64.Release/native/ilc.ilc.rsp"" exited with code -1.

I see this change - but that was already consumed. 700d724
So perhaps this is due to the new MicrosoftDotNetILCompilerVersion?
@sbomer
sbomer
commented
May 22, 2024

Copy link


Copy Markdown

Member
Taking a look.
sbomerand others
added 2 commits
May 22, 2024 22:11
@sbomer
Disable _ComObjectDescriptorSupport in ILCompiler.csproj
a9b00ce
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/icubuild 20240522.2
67d851b
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
@dotnet-maestrodotnet-maestroBot
changed the title
[main] Update dependencies from dotnet/hotreload-utils, dotnet/runtime, dotnet/runtime-assets, dotnet/xharness[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, dotnet/runtime, dotnet/runtime-assets, dotnet/xharnessMay 23, 2024
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
6fe578c
…40520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
10dcb72
…ld 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
cfd84eb
…ild 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
@akoeplingerakoeplinger
mentioned this pull request
May 23, 2024
 Merged

@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
@lewing@akoeplinger - a new WASM failure here:
[14:54:36] info: Initializing dotnet version 9.0.0-ci commit hash f13f27bfc5841b5ed10b67162c35d7bfd4856dfb
[14:54:36] info: Running in parallel with 8 threads.
[14:54:36] fail: [14:54:36] fail: Unhandled Exception:
[14:54:36] fail: System.TypeLoadException: Could not load type of field 'Mono.Options.OptionSet:ValueOption' (3) due to: Could not resolve type with token 0100002f from typeref (expected class 'System.Text.RegularExpressions.Regex' in assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51') assembly:netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 type:System.Text.RegularExpressions.Regex member:(null)
[14:54:36] fail: at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions..cctor()
[14:54:36] info: [0x000fb43c--UI- 14:54:36.940] MONO_WASM: Dumping web worker info as seen by UI thread, it could be stale:
[14:54:36] info: 000 | 0x000fb43c--UI-: isRunning: true isAttached: true isEventLoop:false reuseCount: 0 - UI Thread
[14:54:36] info: 001 | 0x01785ae8-dpty: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 002 | 0x03249620--IO-: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 -
[14:54:36] info: 003 | 0x037518d8-norm: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - Finalizer
[14:54:36] info: 004 | 0x03ca1860-pool: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Worker
[14:54:36] info: 005 | 0x03eaa7c8-gate: isRunning: true isAttached: true isEventLoop:false reuseCount: 1 - .NET TP Gate
[14:54:36] info: 006 | - : isRunning:false isAttached:false isEventLoop:false reuseCount: 0 - emscripten-pool
[14:54:36] fail: [0x000fb43c--UI- 14:54:36.997] MONO_WASM: The type initializer for 'Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationOptions' threw an exception.
at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync()
at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
at WasmTestRunner.Main(String[] args)

Does that look like a flaky failure we can known issue or does it need investigation? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-102489-merge-d6bd7ef2134d48ce84/WasmTestOnFirefox-MT-Microsoft.Extensions.FileSystemGlobbing.Tests/1/console.2b559dea.log?helixlogtype=result
@akoeplinger
akoeplinger
commented
May 23, 2024

Copy link


Copy Markdown

Member
This seems unrelated.
@lewinglewing
mentioned this pull request
May 23, 2024

Open

@lewing
lewing
commented
May 23, 2024

Copy link


Copy Markdown

Member
I opened an KBE that should match
@ericstj
ericstj
commented
May 23, 2024

Copy link


Copy Markdown

Member
/ba-g #102615 should apply to the one test failure here. It didn't have the correct message query, I updated it, but it doesn't seem to be running. Merging this since it's blocking folks from using Preview4 + building runtime
@ericstj
ericstj
merged commit 76367ca
into
mainMay 23, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-36b1ef06-422d-448b-b4d2-2f186c062948

branch
May 23, 2024 17:33
steveharter pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
@dotnet-maestro@sbomer@steveharter
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
327bb82
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@dotnet-maestro@sbomer@Ruihan-Yin
[main] Update dependencies from dotnet/hotreload-utils, dotnet/icu, d…
fe47590
…otnet/runtime, dotnet/runtime-assets, dotnet/xharness (dotnet#102489)
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
* Update dependencies from https://github.com/dotnet/runtime build 20240522.3
Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.5.24262.2 -> To Version 9.0.0-preview.5.24272.3
* Disable _ComObjectDescriptorSupport in ILCompiler.csproj
* Update dependencies from https://github.com/dotnet/icu build 20240522.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 9.0.0-preview.5.24263.1 -> To Version 9.0.0-preview.6.24272.2
* Update dependencies from https://github.com/dotnet/xharness build 20240520.4
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 9.0.0-prerelease.24266.1 -> To Version 9.0.0-prerelease.24270.4
* Update dependencies from https://github.com/dotnet/runtime-assets build 20240521.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 9.0.0-beta.24263.1 -> To Version 9.0.0-beta.24271.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20240521.3
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 9.0.0-alpha.0.24263.1 -> To Version 9.0.0-alpha.0.24271.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@ericstj@sbomer@akoeplinger@lewing@stephentoub