Optimize HttpUtility.UrlPathEncode allocations. by TrayanZapryanov · Pull Request #102823 · dotnet/runtime

TrayanZapryanov · 2024-05-29T15:03:19Z

Omit intermediate string allocations by using Ranges.
Use stackalloc arrays when input is small enough for encoding and ASCII conversions.
Remove string.Contains(' ') loop.

dotnet-policy-service · 2024-05-29T15:03:55Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

TrayanZapryanov · 2024-05-29T15:12:07Z

Benchmark:

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark(Baseline=true)]publicstringUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	260.7 ns	2.41 ns	2.01 ns	1.00	0.00	0.0277	232 B	1.00
UrlPathEncode	338.5 ns	6.03 ns	5.64 ns	1.30	0.02	0.0839	704 B	3.03
UrlPathEncode_PR	325.4 ns	4.59 ns	4.30 ns	1.25	0.02	0.0658	552 B	2.38

MihaZupan · 2024-05-29T18:11:44Z

 }

- private static byte[] UrlEncodeNonAscii(byte[] bytes, int offset, int count)
+ private static string UrlEncodeNonAscii(Span<byte> bytes)


These methods are still allocating quite a bit (the original string even if it's already Ascii, substring and combined string in UrlPathEncodeImpl ...).
The 1 caller of this helper is using Encoding.UTF8 and wants to stop after you see a ?.
Assuming there's sufficient test coverage, I would change this to instead look something like
privatestaticstringUrlPathEncodeImpl(stringvalue){inti=value.AsSpan().IndexOfAnyExceptInRange((char)0x21,(char)0x7F);if(i<0){returnvalue;}intindexOfQuery=value.IndexOf('?');if(indexOfQuery>=0&&indexOfQuery<i){// Everything before the Query is valid ASCIIreturnvalue;}ReadOnlySpan<char>toEncode=indexOfQuery>=0?value.AsSpan(i,indexOfQuery-i):value.AsSpan(i);byte[]bytes=ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetMaxByteCount(toEncode.Length));char[]chars=ArrayPool<char>.Shared.Rent(bytes.Length*3);intutf8Length=Encoding.UTF8.GetBytes(toEncode,bytes);intcharCount=0;foreach(bytebinbytes.AsSpan(0,utf8Length)){if(IsNonAsciiOrSpaceByte(b)){chars[charCount++]='%';chars[charCount++]=HexConverter.ToCharLower(b>>4);chars[charCount++]=HexConverter.ToCharLower(b);}else{chars[charCount++]=(char)b;}}ArrayPool<byte>.Shared.Return(bytes);stringresult=string.Concat(value.AsSpan(0,i),chars.AsSpan(0,charCount),indexOfQuery>=0?value.AsSpan(indexOfQuery):ReadOnlySpan<char>.Empty);ArrayPool<char>.Shared.Return(chars);returnresult;}
This would avoid a bunch of intermediate allocations and transcoding.

MihaZupan · 2024-05-29T18:14:41Z

+ schemeAndAuthority = default(Range);
+ path = Range.All;
+ queryAndFragment = default(Range);


Suggested change
schemeAndAuthority=default(Range);
path=Range.All;
queryAndFragment=default(Range);
returnUrlPathEncodeImpl(value);
Otherwise you would end up allocating a substring for value.AsSpan(path).ToString() + a substring for the string.Concat.

MihaZupan · 2024-05-29T18:16:00Z

 }

- return schemeAndAuthority + UrlPathEncodeImpl(path) + queryAndFragment;
+ return string.Concat(value.AsSpan(schemeAndAuthority), UrlPathEncodeImpl(value.AsSpan(path).ToString()), value.AsSpan(queryAndFragment));


This could be combined into the whole UrlPathEncodeImpl to avoid the substring allocations

MihaZupan · 2024-05-29T18:28:04Z

 // Even if this method returns true, one or more of the out parameters might contain a null or empty string, e.g. if there is no query / fragment.
 // Concatenating the pieces back together will form the original input string.
- internal static bool TrySplitUriForPathEncode(string input, [NotNullWhen(true)] out string? schemeAndAuthority, [NotNullWhen(true)] out string? path, out string? queryAndFragment)
+ internal static bool TrySplitUriForPathEncode(string input, out Range schemeAndAuthority, out Range path, out Range queryAndFragment)


By forcing everything into spans and ranges, you are now also allocating substrings where you might not have needed to previously. E.g. if pathRange is Range.All, you're reallocating the original string.
You could inline ExtractQueryAndFragment into this method, and always use Substring for the path portion.
I would also suggest returning Span instead of Range as it's easier to use given that the callers only need the range to make the span anyway.

TrayanZapryanov · 2024-05-29T19:47:49Z

@MihaZupan Sorry I messed git while trying to rebase after merging previous PRs.
Sorry for the stupid question, but can you tell me how you are updating older branches to latest version without closing existing PR.
Meanwhile I will try to open another PR with your comments integrated.

MihaZupan · 2024-05-29T20:24:06Z

Assuming upstream is this repo and origin is your fork, my workflow looks something like

git checkout main
git pull upstream
git checkout your-branch
git rebase main // And now fix any conflicts
git push origin -f

TrayanZapryanov · 2024-05-29T15:03:19Z

Omit intermediate string allocations by using Ranges.
Use stackalloc arrays when input is small enough for encoding and ASCII conversions.
Remove string.Contains(' ') loop.

dotnet-policy-service · 2024-05-29T15:03:55Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

TrayanZapryanov · 2024-05-29T15:12:07Z

Benchmark:

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark(Baseline=true)]publicstringUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	260.7 ns	2.41 ns	2.01 ns	1.00	0.00	0.0277	232 B	1.00
UrlPathEncode	338.5 ns	6.03 ns	5.64 ns	1.30	0.02	0.0839	704 B	3.03
UrlPathEncode_PR	325.4 ns	4.59 ns	4.30 ns	1.25	0.02	0.0658	552 B	2.38

MihaZupan · 2024-05-29T18:11:44Z

 }

- private static byte[] UrlEncodeNonAscii(byte[] bytes, int offset, int count)
+ private static string UrlEncodeNonAscii(Span<byte> bytes)


These methods are still allocating quite a bit (the original string even if it's already Ascii, substring and combined string in UrlPathEncodeImpl ...).
The 1 caller of this helper is using Encoding.UTF8 and wants to stop after you see a ?.
Assuming there's sufficient test coverage, I would change this to instead look something like
privatestaticstringUrlPathEncodeImpl(stringvalue){inti=value.AsSpan().IndexOfAnyExceptInRange((char)0x21,(char)0x7F);if(i<0){returnvalue;}intindexOfQuery=value.IndexOf('?');if(indexOfQuery>=0&&indexOfQuery<i){// Everything before the Query is valid ASCIIreturnvalue;}ReadOnlySpan<char>toEncode=indexOfQuery>=0?value.AsSpan(i,indexOfQuery-i):value.AsSpan(i);byte[]bytes=ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetMaxByteCount(toEncode.Length));char[]chars=ArrayPool<char>.Shared.Rent(bytes.Length*3);intutf8Length=Encoding.UTF8.GetBytes(toEncode,bytes);intcharCount=0;foreach(bytebinbytes.AsSpan(0,utf8Length)){if(IsNonAsciiOrSpaceByte(b)){chars[charCount++]='%';chars[charCount++]=HexConverter.ToCharLower(b>>4);chars[charCount++]=HexConverter.ToCharLower(b);}else{chars[charCount++]=(char)b;}}ArrayPool<byte>.Shared.Return(bytes);stringresult=string.Concat(value.AsSpan(0,i),chars.AsSpan(0,charCount),indexOfQuery>=0?value.AsSpan(indexOfQuery):ReadOnlySpan<char>.Empty);ArrayPool<char>.Shared.Return(chars);returnresult;}
This would avoid a bunch of intermediate allocations and transcoding.

MihaZupan · 2024-05-29T18:14:41Z

+ schemeAndAuthority = default(Range);
+ path = Range.All;
+ queryAndFragment = default(Range);


Suggested change
schemeAndAuthority=default(Range);
path=Range.All;
queryAndFragment=default(Range);
returnUrlPathEncodeImpl(value);
Otherwise you would end up allocating a substring for value.AsSpan(path).ToString() + a substring for the string.Concat.

MihaZupan · 2024-05-29T18:16:00Z

 }

- return schemeAndAuthority + UrlPathEncodeImpl(path) + queryAndFragment;
+ return string.Concat(value.AsSpan(schemeAndAuthority), UrlPathEncodeImpl(value.AsSpan(path).ToString()), value.AsSpan(queryAndFragment));


This could be combined into the whole UrlPathEncodeImpl to avoid the substring allocations

MihaZupan · 2024-05-29T18:28:04Z

 // Even if this method returns true, one or more of the out parameters might contain a null or empty string, e.g. if there is no query / fragment.
 // Concatenating the pieces back together will form the original input string.
- internal static bool TrySplitUriForPathEncode(string input, [NotNullWhen(true)] out string? schemeAndAuthority, [NotNullWhen(true)] out string? path, out string? queryAndFragment)
+ internal static bool TrySplitUriForPathEncode(string input, out Range schemeAndAuthority, out Range path, out Range queryAndFragment)


By forcing everything into spans and ranges, you are now also allocating substrings where you might not have needed to previously. E.g. if pathRange is Range.All, you're reallocating the original string.
You could inline ExtractQueryAndFragment into this method, and always use Substring for the path portion.
I would also suggest returning Span instead of Range as it's easier to use given that the callers only need the range to make the span anyway.

TrayanZapryanov · 2024-05-29T19:47:49Z

@MihaZupan Sorry I messed git while trying to rebase after merging previous PRs.
Sorry for the stupid question, but can you tell me how you are updating older branches to latest version without closing existing PR.
Meanwhile I will try to open another PR with your comments integrated.

MihaZupan · 2024-05-29T20:24:06Z

Assuming upstream is this repo and origin is your fork, my workflow looks something like

git checkout main
git pull upstream
git checkout your-branch
git rebase main // And now fix any conflicts
git push origin -f

TrayanZapryanov · 2024-05-29T15:03:19Z

Omit intermediate string allocations by using Ranges.
Use stackalloc arrays when input is small enough for encoding and ASCII conversions.
Remove string.Contains(' ') loop.

dotnet-policy-service · 2024-05-29T15:03:55Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

TrayanZapryanov · 2024-05-29T15:12:07Z

Benchmark:

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark(Baseline=true)]publicstringUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	260.7 ns	2.41 ns	2.01 ns	1.00	0.00	0.0277	232 B	1.00
UrlPathEncode	338.5 ns	6.03 ns	5.64 ns	1.30	0.02	0.0839	704 B	3.03
UrlPathEncode_PR	325.4 ns	4.59 ns	4.30 ns	1.25	0.02	0.0658	552 B	2.38

MihaZupan · 2024-05-29T18:11:44Z

 }

- private static byte[] UrlEncodeNonAscii(byte[] bytes, int offset, int count)
+ private static string UrlEncodeNonAscii(Span<byte> bytes)


These methods are still allocating quite a bit (the original string even if it's already Ascii, substring and combined string in UrlPathEncodeImpl ...).
The 1 caller of this helper is using Encoding.UTF8 and wants to stop after you see a ?.
Assuming there's sufficient test coverage, I would change this to instead look something like
privatestaticstringUrlPathEncodeImpl(stringvalue){inti=value.AsSpan().IndexOfAnyExceptInRange((char)0x21,(char)0x7F);if(i<0){returnvalue;}intindexOfQuery=value.IndexOf('?');if(indexOfQuery>=0&&indexOfQuery<i){// Everything before the Query is valid ASCIIreturnvalue;}ReadOnlySpan<char>toEncode=indexOfQuery>=0?value.AsSpan(i,indexOfQuery-i):value.AsSpan(i);byte[]bytes=ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetMaxByteCount(toEncode.Length));char[]chars=ArrayPool<char>.Shared.Rent(bytes.Length*3);intutf8Length=Encoding.UTF8.GetBytes(toEncode,bytes);intcharCount=0;foreach(bytebinbytes.AsSpan(0,utf8Length)){if(IsNonAsciiOrSpaceByte(b)){chars[charCount++]='%';chars[charCount++]=HexConverter.ToCharLower(b>>4);chars[charCount++]=HexConverter.ToCharLower(b);}else{chars[charCount++]=(char)b;}}ArrayPool<byte>.Shared.Return(bytes);stringresult=string.Concat(value.AsSpan(0,i),chars.AsSpan(0,charCount),indexOfQuery>=0?value.AsSpan(indexOfQuery):ReadOnlySpan<char>.Empty);ArrayPool<char>.Shared.Return(chars);returnresult;}
This would avoid a bunch of intermediate allocations and transcoding.

MihaZupan · 2024-05-29T18:14:41Z

+ schemeAndAuthority = default(Range);
+ path = Range.All;
+ queryAndFragment = default(Range);


Suggested change
schemeAndAuthority=default(Range);
path=Range.All;
queryAndFragment=default(Range);
returnUrlPathEncodeImpl(value);
Otherwise you would end up allocating a substring for value.AsSpan(path).ToString() + a substring for the string.Concat.

MihaZupan · 2024-05-29T18:16:00Z

 }

- return schemeAndAuthority + UrlPathEncodeImpl(path) + queryAndFragment;
+ return string.Concat(value.AsSpan(schemeAndAuthority), UrlPathEncodeImpl(value.AsSpan(path).ToString()), value.AsSpan(queryAndFragment));


This could be combined into the whole UrlPathEncodeImpl to avoid the substring allocations

MihaZupan · 2024-05-29T18:28:04Z

 // Even if this method returns true, one or more of the out parameters might contain a null or empty string, e.g. if there is no query / fragment.
 // Concatenating the pieces back together will form the original input string.
- internal static bool TrySplitUriForPathEncode(string input, [NotNullWhen(true)] out string? schemeAndAuthority, [NotNullWhen(true)] out string? path, out string? queryAndFragment)
+ internal static bool TrySplitUriForPathEncode(string input, out Range schemeAndAuthority, out Range path, out Range queryAndFragment)


By forcing everything into spans and ranges, you are now also allocating substrings where you might not have needed to previously. E.g. if pathRange is Range.All, you're reallocating the original string.
You could inline ExtractQueryAndFragment into this method, and always use Substring for the path portion.
I would also suggest returning Span instead of Range as it's easier to use given that the callers only need the range to make the span anyway.

TrayanZapryanov · 2024-05-29T19:47:49Z

@MihaZupan Sorry I messed git while trying to rebase after merging previous PRs.
Sorry for the stupid question, but can you tell me how you are updating older branches to latest version without closing existing PR.
Meanwhile I will try to open another PR with your comments integrated.

MihaZupan · 2024-05-29T20:24:06Z

Assuming upstream is this repo and origin is your fork, my workflow looks something like

git checkout main
git pull upstream
git checkout your-branch
git rebase main // And now fix any conflicts
git push origin -f

TrayanZapryanov · 2024-05-29T15:03:19Z

Omit intermediate string allocations by using Ranges.
Use stackalloc arrays when input is small enough for encoding and ASCII conversions.
Remove string.Contains(' ') loop.

dotnet-policy-service · 2024-05-29T15:03:55Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

TrayanZapryanov · 2024-05-29T15:12:07Z

Benchmark:

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark(Baseline=true)]publicstringUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	260.7 ns	2.41 ns	2.01 ns	1.00	0.00	0.0277	232 B	1.00
UrlPathEncode	338.5 ns	6.03 ns	5.64 ns	1.30	0.02	0.0839	704 B	3.03
UrlPathEncode_PR	325.4 ns	4.59 ns	4.30 ns	1.25	0.02	0.0658	552 B	2.38

MihaZupan · 2024-05-29T18:11:44Z

 }

- private static byte[] UrlEncodeNonAscii(byte[] bytes, int offset, int count)
+ private static string UrlEncodeNonAscii(Span<byte> bytes)


These methods are still allocating quite a bit (the original string even if it's already Ascii, substring and combined string in UrlPathEncodeImpl ...).
The 1 caller of this helper is using Encoding.UTF8 and wants to stop after you see a ?.
Assuming there's sufficient test coverage, I would change this to instead look something like
privatestaticstringUrlPathEncodeImpl(stringvalue){inti=value.AsSpan().IndexOfAnyExceptInRange((char)0x21,(char)0x7F);if(i<0){returnvalue;}intindexOfQuery=value.IndexOf('?');if(indexOfQuery>=0&&indexOfQuery<i){// Everything before the Query is valid ASCIIreturnvalue;}ReadOnlySpan<char>toEncode=indexOfQuery>=0?value.AsSpan(i,indexOfQuery-i):value.AsSpan(i);byte[]bytes=ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetMaxByteCount(toEncode.Length));char[]chars=ArrayPool<char>.Shared.Rent(bytes.Length*3);intutf8Length=Encoding.UTF8.GetBytes(toEncode,bytes);intcharCount=0;foreach(bytebinbytes.AsSpan(0,utf8Length)){if(IsNonAsciiOrSpaceByte(b)){chars[charCount++]='%';chars[charCount++]=HexConverter.ToCharLower(b>>4);chars[charCount++]=HexConverter.ToCharLower(b);}else{chars[charCount++]=(char)b;}}ArrayPool<byte>.Shared.Return(bytes);stringresult=string.Concat(value.AsSpan(0,i),chars.AsSpan(0,charCount),indexOfQuery>=0?value.AsSpan(indexOfQuery):ReadOnlySpan<char>.Empty);ArrayPool<char>.Shared.Return(chars);returnresult;}
This would avoid a bunch of intermediate allocations and transcoding.

MihaZupan · 2024-05-29T18:14:41Z

+ schemeAndAuthority = default(Range);
+ path = Range.All;
+ queryAndFragment = default(Range);


Suggested change
schemeAndAuthority=default(Range);
path=Range.All;
queryAndFragment=default(Range);
returnUrlPathEncodeImpl(value);
Otherwise you would end up allocating a substring for value.AsSpan(path).ToString() + a substring for the string.Concat.

MihaZupan · 2024-05-29T18:16:00Z

 }

- return schemeAndAuthority + UrlPathEncodeImpl(path) + queryAndFragment;
+ return string.Concat(value.AsSpan(schemeAndAuthority), UrlPathEncodeImpl(value.AsSpan(path).ToString()), value.AsSpan(queryAndFragment));


This could be combined into the whole UrlPathEncodeImpl to avoid the substring allocations

MihaZupan · 2024-05-29T18:28:04Z

 // Even if this method returns true, one or more of the out parameters might contain a null or empty string, e.g. if there is no query / fragment.
 // Concatenating the pieces back together will form the original input string.
- internal static bool TrySplitUriForPathEncode(string input, [NotNullWhen(true)] out string? schemeAndAuthority, [NotNullWhen(true)] out string? path, out string? queryAndFragment)
+ internal static bool TrySplitUriForPathEncode(string input, out Range schemeAndAuthority, out Range path, out Range queryAndFragment)


By forcing everything into spans and ranges, you are now also allocating substrings where you might not have needed to previously. E.g. if pathRange is Range.All, you're reallocating the original string.
You could inline ExtractQueryAndFragment into this method, and always use Substring for the path portion.
I would also suggest returning Span instead of Range as it's easier to use given that the callers only need the range to make the span anyway.

TrayanZapryanov · 2024-05-29T19:47:49Z

@MihaZupan Sorry I messed git while trying to rebase after merging previous PRs.
Sorry for the stupid question, but can you tell me how you are updating older branches to latest version without closing existing PR.
Meanwhile I will try to open another PR with your comments integrated.

MihaZupan · 2024-05-29T20:24:06Z

Assuming upstream is this repo and origin is your fork, my workflow looks something like

git checkout main
git pull upstream
git checkout your-branch
git rebase main // And now fix any conflicts
git push origin -f

TrayanZapryanov · 2024-05-29T15:03:19Z

Omit intermediate string allocations by using Ranges.
Use stackalloc arrays when input is small enough for encoding and ASCII conversions.
Remove string.Contains(' ') loop.

dotnet-policy-service · 2024-05-29T15:03:55Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

TrayanZapryanov · 2024-05-29T15:12:07Z

Benchmark:

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark(Baseline=true)]publicstringUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	260.7 ns	2.41 ns	2.01 ns	1.00	0.00	0.0277	232 B	1.00
UrlPathEncode	338.5 ns	6.03 ns	5.64 ns	1.30	0.02	0.0839	704 B	3.03
UrlPathEncode_PR	325.4 ns	4.59 ns	4.30 ns	1.25	0.02	0.0658	552 B	2.38

MihaZupan · 2024-05-29T18:11:44Z

 }

- private static byte[] UrlEncodeNonAscii(byte[] bytes, int offset, int count)
+ private static string UrlEncodeNonAscii(Span<byte> bytes)


These methods are still allocating quite a bit (the original string even if it's already Ascii, substring and combined string in UrlPathEncodeImpl ...).
The 1 caller of this helper is using Encoding.UTF8 and wants to stop after you see a ?.
Assuming there's sufficient test coverage, I would change this to instead look something like
privatestaticstringUrlPathEncodeImpl(stringvalue){inti=value.AsSpan().IndexOfAnyExceptInRange((char)0x21,(char)0x7F);if(i<0){returnvalue;}intindexOfQuery=value.IndexOf('?');if(indexOfQuery>=0&&indexOfQuery<i){// Everything before the Query is valid ASCIIreturnvalue;}ReadOnlySpan<char>toEncode=indexOfQuery>=0?value.AsSpan(i,indexOfQuery-i):value.AsSpan(i);byte[]bytes=ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetMaxByteCount(toEncode.Length));char[]chars=ArrayPool<char>.Shared.Rent(bytes.Length*3);intutf8Length=Encoding.UTF8.GetBytes(toEncode,bytes);intcharCount=0;foreach(bytebinbytes.AsSpan(0,utf8Length)){if(IsNonAsciiOrSpaceByte(b)){chars[charCount++]='%';chars[charCount++]=HexConverter.ToCharLower(b>>4);chars[charCount++]=HexConverter.ToCharLower(b);}else{chars[charCount++]=(char)b;}}ArrayPool<byte>.Shared.Return(bytes);stringresult=string.Concat(value.AsSpan(0,i),chars.AsSpan(0,charCount),indexOfQuery>=0?value.AsSpan(indexOfQuery):ReadOnlySpan<char>.Empty);ArrayPool<char>.Shared.Return(chars);returnresult;}
This would avoid a bunch of intermediate allocations and transcoding.

MihaZupan · 2024-05-29T18:14:41Z

+ schemeAndAuthority = default(Range);
+ path = Range.All;
+ queryAndFragment = default(Range);


Suggested change
schemeAndAuthority=default(Range);
path=Range.All;
queryAndFragment=default(Range);
returnUrlPathEncodeImpl(value);
Otherwise you would end up allocating a substring for value.AsSpan(path).ToString() + a substring for the string.Concat.

MihaZupan · 2024-05-29T18:16:00Z

 }

- return schemeAndAuthority + UrlPathEncodeImpl(path) + queryAndFragment;
+ return string.Concat(value.AsSpan(schemeAndAuthority), UrlPathEncodeImpl(value.AsSpan(path).ToString()), value.AsSpan(queryAndFragment));


This could be combined into the whole UrlPathEncodeImpl to avoid the substring allocations

MihaZupan · 2024-05-29T18:28:04Z

 // Even if this method returns true, one or more of the out parameters might contain a null or empty string, e.g. if there is no query / fragment.
 // Concatenating the pieces back together will form the original input string.
- internal static bool TrySplitUriForPathEncode(string input, [NotNullWhen(true)] out string? schemeAndAuthority, [NotNullWhen(true)] out string? path, out string? queryAndFragment)
+ internal static bool TrySplitUriForPathEncode(string input, out Range schemeAndAuthority, out Range path, out Range queryAndFragment)


By forcing everything into spans and ranges, you are now also allocating substrings where you might not have needed to previously. E.g. if pathRange is Range.All, you're reallocating the original string.
You could inline ExtractQueryAndFragment into this method, and always use Substring for the path portion.
I would also suggest returning Span instead of Range as it's easier to use given that the callers only need the range to make the span anyway.

TrayanZapryanov · 2024-05-29T19:47:49Z

@MihaZupan Sorry I messed git while trying to rebase after merging previous PRs.
Sorry for the stupid question, but can you tell me how you are updating older branches to latest version without closing existing PR.
Meanwhile I will try to open another PR with your comments integrated.

MihaZupan · 2024-05-29T20:24:06Z

Assuming upstream is this repo and origin is your fork, my workflow looks something like

git checkout main
git pull upstream
git checkout your-branch
git rebase main // And now fix any conflicts
git push origin -f

TrayanZapryanov · 2024-05-29T15:03:19Z

Omit intermediate string allocations by using Ranges.
Use stackalloc arrays when input is small enough for encoding and ASCII conversions.
Remove string.Contains(' ') loop.

dotnet-policy-service · 2024-05-29T15:03:55Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

TrayanZapryanov · 2024-05-29T15:12:07Z

Benchmark:

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark(Baseline=true)]publicstringUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	260.7 ns	2.41 ns	2.01 ns	1.00	0.00	0.0277	232 B	1.00
UrlPathEncode	338.5 ns	6.03 ns	5.64 ns	1.30	0.02	0.0839	704 B	3.03
UrlPathEncode_PR	325.4 ns	4.59 ns	4.30 ns	1.25	0.02	0.0658	552 B	2.38

MihaZupan · 2024-05-29T18:11:44Z

 }

- private static byte[] UrlEncodeNonAscii(byte[] bytes, int offset, int count)
+ private static string UrlEncodeNonAscii(Span<byte> bytes)


These methods are still allocating quite a bit (the original string even if it's already Ascii, substring and combined string in UrlPathEncodeImpl ...).
The 1 caller of this helper is using Encoding.UTF8 and wants to stop after you see a ?.
Assuming there's sufficient test coverage, I would change this to instead look something like
privatestaticstringUrlPathEncodeImpl(stringvalue){inti=value.AsSpan().IndexOfAnyExceptInRange((char)0x21,(char)0x7F);if(i<0){returnvalue;}intindexOfQuery=value.IndexOf('?');if(indexOfQuery>=0&&indexOfQuery<i){// Everything before the Query is valid ASCIIreturnvalue;}ReadOnlySpan<char>toEncode=indexOfQuery>=0?value.AsSpan(i,indexOfQuery-i):value.AsSpan(i);byte[]bytes=ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetMaxByteCount(toEncode.Length));char[]chars=ArrayPool<char>.Shared.Rent(bytes.Length*3);intutf8Length=Encoding.UTF8.GetBytes(toEncode,bytes);intcharCount=0;foreach(bytebinbytes.AsSpan(0,utf8Length)){if(IsNonAsciiOrSpaceByte(b)){chars[charCount++]='%';chars[charCount++]=HexConverter.ToCharLower(b>>4);chars[charCount++]=HexConverter.ToCharLower(b);}else{chars[charCount++]=(char)b;}}ArrayPool<byte>.Shared.Return(bytes);stringresult=string.Concat(value.AsSpan(0,i),chars.AsSpan(0,charCount),indexOfQuery>=0?value.AsSpan(indexOfQuery):ReadOnlySpan<char>.Empty);ArrayPool<char>.Shared.Return(chars);returnresult;}
This would avoid a bunch of intermediate allocations and transcoding.

MihaZupan · 2024-05-29T18:14:41Z

+ schemeAndAuthority = default(Range);
+ path = Range.All;
+ queryAndFragment = default(Range);


Suggested change
schemeAndAuthority=default(Range);
path=Range.All;
queryAndFragment=default(Range);
returnUrlPathEncodeImpl(value);
Otherwise you would end up allocating a substring for value.AsSpan(path).ToString() + a substring for the string.Concat.

MihaZupan · 2024-05-29T18:16:00Z

 }

- return schemeAndAuthority + UrlPathEncodeImpl(path) + queryAndFragment;
+ return string.Concat(value.AsSpan(schemeAndAuthority), UrlPathEncodeImpl(value.AsSpan(path).ToString()), value.AsSpan(queryAndFragment));


This could be combined into the whole UrlPathEncodeImpl to avoid the substring allocations

MihaZupan · 2024-05-29T18:28:04Z

 // Even if this method returns true, one or more of the out parameters might contain a null or empty string, e.g. if there is no query / fragment.
 // Concatenating the pieces back together will form the original input string.
- internal static bool TrySplitUriForPathEncode(string input, [NotNullWhen(true)] out string? schemeAndAuthority, [NotNullWhen(true)] out string? path, out string? queryAndFragment)
+ internal static bool TrySplitUriForPathEncode(string input, out Range schemeAndAuthority, out Range path, out Range queryAndFragment)


By forcing everything into spans and ranges, you are now also allocating substrings where you might not have needed to previously. E.g. if pathRange is Range.All, you're reallocating the original string.
You could inline ExtractQueryAndFragment into this method, and always use Substring for the path portion.
I would also suggest returning Span instead of Range as it's easier to use given that the callers only need the range to make the span anyway.

TrayanZapryanov · 2024-05-29T19:47:49Z

@MihaZupan Sorry I messed git while trying to rebase after merging previous PRs.
Sorry for the stupid question, but can you tell me how you are updating older branches to latest version without closing existing PR.
Meanwhile I will try to open another PR with your comments integrated.

MihaZupan · 2024-05-29T20:24:06Z

Assuming upstream is this repo and origin is your fork, my workflow looks something like

git checkout main
git pull upstream
git checkout your-branch
git rebase main // And now fix any conflicts
git push origin -f

TrayanZapryanov · 2024-05-29T15:03:19Z

Omit intermediate string allocations by using Ranges.
Use stackalloc arrays when input is small enough for encoding and ASCII conversions.
Remove string.Contains(' ') loop.

dotnet-policy-service · 2024-05-29T15:03:55Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

TrayanZapryanov · 2024-05-29T15:12:07Z

Benchmark:

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark(Baseline=true)]publicstringUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	260.7 ns	2.41 ns	2.01 ns	1.00	0.00	0.0277	232 B	1.00
UrlPathEncode	338.5 ns	6.03 ns	5.64 ns	1.30	0.02	0.0839	704 B	3.03
UrlPathEncode_PR	325.4 ns	4.59 ns	4.30 ns	1.25	0.02	0.0658	552 B	2.38

MihaZupan · 2024-05-29T18:11:44Z

 }

- private static byte[] UrlEncodeNonAscii(byte[] bytes, int offset, int count)
+ private static string UrlEncodeNonAscii(Span<byte> bytes)


These methods are still allocating quite a bit (the original string even if it's already Ascii, substring and combined string in UrlPathEncodeImpl ...).
The 1 caller of this helper is using Encoding.UTF8 and wants to stop after you see a ?.
Assuming there's sufficient test coverage, I would change this to instead look something like
privatestaticstringUrlPathEncodeImpl(stringvalue){inti=value.AsSpan().IndexOfAnyExceptInRange((char)0x21,(char)0x7F);if(i<0){returnvalue;}intindexOfQuery=value.IndexOf('?');if(indexOfQuery>=0&&indexOfQuery<i){// Everything before the Query is valid ASCIIreturnvalue;}ReadOnlySpan<char>toEncode=indexOfQuery>=0?value.AsSpan(i,indexOfQuery-i):value.AsSpan(i);byte[]bytes=ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetMaxByteCount(toEncode.Length));char[]chars=ArrayPool<char>.Shared.Rent(bytes.Length*3);intutf8Length=Encoding.UTF8.GetBytes(toEncode,bytes);intcharCount=0;foreach(bytebinbytes.AsSpan(0,utf8Length)){if(IsNonAsciiOrSpaceByte(b)){chars[charCount++]='%';chars[charCount++]=HexConverter.ToCharLower(b>>4);chars[charCount++]=HexConverter.ToCharLower(b);}else{chars[charCount++]=(char)b;}}ArrayPool<byte>.Shared.Return(bytes);stringresult=string.Concat(value.AsSpan(0,i),chars.AsSpan(0,charCount),indexOfQuery>=0?value.AsSpan(indexOfQuery):ReadOnlySpan<char>.Empty);ArrayPool<char>.Shared.Return(chars);returnresult;}
This would avoid a bunch of intermediate allocations and transcoding.

MihaZupan · 2024-05-29T18:14:41Z

+ schemeAndAuthority = default(Range);
+ path = Range.All;
+ queryAndFragment = default(Range);


Suggested change
schemeAndAuthority=default(Range);
path=Range.All;
queryAndFragment=default(Range);
returnUrlPathEncodeImpl(value);
Otherwise you would end up allocating a substring for value.AsSpan(path).ToString() + a substring for the string.Concat.

MihaZupan · 2024-05-29T18:16:00Z

 }

- return schemeAndAuthority + UrlPathEncodeImpl(path) + queryAndFragment;
+ return string.Concat(value.AsSpan(schemeAndAuthority), UrlPathEncodeImpl(value.AsSpan(path).ToString()), value.AsSpan(queryAndFragment));


This could be combined into the whole UrlPathEncodeImpl to avoid the substring allocations

MihaZupan · 2024-05-29T18:28:04Z

 // Even if this method returns true, one or more of the out parameters might contain a null or empty string, e.g. if there is no query / fragment.
 // Concatenating the pieces back together will form the original input string.
- internal static bool TrySplitUriForPathEncode(string input, [NotNullWhen(true)] out string? schemeAndAuthority, [NotNullWhen(true)] out string? path, out string? queryAndFragment)
+ internal static bool TrySplitUriForPathEncode(string input, out Range schemeAndAuthority, out Range path, out Range queryAndFragment)


By forcing everything into spans and ranges, you are now also allocating substrings where you might not have needed to previously. E.g. if pathRange is Range.All, you're reallocating the original string.
You could inline ExtractQueryAndFragment into this method, and always use Substring for the path portion.
I would also suggest returning Span instead of Range as it's easier to use given that the callers only need the range to make the span anyway.

TrayanZapryanov · 2024-05-29T19:47:49Z

@MihaZupan Sorry I messed git while trying to rebase after merging previous PRs.
Sorry for the stupid question, but can you tell me how you are updating older branches to latest version without closing existing PR.
Meanwhile I will try to open another PR with your comments integrated.

MihaZupan · 2024-05-29T20:24:06Z

Assuming upstream is this repo and origin is your fork, my workflow looks something like

git checkout main
git pull upstream
git checkout your-branch
git rebase main // And now fix any conflicts
git push origin -f

TrayanZapryanov · 2024-05-29T15:03:19Z

Omit intermediate string allocations by using Ranges.
Use stackalloc arrays when input is small enough for encoding and ASCII conversions.
Remove string.Contains(' ') loop.

dotnet-policy-service · 2024-05-29T15:03:55Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

TrayanZapryanov · 2024-05-29T15:12:07Z

Benchmark:

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark(Baseline=true)]publicstringUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	260.7 ns	2.41 ns	2.01 ns	1.00	0.00	0.0277	232 B	1.00
UrlPathEncode	338.5 ns	6.03 ns	5.64 ns	1.30	0.02	0.0839	704 B	3.03
UrlPathEncode_PR	325.4 ns	4.59 ns	4.30 ns	1.25	0.02	0.0658	552 B	2.38

MihaZupan · 2024-05-29T18:11:44Z

 }

- private static byte[] UrlEncodeNonAscii(byte[] bytes, int offset, int count)
+ private static string UrlEncodeNonAscii(Span<byte> bytes)


These methods are still allocating quite a bit (the original string even if it's already Ascii, substring and combined string in UrlPathEncodeImpl ...).
The 1 caller of this helper is using Encoding.UTF8 and wants to stop after you see a ?.
Assuming there's sufficient test coverage, I would change this to instead look something like
privatestaticstringUrlPathEncodeImpl(stringvalue){inti=value.AsSpan().IndexOfAnyExceptInRange((char)0x21,(char)0x7F);if(i<0){returnvalue;}intindexOfQuery=value.IndexOf('?');if(indexOfQuery>=0&&indexOfQuery<i){// Everything before the Query is valid ASCIIreturnvalue;}ReadOnlySpan<char>toEncode=indexOfQuery>=0?value.AsSpan(i,indexOfQuery-i):value.AsSpan(i);byte[]bytes=ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetMaxByteCount(toEncode.Length));char[]chars=ArrayPool<char>.Shared.Rent(bytes.Length*3);intutf8Length=Encoding.UTF8.GetBytes(toEncode,bytes);intcharCount=0;foreach(bytebinbytes.AsSpan(0,utf8Length)){if(IsNonAsciiOrSpaceByte(b)){chars[charCount++]='%';chars[charCount++]=HexConverter.ToCharLower(b>>4);chars[charCount++]=HexConverter.ToCharLower(b);}else{chars[charCount++]=(char)b;}}ArrayPool<byte>.Shared.Return(bytes);stringresult=string.Concat(value.AsSpan(0,i),chars.AsSpan(0,charCount),indexOfQuery>=0?value.AsSpan(indexOfQuery):ReadOnlySpan<char>.Empty);ArrayPool<char>.Shared.Return(chars);returnresult;}
This would avoid a bunch of intermediate allocations and transcoding.

MihaZupan · 2024-05-29T18:14:41Z

+ schemeAndAuthority = default(Range);
+ path = Range.All;
+ queryAndFragment = default(Range);


Suggested change
schemeAndAuthority=default(Range);
path=Range.All;
queryAndFragment=default(Range);
returnUrlPathEncodeImpl(value);
Otherwise you would end up allocating a substring for value.AsSpan(path).ToString() + a substring for the string.Concat.

MihaZupan · 2024-05-29T18:16:00Z

 }

- return schemeAndAuthority + UrlPathEncodeImpl(path) + queryAndFragment;
+ return string.Concat(value.AsSpan(schemeAndAuthority), UrlPathEncodeImpl(value.AsSpan(path).ToString()), value.AsSpan(queryAndFragment));


This could be combined into the whole UrlPathEncodeImpl to avoid the substring allocations

MihaZupan · 2024-05-29T18:28:04Z

 // Even if this method returns true, one or more of the out parameters might contain a null or empty string, e.g. if there is no query / fragment.
 // Concatenating the pieces back together will form the original input string.
- internal static bool TrySplitUriForPathEncode(string input, [NotNullWhen(true)] out string? schemeAndAuthority, [NotNullWhen(true)] out string? path, out string? queryAndFragment)
+ internal static bool TrySplitUriForPathEncode(string input, out Range schemeAndAuthority, out Range path, out Range queryAndFragment)


By forcing everything into spans and ranges, you are now also allocating substrings where you might not have needed to previously. E.g. if pathRange is Range.All, you're reallocating the original string.
You could inline ExtractQueryAndFragment into this method, and always use Substring for the path portion.
I would also suggest returning Span instead of Range as it's easier to use given that the callers only need the range to make the span anyway.

TrayanZapryanov · 2024-05-29T19:47:49Z

@MihaZupan Sorry I messed git while trying to rebase after merging previous PRs.
Sorry for the stupid question, but can you tell me how you are updating older branches to latest version without closing existing PR.
Meanwhile I will try to open another PR with your comments integrated.

MihaZupan · 2024-05-29T20:24:06Z

Assuming upstream is this repo and origin is your fork, my workflow looks something like

git checkout main
git pull upstream
git checkout your-branch
git rebase main // And now fix any conflicts
git push origin -f

ghost added the area-System.Net label May 29, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 29, 2024

This was referenced May 29, 2024
Test failure System.Diagnostics.Tests.PerformanceCounterCategoryTests.PerformanceCounterCategory_DeleteCategory #94395
Closed
[browser][MT] Tests timed out #102559
Closed

MihaZupan reviewed May 29, 2024
View reviewed changes

TrayanZapryanov closed this May 29, 2024

TrayanZapryanov force-pushed the main branch from 20e0014 to 03bc51fCompare May 29, 2024 19:10

TrayanZapryanov mentioned this pull request May 31, 2024
Reduce allocation in HttpUtility.UrlPathEncode. #102909
Merged

karelz added this to the 9.0.0 milestone Jun 24, 2024

github-actionsBot locked and limited conversation to collaborators Jul 25, 2024

ghost added the area-System.Net label May 29, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 29, 2024

This was referenced May 29, 2024
Test failure System.Diagnostics.Tests.PerformanceCounterCategoryTests.PerformanceCounterCategory_DeleteCategory #94395
Closed
[browser][MT] Tests timed out #102559
Closed

MihaZupan reviewed May 29, 2024
View reviewed changes

TrayanZapryanov closed this May 29, 2024

TrayanZapryanov force-pushed the main branch from 20e0014 to 03bc51fCompare May 29, 2024 19:10

TrayanZapryanov mentioned this pull request May 31, 2024
Reduce allocation in HttpUtility.UrlPathEncode. #102909
Merged

karelz added this to the 9.0.0 milestone Jun 24, 2024

github-actionsBot locked and limited conversation to collaborators Jul 25, 2024

ghost added the area-System.Net label May 29, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 29, 2024

This was referenced May 29, 2024
Test failure System.Diagnostics.Tests.PerformanceCounterCategoryTests.PerformanceCounterCategory_DeleteCategory #94395
Closed
[browser][MT] Tests timed out #102559
Closed

MihaZupan reviewed May 29, 2024
View reviewed changes

TrayanZapryanov closed this May 29, 2024

TrayanZapryanov force-pushed the main branch from 20e0014 to 03bc51fCompare May 29, 2024 19:10

TrayanZapryanov mentioned this pull request May 31, 2024
Reduce allocation in HttpUtility.UrlPathEncode. #102909
Merged

karelz added this to the 9.0.0 milestone Jun 24, 2024

github-actionsBot locked and limited conversation to collaborators Jul 25, 2024

ghost added the area-System.Net label May 29, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 29, 2024

This was referenced May 29, 2024
Test failure System.Diagnostics.Tests.PerformanceCounterCategoryTests.PerformanceCounterCategory_DeleteCategory #94395
Closed
[browser][MT] Tests timed out #102559
Closed

MihaZupan reviewed May 29, 2024
View reviewed changes

TrayanZapryanov closed this May 29, 2024

TrayanZapryanov force-pushed the main branch from 20e0014 to 03bc51fCompare May 29, 2024 19:10

TrayanZapryanov mentioned this pull request May 31, 2024
Reduce allocation in HttpUtility.UrlPathEncode. #102909
Merged

karelz added this to the 9.0.0 milestone Jun 24, 2024

github-actionsBot locked and limited conversation to collaborators Jul 25, 2024

ghost added the area-System.Net label May 29, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 29, 2024

This was referenced May 29, 2024
Test failure System.Diagnostics.Tests.PerformanceCounterCategoryTests.PerformanceCounterCategory_DeleteCategory #94395
Closed
[browser][MT] Tests timed out #102559
Closed

MihaZupan reviewed May 29, 2024
View reviewed changes

TrayanZapryanov closed this May 29, 2024

TrayanZapryanov force-pushed the main branch from 20e0014 to 03bc51fCompare May 29, 2024 19:10

TrayanZapryanov mentioned this pull request May 31, 2024
Reduce allocation in HttpUtility.UrlPathEncode. #102909
Merged

karelz added this to the 9.0.0 milestone Jun 24, 2024

github-actionsBot locked and limited conversation to collaborators Jul 25, 2024

ghost added the area-System.Net label May 29, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 29, 2024

This was referenced May 29, 2024
Test failure System.Diagnostics.Tests.PerformanceCounterCategoryTests.PerformanceCounterCategory_DeleteCategory #94395
Closed
[browser][MT] Tests timed out #102559
Closed

MihaZupan reviewed May 29, 2024
View reviewed changes

TrayanZapryanov closed this May 29, 2024

TrayanZapryanov force-pushed the main branch from 20e0014 to 03bc51fCompare May 29, 2024 19:10

TrayanZapryanov mentioned this pull request May 31, 2024
Reduce allocation in HttpUtility.UrlPathEncode. #102909
Merged

karelz added this to the 9.0.0 milestone Jun 24, 2024

github-actionsBot locked and limited conversation to collaborators Jul 25, 2024

ghost added the area-System.Net label May 29, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 29, 2024

This was referenced May 29, 2024
Test failure System.Diagnostics.Tests.PerformanceCounterCategoryTests.PerformanceCounterCategory_DeleteCategory #94395
Closed
[browser][MT] Tests timed out #102559
Closed

MihaZupan reviewed May 29, 2024
View reviewed changes

TrayanZapryanov closed this May 29, 2024

TrayanZapryanov force-pushed the main branch from 20e0014 to 03bc51fCompare May 29, 2024 19:10

TrayanZapryanov mentioned this pull request May 31, 2024
Reduce allocation in HttpUtility.UrlPathEncode. #102909
Merged

karelz added this to the 9.0.0 milestone Jun 24, 2024

github-actionsBot locked and limited conversation to collaborators Jul 25, 2024

ghost added the area-System.Net label May 29, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 29, 2024

This was referenced May 29, 2024
Test failure System.Diagnostics.Tests.PerformanceCounterCategoryTests.PerformanceCounterCategory_DeleteCategory #94395
Closed
[browser][MT] Tests timed out #102559
Closed

MihaZupan reviewed May 29, 2024
View reviewed changes

TrayanZapryanov closed this May 29, 2024

TrayanZapryanov force-pushed the main branch from 20e0014 to 03bc51fCompare May 29, 2024 19:10

TrayanZapryanov mentioned this pull request May 31, 2024
Reduce allocation in HttpUtility.UrlPathEncode. #102909
Merged

karelz added this to the 9.0.0 milestone Jun 24, 2024

github-actionsBot locked and limited conversation to collaborators Jul 25, 2024

-schemeAndAuthority=default(Range);
-path=Range.All;
-queryAndFragment=default(Range);
+returnUrlPathEncodeImpl(value);

Uh oh!

Conversation

TrayanZapryanov commented May 29, 2024

Uh oh!

dotnet-policy-serviceBot commented May 29, 2024

Uh oh!

TrayanZapryanov commented May 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TrayanZapryanov commented May 29, 2024

Uh oh!

MihaZupan commented May 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

TrayanZapryanov commented May 29, 2024

Uh oh!

dotnet-policy-serviceBot commented May 29, 2024

Uh oh!

TrayanZapryanov commented May 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TrayanZapryanov commented May 29, 2024

Uh oh!

MihaZupan commented May 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

TrayanZapryanov commented May 29, 2024

Uh oh!

dotnet-policy-serviceBot commented May 29, 2024

Uh oh!

TrayanZapryanov commented May 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TrayanZapryanov commented May 29, 2024

Uh oh!

MihaZupan commented May 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects