Reduce allocation in HttpUtility.UrlPathEncode. by TrayanZapryanov · Pull Request #102909 · dotnet/runtime

TrayanZapryanov · 2024-05-31T08:11:24Z

Incorporate previously closedPR + feedback.
New benchmarks with slightly modified URL to contain non ascii characters.

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark]publicboolUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri);[Benchmark(Baseline=true)]publicstringUrlTryCreateAndUseAuthority()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	305.1 ns	6.07 ns	7.68 ns	0.82	0.03	0.0677	568 B	0.86
UrlTryCreateAndUseAuthority	376.1 ns	4.76 ns	4.45 ns	1.00	0.00	0.0792	664 B	1.00
UrlPathEncode	437.4 ns	2.93 ns	2.45 ns	1.16	0.02	0.1211	1016 B	1.53
UrlPathEncode_PR	438.8 ns	6.04 ns	5.65 ns	1.17	0.02	0.0982	824 B	1.24

There is a small regression in worst scenario - I guess due to renting 2 arrays, but this saves quite a lot of allocations.
These are results for URL without non ascii chars: http://example.net:8080/default.xxx?sdsd=sds

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	88.95 ns	0.692 ns	0.614 ns	0.35	0.00	0.0067	56 B	0.23
UrlTryCreateAndUseAuthority	257.24 ns	2.847 ns	2.663 ns	1.00	0.00	0.0286	240 B	1.00
UrlPathEncode	342.34 ns	4.357 ns	3.862 ns	1.33	0.02	0.0830	696 B	2.90
UrlPathEncode_PR	289.49 ns	3.168 ns	2.963 ns	1.13	0.02	0.0591	496 B	2.07

MihaZupan · 2024-06-07T17:55:52Z

Btw this one also hit a conflict after #102917 got merged

TrayanZapryanov · 2024-06-12T13:43:30Z

@MihaZupan Rebase done.

MihaZupan · 2024-06-12T20:23:50Z

Thanks

TrayanZapryanov · 2024-05-31T08:11:24Z

Incorporate previously closedPR + feedback.
New benchmarks with slightly modified URL to contain non ascii characters.

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark]publicboolUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri);[Benchmark(Baseline=true)]publicstringUrlTryCreateAndUseAuthority()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	305.1 ns	6.07 ns	7.68 ns	0.82	0.03	0.0677	568 B	0.86
UrlTryCreateAndUseAuthority	376.1 ns	4.76 ns	4.45 ns	1.00	0.00	0.0792	664 B	1.00
UrlPathEncode	437.4 ns	2.93 ns	2.45 ns	1.16	0.02	0.1211	1016 B	1.53
UrlPathEncode_PR	438.8 ns	6.04 ns	5.65 ns	1.17	0.02	0.0982	824 B	1.24

There is a small regression in worst scenario - I guess due to renting 2 arrays, but this saves quite a lot of allocations.
These are results for URL without non ascii chars: http://example.net:8080/default.xxx?sdsd=sds

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	88.95 ns	0.692 ns	0.614 ns	0.35	0.00	0.0067	56 B	0.23
UrlTryCreateAndUseAuthority	257.24 ns	2.847 ns	2.663 ns	1.00	0.00	0.0286	240 B	1.00
UrlPathEncode	342.34 ns	4.357 ns	3.862 ns	1.33	0.02	0.0830	696 B	2.90
UrlPathEncode_PR	289.49 ns	3.168 ns	2.963 ns	1.13	0.02	0.0591	496 B	2.07

MihaZupan · 2024-06-07T17:55:52Z

Btw this one also hit a conflict after #102917 got merged

TrayanZapryanov · 2024-06-12T13:43:30Z

@MihaZupan Rebase done.

MihaZupan · 2024-06-12T20:23:50Z

Thanks

TrayanZapryanov · 2024-05-31T08:11:24Z

Incorporate previously closedPR + feedback.
New benchmarks with slightly modified URL to contain non ascii characters.

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark]publicboolUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri);[Benchmark(Baseline=true)]publicstringUrlTryCreateAndUseAuthority()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	305.1 ns	6.07 ns	7.68 ns	0.82	0.03	0.0677	568 B	0.86
UrlTryCreateAndUseAuthority	376.1 ns	4.76 ns	4.45 ns	1.00	0.00	0.0792	664 B	1.00
UrlPathEncode	437.4 ns	2.93 ns	2.45 ns	1.16	0.02	0.1211	1016 B	1.53
UrlPathEncode_PR	438.8 ns	6.04 ns	5.65 ns	1.17	0.02	0.0982	824 B	1.24

There is a small regression in worst scenario - I guess due to renting 2 arrays, but this saves quite a lot of allocations.
These are results for URL without non ascii chars: http://example.net:8080/default.xxx?sdsd=sds

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	88.95 ns	0.692 ns	0.614 ns	0.35	0.00	0.0067	56 B	0.23
UrlTryCreateAndUseAuthority	257.24 ns	2.847 ns	2.663 ns	1.00	0.00	0.0286	240 B	1.00
UrlPathEncode	342.34 ns	4.357 ns	3.862 ns	1.33	0.02	0.0830	696 B	2.90
UrlPathEncode_PR	289.49 ns	3.168 ns	2.963 ns	1.13	0.02	0.0591	496 B	2.07

MihaZupan · 2024-06-07T17:55:52Z

Btw this one also hit a conflict after #102917 got merged

TrayanZapryanov · 2024-06-12T13:43:30Z

@MihaZupan Rebase done.

MihaZupan · 2024-06-12T20:23:50Z

Thanks

TrayanZapryanov · 2024-05-31T08:11:24Z

Incorporate previously closedPR + feedback.
New benchmarks with slightly modified URL to contain non ascii characters.

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark]publicboolUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri);[Benchmark(Baseline=true)]publicstringUrlTryCreateAndUseAuthority()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	305.1 ns	6.07 ns	7.68 ns	0.82	0.03	0.0677	568 B	0.86
UrlTryCreateAndUseAuthority	376.1 ns	4.76 ns	4.45 ns	1.00	0.00	0.0792	664 B	1.00
UrlPathEncode	437.4 ns	2.93 ns	2.45 ns	1.16	0.02	0.1211	1016 B	1.53
UrlPathEncode_PR	438.8 ns	6.04 ns	5.65 ns	1.17	0.02	0.0982	824 B	1.24

There is a small regression in worst scenario - I guess due to renting 2 arrays, but this saves quite a lot of allocations.
These are results for URL without non ascii chars: http://example.net:8080/default.xxx?sdsd=sds

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	88.95 ns	0.692 ns	0.614 ns	0.35	0.00	0.0067	56 B	0.23
UrlTryCreateAndUseAuthority	257.24 ns	2.847 ns	2.663 ns	1.00	0.00	0.0286	240 B	1.00
UrlPathEncode	342.34 ns	4.357 ns	3.862 ns	1.33	0.02	0.0830	696 B	2.90
UrlPathEncode_PR	289.49 ns	3.168 ns	2.963 ns	1.13	0.02	0.0591	496 B	2.07

MihaZupan · 2024-06-07T17:55:52Z

Btw this one also hit a conflict after #102917 got merged

TrayanZapryanov · 2024-06-12T13:43:30Z

@MihaZupan Rebase done.

MihaZupan · 2024-06-12T20:23:50Z

Thanks

TrayanZapryanov · 2024-05-31T08:11:24Z

Incorporate previously closedPR + feedback.
New benchmarks with slightly modified URL to contain non ascii characters.

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark]publicboolUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri);[Benchmark(Baseline=true)]publicstringUrlTryCreateAndUseAuthority()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	305.1 ns	6.07 ns	7.68 ns	0.82	0.03	0.0677	568 B	0.86
UrlTryCreateAndUseAuthority	376.1 ns	4.76 ns	4.45 ns	1.00	0.00	0.0792	664 B	1.00
UrlPathEncode	437.4 ns	2.93 ns	2.45 ns	1.16	0.02	0.1211	1016 B	1.53
UrlPathEncode_PR	438.8 ns	6.04 ns	5.65 ns	1.17	0.02	0.0982	824 B	1.24

There is a small regression in worst scenario - I guess due to renting 2 arrays, but this saves quite a lot of allocations.
These are results for URL without non ascii chars: http://example.net:8080/default.xxx?sdsd=sds

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	88.95 ns	0.692 ns	0.614 ns	0.35	0.00	0.0067	56 B	0.23
UrlTryCreateAndUseAuthority	257.24 ns	2.847 ns	2.663 ns	1.00	0.00	0.0286	240 B	1.00
UrlPathEncode	342.34 ns	4.357 ns	3.862 ns	1.33	0.02	0.0830	696 B	2.90
UrlPathEncode_PR	289.49 ns	3.168 ns	2.963 ns	1.13	0.02	0.0591	496 B	2.07

MihaZupan · 2024-06-07T17:55:52Z

Btw this one also hit a conflict after #102917 got merged

TrayanZapryanov · 2024-06-12T13:43:30Z

@MihaZupan Rebase done.

MihaZupan · 2024-06-12T20:23:50Z

Thanks

TrayanZapryanov · 2024-05-31T08:11:24Z

Incorporate previously closedPR + feedback.
New benchmarks with slightly modified URL to contain non ascii characters.

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark]publicboolUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri);[Benchmark(Baseline=true)]publicstringUrlTryCreateAndUseAuthority()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	305.1 ns	6.07 ns	7.68 ns	0.82	0.03	0.0677	568 B	0.86
UrlTryCreateAndUseAuthority	376.1 ns	4.76 ns	4.45 ns	1.00	0.00	0.0792	664 B	1.00
UrlPathEncode	437.4 ns	2.93 ns	2.45 ns	1.16	0.02	0.1211	1016 B	1.53
UrlPathEncode_PR	438.8 ns	6.04 ns	5.65 ns	1.17	0.02	0.0982	824 B	1.24

There is a small regression in worst scenario - I guess due to renting 2 arrays, but this saves quite a lot of allocations.
These are results for URL without non ascii chars: http://example.net:8080/default.xxx?sdsd=sds

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	88.95 ns	0.692 ns	0.614 ns	0.35	0.00	0.0067	56 B	0.23
UrlTryCreateAndUseAuthority	257.24 ns	2.847 ns	2.663 ns	1.00	0.00	0.0286	240 B	1.00
UrlPathEncode	342.34 ns	4.357 ns	3.862 ns	1.33	0.02	0.0830	696 B	2.90
UrlPathEncode_PR	289.49 ns	3.168 ns	2.963 ns	1.13	0.02	0.0591	496 B	2.07

MihaZupan · 2024-06-07T17:55:52Z

Btw this one also hit a conflict after #102917 got merged

TrayanZapryanov · 2024-06-12T13:43:30Z

@MihaZupan Rebase done.

MihaZupan · 2024-06-12T20:23:50Z

Thanks

TrayanZapryanov · 2024-05-31T08:11:24Z

Incorporate previously closedPR + feedback.
New benchmarks with slightly modified URL to contain non ascii characters.

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark]publicboolUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri);[Benchmark(Baseline=true)]publicstringUrlTryCreateAndUseAuthority()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	305.1 ns	6.07 ns	7.68 ns	0.82	0.03	0.0677	568 B	0.86
UrlTryCreateAndUseAuthority	376.1 ns	4.76 ns	4.45 ns	1.00	0.00	0.0792	664 B	1.00
UrlPathEncode	437.4 ns	2.93 ns	2.45 ns	1.16	0.02	0.1211	1016 B	1.53
UrlPathEncode_PR	438.8 ns	6.04 ns	5.65 ns	1.17	0.02	0.0982	824 B	1.24

There is a small regression in worst scenario - I guess due to renting 2 arrays, but this saves quite a lot of allocations.
These are results for URL without non ascii chars: http://example.net:8080/default.xxx?sdsd=sds

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	88.95 ns	0.692 ns	0.614 ns	0.35	0.00	0.0067	56 B	0.23
UrlTryCreateAndUseAuthority	257.24 ns	2.847 ns	2.663 ns	1.00	0.00	0.0286	240 B	1.00
UrlPathEncode	342.34 ns	4.357 ns	3.862 ns	1.33	0.02	0.0830	696 B	2.90
UrlPathEncode_PR	289.49 ns	3.168 ns	2.963 ns	1.13	0.02	0.0591	496 B	2.07

MihaZupan · 2024-06-07T17:55:52Z

Btw this one also hit a conflict after #102917 got merged

TrayanZapryanov · 2024-06-12T13:43:30Z

@MihaZupan Rebase done.

MihaZupan · 2024-06-12T20:23:50Z

Thanks

TrayanZapryanov · 2024-05-31T08:11:24Z

Incorporate previously closedPR + feedback.
New benchmarks with slightly modified URL to contain non ascii characters.

[MemoryDiagnoser]publicclassHttpUtilityBenchmarks{[Benchmark]publicboolUrlTryCreate()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri);[Benchmark(Baseline=true)]publicstringUrlTryCreateAndUseAuthority()=>Uri.TryCreate("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds",UriKind.Absolute,outvaruri)?uri.Authority:"error";[Benchmark]publicstringUrlPathEncode()=>HttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");[Benchmark]publicstringUrlPathEncode_PR()=>MyHttpUtility.UrlPathEncode("http://EXAMPLE.NET/d\u00E9fault.xxx?sdsd=sds");}

Results:

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	305.1 ns	6.07 ns	7.68 ns	0.82	0.03	0.0677	568 B	0.86
UrlTryCreateAndUseAuthority	376.1 ns	4.76 ns	4.45 ns	1.00	0.00	0.0792	664 B	1.00
UrlPathEncode	437.4 ns	2.93 ns	2.45 ns	1.16	0.02	0.1211	1016 B	1.53
UrlPathEncode_PR	438.8 ns	6.04 ns	5.65 ns	1.17	0.02	0.0982	824 B	1.24

There is a small regression in worst scenario - I guess due to renting 2 arrays, but this saves quite a lot of allocations.
These are results for URL without non ascii chars: http://example.net:8080/default.xxx?sdsd=sds

Method	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
UrlTryCreate	88.95 ns	0.692 ns	0.614 ns	0.35	0.00	0.0067	56 B	0.23
UrlTryCreateAndUseAuthority	257.24 ns	2.847 ns	2.663 ns	1.00	0.00	0.0286	240 B	1.00
UrlPathEncode	342.34 ns	4.357 ns	3.862 ns	1.33	0.02	0.0830	696 B	2.90
UrlPathEncode_PR	289.49 ns	3.168 ns	2.963 ns	1.13	0.02	0.0591	496 B	2.07

MihaZupan · 2024-06-07T17:55:52Z

Btw this one also hit a conflict after #102917 got merged

TrayanZapryanov · 2024-06-12T13:43:30Z

@MihaZupan Rebase done.

MihaZupan · 2024-06-12T20:23:50Z

Thanks

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 31, 2024

gfoidl reviewed May 31, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 31, 2024
[browser][MT] Tests timed out #102559
Closed

MihaZupan approved these changes May 31, 2024
View reviewed changes

Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs

MihaZupan added this to the 9.0.0 milestone May 31, 2024

MihaZupan approved these changes Jun 3, 2024
View reviewed changes

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from 051f1c9 to bc43beeCompare June 4, 2024 11:59

This was referenced Jun 5, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
[wasm] ystem addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL. #103060
Closed

Trayan-Zapryanov added 4 commits June 12, 2024 16:35

Reduce allocation in HttpUtility.UrlPathEncode.
e920339

Add feedback optimizations
6961eff

new feedback
82cdaf2

fix rebase
fda0521

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from bc43bee to fda0521Compare June 12, 2024 13:38

Remove HttpEncoderUtility.cs as it is not used anymore
8cb7c0a

This was referenced Jun 12, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
[browser][ST] Wasm tests timeout #103246
Closed

MihaZupan merged commit 5f91817 into dotnet:mainJun 12, 2024

TrayanZapryanov deleted the optimize_httputility_UrlPathEncode2 branch June 13, 2024 06:31

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 31, 2024

gfoidl reviewed May 31, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 31, 2024
[browser][MT] Tests timed out #102559
Closed

MihaZupan approved these changes May 31, 2024
View reviewed changes

Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs

MihaZupan added this to the 9.0.0 milestone May 31, 2024

MihaZupan approved these changes Jun 3, 2024
View reviewed changes

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from 051f1c9 to bc43beeCompare June 4, 2024 11:59

This was referenced Jun 5, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
[wasm] ystem addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL. #103060
Closed

Trayan-Zapryanov added 4 commits June 12, 2024 16:35

Reduce allocation in HttpUtility.UrlPathEncode.
e920339

Add feedback optimizations
6961eff

new feedback
82cdaf2

fix rebase
fda0521

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from bc43bee to fda0521Compare June 12, 2024 13:38

Remove HttpEncoderUtility.cs as it is not used anymore
8cb7c0a

This was referenced Jun 12, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
[browser][ST] Wasm tests timeout #103246
Closed

MihaZupan merged commit 5f91817 into dotnet:mainJun 12, 2024

TrayanZapryanov deleted the optimize_httputility_UrlPathEncode2 branch June 13, 2024 06:31

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 31, 2024

gfoidl reviewed May 31, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 31, 2024
[browser][MT] Tests timed out #102559
Closed

MihaZupan approved these changes May 31, 2024
View reviewed changes

Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs

MihaZupan added this to the 9.0.0 milestone May 31, 2024

MihaZupan approved these changes Jun 3, 2024
View reviewed changes

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from 051f1c9 to bc43beeCompare June 4, 2024 11:59

This was referenced Jun 5, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
[wasm] ystem addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL. #103060
Closed

Trayan-Zapryanov added 4 commits June 12, 2024 16:35

Reduce allocation in HttpUtility.UrlPathEncode.
e920339

Add feedback optimizations
6961eff

new feedback
82cdaf2

fix rebase
fda0521

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from bc43bee to fda0521Compare June 12, 2024 13:38

Remove HttpEncoderUtility.cs as it is not used anymore
8cb7c0a

This was referenced Jun 12, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
[browser][ST] Wasm tests timeout #103246
Closed

MihaZupan merged commit 5f91817 into dotnet:mainJun 12, 2024

TrayanZapryanov deleted the optimize_httputility_UrlPathEncode2 branch June 13, 2024 06:31

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 31, 2024

gfoidl reviewed May 31, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 31, 2024
[browser][MT] Tests timed out #102559
Closed

MihaZupan approved these changes May 31, 2024
View reviewed changes

Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs

MihaZupan added this to the 9.0.0 milestone May 31, 2024

MihaZupan approved these changes Jun 3, 2024
View reviewed changes

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from 051f1c9 to bc43beeCompare June 4, 2024 11:59

This was referenced Jun 5, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
[wasm] ystem addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL. #103060
Closed

Trayan-Zapryanov added 4 commits June 12, 2024 16:35

Reduce allocation in HttpUtility.UrlPathEncode.
e920339

Add feedback optimizations
6961eff

new feedback
82cdaf2

fix rebase
fda0521

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from bc43bee to fda0521Compare June 12, 2024 13:38

Remove HttpEncoderUtility.cs as it is not used anymore
8cb7c0a

This was referenced Jun 12, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
[browser][ST] Wasm tests timeout #103246
Closed

MihaZupan merged commit 5f91817 into dotnet:mainJun 12, 2024

TrayanZapryanov deleted the optimize_httputility_UrlPathEncode2 branch June 13, 2024 06:31

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 31, 2024

gfoidl reviewed May 31, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 31, 2024
[browser][MT] Tests timed out #102559
Closed

MihaZupan approved these changes May 31, 2024
View reviewed changes

Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs

MihaZupan added this to the 9.0.0 milestone May 31, 2024

MihaZupan approved these changes Jun 3, 2024
View reviewed changes

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from 051f1c9 to bc43beeCompare June 4, 2024 11:59

This was referenced Jun 5, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
[wasm] ystem addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL. #103060
Closed

Trayan-Zapryanov added 4 commits June 12, 2024 16:35

Reduce allocation in HttpUtility.UrlPathEncode.
e920339

Add feedback optimizations
6961eff

new feedback
82cdaf2

fix rebase
fda0521

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from bc43bee to fda0521Compare June 12, 2024 13:38

Remove HttpEncoderUtility.cs as it is not used anymore
8cb7c0a

This was referenced Jun 12, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
[browser][ST] Wasm tests timeout #103246
Closed

MihaZupan merged commit 5f91817 into dotnet:mainJun 12, 2024

TrayanZapryanov deleted the optimize_httputility_UrlPathEncode2 branch June 13, 2024 06:31

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 31, 2024

gfoidl reviewed May 31, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 31, 2024
[browser][MT] Tests timed out #102559
Closed

MihaZupan approved these changes May 31, 2024
View reviewed changes

Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs

MihaZupan added this to the 9.0.0 milestone May 31, 2024

MihaZupan approved these changes Jun 3, 2024
View reviewed changes

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from 051f1c9 to bc43beeCompare June 4, 2024 11:59

This was referenced Jun 5, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
[wasm] ystem addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL. #103060
Closed

Trayan-Zapryanov added 4 commits June 12, 2024 16:35

Reduce allocation in HttpUtility.UrlPathEncode.
e920339

Add feedback optimizations
6961eff

new feedback
82cdaf2

fix rebase
fda0521

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from bc43bee to fda0521Compare June 12, 2024 13:38

Remove HttpEncoderUtility.cs as it is not used anymore
8cb7c0a

This was referenced Jun 12, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
[browser][ST] Wasm tests timeout #103246
Closed

MihaZupan merged commit 5f91817 into dotnet:mainJun 12, 2024

TrayanZapryanov deleted the optimize_httputility_UrlPathEncode2 branch June 13, 2024 06:31

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 31, 2024

gfoidl reviewed May 31, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 31, 2024
[browser][MT] Tests timed out #102559
Closed

MihaZupan approved these changes May 31, 2024
View reviewed changes

Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs

MihaZupan added this to the 9.0.0 milestone May 31, 2024

MihaZupan approved these changes Jun 3, 2024
View reviewed changes

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from 051f1c9 to bc43beeCompare June 4, 2024 11:59

This was referenced Jun 5, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
[wasm] ystem addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL. #103060
Closed

Trayan-Zapryanov added 4 commits June 12, 2024 16:35

Reduce allocation in HttpUtility.UrlPathEncode.
e920339

Add feedback optimizations
6961eff

new feedback
82cdaf2

fix rebase
fda0521

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from bc43bee to fda0521Compare June 12, 2024 13:38

Remove HttpEncoderUtility.cs as it is not used anymore
8cb7c0a

This was referenced Jun 12, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
[browser][ST] Wasm tests timeout #103246
Closed

MihaZupan merged commit 5f91817 into dotnet:mainJun 12, 2024

TrayanZapryanov deleted the optimize_httputility_UrlPathEncode2 branch June 13, 2024 06:31

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 31, 2024

gfoidl reviewed May 31, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 31, 2024
[browser][MT] Tests timed out #102559
Closed

MihaZupan approved these changes May 31, 2024
View reviewed changes

Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs Outdated
Comment threadsrc/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoder.cs

MihaZupan added this to the 9.0.0 milestone May 31, 2024

MihaZupan approved these changes Jun 3, 2024
View reviewed changes

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from 051f1c9 to bc43beeCompare June 4, 2024 11:59

This was referenced Jun 5, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
[wasm] ystem addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL. #103060
Closed

Trayan-Zapryanov added 4 commits June 12, 2024 16:35

Reduce allocation in HttpUtility.UrlPathEncode.
e920339

Add feedback optimizations
6961eff

new feedback
82cdaf2

fix rebase
fda0521

TrayanZapryanov force-pushed the optimize_httputility_UrlPathEncode2 branch from bc43bee to fda0521Compare June 12, 2024 13:38

Remove HttpEncoderUtility.cs as it is not used anymore
8cb7c0a

This was referenced Jun 12, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
[browser][ST] Wasm tests timeout #103246
Closed

MihaZupan merged commit 5f91817 into dotnet:mainJun 12, 2024

TrayanZapryanov deleted the optimize_httputility_UrlPathEncode2 branch June 13, 2024 06:31

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

Uh oh!

Conversation

TrayanZapryanov commented May 31, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MihaZupan commented Jun 7, 2024

Uh oh!

TrayanZapryanov commented Jun 12, 2024

Uh oh!

MihaZupan commented Jun 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

TrayanZapryanov commented May 31, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MihaZupan commented Jun 7, 2024

Uh oh!

TrayanZapryanov commented Jun 12, 2024

Uh oh!

MihaZupan commented Jun 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

TrayanZapryanov commented May 31, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MihaZupan commented Jun 7, 2024

Uh oh!

TrayanZapryanov commented Jun 12, 2024

Uh oh!

MihaZupan commented Jun 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

TrayanZapryanov commented May 31, 2024

Uh oh!

Uh oh!