[cdac] Basic ISOSDacInterface::GetMethodDescData by lambdageek · Pull Request #106413 · dotnet/runtime

lambdageek · 2024-08-14T19:45:18Z

Currently only works on non-generic non-R2R methods (and probably only ones that are still Tier0)

TODO:

Separate the contracts: Precode, Code Versions, ReJIT and ExecutionManager are separate ideas
Contract markdown
Extract a LoaderAllocator contract
Use the cached LoaderModule members from MethodDescChunk and FnPtrTypeDesc
Unit tests
Backport the data descriptor and precode descriptor changes to .net 9 [feature/9.0-cdac-backports] Data descriptor changes for GetMethodDescName #106463

contributes to #99302

dotnet-policy-service · 2024-08-14T19:46:21Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Extracted from dotnet#106413

davidwrighton · 2024-08-21T23:43:31Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


I think we'll want to have a LoaderAllocator contract. There is a bunch of ... stuff... on there, and I feel like we'll likely need something there.

For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

davidwrighton · 2024-08-21T23:50:28Z

+ public virtual bool IsVersionable(MethodDescHandle methodDesc);
+
+ // Return a pointer to the IL versioning state of the MethodDesc
+ public virtual TargetPointer GetMethodDescVersioningState(MethodDescHandle methodDesc);


We're going to need the ability to walk the list of IL versions, and Native code versions, and query various details about these things. This doesn't feel like the right api. Could you get it onto the CodeVersions contract?

This just extracts the address from the MethodDescCodeData. All the logic for working with the versioning state is in CodeVersions.
It's not that different from
TargetPointermodAddr=RuntimeTypeSystem.GetModule(TypeHandleth); ModuleHandlemod=Loader.GetModuleHandle(modAddr);
RTS gives you a pointer and Loader turns it into a handle that you can use for queries. Similarly RTS will give a pointer to the versioning state and CodeVersions will consume it in some manner.
Currently the versioning state is consumed entirely internally in the CodeVersions contract, but in the future it could be exposed via a handle or through some data API (see GetSpecificNativeCodeVersion and IsActiveNativeCodeVersion implementations)

elinor-fung · 2024-08-22T23:19:46Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

dotnet-policy-service · 2024-10-12T14:06:47Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

lambdageek · 2024-08-14T19:45:18Z

Currently only works on non-generic non-R2R methods (and probably only ones that are still Tier0)

TODO:

Separate the contracts: Precode, Code Versions, ReJIT and ExecutionManager are separate ideas
Contract markdown
Extract a LoaderAllocator contract
Use the cached LoaderModule members from MethodDescChunk and FnPtrTypeDesc
Unit tests
Backport the data descriptor and precode descriptor changes to .net 9 [feature/9.0-cdac-backports] Data descriptor changes for GetMethodDescName #106463

contributes to #99302

dotnet-policy-service · 2024-08-14T19:46:21Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Extracted from dotnet#106413

davidwrighton · 2024-08-21T23:43:31Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


I think we'll want to have a LoaderAllocator contract. There is a bunch of ... stuff... on there, and I feel like we'll likely need something there.

For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

davidwrighton · 2024-08-21T23:50:28Z

+ public virtual bool IsVersionable(MethodDescHandle methodDesc);
+
+ // Return a pointer to the IL versioning state of the MethodDesc
+ public virtual TargetPointer GetMethodDescVersioningState(MethodDescHandle methodDesc);


We're going to need the ability to walk the list of IL versions, and Native code versions, and query various details about these things. This doesn't feel like the right api. Could you get it onto the CodeVersions contract?

This just extracts the address from the MethodDescCodeData. All the logic for working with the versioning state is in CodeVersions.
It's not that different from
TargetPointermodAddr=RuntimeTypeSystem.GetModule(TypeHandleth); ModuleHandlemod=Loader.GetModuleHandle(modAddr);
RTS gives you a pointer and Loader turns it into a handle that you can use for queries. Similarly RTS will give a pointer to the versioning state and CodeVersions will consume it in some manner.
Currently the versioning state is consumed entirely internally in the CodeVersions contract, but in the future it could be exposed via a handle or through some data API (see GetSpecificNativeCodeVersion and IsActiveNativeCodeVersion implementations)

elinor-fung · 2024-08-22T23:19:46Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

dotnet-policy-service · 2024-10-12T14:06:47Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

lambdageek · 2024-08-14T19:45:18Z

Currently only works on non-generic non-R2R methods (and probably only ones that are still Tier0)

TODO:

Separate the contracts: Precode, Code Versions, ReJIT and ExecutionManager are separate ideas
Contract markdown
Extract a LoaderAllocator contract
Use the cached LoaderModule members from MethodDescChunk and FnPtrTypeDesc
Unit tests
Backport the data descriptor and precode descriptor changes to .net 9 [feature/9.0-cdac-backports] Data descriptor changes for GetMethodDescName #106463

contributes to #99302

dotnet-policy-service · 2024-08-14T19:46:21Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Extracted from dotnet#106413

davidwrighton · 2024-08-21T23:43:31Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


I think we'll want to have a LoaderAllocator contract. There is a bunch of ... stuff... on there, and I feel like we'll likely need something there.

For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

davidwrighton · 2024-08-21T23:50:28Z

+ public virtual bool IsVersionable(MethodDescHandle methodDesc);
+
+ // Return a pointer to the IL versioning state of the MethodDesc
+ public virtual TargetPointer GetMethodDescVersioningState(MethodDescHandle methodDesc);


We're going to need the ability to walk the list of IL versions, and Native code versions, and query various details about these things. This doesn't feel like the right api. Could you get it onto the CodeVersions contract?

This just extracts the address from the MethodDescCodeData. All the logic for working with the versioning state is in CodeVersions.
It's not that different from
TargetPointermodAddr=RuntimeTypeSystem.GetModule(TypeHandleth); ModuleHandlemod=Loader.GetModuleHandle(modAddr);
RTS gives you a pointer and Loader turns it into a handle that you can use for queries. Similarly RTS will give a pointer to the versioning state and CodeVersions will consume it in some manner.
Currently the versioning state is consumed entirely internally in the CodeVersions contract, but in the future it could be exposed via a handle or through some data API (see GetSpecificNativeCodeVersion and IsActiveNativeCodeVersion implementations)

elinor-fung · 2024-08-22T23:19:46Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

dotnet-policy-service · 2024-10-12T14:06:47Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

lambdageek · 2024-08-14T19:45:18Z

Currently only works on non-generic non-R2R methods (and probably only ones that are still Tier0)

TODO:

Separate the contracts: Precode, Code Versions, ReJIT and ExecutionManager are separate ideas
Contract markdown
Extract a LoaderAllocator contract
Use the cached LoaderModule members from MethodDescChunk and FnPtrTypeDesc
Unit tests
Backport the data descriptor and precode descriptor changes to .net 9 [feature/9.0-cdac-backports] Data descriptor changes for GetMethodDescName #106463

contributes to #99302

dotnet-policy-service · 2024-08-14T19:46:21Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Extracted from dotnet#106413

davidwrighton · 2024-08-21T23:43:31Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


I think we'll want to have a LoaderAllocator contract. There is a bunch of ... stuff... on there, and I feel like we'll likely need something there.

For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

davidwrighton · 2024-08-21T23:50:28Z

+ public virtual bool IsVersionable(MethodDescHandle methodDesc);
+
+ // Return a pointer to the IL versioning state of the MethodDesc
+ public virtual TargetPointer GetMethodDescVersioningState(MethodDescHandle methodDesc);


We're going to need the ability to walk the list of IL versions, and Native code versions, and query various details about these things. This doesn't feel like the right api. Could you get it onto the CodeVersions contract?

This just extracts the address from the MethodDescCodeData. All the logic for working with the versioning state is in CodeVersions.
It's not that different from
TargetPointermodAddr=RuntimeTypeSystem.GetModule(TypeHandleth); ModuleHandlemod=Loader.GetModuleHandle(modAddr);
RTS gives you a pointer and Loader turns it into a handle that you can use for queries. Similarly RTS will give a pointer to the versioning state and CodeVersions will consume it in some manner.
Currently the versioning state is consumed entirely internally in the CodeVersions contract, but in the future it could be exposed via a handle or through some data API (see GetSpecificNativeCodeVersion and IsActiveNativeCodeVersion implementations)

elinor-fung · 2024-08-22T23:19:46Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

dotnet-policy-service · 2024-10-12T14:06:47Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

lambdageek · 2024-08-14T19:45:18Z

Currently only works on non-generic non-R2R methods (and probably only ones that are still Tier0)

TODO:

Separate the contracts: Precode, Code Versions, ReJIT and ExecutionManager are separate ideas
Contract markdown
Extract a LoaderAllocator contract
Use the cached LoaderModule members from MethodDescChunk and FnPtrTypeDesc
Unit tests
Backport the data descriptor and precode descriptor changes to .net 9 [feature/9.0-cdac-backports] Data descriptor changes for GetMethodDescName #106463

contributes to #99302

dotnet-policy-service · 2024-08-14T19:46:21Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Extracted from dotnet#106413

davidwrighton · 2024-08-21T23:43:31Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


I think we'll want to have a LoaderAllocator contract. There is a bunch of ... stuff... on there, and I feel like we'll likely need something there.

For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

davidwrighton · 2024-08-21T23:50:28Z

+ public virtual bool IsVersionable(MethodDescHandle methodDesc);
+
+ // Return a pointer to the IL versioning state of the MethodDesc
+ public virtual TargetPointer GetMethodDescVersioningState(MethodDescHandle methodDesc);


We're going to need the ability to walk the list of IL versions, and Native code versions, and query various details about these things. This doesn't feel like the right api. Could you get it onto the CodeVersions contract?

This just extracts the address from the MethodDescCodeData. All the logic for working with the versioning state is in CodeVersions.
It's not that different from
TargetPointermodAddr=RuntimeTypeSystem.GetModule(TypeHandleth); ModuleHandlemod=Loader.GetModuleHandle(modAddr);
RTS gives you a pointer and Loader turns it into a handle that you can use for queries. Similarly RTS will give a pointer to the versioning state and CodeVersions will consume it in some manner.
Currently the versioning state is consumed entirely internally in the CodeVersions contract, but in the future it could be exposed via a handle or through some data API (see GetSpecificNativeCodeVersion and IsActiveNativeCodeVersion implementations)

elinor-fung · 2024-08-22T23:19:46Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

dotnet-policy-service · 2024-10-12T14:06:47Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

lambdageek · 2024-08-14T19:45:18Z

Currently only works on non-generic non-R2R methods (and probably only ones that are still Tier0)

TODO:

Separate the contracts: Precode, Code Versions, ReJIT and ExecutionManager are separate ideas
Contract markdown
Extract a LoaderAllocator contract
Use the cached LoaderModule members from MethodDescChunk and FnPtrTypeDesc
Unit tests
Backport the data descriptor and precode descriptor changes to .net 9 [feature/9.0-cdac-backports] Data descriptor changes for GetMethodDescName #106463

contributes to #99302

dotnet-policy-service · 2024-08-14T19:46:21Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Extracted from dotnet#106413

davidwrighton · 2024-08-21T23:43:31Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


I think we'll want to have a LoaderAllocator contract. There is a bunch of ... stuff... on there, and I feel like we'll likely need something there.

For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

davidwrighton · 2024-08-21T23:50:28Z

+ public virtual bool IsVersionable(MethodDescHandle methodDesc);
+
+ // Return a pointer to the IL versioning state of the MethodDesc
+ public virtual TargetPointer GetMethodDescVersioningState(MethodDescHandle methodDesc);


We're going to need the ability to walk the list of IL versions, and Native code versions, and query various details about these things. This doesn't feel like the right api. Could you get it onto the CodeVersions contract?

This just extracts the address from the MethodDescCodeData. All the logic for working with the versioning state is in CodeVersions.
It's not that different from
TargetPointermodAddr=RuntimeTypeSystem.GetModule(TypeHandleth); ModuleHandlemod=Loader.GetModuleHandle(modAddr);
RTS gives you a pointer and Loader turns it into a handle that you can use for queries. Similarly RTS will give a pointer to the versioning state and CodeVersions will consume it in some manner.
Currently the versioning state is consumed entirely internally in the CodeVersions contract, but in the future it could be exposed via a handle or through some data API (see GetSpecificNativeCodeVersion and IsActiveNativeCodeVersion implementations)

elinor-fung · 2024-08-22T23:19:46Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

dotnet-policy-service · 2024-10-12T14:06:47Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

lambdageek · 2024-08-14T19:45:18Z

Currently only works on non-generic non-R2R methods (and probably only ones that are still Tier0)

TODO:

Separate the contracts: Precode, Code Versions, ReJIT and ExecutionManager are separate ideas
Contract markdown
Extract a LoaderAllocator contract
Use the cached LoaderModule members from MethodDescChunk and FnPtrTypeDesc
Unit tests
Backport the data descriptor and precode descriptor changes to .net 9 [feature/9.0-cdac-backports] Data descriptor changes for GetMethodDescName #106463

contributes to #99302

dotnet-policy-service · 2024-08-14T19:46:21Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Extracted from dotnet#106413

davidwrighton · 2024-08-21T23:43:31Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


I think we'll want to have a LoaderAllocator contract. There is a bunch of ... stuff... on there, and I feel like we'll likely need something there.

For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

davidwrighton · 2024-08-21T23:50:28Z

+ public virtual bool IsVersionable(MethodDescHandle methodDesc);
+
+ // Return a pointer to the IL versioning state of the MethodDesc
+ public virtual TargetPointer GetMethodDescVersioningState(MethodDescHandle methodDesc);


We're going to need the ability to walk the list of IL versions, and Native code versions, and query various details about these things. This doesn't feel like the right api. Could you get it onto the CodeVersions contract?

This just extracts the address from the MethodDescCodeData. All the logic for working with the versioning state is in CodeVersions.
It's not that different from
TargetPointermodAddr=RuntimeTypeSystem.GetModule(TypeHandleth); ModuleHandlemod=Loader.GetModuleHandle(modAddr);
RTS gives you a pointer and Loader turns it into a handle that you can use for queries. Similarly RTS will give a pointer to the versioning state and CodeVersions will consume it in some manner.
Currently the versioning state is consumed entirely internally in the CodeVersions contract, but in the future it could be exposed via a handle or through some data API (see GetSpecificNativeCodeVersion and IsActiveNativeCodeVersion implementations)

elinor-fung · 2024-08-22T23:19:46Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

dotnet-policy-service · 2024-10-12T14:06:47Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

lambdageek · 2024-08-14T19:45:18Z

Currently only works on non-generic non-R2R methods (and probably only ones that are still Tier0)

TODO:

Separate the contracts: Precode, Code Versions, ReJIT and ExecutionManager are separate ideas
Contract markdown
Extract a LoaderAllocator contract
Use the cached LoaderModule members from MethodDescChunk and FnPtrTypeDesc
Unit tests
Backport the data descriptor and precode descriptor changes to .net 9 [feature/9.0-cdac-backports] Data descriptor changes for GetMethodDescName #106463

contributes to #99302

dotnet-policy-service · 2024-08-14T19:46:21Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Extracted from dotnet#106413

davidwrighton · 2024-08-21T23:43:31Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


I think we'll want to have a LoaderAllocator contract. There is a bunch of ... stuff... on there, and I feel like we'll likely need something there.

For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

davidwrighton · 2024-08-21T23:50:28Z

+ public virtual bool IsVersionable(MethodDescHandle methodDesc);
+
+ // Return a pointer to the IL versioning state of the MethodDesc
+ public virtual TargetPointer GetMethodDescVersioningState(MethodDescHandle methodDesc);


We're going to need the ability to walk the list of IL versions, and Native code versions, and query various details about these things. This doesn't feel like the right api. Could you get it onto the CodeVersions contract?

This just extracts the address from the MethodDescCodeData. All the logic for working with the versioning state is in CodeVersions.
It's not that different from
TargetPointermodAddr=RuntimeTypeSystem.GetModule(TypeHandleth); ModuleHandlemod=Loader.GetModuleHandle(modAddr);
RTS gives you a pointer and Loader turns it into a handle that you can use for queries. Similarly RTS will give a pointer to the versioning state and CodeVersions will consume it in some manner.
Currently the versioning state is consumed entirely internally in the CodeVersions contract, but in the future it could be exposed via a handle or through some data API (see GetSpecificNativeCodeVersion and IsActiveNativeCodeVersion implementations)

elinor-fung · 2024-08-22T23:19:46Z

 TargetPointer GetILBase(ModuleHandle handle);
 ModuleLookupTables GetLookupTables(ModuleHandle handle);
+TargetPointer GetModuleLookupMapElement(TargetPointer table, uint rid, out TargetNUInt flags);
+bool IsCollectibleLoaderAllocator(ModuleHandle handle);


For this particular API (checking if the module is collectible), it seems like it should cut out the LoaderAllocator concept? Since once you're at the Module (instead of a MethodDesc), the module's IsCollectible should match the module's loader allocator's IsCollectible.

dotnet-policy-service · 2024-10-12T14:06:47Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton and elinor-fung August 14, 2024 19:45

lambdageek added the area-Diagnostics-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

This was referenced Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData #106417
Closed
[cdac] Implement !PrintException#99302
Closed

This was referenced Aug 14, 2024
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed
Test failure baseservices\\exceptions\\stackoverflow\\stackoverflowtester\\stackoverflowtester.cmd #84911
Closed

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 15, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
c44a09f
Extracted from dotnet#106413

lambdageek force-pushed the cdac-nativecodeptr branch from ebdeb59 to 2383fd2Compare August 15, 2024 15:00

lambdageek added 10 commits August 19, 2024 10:14

wip: NativeCodePointers and MethodDesc CodeData
601938d

checkpoint: PrecodeMachineDescriptor and KnownPrecodeType
5f3599c

checkpoint: StubPrecodeData, StubCodePageSize
2cf8fd4

GetTemporaryEntryPointIfExists
7ef9016

wip GetMethodEntryPointIfExists
9cf7a7a

add contract
2d1e34e

add missing descriptor fields
2d4252a

fix data descriptor reads
c83ad25

add FixupPrecodeData
c6dae6f

add size of MethodDesc
43e1748

lambdageek added 3 commits August 19, 2024 10:14

fix build
f1d757e

placeholder ExecutionManager contract
f1d7be8

placeholder ExecutionManager contract; updates to RTS and Loader
ebb4a67

lambdageek force-pushed the cdac-nativecodeptr branch from 79bbf28 to ebb4a67Compare August 19, 2024 14:14

refactor ExecutionManager
aac3faf

lambdageek force-pushed the cdac-nativecodeptr branch from e9fe709 to aac3fafCompare August 19, 2024 17:46

build-analysisBot mentioned this pull request Aug 19, 2024
'chrome-GetPropertiesTests' timing out #106625
Closed

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threadsrc/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.NonValidated.cs Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

lambdageekand others added 3 commits August 22, 2024 13:42

remove dead method from contract
ef51f0e

fix typo
92764a2

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
4e1a620

elinor-fung reviewed Aug 22, 2024
View reviewed changes

build-analysisBot mentioned this pull request Aug 23, 2024
Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928
Open
3 tasks

lambdageek added 2 commits August 23, 2024 12:32

Apply suggestions from code review
037c349

Add PrecodeStubs contract writeup
25d8343

This was referenced Aug 23, 2024
System.Threading.ThreadPool.Tests fail in CI with System.Net.Sockets.SocketException #106371
Closed
XmlSerializerTests.Xml_DerivedIXmlSerializable is failing on linux-musl legs #106865
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
ac0165a

lambdageek mentioned this pull request Sep 11, 2024
[cdac] break up cdacreader into 4 separate assemblies #107709
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
8f5e98b

lambdageek mentioned this pull request Sep 24, 2024
[cdac] break up cdacreader into 4 separate assemblies #108156
Merged

lambdageek mentioned this pull request Oct 4, 2024
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed
33 tasks

dotnet-policy-serviceBot closed this Oct 12, 2024

github-actionsBot locked and limited conversation to collaborators Nov 12, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton and elinor-fung August 14, 2024 19:45

lambdageek added the area-Diagnostics-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

This was referenced Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData #106417
Closed
[cdac] Implement !PrintException#99302
Closed

This was referenced Aug 14, 2024
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed
Test failure baseservices\\exceptions\\stackoverflow\\stackoverflowtester\\stackoverflowtester.cmd #84911
Closed

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 15, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
c44a09f
Extracted from dotnet#106413

lambdageek force-pushed the cdac-nativecodeptr branch from ebdeb59 to 2383fd2Compare August 15, 2024 15:00

lambdageek added 10 commits August 19, 2024 10:14

wip: NativeCodePointers and MethodDesc CodeData
601938d

checkpoint: PrecodeMachineDescriptor and KnownPrecodeType
5f3599c

checkpoint: StubPrecodeData, StubCodePageSize
2cf8fd4

GetTemporaryEntryPointIfExists
7ef9016

wip GetMethodEntryPointIfExists
9cf7a7a

add contract
2d1e34e

add missing descriptor fields
2d4252a

fix data descriptor reads
c83ad25

add FixupPrecodeData
c6dae6f

add size of MethodDesc
43e1748

lambdageek added 3 commits August 19, 2024 10:14

fix build
f1d757e

placeholder ExecutionManager contract
f1d7be8

placeholder ExecutionManager contract; updates to RTS and Loader
ebb4a67

lambdageek force-pushed the cdac-nativecodeptr branch from 79bbf28 to ebb4a67Compare August 19, 2024 14:14

refactor ExecutionManager
aac3faf

lambdageek force-pushed the cdac-nativecodeptr branch from e9fe709 to aac3fafCompare August 19, 2024 17:46

build-analysisBot mentioned this pull request Aug 19, 2024
'chrome-GetPropertiesTests' timing out #106625
Closed

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threadsrc/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.NonValidated.cs Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

lambdageekand others added 3 commits August 22, 2024 13:42

remove dead method from contract
ef51f0e

fix typo
92764a2

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
4e1a620

elinor-fung reviewed Aug 22, 2024
View reviewed changes

build-analysisBot mentioned this pull request Aug 23, 2024
Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928
Open
3 tasks

lambdageek added 2 commits August 23, 2024 12:32

Apply suggestions from code review
037c349

Add PrecodeStubs contract writeup
25d8343

This was referenced Aug 23, 2024
System.Threading.ThreadPool.Tests fail in CI with System.Net.Sockets.SocketException #106371
Closed
XmlSerializerTests.Xml_DerivedIXmlSerializable is failing on linux-musl legs #106865
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
ac0165a

lambdageek mentioned this pull request Sep 11, 2024
[cdac] break up cdacreader into 4 separate assemblies #107709
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
8f5e98b

lambdageek mentioned this pull request Sep 24, 2024
[cdac] break up cdacreader into 4 separate assemblies #108156
Merged

lambdageek mentioned this pull request Oct 4, 2024
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed
33 tasks

dotnet-policy-serviceBot closed this Oct 12, 2024

github-actionsBot locked and limited conversation to collaborators Nov 12, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton and elinor-fung August 14, 2024 19:45

lambdageek added the area-Diagnostics-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

This was referenced Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData #106417
Closed
[cdac] Implement !PrintException#99302
Closed

This was referenced Aug 14, 2024
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed
Test failure baseservices\\exceptions\\stackoverflow\\stackoverflowtester\\stackoverflowtester.cmd #84911
Closed

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 15, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
c44a09f
Extracted from dotnet#106413

lambdageek force-pushed the cdac-nativecodeptr branch from ebdeb59 to 2383fd2Compare August 15, 2024 15:00

lambdageek added 10 commits August 19, 2024 10:14

wip: NativeCodePointers and MethodDesc CodeData
601938d

checkpoint: PrecodeMachineDescriptor and KnownPrecodeType
5f3599c

checkpoint: StubPrecodeData, StubCodePageSize
2cf8fd4

GetTemporaryEntryPointIfExists
7ef9016

wip GetMethodEntryPointIfExists
9cf7a7a

add contract
2d1e34e

add missing descriptor fields
2d4252a

fix data descriptor reads
c83ad25

add FixupPrecodeData
c6dae6f

add size of MethodDesc
43e1748

lambdageek added 3 commits August 19, 2024 10:14

fix build
f1d757e

placeholder ExecutionManager contract
f1d7be8

placeholder ExecutionManager contract; updates to RTS and Loader
ebb4a67

lambdageek force-pushed the cdac-nativecodeptr branch from 79bbf28 to ebb4a67Compare August 19, 2024 14:14

refactor ExecutionManager
aac3faf

lambdageek force-pushed the cdac-nativecodeptr branch from e9fe709 to aac3fafCompare August 19, 2024 17:46

build-analysisBot mentioned this pull request Aug 19, 2024
'chrome-GetPropertiesTests' timing out #106625
Closed

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threadsrc/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.NonValidated.cs Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

lambdageekand others added 3 commits August 22, 2024 13:42

remove dead method from contract
ef51f0e

fix typo
92764a2

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
4e1a620

elinor-fung reviewed Aug 22, 2024
View reviewed changes

build-analysisBot mentioned this pull request Aug 23, 2024
Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928
Open
3 tasks

lambdageek added 2 commits August 23, 2024 12:32

Apply suggestions from code review
037c349

Add PrecodeStubs contract writeup
25d8343

This was referenced Aug 23, 2024
System.Threading.ThreadPool.Tests fail in CI with System.Net.Sockets.SocketException #106371
Closed
XmlSerializerTests.Xml_DerivedIXmlSerializable is failing on linux-musl legs #106865
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
ac0165a

lambdageek mentioned this pull request Sep 11, 2024
[cdac] break up cdacreader into 4 separate assemblies #107709
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
8f5e98b

lambdageek mentioned this pull request Sep 24, 2024
[cdac] break up cdacreader into 4 separate assemblies #108156
Merged

lambdageek mentioned this pull request Oct 4, 2024
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed
33 tasks

dotnet-policy-serviceBot closed this Oct 12, 2024

github-actionsBot locked and limited conversation to collaborators Nov 12, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton and elinor-fung August 14, 2024 19:45

lambdageek added the area-Diagnostics-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

This was referenced Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData #106417
Closed
[cdac] Implement !PrintException#99302
Closed

This was referenced Aug 14, 2024
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed
Test failure baseservices\\exceptions\\stackoverflow\\stackoverflowtester\\stackoverflowtester.cmd #84911
Closed

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 15, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
c44a09f
Extracted from dotnet#106413

lambdageek force-pushed the cdac-nativecodeptr branch from ebdeb59 to 2383fd2Compare August 15, 2024 15:00

lambdageek added 10 commits August 19, 2024 10:14

wip: NativeCodePointers and MethodDesc CodeData
601938d

checkpoint: PrecodeMachineDescriptor and KnownPrecodeType
5f3599c

checkpoint: StubPrecodeData, StubCodePageSize
2cf8fd4

GetTemporaryEntryPointIfExists
7ef9016

wip GetMethodEntryPointIfExists
9cf7a7a

add contract
2d1e34e

add missing descriptor fields
2d4252a

fix data descriptor reads
c83ad25

add FixupPrecodeData
c6dae6f

add size of MethodDesc
43e1748

lambdageek added 3 commits August 19, 2024 10:14

fix build
f1d757e

placeholder ExecutionManager contract
f1d7be8

placeholder ExecutionManager contract; updates to RTS and Loader
ebb4a67

lambdageek force-pushed the cdac-nativecodeptr branch from 79bbf28 to ebb4a67Compare August 19, 2024 14:14

refactor ExecutionManager
aac3faf

lambdageek force-pushed the cdac-nativecodeptr branch from e9fe709 to aac3fafCompare August 19, 2024 17:46

build-analysisBot mentioned this pull request Aug 19, 2024
'chrome-GetPropertiesTests' timing out #106625
Closed

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threadsrc/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.NonValidated.cs Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

lambdageekand others added 3 commits August 22, 2024 13:42

remove dead method from contract
ef51f0e

fix typo
92764a2

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
4e1a620

elinor-fung reviewed Aug 22, 2024
View reviewed changes

build-analysisBot mentioned this pull request Aug 23, 2024
Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928
Open
3 tasks

lambdageek added 2 commits August 23, 2024 12:32

Apply suggestions from code review
037c349

Add PrecodeStubs contract writeup
25d8343

This was referenced Aug 23, 2024
System.Threading.ThreadPool.Tests fail in CI with System.Net.Sockets.SocketException #106371
Closed
XmlSerializerTests.Xml_DerivedIXmlSerializable is failing on linux-musl legs #106865
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
ac0165a

lambdageek mentioned this pull request Sep 11, 2024
[cdac] break up cdacreader into 4 separate assemblies #107709
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
8f5e98b

lambdageek mentioned this pull request Sep 24, 2024
[cdac] break up cdacreader into 4 separate assemblies #108156
Merged

lambdageek mentioned this pull request Oct 4, 2024
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed
33 tasks

dotnet-policy-serviceBot closed this Oct 12, 2024

github-actionsBot locked and limited conversation to collaborators Nov 12, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton and elinor-fung August 14, 2024 19:45

lambdageek added the area-Diagnostics-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

This was referenced Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData #106417
Closed
[cdac] Implement !PrintException#99302
Closed

This was referenced Aug 14, 2024
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed
Test failure baseservices\\exceptions\\stackoverflow\\stackoverflowtester\\stackoverflowtester.cmd #84911
Closed

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 15, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
c44a09f
Extracted from dotnet#106413

lambdageek force-pushed the cdac-nativecodeptr branch from ebdeb59 to 2383fd2Compare August 15, 2024 15:00

lambdageek added 10 commits August 19, 2024 10:14

wip: NativeCodePointers and MethodDesc CodeData
601938d

checkpoint: PrecodeMachineDescriptor and KnownPrecodeType
5f3599c

checkpoint: StubPrecodeData, StubCodePageSize
2cf8fd4

GetTemporaryEntryPointIfExists
7ef9016

wip GetMethodEntryPointIfExists
9cf7a7a

add contract
2d1e34e

add missing descriptor fields
2d4252a

fix data descriptor reads
c83ad25

add FixupPrecodeData
c6dae6f

add size of MethodDesc
43e1748

lambdageek added 3 commits August 19, 2024 10:14

fix build
f1d757e

placeholder ExecutionManager contract
f1d7be8

placeholder ExecutionManager contract; updates to RTS and Loader
ebb4a67

lambdageek force-pushed the cdac-nativecodeptr branch from 79bbf28 to ebb4a67Compare August 19, 2024 14:14

refactor ExecutionManager
aac3faf

lambdageek force-pushed the cdac-nativecodeptr branch from e9fe709 to aac3fafCompare August 19, 2024 17:46

build-analysisBot mentioned this pull request Aug 19, 2024
'chrome-GetPropertiesTests' timing out #106625
Closed

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threadsrc/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.NonValidated.cs Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

lambdageekand others added 3 commits August 22, 2024 13:42

remove dead method from contract
ef51f0e

fix typo
92764a2

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
4e1a620

elinor-fung reviewed Aug 22, 2024
View reviewed changes

build-analysisBot mentioned this pull request Aug 23, 2024
Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928
Open
3 tasks

lambdageek added 2 commits August 23, 2024 12:32

Apply suggestions from code review
037c349

Add PrecodeStubs contract writeup
25d8343

This was referenced Aug 23, 2024
System.Threading.ThreadPool.Tests fail in CI with System.Net.Sockets.SocketException #106371
Closed
XmlSerializerTests.Xml_DerivedIXmlSerializable is failing on linux-musl legs #106865
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
ac0165a

lambdageek mentioned this pull request Sep 11, 2024
[cdac] break up cdacreader into 4 separate assemblies #107709
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
8f5e98b

lambdageek mentioned this pull request Sep 24, 2024
[cdac] break up cdacreader into 4 separate assemblies #108156
Merged

lambdageek mentioned this pull request Oct 4, 2024
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed
33 tasks

dotnet-policy-serviceBot closed this Oct 12, 2024

github-actionsBot locked and limited conversation to collaborators Nov 12, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton and elinor-fung August 14, 2024 19:45

lambdageek added the area-Diagnostics-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

This was referenced Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData #106417
Closed
[cdac] Implement !PrintException#99302
Closed

This was referenced Aug 14, 2024
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed
Test failure baseservices\\exceptions\\stackoverflow\\stackoverflowtester\\stackoverflowtester.cmd #84911
Closed

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 15, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
c44a09f
Extracted from dotnet#106413

lambdageek force-pushed the cdac-nativecodeptr branch from ebdeb59 to 2383fd2Compare August 15, 2024 15:00

lambdageek added 10 commits August 19, 2024 10:14

wip: NativeCodePointers and MethodDesc CodeData
601938d

checkpoint: PrecodeMachineDescriptor and KnownPrecodeType
5f3599c

checkpoint: StubPrecodeData, StubCodePageSize
2cf8fd4

GetTemporaryEntryPointIfExists
7ef9016

wip GetMethodEntryPointIfExists
9cf7a7a

add contract
2d1e34e

add missing descriptor fields
2d4252a

fix data descriptor reads
c83ad25

add FixupPrecodeData
c6dae6f

add size of MethodDesc
43e1748

lambdageek added 3 commits August 19, 2024 10:14

fix build
f1d757e

placeholder ExecutionManager contract
f1d7be8

placeholder ExecutionManager contract; updates to RTS and Loader
ebb4a67

lambdageek force-pushed the cdac-nativecodeptr branch from 79bbf28 to ebb4a67Compare August 19, 2024 14:14

refactor ExecutionManager
aac3faf

lambdageek force-pushed the cdac-nativecodeptr branch from e9fe709 to aac3fafCompare August 19, 2024 17:46

build-analysisBot mentioned this pull request Aug 19, 2024
'chrome-GetPropertiesTests' timing out #106625
Closed

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threadsrc/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.NonValidated.cs Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

lambdageekand others added 3 commits August 22, 2024 13:42

remove dead method from contract
ef51f0e

fix typo
92764a2

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
4e1a620

elinor-fung reviewed Aug 22, 2024
View reviewed changes

build-analysisBot mentioned this pull request Aug 23, 2024
Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928
Open
3 tasks

lambdageek added 2 commits August 23, 2024 12:32

Apply suggestions from code review
037c349

Add PrecodeStubs contract writeup
25d8343

This was referenced Aug 23, 2024
System.Threading.ThreadPool.Tests fail in CI with System.Net.Sockets.SocketException #106371
Closed
XmlSerializerTests.Xml_DerivedIXmlSerializable is failing on linux-musl legs #106865
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
ac0165a

lambdageek mentioned this pull request Sep 11, 2024
[cdac] break up cdacreader into 4 separate assemblies #107709
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
8f5e98b

lambdageek mentioned this pull request Sep 24, 2024
[cdac] break up cdacreader into 4 separate assemblies #108156
Merged

lambdageek mentioned this pull request Oct 4, 2024
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed
33 tasks

dotnet-policy-serviceBot closed this Oct 12, 2024

github-actionsBot locked and limited conversation to collaborators Nov 12, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton and elinor-fung August 14, 2024 19:45

lambdageek added the area-Diagnostics-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

This was referenced Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData #106417
Closed
[cdac] Implement !PrintException#99302
Closed

This was referenced Aug 14, 2024
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed
Test failure baseservices\\exceptions\\stackoverflow\\stackoverflowtester\\stackoverflowtester.cmd #84911
Closed

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 15, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
c44a09f
Extracted from dotnet#106413

lambdageek force-pushed the cdac-nativecodeptr branch from ebdeb59 to 2383fd2Compare August 15, 2024 15:00

lambdageek added 10 commits August 19, 2024 10:14

wip: NativeCodePointers and MethodDesc CodeData
601938d

checkpoint: PrecodeMachineDescriptor and KnownPrecodeType
5f3599c

checkpoint: StubPrecodeData, StubCodePageSize
2cf8fd4

GetTemporaryEntryPointIfExists
7ef9016

wip GetMethodEntryPointIfExists
9cf7a7a

add contract
2d1e34e

add missing descriptor fields
2d4252a

fix data descriptor reads
c83ad25

add FixupPrecodeData
c6dae6f

add size of MethodDesc
43e1748

lambdageek added 3 commits August 19, 2024 10:14

fix build
f1d757e

placeholder ExecutionManager contract
f1d7be8

placeholder ExecutionManager contract; updates to RTS and Loader
ebb4a67

lambdageek force-pushed the cdac-nativecodeptr branch from 79bbf28 to ebb4a67Compare August 19, 2024 14:14

refactor ExecutionManager
aac3faf

lambdageek force-pushed the cdac-nativecodeptr branch from e9fe709 to aac3fafCompare August 19, 2024 17:46

build-analysisBot mentioned this pull request Aug 19, 2024
'chrome-GetPropertiesTests' timing out #106625
Closed

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threadsrc/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.NonValidated.cs Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

lambdageekand others added 3 commits August 22, 2024 13:42

remove dead method from contract
ef51f0e

fix typo
92764a2

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
4e1a620

elinor-fung reviewed Aug 22, 2024
View reviewed changes

build-analysisBot mentioned this pull request Aug 23, 2024
Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928
Open
3 tasks

lambdageek added 2 commits August 23, 2024 12:32

Apply suggestions from code review
037c349

Add PrecodeStubs contract writeup
25d8343

This was referenced Aug 23, 2024
System.Threading.ThreadPool.Tests fail in CI with System.Net.Sockets.SocketException #106371
Closed
XmlSerializerTests.Xml_DerivedIXmlSerializable is failing on linux-musl legs #106865
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
ac0165a

lambdageek mentioned this pull request Sep 11, 2024
[cdac] break up cdacreader into 4 separate assemblies #107709
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
8f5e98b

lambdageek mentioned this pull request Sep 24, 2024
[cdac] break up cdacreader into 4 separate assemblies #108156
Merged

lambdageek mentioned this pull request Oct 4, 2024
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed
33 tasks

dotnet-policy-serviceBot closed this Oct 12, 2024

github-actionsBot locked and limited conversation to collaborators Nov 12, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton and elinor-fung August 14, 2024 19:45

lambdageek added the area-Diagnostics-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 14, 2024

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

This was referenced Aug 14, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData #106417
Closed
[cdac] Implement !PrintException#99302
Closed

This was referenced Aug 14, 2024
System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783
Closed
Test failure baseservices\\exceptions\\stackoverflow\\stackoverflowtester\\stackoverflowtester.cmd #84911
Closed

lambdageek added a commit to lambdageek/runtime that referenced this pull request Aug 15, 2024
[cdac][.NET9] Data descriptor changes for GetMethodDescData
c44a09f
Extracted from dotnet#106413

lambdageek force-pushed the cdac-nativecodeptr branch from ebdeb59 to 2383fd2Compare August 15, 2024 15:00

lambdageek added 10 commits August 19, 2024 10:14

wip: NativeCodePointers and MethodDesc CodeData
601938d

checkpoint: PrecodeMachineDescriptor and KnownPrecodeType
5f3599c

checkpoint: StubPrecodeData, StubCodePageSize
2cf8fd4

GetTemporaryEntryPointIfExists
7ef9016

wip GetMethodEntryPointIfExists
9cf7a7a

add contract
2d1e34e

add missing descriptor fields
2d4252a

fix data descriptor reads
c83ad25

add FixupPrecodeData
c6dae6f

add size of MethodDesc
43e1748

lambdageek added 3 commits August 19, 2024 10:14

fix build
f1d757e

placeholder ExecutionManager contract
f1d7be8

placeholder ExecutionManager contract; updates to RTS and Loader
ebb4a67

lambdageek force-pushed the cdac-nativecodeptr branch from 79bbf28 to ebb4a67Compare August 19, 2024 14:14

refactor ExecutionManager
aac3faf

lambdageek force-pushed the cdac-nativecodeptr branch from e9fe709 to aac3fafCompare August 19, 2024 17:46

build-analysisBot mentioned this pull request Aug 19, 2024
'chrome-GetPropertiesTests' timing out #106625
Closed

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

Comment threadsrc/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_1.NonValidated.cs Outdated

davidwrighton reviewed Aug 21, 2024
View reviewed changes

lambdageekand others added 3 commits August 22, 2024 13:42

remove dead method from contract
ef51f0e

fix typo
92764a2

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
4e1a620

elinor-fung reviewed Aug 22, 2024
View reviewed changes

build-analysisBot mentioned this pull request Aug 23, 2024
Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928
Open
3 tasks

lambdageek added 2 commits August 23, 2024 12:32

Apply suggestions from code review
037c349

Add PrecodeStubs contract writeup
25d8343

This was referenced Aug 23, 2024
System.Threading.ThreadPool.Tests fail in CI with System.Net.Sockets.SocketException #106371
Closed
XmlSerializerTests.Xml_DerivedIXmlSerializable is failing on linux-musl legs #106865
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
ac0165a

lambdageek mentioned this pull request Sep 11, 2024
[cdac] break up cdacreader into 4 separate assemblies #107709
Closed

Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr
8f5e98b

lambdageek mentioned this pull request Sep 24, 2024
[cdac] break up cdacreader into 4 separate assemblies #108156
Merged

lambdageek mentioned this pull request Oct 4, 2024
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed
33 tasks

dotnet-policy-serviceBot closed this Oct 12, 2024

github-actionsBot locked and limited conversation to collaborators Nov 12, 2024

Uh oh!

Conversation

lambdageek commented Aug 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Aug 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Oct 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

lambdageek commented Aug 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Aug 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Oct 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

lambdageek commented Aug 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Aug 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

lambdageek commented Aug 14, 2024•
edited
Loading

lambdageek commented Aug 14, 2024•
edited
Loading

lambdageek commented Aug 14, 2024•
edited
Loading

lambdageek commented Aug 14, 2024•
edited
Loading