[cdac][.NET9] Data descriptor changes for GetMethodDescData by lambdageek · Pull Request #106417 · dotnet/runtime

lambdageek · 2024-08-14T20:10:20Z

Extracted from #106413

The main new thing here is a PrecodeMachineDescriptor struct and global: this is used to copy out the enum values and masks that show how to manipulate precode stubs to figure out what kind of a stub we're looking at.

Contributes to #99302

Extracted from dotnet#106413

dotnet-policy-service · 2024-08-14T20:10:58Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

carlossanlop · 2024-08-14T20:24:32Z

@jkotas @AaronRobinsonMSFT @davidwrighton @elinor-fung please help reviewing this PR. @lambdageek has requested that I wait for it before the RC1 snap if possible.

AaronRobinsonMSFT

Do we need to update any markdown?

AaronRobinsonMSFT · 2024-08-14T20:43:10Z

 bool m_fMarked;
 int m_nGCCount;
-bool m_IsCollectible;
+BYTE m_IsCollectible;


Suggested change
BYTE m_IsCollectible;
constBYTE m_IsCollectible;

So it turns out we can't make m_IsCollectibleconst. The reason is because LoaderAllocator is a DAC-ized base class and the VPTR_BASE_VTABLE_CLASS macro adds a LoaderAllocator(TADDR addr, TADDR vtAddr) {} constructor which doesn't include an initializer for m_IsCollectible which results in a compilation error:
E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(291): error C2789: 'LoaderAllocator::m_IsCollectible' : an object of const-qualified type must be initialized E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(335): note: see declaration of 'LoaderAllocator::m_Is Collectible'

elinor-fung · 2024-08-14T21:01:55Z

Do we need to update any markdown?

Not for this portion - this is the data descriptors (and the new struct/global in runtime to better represent needed data), not tied to contracts yet.

davidwrighton · 2024-08-14T21:05:12Z


+PrecodeMachineDescriptor g_PrecodeMachineDescriptor;
+
+void PrecodeMachineDescriptor::Init()


Why is there an Init routine as well as a set of non-static data member initializers here?

I need to delete the initializers, that was an idea that didn't work out

Are you doing this before you want this checked in? Given the snap deadline, I think we should probably miss it, and do a backport of the data descriptors when we're ready in reality to declare that .NET 9 might actually be useable with the cDAC and CLRMA. In general, I'm leery of stuff that has a static initializer, and that's what we have here now, and I don't see us fixing this before the snap happens.

Yea, let's miss the snap. I can't fix and validate this in the next couple hours

lambdageek · 2024-08-14T22:05:17Z

@carlossanlop I'm going to close this and do a back port after the snap, it needs more work

lambdageek · 2024-08-14T20:10:20Z

Extracted from #106413

The main new thing here is a PrecodeMachineDescriptor struct and global: this is used to copy out the enum values and masks that show how to manipulate precode stubs to figure out what kind of a stub we're looking at.

Contributes to #99302

Extracted from dotnet#106413

dotnet-policy-service · 2024-08-14T20:10:58Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

carlossanlop · 2024-08-14T20:24:32Z

@jkotas @AaronRobinsonMSFT @davidwrighton @elinor-fung please help reviewing this PR. @lambdageek has requested that I wait for it before the RC1 snap if possible.

AaronRobinsonMSFT

Do we need to update any markdown?

AaronRobinsonMSFT · 2024-08-14T20:43:10Z

 bool m_fMarked;
 int m_nGCCount;
-bool m_IsCollectible;
+BYTE m_IsCollectible;


Suggested change
BYTE m_IsCollectible;
constBYTE m_IsCollectible;

So it turns out we can't make m_IsCollectibleconst. The reason is because LoaderAllocator is a DAC-ized base class and the VPTR_BASE_VTABLE_CLASS macro adds a LoaderAllocator(TADDR addr, TADDR vtAddr) {} constructor which doesn't include an initializer for m_IsCollectible which results in a compilation error:
E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(291): error C2789: 'LoaderAllocator::m_IsCollectible' : an object of const-qualified type must be initialized E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(335): note: see declaration of 'LoaderAllocator::m_Is Collectible'

elinor-fung · 2024-08-14T21:01:55Z

Do we need to update any markdown?

Not for this portion - this is the data descriptors (and the new struct/global in runtime to better represent needed data), not tied to contracts yet.

davidwrighton · 2024-08-14T21:05:12Z


+PrecodeMachineDescriptor g_PrecodeMachineDescriptor;
+
+void PrecodeMachineDescriptor::Init()


Why is there an Init routine as well as a set of non-static data member initializers here?

I need to delete the initializers, that was an idea that didn't work out

Are you doing this before you want this checked in? Given the snap deadline, I think we should probably miss it, and do a backport of the data descriptors when we're ready in reality to declare that .NET 9 might actually be useable with the cDAC and CLRMA. In general, I'm leery of stuff that has a static initializer, and that's what we have here now, and I don't see us fixing this before the snap happens.

Yea, let's miss the snap. I can't fix and validate this in the next couple hours

lambdageek · 2024-08-14T22:05:17Z

@carlossanlop I'm going to close this and do a back port after the snap, it needs more work

lambdageek · 2024-08-14T20:10:20Z

Extracted from #106413

The main new thing here is a PrecodeMachineDescriptor struct and global: this is used to copy out the enum values and masks that show how to manipulate precode stubs to figure out what kind of a stub we're looking at.

Contributes to #99302

Extracted from dotnet#106413

dotnet-policy-service · 2024-08-14T20:10:58Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

carlossanlop · 2024-08-14T20:24:32Z

@jkotas @AaronRobinsonMSFT @davidwrighton @elinor-fung please help reviewing this PR. @lambdageek has requested that I wait for it before the RC1 snap if possible.

AaronRobinsonMSFT

Do we need to update any markdown?

AaronRobinsonMSFT · 2024-08-14T20:43:10Z

 bool m_fMarked;
 int m_nGCCount;
-bool m_IsCollectible;
+BYTE m_IsCollectible;


Suggested change
BYTE m_IsCollectible;
constBYTE m_IsCollectible;

So it turns out we can't make m_IsCollectibleconst. The reason is because LoaderAllocator is a DAC-ized base class and the VPTR_BASE_VTABLE_CLASS macro adds a LoaderAllocator(TADDR addr, TADDR vtAddr) {} constructor which doesn't include an initializer for m_IsCollectible which results in a compilation error:
E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(291): error C2789: 'LoaderAllocator::m_IsCollectible' : an object of const-qualified type must be initialized E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(335): note: see declaration of 'LoaderAllocator::m_Is Collectible'

elinor-fung · 2024-08-14T21:01:55Z

Do we need to update any markdown?

Not for this portion - this is the data descriptors (and the new struct/global in runtime to better represent needed data), not tied to contracts yet.

davidwrighton · 2024-08-14T21:05:12Z


+PrecodeMachineDescriptor g_PrecodeMachineDescriptor;
+
+void PrecodeMachineDescriptor::Init()


Why is there an Init routine as well as a set of non-static data member initializers here?

I need to delete the initializers, that was an idea that didn't work out

Are you doing this before you want this checked in? Given the snap deadline, I think we should probably miss it, and do a backport of the data descriptors when we're ready in reality to declare that .NET 9 might actually be useable with the cDAC and CLRMA. In general, I'm leery of stuff that has a static initializer, and that's what we have here now, and I don't see us fixing this before the snap happens.

Yea, let's miss the snap. I can't fix and validate this in the next couple hours

lambdageek · 2024-08-14T22:05:17Z

@carlossanlop I'm going to close this and do a back port after the snap, it needs more work

lambdageek · 2024-08-14T20:10:20Z

Extracted from #106413

The main new thing here is a PrecodeMachineDescriptor struct and global: this is used to copy out the enum values and masks that show how to manipulate precode stubs to figure out what kind of a stub we're looking at.

Contributes to #99302

Extracted from dotnet#106413

dotnet-policy-service · 2024-08-14T20:10:58Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

carlossanlop · 2024-08-14T20:24:32Z

@jkotas @AaronRobinsonMSFT @davidwrighton @elinor-fung please help reviewing this PR. @lambdageek has requested that I wait for it before the RC1 snap if possible.

AaronRobinsonMSFT

Do we need to update any markdown?

AaronRobinsonMSFT · 2024-08-14T20:43:10Z

 bool m_fMarked;
 int m_nGCCount;
-bool m_IsCollectible;
+BYTE m_IsCollectible;


Suggested change
BYTE m_IsCollectible;
constBYTE m_IsCollectible;

So it turns out we can't make m_IsCollectibleconst. The reason is because LoaderAllocator is a DAC-ized base class and the VPTR_BASE_VTABLE_CLASS macro adds a LoaderAllocator(TADDR addr, TADDR vtAddr) {} constructor which doesn't include an initializer for m_IsCollectible which results in a compilation error:
E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(291): error C2789: 'LoaderAllocator::m_IsCollectible' : an object of const-qualified type must be initialized E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(335): note: see declaration of 'LoaderAllocator::m_Is Collectible'

elinor-fung · 2024-08-14T21:01:55Z

Do we need to update any markdown?

Not for this portion - this is the data descriptors (and the new struct/global in runtime to better represent needed data), not tied to contracts yet.

davidwrighton · 2024-08-14T21:05:12Z


+PrecodeMachineDescriptor g_PrecodeMachineDescriptor;
+
+void PrecodeMachineDescriptor::Init()


Why is there an Init routine as well as a set of non-static data member initializers here?

I need to delete the initializers, that was an idea that didn't work out

Are you doing this before you want this checked in? Given the snap deadline, I think we should probably miss it, and do a backport of the data descriptors when we're ready in reality to declare that .NET 9 might actually be useable with the cDAC and CLRMA. In general, I'm leery of stuff that has a static initializer, and that's what we have here now, and I don't see us fixing this before the snap happens.

Yea, let's miss the snap. I can't fix and validate this in the next couple hours

lambdageek · 2024-08-14T22:05:17Z

@carlossanlop I'm going to close this and do a back port after the snap, it needs more work

lambdageek · 2024-08-14T20:10:20Z

Extracted from #106413

The main new thing here is a PrecodeMachineDescriptor struct and global: this is used to copy out the enum values and masks that show how to manipulate precode stubs to figure out what kind of a stub we're looking at.

Contributes to #99302

Extracted from dotnet#106413

dotnet-policy-service · 2024-08-14T20:10:58Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

carlossanlop · 2024-08-14T20:24:32Z

@jkotas @AaronRobinsonMSFT @davidwrighton @elinor-fung please help reviewing this PR. @lambdageek has requested that I wait for it before the RC1 snap if possible.

AaronRobinsonMSFT

Do we need to update any markdown?

AaronRobinsonMSFT · 2024-08-14T20:43:10Z

 bool m_fMarked;
 int m_nGCCount;
-bool m_IsCollectible;
+BYTE m_IsCollectible;


Suggested change
BYTE m_IsCollectible;
constBYTE m_IsCollectible;

So it turns out we can't make m_IsCollectibleconst. The reason is because LoaderAllocator is a DAC-ized base class and the VPTR_BASE_VTABLE_CLASS macro adds a LoaderAllocator(TADDR addr, TADDR vtAddr) {} constructor which doesn't include an initializer for m_IsCollectible which results in a compilation error:
E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(291): error C2789: 'LoaderAllocator::m_IsCollectible' : an object of const-qualified type must be initialized E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(335): note: see declaration of 'LoaderAllocator::m_Is Collectible'

elinor-fung · 2024-08-14T21:01:55Z

Do we need to update any markdown?

Not for this portion - this is the data descriptors (and the new struct/global in runtime to better represent needed data), not tied to contracts yet.

davidwrighton · 2024-08-14T21:05:12Z


+PrecodeMachineDescriptor g_PrecodeMachineDescriptor;
+
+void PrecodeMachineDescriptor::Init()


Why is there an Init routine as well as a set of non-static data member initializers here?

I need to delete the initializers, that was an idea that didn't work out

Are you doing this before you want this checked in? Given the snap deadline, I think we should probably miss it, and do a backport of the data descriptors when we're ready in reality to declare that .NET 9 might actually be useable with the cDAC and CLRMA. In general, I'm leery of stuff that has a static initializer, and that's what we have here now, and I don't see us fixing this before the snap happens.

Yea, let's miss the snap. I can't fix and validate this in the next couple hours

lambdageek · 2024-08-14T22:05:17Z

@carlossanlop I'm going to close this and do a back port after the snap, it needs more work

lambdageek · 2024-08-14T20:10:20Z

Extracted from #106413

The main new thing here is a PrecodeMachineDescriptor struct and global: this is used to copy out the enum values and masks that show how to manipulate precode stubs to figure out what kind of a stub we're looking at.

Contributes to #99302

Extracted from dotnet#106413

dotnet-policy-service · 2024-08-14T20:10:58Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

carlossanlop · 2024-08-14T20:24:32Z

@jkotas @AaronRobinsonMSFT @davidwrighton @elinor-fung please help reviewing this PR. @lambdageek has requested that I wait for it before the RC1 snap if possible.

AaronRobinsonMSFT

Do we need to update any markdown?

AaronRobinsonMSFT · 2024-08-14T20:43:10Z

 bool m_fMarked;
 int m_nGCCount;
-bool m_IsCollectible;
+BYTE m_IsCollectible;


Suggested change
BYTE m_IsCollectible;
constBYTE m_IsCollectible;

So it turns out we can't make m_IsCollectibleconst. The reason is because LoaderAllocator is a DAC-ized base class and the VPTR_BASE_VTABLE_CLASS macro adds a LoaderAllocator(TADDR addr, TADDR vtAddr) {} constructor which doesn't include an initializer for m_IsCollectible which results in a compilation error:
E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(291): error C2789: 'LoaderAllocator::m_IsCollectible' : an object of const-qualified type must be initialized E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(335): note: see declaration of 'LoaderAllocator::m_Is Collectible'

elinor-fung · 2024-08-14T21:01:55Z

Do we need to update any markdown?

Not for this portion - this is the data descriptors (and the new struct/global in runtime to better represent needed data), not tied to contracts yet.

davidwrighton · 2024-08-14T21:05:12Z


+PrecodeMachineDescriptor g_PrecodeMachineDescriptor;
+
+void PrecodeMachineDescriptor::Init()


Why is there an Init routine as well as a set of non-static data member initializers here?

I need to delete the initializers, that was an idea that didn't work out

Are you doing this before you want this checked in? Given the snap deadline, I think we should probably miss it, and do a backport of the data descriptors when we're ready in reality to declare that .NET 9 might actually be useable with the cDAC and CLRMA. In general, I'm leery of stuff that has a static initializer, and that's what we have here now, and I don't see us fixing this before the snap happens.

Yea, let's miss the snap. I can't fix and validate this in the next couple hours

lambdageek · 2024-08-14T22:05:17Z

@carlossanlop I'm going to close this and do a back port after the snap, it needs more work

lambdageek · 2024-08-14T20:10:20Z

Extracted from #106413

The main new thing here is a PrecodeMachineDescriptor struct and global: this is used to copy out the enum values and masks that show how to manipulate precode stubs to figure out what kind of a stub we're looking at.

Contributes to #99302

Extracted from dotnet#106413

dotnet-policy-service · 2024-08-14T20:10:58Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

carlossanlop · 2024-08-14T20:24:32Z

@jkotas @AaronRobinsonMSFT @davidwrighton @elinor-fung please help reviewing this PR. @lambdageek has requested that I wait for it before the RC1 snap if possible.

AaronRobinsonMSFT

Do we need to update any markdown?

AaronRobinsonMSFT · 2024-08-14T20:43:10Z

 bool m_fMarked;
 int m_nGCCount;
-bool m_IsCollectible;
+BYTE m_IsCollectible;


Suggested change
BYTE m_IsCollectible;
constBYTE m_IsCollectible;

So it turns out we can't make m_IsCollectibleconst. The reason is because LoaderAllocator is a DAC-ized base class and the VPTR_BASE_VTABLE_CLASS macro adds a LoaderAllocator(TADDR addr, TADDR vtAddr) {} constructor which doesn't include an initializer for m_IsCollectible which results in a compilation error:
E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(291): error C2789: 'LoaderAllocator::m_IsCollectible' : an object of const-qualified type must be initialized E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(335): note: see declaration of 'LoaderAllocator::m_Is Collectible'

elinor-fung · 2024-08-14T21:01:55Z

Do we need to update any markdown?

Not for this portion - this is the data descriptors (and the new struct/global in runtime to better represent needed data), not tied to contracts yet.

davidwrighton · 2024-08-14T21:05:12Z


+PrecodeMachineDescriptor g_PrecodeMachineDescriptor;
+
+void PrecodeMachineDescriptor::Init()


Why is there an Init routine as well as a set of non-static data member initializers here?

I need to delete the initializers, that was an idea that didn't work out

Are you doing this before you want this checked in? Given the snap deadline, I think we should probably miss it, and do a backport of the data descriptors when we're ready in reality to declare that .NET 9 might actually be useable with the cDAC and CLRMA. In general, I'm leery of stuff that has a static initializer, and that's what we have here now, and I don't see us fixing this before the snap happens.

Yea, let's miss the snap. I can't fix and validate this in the next couple hours

lambdageek · 2024-08-14T22:05:17Z

@carlossanlop I'm going to close this and do a back port after the snap, it needs more work

lambdageek · 2024-08-14T20:10:20Z

Extracted from #106413

The main new thing here is a PrecodeMachineDescriptor struct and global: this is used to copy out the enum values and masks that show how to manipulate precode stubs to figure out what kind of a stub we're looking at.

Contributes to #99302

Extracted from dotnet#106413

dotnet-policy-service · 2024-08-14T20:10:58Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

carlossanlop · 2024-08-14T20:24:32Z

@jkotas @AaronRobinsonMSFT @davidwrighton @elinor-fung please help reviewing this PR. @lambdageek has requested that I wait for it before the RC1 snap if possible.

AaronRobinsonMSFT

Do we need to update any markdown?

AaronRobinsonMSFT · 2024-08-14T20:43:10Z

 bool m_fMarked;
 int m_nGCCount;
-bool m_IsCollectible;
+BYTE m_IsCollectible;


Suggested change
BYTE m_IsCollectible;
constBYTE m_IsCollectible;

So it turns out we can't make m_IsCollectibleconst. The reason is because LoaderAllocator is a DAC-ized base class and the VPTR_BASE_VTABLE_CLASS macro adds a LoaderAllocator(TADDR addr, TADDR vtAddr) {} constructor which doesn't include an initializer for m_IsCollectible which results in a compilation error:
E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(291): error C2789: 'LoaderAllocator::m_IsCollectible' : an object of const-qualified type must be initialized E:\dotnet-runtime\runtime-m\src\coreclr\vm\loaderallocator.hpp(335): note: see declaration of 'LoaderAllocator::m_Is Collectible'

elinor-fung · 2024-08-14T21:01:55Z

Do we need to update any markdown?

Not for this portion - this is the data descriptors (and the new struct/global in runtime to better represent needed data), not tied to contracts yet.

davidwrighton · 2024-08-14T21:05:12Z


+PrecodeMachineDescriptor g_PrecodeMachineDescriptor;
+
+void PrecodeMachineDescriptor::Init()


Why is there an Init routine as well as a set of non-static data member initializers here?

I need to delete the initializers, that was an idea that didn't work out

Are you doing this before you want this checked in? Given the snap deadline, I think we should probably miss it, and do a backport of the data descriptors when we're ready in reality to declare that .NET 9 might actually be useable with the cDAC and CLRMA. In general, I'm leery of stuff that has a static initializer, and that's what we have here now, and I don't see us fixing this before the snap happens.

Yea, let's miss the snap. I can't fix and validate this in the next couple hours

lambdageek · 2024-08-14T22:05:17Z

@carlossanlop I'm going to close this and do a back port after the snap, it needs more work

[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

ghost added the area-VM-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Implement !PrintException#99302
Closed
25 tasks

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and jkotas August 14, 2024 20:11

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Basic ISOSDacInterface::GetMethodDescData #106413
Closed
6 tasks

AaronRobinsonMSFT reviewed Aug 14, 2024
View reviewed changes

davidwrighton reviewed Aug 14, 2024
View reviewed changes

lambdageek closed this Aug 14, 2024

github-actionsBot locked and limited conversation to collaborators Sep 15, 2024

[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

ghost added the area-VM-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Implement !PrintException#99302
Closed
25 tasks

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and jkotas August 14, 2024 20:11

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Basic ISOSDacInterface::GetMethodDescData #106413
Closed
6 tasks

AaronRobinsonMSFT reviewed Aug 14, 2024
View reviewed changes

davidwrighton reviewed Aug 14, 2024
View reviewed changes

lambdageek closed this Aug 14, 2024

github-actionsBot locked and limited conversation to collaborators Sep 15, 2024

[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

ghost added the area-VM-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Implement !PrintException#99302
Closed
25 tasks

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and jkotas August 14, 2024 20:11

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Basic ISOSDacInterface::GetMethodDescData #106413
Closed
6 tasks

AaronRobinsonMSFT reviewed Aug 14, 2024
View reviewed changes

davidwrighton reviewed Aug 14, 2024
View reviewed changes

lambdageek closed this Aug 14, 2024

github-actionsBot locked and limited conversation to collaborators Sep 15, 2024

[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

ghost added the area-VM-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Implement !PrintException#99302
Closed
25 tasks

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and jkotas August 14, 2024 20:11

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Basic ISOSDacInterface::GetMethodDescData #106413
Closed
6 tasks

AaronRobinsonMSFT reviewed Aug 14, 2024
View reviewed changes

davidwrighton reviewed Aug 14, 2024
View reviewed changes

lambdageek closed this Aug 14, 2024

github-actionsBot locked and limited conversation to collaborators Sep 15, 2024

[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

ghost added the area-VM-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Implement !PrintException#99302
Closed
25 tasks

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and jkotas August 14, 2024 20:11

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Basic ISOSDacInterface::GetMethodDescData #106413
Closed
6 tasks

AaronRobinsonMSFT reviewed Aug 14, 2024
View reviewed changes

davidwrighton reviewed Aug 14, 2024
View reviewed changes

lambdageek closed this Aug 14, 2024

github-actionsBot locked and limited conversation to collaborators Sep 15, 2024

[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

ghost added the area-VM-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Implement !PrintException#99302
Closed
25 tasks

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and jkotas August 14, 2024 20:11

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Basic ISOSDacInterface::GetMethodDescData #106413
Closed
6 tasks

AaronRobinsonMSFT reviewed Aug 14, 2024
View reviewed changes

davidwrighton reviewed Aug 14, 2024
View reviewed changes

lambdageek closed this Aug 14, 2024

github-actionsBot locked and limited conversation to collaborators Sep 15, 2024

[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

ghost added the area-VM-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Implement !PrintException#99302
Closed
25 tasks

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and jkotas August 14, 2024 20:11

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Basic ISOSDacInterface::GetMethodDescData #106413
Closed
6 tasks

AaronRobinsonMSFT reviewed Aug 14, 2024
View reviewed changes

davidwrighton reviewed Aug 14, 2024
View reviewed changes

lambdageek closed this Aug 14, 2024

github-actionsBot locked and limited conversation to collaborators Sep 15, 2024

[cdac][.NET9] Data descriptor changes for GetMethodDescData
1e28fa3
Extracted from dotnet#106413

ghost added the area-VM-coreclr label Aug 14, 2024

dotnet-policy-serviceBot assigned lambdageek Aug 14, 2024

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Implement !PrintException#99302
Closed
25 tasks

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and jkotas August 14, 2024 20:11

lambdageek mentioned this pull request Aug 14, 2024
[cdac] Basic ISOSDacInterface::GetMethodDescData #106413
Closed
6 tasks

AaronRobinsonMSFT reviewed Aug 14, 2024
View reviewed changes

davidwrighton reviewed Aug 14, 2024
View reviewed changes

lambdageek closed this Aug 14, 2024

github-actionsBot locked and limited conversation to collaborators Sep 15, 2024


		PrecodeMachineDescriptor g_PrecodeMachineDescriptor;

		void PrecodeMachineDescriptor::Init()

Uh oh!

Conversation

lambdageek commented Aug 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Aug 14, 2024

Uh oh!

carlossanlop commented Aug 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elinor-fung commented Aug 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lambdageek commented Aug 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

lambdageek commented Aug 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Aug 14, 2024

Uh oh!

carlossanlop commented Aug 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elinor-fung commented Aug 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lambdageek commented Aug 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

lambdageek commented Aug 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Aug 14, 2024

lambdageek commented Aug 14, 2024•
edited
Loading

carlossanlop commented Aug 14, 2024•
edited
Loading

lambdageek commented Aug 14, 2024•
edited
Loading

carlossanlop commented Aug 14, 2024•
edited
Loading

lambdageek commented Aug 14, 2024•
edited
Loading

carlossanlop commented Aug 14, 2024•
edited
Loading

lambdageek commented Aug 14, 2024•
edited
Loading