Unhandled exception handler. by VSadov · Pull Request #109806 · dotnet/runtime

VSadov · 2024-11-14T03:09:50Z

The managed part of #101560
It implements the public static void SetUnhandledExceptionHandler(UnhandledExceptionHandler handler); API

This covers CoreCLR and NativeAOT.
(Mono will need to be addressed separately)

ghost · 2024-11-14T03:09:58Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-11-14T03:09:59Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-11-14T03:12:06Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

dotnet-policy-service · 2024-11-14T03:12:07Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

VSadov · 2024-11-15T01:32:23Z

Build browser-wasm linux Release LibraryTests is timing out at build stage. It is probably not related to the changes in this PR

VSadov · 2024-11-15T01:35:47Z

I think this is ready for review.

VSadov · 2024-11-15T01:40:42Z

(Mono will need to be addressed separately)

That is because I am far less familiar with where the relevant pieces are in Mono, so I'd like to get CoreCLR/NativeAOT and tests settled.
I may need help with Mono.

janvorli · 2024-11-18T20:44:43Z

+#include <pthread.h>
+#endif // _WIN32
+
+// Work around typedef redefinition: platformdefines.h defines error_t


I wonder if the platformdefines.h should be fixed instead to not to define the error_t and include the errno.h instead.

janvorli · 2024-11-18T20:54:39Z

+public class PInvokeRevPInvokeUnhandled
+{
+ [DllImport("ForeignThreadRevPInvokeUnhandled")]
+ public static extern void InvokeCallback(MyCallback callback);


I cannot see this being used in this test

I just copied the file between two tests. One uses InvokeCallback another uses InvokeCallbackOnNewThread. I can remove redundant ones.

…handledTrivial.cs

jkotas

LGTM. Thank you!

VSadov · 2024-11-25T23:59:33Z

The failure in x86 tests is #110127

VSadov · 2024-11-26T00:02:30Z

/ba-g #110127

teo-tsirpanis · 2024-11-26T01:03:23Z

+
+namespace System.Runtime.ExceptionServices
+{
+ public delegate bool UnhandledExceptionHandler(System.Exception exception);


@VSadov the approved API shape used Func<Exception, bool> instead of a custom delegate.

@VSadov the approved API shape used Func<Exception, bool> instead of a custom delegate.
@VSadov do you have plans to address this? We cannot check in new unapproved public APIs.

Opened #110254.

do you have plans to address this? We cannot check in new unapproved public APIs.
Yes. It was an oversight.
The approved shape was the same as in proposal except for this part. I missed that there was a diff from the proposal.

* unhandled exceptions in Finalizers (Core and AOT) * catch in threadpool * handle in threads * trivial tests * HandlerThrows * HandlerRefuses * NoEffectInMainThread * Rev PInvoke tests * make all pri-0 and disable on mono * use ?. * whitespaces * rename unhandledHandler-->UnhandledExceptionHandler * PR feedback * define error_t as int * ref/System.Runtime formatting * Update src/tests/baseservices/exceptions/UnhandledExceptionHandler/UnhandledTrivial.cs --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

The latest daily build of the .NET 10 SDK fails to build the msbuild repo due to the following build error: ``` /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(1330,41): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/Components/ProjectCache/ProjectCacheService.cs(875,17): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(1437,57): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(1448,41): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(1584,17): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(1806,49): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(1879,21): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(1879,66): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(2483,44): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(2484,161): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(2493,169): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] /repos/dotnet/src/msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs(2976,41): error CS0104: 'ExceptionHandling' is an ambiguous reference between 'Microsoft.Build.Shared.ExceptionHandling' and 'System.Runtime.ExceptionServices.ExceptionHandling' [/repos/dotnet/src/msbuild/src/Build/Microsoft.Build.csproj] ``` This is due to a conflict in a class name with a new public class from runtime: dotnet/runtime#109806 Fixed by explicitly defining the namespace to use. This was found as part of the work on dotnet/sdk#45435.

ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Nov 14, 2024

dotnet-policy-serviceBot assigned VSadov Nov 14, 2024

VSadov force-pushed the unh branch from a3f9ae0 to 8602588Compare November 14, 2024 03:12

jkotas removed area-VM-coreclr area-NativeAOT-coreclr labels Nov 14, 2024

VSadov marked this pull request as ready for review November 15, 2024 01:35

VSadov requested a review from MichalStrehovsky as a code owner November 15, 2024 01:35

VSadov requested review from janvorli and jkotas and removed request for MichalStrehovsky November 15, 2024 01:35

unhandled exceptions in Finalizers (Core and AOT)
5c15489

VSadov added 3 commits November 15, 2024 08:54

NoEffectInMainThread
8bd32f2

Rev PInvoke tests
e9aeb09

make all pri-0 and disable on mono
eff45d1

VSadov force-pushed the unh branch from 8602588 to eff45d1Compare November 15, 2024 16:54

jkotas reviewed Nov 16, 2024
View reviewed changes

janvorli reviewed Nov 18, 2024
View reviewed changes

MichalStrehovsky reviewed Nov 19, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime.Base/src/System/Runtime/__Finalizer.cs

VSadovand others added 6 commits November 23, 2024 09:57

use ?.
5b3f13c

whitespaces
4496367

rename unhandledHandler-->UnhandledExceptionHandler
c7833c5

PR feedback
4fd352e

define error_t as int
96ef6e2

ref/System.Runtime formatting
d1ade60

jkotas reviewed Nov 25, 2024
View reviewed changes

Comment threadsrc/tests/baseservices/exceptions/UnhandledExceptionHandler/UnhandledTrivial.cs Outdated

Update src/tests/baseservices/exceptions/UnhandledExceptionHandler/Un…
fa16227
…handledTrivial.cs

jkotas approved these changes Nov 25, 2024
View reviewed changes

build-analysisBot mentioned this pull request Nov 25, 2024
[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090
Closed

VSadov merged commit 17cb826 into dotnet:mainNov 26, 2024

VSadov deleted the unh branch November 26, 2024 00:03

teo-tsirpanis reviewed Nov 26, 2024
View reviewed changes

teo-tsirpanis mentioned this pull request Nov 28, 2024
Update unhandled exception handler API to match approved shape. #110254
Merged

SingleAccretion mentioned this pull request Nov 29, 2024
[NativeAOT-LLVM] Post-merge tasks dotnet/runtimelab#2472
Open

mdh1418 mentioned this pull request Dec 10, 2024
Long git directory name causes error C1083 when building coreclr tests (cl.exe) #110407
Open

mthalman mentioned this pull request Dec 18, 2024
Fix ambiguous reference for ExceptionHandling class dotnet/msbuild#11173
Merged

github-actionsBot locked and limited conversation to collaborators Dec 29, 2024

Uh oh!

Conversation

VSadov commented Nov 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Nov 14, 2024

Uh oh!

ghost commented Nov 14, 2024

Uh oh!

dotnet-policy-serviceBot commented Nov 14, 2024

Uh oh!

dotnet-policy-serviceBot commented Nov 14, 2024

Uh oh!

VSadov commented Nov 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VSadov commented Nov 15, 2024

Uh oh!

VSadov commented Nov 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janvorliNov 18, 2024

Choose a reason for hiding this comment

Uh oh!

janvorliNov 18, 2024

Choose a reason for hiding this comment

Uh oh!

VSadovNov 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

VSadov commented Nov 25, 2024

Uh oh!

VSadov commented Nov 26, 2024

Uh oh!

teo-tsirpanisNov 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MichalStrehovskyNov 28, 2024

Choose a reason for hiding this comment

Uh oh!

teo-tsirpanisNov 28, 2024

Choose a reason for hiding this comment

Uh oh!

VSadovNov 28, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VSadov commented Nov 14, 2024•
edited
Loading

VSadov commented Nov 15, 2024•
edited
Loading

VSadov commented Nov 15, 2024•
edited
Loading

teo-tsirpanisNov 26, 2024•
edited
Loading