Skip to content

Update unhandled exception handler API to match approved shape. - #110254

Merged
jkotas merged 6 commits into
dotnet:mainfrom
teo-tsirpanis:ueh-fix
Nov 30, 2024
Merged

Update unhandled exception handler API to match approved shape.#110254
jkotas merged 6 commits into
dotnet:mainfrom
teo-tsirpanis:ueh-fix

Conversation

@teo-tsirpanis

@teo-tsirpanisteo-tsirpanis commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

@ghostghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Nov 28, 2024
@ghost

ghost commented Nov 28, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost

ghost commented Nov 28, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Nov 28, 2024
@teo-tsirpanisteo-tsirpanis mentioned this pull request Nov 28, 2024
Merged
@teo-tsirpanisteo-tsirpanis added area-ExceptionHandling-coreclr only use for closed issues and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 28, 2024
jkotas
jkotas reviewed Nov 28, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated
@jkotas
jkotas requested a review from VSadovNovember 28, 2024 23:37
jkotas
jkotas approved these changes Nov 28, 2024
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@build-analysisbuild-analysisBot mentioned this pull request Nov 29, 2024
Open
3 tasks
jkotas
jkotas requested changes Nov 29, 2024
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more changes to fix build breaks.

@VSadov

VSadov commented Nov 29, 2024

Copy link
Copy Markdown
Member

Test.CoreLib is a limited runtime and does not have Func delegates declared as they were not needed so far.

This change needs that at least Func`2 is declared in the test lib.

jkotas
jkotas reviewed Nov 29, 2024
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Test.CoreLib/src/System/Functions.cs Outdated
This was referenced Nov 29, 2024
Closed
Closed
jkotas
jkotas reviewed Nov 30, 2024
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Runtime.Base/src/System/Runtime/__Finalizer.cs Outdated
jkotas
jkotas approved these changes Nov 30, 2024
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas
jkotas merged commit 1db85e8 into dotnet:mainNov 30, 2024
@teo-tsirpanis
teo-tsirpanis deleted the ueh-fix branch November 30, 2024 17:11
eduardo-vp pushed a commit to eduardo-vp/runtime that referenced this pull request Dec 5, 2024
@teo-tsirpanis@VSadov
@jkotas@eduardo-vp
Update unhandled exception handler API to match approved shape. (dotn…
73e6b6b
…et#110254)
* Update unhandled exception handler API to match approved shape.
* Update the correct API in the reference assembly.
* IsHandledByGlobalHandler helper
---------
Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@teo-tsirpanis@VSadov
@jkotas@mikelle-rogers
Update unhandled exception handler API to match approved shape. (dotn…
0956c7c
…et#110254)
* Update unhandled exception handler API to match approved shape.
* Update the correct API in the reference assembly.
* IsHandledByGlobalHandler helper
---------
Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 31, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@VSadovVSadovAwaiting requested review from VSadov

Assignees

No one assigned

Labels

area-ExceptionHandling-coreclronly use for closed issuescommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@teo-tsirpanis@VSadov@jkotas