Skip to content

fix #112163 - #112215

Closed
Ruihan-Yin wants to merge 2 commits into
dotnet:mainfrom
Ruihan-Yin:fix112163
Closed

fix #112163#112215
Ruihan-Yin wants to merge 2 commits into
dotnet:mainfrom
Ruihan-Yin:fix112163

Conversation

@Ruihan-Yin

@Ruihan-YinRuihan-Yin commented Feb 5, 2025

Copy link
Copy Markdown
Member

More details in #112163 (comment)

I'm not so sure if simply isolating the case for vmovss will be a proper fix, but I will run through the CI first to check if there is any other problem.

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 5, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 5, 2025
@dotnet-policy-service

dotnet-policy-serviceBot commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@saucecontrol

saucecontrol commented Feb 6, 2025

Copy link
Copy Markdown
Member

Sorry, I didn't see you had put this up. I've created #112217 which also covers double->double (movsd would also get the bad encoding as is)

@Ruihan-Yin

Ruihan-Yin commented Feb 6, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Sorry, I didn't see you had put this up. I've created #112217 which also covers double->double (movsd would also get the bad encoding as is)

That's completely fine, happy to see this bug is being addressed so quickly, I'm fine with closing this PR and proceed on your side if needed, and please let me know if anything I can help with.

@saucecontrol

saucecontrol commented Feb 6, 2025

Copy link
Copy Markdown
Member

happy to see this bug is being addressed so quickly

Same. I appreciate your help root-causing it 😄

@Ruihan-Yin

Ruihan-Yin commented Feb 7, 2025

Copy link
Copy Markdown
MemberAuthor

Closing as #112217 is covering this bug and providing a better solution.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ruihan-Yin@saucecontrol