Uh oh!
There was an error while loading. Please reload this page.
JIT: Fix illegal instruction encoding for float->float casts - #112217
Merged
Conversation
Closed
saucecontrol
marked this pull request as ready for review
February 6, 2025 06:56
EgorBo
commented
Feb 6, 2025
Member
/azp run runtime-coreclr jitstress-isas-avx512 |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
EgorBo
commented
Feb 6, 2025
Member
/azp list |
This comment was marked as resolved.
This comment was marked as resolved.
saucecontrol
commented
Feb 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
BruceForstall
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#112163
This resolves the illegal instruction encoding by no longer pretending that
movssandmovsdare 'conversion' instructions, which have different encoding forms.There's a minor codegen improvement (diffs) when a no-op cast has different source and target registers, where we now emit
movapsinstead ofmovss/movsd. Previously we would elide the cast only if source and target reg were the same.