JSON: Don't mark unmapped properties as read by PranavSenthilnathan · Pull Request #116807 · dotnet/runtime

PranavSenthilnathan · 2025-06-19T05:57:14Z

During deserialization we keep track of the properties that are read in order to do duplicate detection and required property validation. When a parametrized constructor is specified for deserialization, there are four types of JSON properties:

Properties that map to a constructor parameter
Properties that don't map to a constructor parameter but still map to a property on the class
Properties that map to the ExtensionData property
Properties that are unmapped

(The last two cases are only differentiated by whether the class has a property with the ExtensionData attribute.)

#115856 added duplicate detection by keeping track of properties that were assigned. Paths to handle cases 1, 2 and 3 were added but case 4 was an edge case that was not considered. So when this case was hit we would try to find the mapping like we do for case 1 or 2 when we actually don't have one. This PR fixes this case by explicitly checking for it and skipping duplicate detection for it.

Fixes#116801

Copilot

Pull Request Overview

This PR fixes an issue where unmapped JSON properties were incorrectly being marked as "read" during deserialization, which affected duplicate detection and required property validation. Key changes include:

Updating tests to include the new behavior with a class having a required property.
Modifying the converter logic to skip marking unmapped properties as read.
Adding corresponding test cases to verify the fix.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
System.Text.Json.SourceGeneration.Tests/Serialization/ConstructorTests.cs	Added JsonSerializable attribute for ClassWithRequiredProperty in both metadata and default contexts.
ConstructorTests.ParameterMatching.cs	Added a new test case to ensure unmapped properties do not interfere with duplicate detection.
ObjectWithParameterizedConstructorConverter.cs	Adjusted condition and comment to prevent marking unmapped properties as read.

Comments suppressed due to low confidence (2)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs:632

[nitpick] Consider enhancing the comment to reference issue #116801 for additional context on why unmapped properties are skipped during duplicate detection.

 if (!useExtensionProperty && jsonPropertyInfo != JsonPropertyInfo.s_missingProperty)

src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs:1825

[nitpick] Consider extending the 'RequiredMemberWithUnmappedMember' test to explicitly validate that duplicate detection is bypassed for unmapped properties, if such verification is feasible.

 [Fact]

dotnet-policy-service · 2025-06-19T05:57:48Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

eiriktsarpalis

Thanks for the fast fix @PranavSenthilnathan

PranavSenthilnathan · 2025-06-19T16:44:21Z

/ba-g Known test failures, unrelated to this PR. #116671 and #116558

joperezr · 2025-06-19T17:32:12Z

Thanks for fixing this @PranavSenthilnathan! Do you plan on backporting this to preview 6? We need it in order to be able to get the new aspnetcore Passkey feature working again

PranavSenthilnathan · 2025-06-19T17:44:36Z

/backport to release/10.0-preview6

github-actions · 2025-06-19T17:44:46Z

Started backporting to release/10.0-preview6: https://github.com/dotnet/runtime/actions/runs/15763591698

PranavSenthilnathan · 2025-06-19T05:57:14Z

During deserialization we keep track of the properties that are read in order to do duplicate detection and required property validation. When a parametrized constructor is specified for deserialization, there are four types of JSON properties:

Properties that map to a constructor parameter
Properties that don't map to a constructor parameter but still map to a property on the class
Properties that map to the ExtensionData property
Properties that are unmapped

(The last two cases are only differentiated by whether the class has a property with the ExtensionData attribute.)

#115856 added duplicate detection by keeping track of properties that were assigned. Paths to handle cases 1, 2 and 3 were added but case 4 was an edge case that was not considered. So when this case was hit we would try to find the mapping like we do for case 1 or 2 when we actually don't have one. This PR fixes this case by explicitly checking for it and skipping duplicate detection for it.

Fixes#116801

Copilot

Pull Request Overview

This PR fixes an issue where unmapped JSON properties were incorrectly being marked as "read" during deserialization, which affected duplicate detection and required property validation. Key changes include:

Updating tests to include the new behavior with a class having a required property.
Modifying the converter logic to skip marking unmapped properties as read.
Adding corresponding test cases to verify the fix.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
System.Text.Json.SourceGeneration.Tests/Serialization/ConstructorTests.cs	Added JsonSerializable attribute for ClassWithRequiredProperty in both metadata and default contexts.
ConstructorTests.ParameterMatching.cs	Added a new test case to ensure unmapped properties do not interfere with duplicate detection.
ObjectWithParameterizedConstructorConverter.cs	Adjusted condition and comment to prevent marking unmapped properties as read.

Comments suppressed due to low confidence (2)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs:632

[nitpick] Consider enhancing the comment to reference issue #116801 for additional context on why unmapped properties are skipped during duplicate detection.

 if (!useExtensionProperty && jsonPropertyInfo != JsonPropertyInfo.s_missingProperty)

src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs:1825

[nitpick] Consider extending the 'RequiredMemberWithUnmappedMember' test to explicitly validate that duplicate detection is bypassed for unmapped properties, if such verification is feasible.

 [Fact]

dotnet-policy-service · 2025-06-19T05:57:48Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

eiriktsarpalis

Thanks for the fast fix @PranavSenthilnathan

PranavSenthilnathan · 2025-06-19T16:44:21Z

/ba-g Known test failures, unrelated to this PR. #116671 and #116558

joperezr · 2025-06-19T17:32:12Z

Thanks for fixing this @PranavSenthilnathan! Do you plan on backporting this to preview 6? We need it in order to be able to get the new aspnetcore Passkey feature working again

PranavSenthilnathan · 2025-06-19T17:44:36Z

/backport to release/10.0-preview6

github-actions · 2025-06-19T17:44:46Z

Started backporting to release/10.0-preview6: https://github.com/dotnet/runtime/actions/runs/15763591698

PranavSenthilnathan · 2025-06-19T05:57:14Z

During deserialization we keep track of the properties that are read in order to do duplicate detection and required property validation. When a parametrized constructor is specified for deserialization, there are four types of JSON properties:

Properties that map to a constructor parameter
Properties that don't map to a constructor parameter but still map to a property on the class
Properties that map to the ExtensionData property
Properties that are unmapped

(The last two cases are only differentiated by whether the class has a property with the ExtensionData attribute.)

#115856 added duplicate detection by keeping track of properties that were assigned. Paths to handle cases 1, 2 and 3 were added but case 4 was an edge case that was not considered. So when this case was hit we would try to find the mapping like we do for case 1 or 2 when we actually don't have one. This PR fixes this case by explicitly checking for it and skipping duplicate detection for it.

Fixes#116801

Copilot

Pull Request Overview

This PR fixes an issue where unmapped JSON properties were incorrectly being marked as "read" during deserialization, which affected duplicate detection and required property validation. Key changes include:

Updating tests to include the new behavior with a class having a required property.
Modifying the converter logic to skip marking unmapped properties as read.
Adding corresponding test cases to verify the fix.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
System.Text.Json.SourceGeneration.Tests/Serialization/ConstructorTests.cs	Added JsonSerializable attribute for ClassWithRequiredProperty in both metadata and default contexts.
ConstructorTests.ParameterMatching.cs	Added a new test case to ensure unmapped properties do not interfere with duplicate detection.
ObjectWithParameterizedConstructorConverter.cs	Adjusted condition and comment to prevent marking unmapped properties as read.

Comments suppressed due to low confidence (2)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs:632

[nitpick] Consider enhancing the comment to reference issue #116801 for additional context on why unmapped properties are skipped during duplicate detection.

 if (!useExtensionProperty && jsonPropertyInfo != JsonPropertyInfo.s_missingProperty)

src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs:1825

[nitpick] Consider extending the 'RequiredMemberWithUnmappedMember' test to explicitly validate that duplicate detection is bypassed for unmapped properties, if such verification is feasible.

 [Fact]

dotnet-policy-service · 2025-06-19T05:57:48Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

eiriktsarpalis

Thanks for the fast fix @PranavSenthilnathan

PranavSenthilnathan · 2025-06-19T16:44:21Z

/ba-g Known test failures, unrelated to this PR. #116671 and #116558

joperezr · 2025-06-19T17:32:12Z

Thanks for fixing this @PranavSenthilnathan! Do you plan on backporting this to preview 6? We need it in order to be able to get the new aspnetcore Passkey feature working again

PranavSenthilnathan · 2025-06-19T17:44:36Z

/backport to release/10.0-preview6

github-actions · 2025-06-19T17:44:46Z

Started backporting to release/10.0-preview6: https://github.com/dotnet/runtime/actions/runs/15763591698

PranavSenthilnathan · 2025-06-19T05:57:14Z

During deserialization we keep track of the properties that are read in order to do duplicate detection and required property validation. When a parametrized constructor is specified for deserialization, there are four types of JSON properties:

Properties that map to a constructor parameter
Properties that don't map to a constructor parameter but still map to a property on the class
Properties that map to the ExtensionData property
Properties that are unmapped

(The last two cases are only differentiated by whether the class has a property with the ExtensionData attribute.)

#115856 added duplicate detection by keeping track of properties that were assigned. Paths to handle cases 1, 2 and 3 were added but case 4 was an edge case that was not considered. So when this case was hit we would try to find the mapping like we do for case 1 or 2 when we actually don't have one. This PR fixes this case by explicitly checking for it and skipping duplicate detection for it.

Fixes#116801

Copilot

Pull Request Overview

This PR fixes an issue where unmapped JSON properties were incorrectly being marked as "read" during deserialization, which affected duplicate detection and required property validation. Key changes include:

Updating tests to include the new behavior with a class having a required property.
Modifying the converter logic to skip marking unmapped properties as read.
Adding corresponding test cases to verify the fix.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
System.Text.Json.SourceGeneration.Tests/Serialization/ConstructorTests.cs	Added JsonSerializable attribute for ClassWithRequiredProperty in both metadata and default contexts.
ConstructorTests.ParameterMatching.cs	Added a new test case to ensure unmapped properties do not interfere with duplicate detection.
ObjectWithParameterizedConstructorConverter.cs	Adjusted condition and comment to prevent marking unmapped properties as read.

Comments suppressed due to low confidence (2)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs:632

[nitpick] Consider enhancing the comment to reference issue #116801 for additional context on why unmapped properties are skipped during duplicate detection.

 if (!useExtensionProperty && jsonPropertyInfo != JsonPropertyInfo.s_missingProperty)

src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs:1825

[nitpick] Consider extending the 'RequiredMemberWithUnmappedMember' test to explicitly validate that duplicate detection is bypassed for unmapped properties, if such verification is feasible.

 [Fact]

dotnet-policy-service · 2025-06-19T05:57:48Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

eiriktsarpalis

Thanks for the fast fix @PranavSenthilnathan

PranavSenthilnathan · 2025-06-19T16:44:21Z

/ba-g Known test failures, unrelated to this PR. #116671 and #116558

joperezr · 2025-06-19T17:32:12Z

Thanks for fixing this @PranavSenthilnathan! Do you plan on backporting this to preview 6? We need it in order to be able to get the new aspnetcore Passkey feature working again

PranavSenthilnathan · 2025-06-19T17:44:36Z

/backport to release/10.0-preview6

github-actions · 2025-06-19T17:44:46Z

Started backporting to release/10.0-preview6: https://github.com/dotnet/runtime/actions/runs/15763591698

PranavSenthilnathan · 2025-06-19T05:57:14Z

During deserialization we keep track of the properties that are read in order to do duplicate detection and required property validation. When a parametrized constructor is specified for deserialization, there are four types of JSON properties:

Properties that map to a constructor parameter
Properties that don't map to a constructor parameter but still map to a property on the class
Properties that map to the ExtensionData property
Properties that are unmapped

(The last two cases are only differentiated by whether the class has a property with the ExtensionData attribute.)

#115856 added duplicate detection by keeping track of properties that were assigned. Paths to handle cases 1, 2 and 3 were added but case 4 was an edge case that was not considered. So when this case was hit we would try to find the mapping like we do for case 1 or 2 when we actually don't have one. This PR fixes this case by explicitly checking for it and skipping duplicate detection for it.

Fixes#116801

Copilot

Pull Request Overview

This PR fixes an issue where unmapped JSON properties were incorrectly being marked as "read" during deserialization, which affected duplicate detection and required property validation. Key changes include:

Updating tests to include the new behavior with a class having a required property.
Modifying the converter logic to skip marking unmapped properties as read.
Adding corresponding test cases to verify the fix.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
System.Text.Json.SourceGeneration.Tests/Serialization/ConstructorTests.cs	Added JsonSerializable attribute for ClassWithRequiredProperty in both metadata and default contexts.
ConstructorTests.ParameterMatching.cs	Added a new test case to ensure unmapped properties do not interfere with duplicate detection.
ObjectWithParameterizedConstructorConverter.cs	Adjusted condition and comment to prevent marking unmapped properties as read.

Comments suppressed due to low confidence (2)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs:632

[nitpick] Consider enhancing the comment to reference issue #116801 for additional context on why unmapped properties are skipped during duplicate detection.

 if (!useExtensionProperty && jsonPropertyInfo != JsonPropertyInfo.s_missingProperty)

src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs:1825

[nitpick] Consider extending the 'RequiredMemberWithUnmappedMember' test to explicitly validate that duplicate detection is bypassed for unmapped properties, if such verification is feasible.

 [Fact]

dotnet-policy-service · 2025-06-19T05:57:48Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

eiriktsarpalis

Thanks for the fast fix @PranavSenthilnathan

PranavSenthilnathan · 2025-06-19T16:44:21Z

/ba-g Known test failures, unrelated to this PR. #116671 and #116558

joperezr · 2025-06-19T17:32:12Z

Thanks for fixing this @PranavSenthilnathan! Do you plan on backporting this to preview 6? We need it in order to be able to get the new aspnetcore Passkey feature working again

PranavSenthilnathan · 2025-06-19T17:44:36Z

/backport to release/10.0-preview6

github-actions · 2025-06-19T17:44:46Z

Started backporting to release/10.0-preview6: https://github.com/dotnet/runtime/actions/runs/15763591698

PranavSenthilnathan · 2025-06-19T05:57:14Z

During deserialization we keep track of the properties that are read in order to do duplicate detection and required property validation. When a parametrized constructor is specified for deserialization, there are four types of JSON properties:

Properties that map to a constructor parameter
Properties that don't map to a constructor parameter but still map to a property on the class
Properties that map to the ExtensionData property
Properties that are unmapped

(The last two cases are only differentiated by whether the class has a property with the ExtensionData attribute.)

#115856 added duplicate detection by keeping track of properties that were assigned. Paths to handle cases 1, 2 and 3 were added but case 4 was an edge case that was not considered. So when this case was hit we would try to find the mapping like we do for case 1 or 2 when we actually don't have one. This PR fixes this case by explicitly checking for it and skipping duplicate detection for it.

Fixes#116801

Copilot

Pull Request Overview

This PR fixes an issue where unmapped JSON properties were incorrectly being marked as "read" during deserialization, which affected duplicate detection and required property validation. Key changes include:

Updating tests to include the new behavior with a class having a required property.
Modifying the converter logic to skip marking unmapped properties as read.
Adding corresponding test cases to verify the fix.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
System.Text.Json.SourceGeneration.Tests/Serialization/ConstructorTests.cs	Added JsonSerializable attribute for ClassWithRequiredProperty in both metadata and default contexts.
ConstructorTests.ParameterMatching.cs	Added a new test case to ensure unmapped properties do not interfere with duplicate detection.
ObjectWithParameterizedConstructorConverter.cs	Adjusted condition and comment to prevent marking unmapped properties as read.

Comments suppressed due to low confidence (2)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs:632

[nitpick] Consider enhancing the comment to reference issue #116801 for additional context on why unmapped properties are skipped during duplicate detection.

 if (!useExtensionProperty && jsonPropertyInfo != JsonPropertyInfo.s_missingProperty)

src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs:1825

[nitpick] Consider extending the 'RequiredMemberWithUnmappedMember' test to explicitly validate that duplicate detection is bypassed for unmapped properties, if such verification is feasible.

 [Fact]

dotnet-policy-service · 2025-06-19T05:57:48Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

eiriktsarpalis

Thanks for the fast fix @PranavSenthilnathan

PranavSenthilnathan · 2025-06-19T16:44:21Z

/ba-g Known test failures, unrelated to this PR. #116671 and #116558

joperezr · 2025-06-19T17:32:12Z

Thanks for fixing this @PranavSenthilnathan! Do you plan on backporting this to preview 6? We need it in order to be able to get the new aspnetcore Passkey feature working again

PranavSenthilnathan · 2025-06-19T17:44:36Z

/backport to release/10.0-preview6

github-actions · 2025-06-19T17:44:46Z

Started backporting to release/10.0-preview6: https://github.com/dotnet/runtime/actions/runs/15763591698

PranavSenthilnathan · 2025-06-19T05:57:14Z

During deserialization we keep track of the properties that are read in order to do duplicate detection and required property validation. When a parametrized constructor is specified for deserialization, there are four types of JSON properties:

Properties that map to a constructor parameter
Properties that don't map to a constructor parameter but still map to a property on the class
Properties that map to the ExtensionData property
Properties that are unmapped

(The last two cases are only differentiated by whether the class has a property with the ExtensionData attribute.)

#115856 added duplicate detection by keeping track of properties that were assigned. Paths to handle cases 1, 2 and 3 were added but case 4 was an edge case that was not considered. So when this case was hit we would try to find the mapping like we do for case 1 or 2 when we actually don't have one. This PR fixes this case by explicitly checking for it and skipping duplicate detection for it.

Fixes#116801

Copilot

Pull Request Overview

This PR fixes an issue where unmapped JSON properties were incorrectly being marked as "read" during deserialization, which affected duplicate detection and required property validation. Key changes include:

Updating tests to include the new behavior with a class having a required property.
Modifying the converter logic to skip marking unmapped properties as read.
Adding corresponding test cases to verify the fix.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
System.Text.Json.SourceGeneration.Tests/Serialization/ConstructorTests.cs	Added JsonSerializable attribute for ClassWithRequiredProperty in both metadata and default contexts.
ConstructorTests.ParameterMatching.cs	Added a new test case to ensure unmapped properties do not interfere with duplicate detection.
ObjectWithParameterizedConstructorConverter.cs	Adjusted condition and comment to prevent marking unmapped properties as read.

Comments suppressed due to low confidence (2)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs:632

[nitpick] Consider enhancing the comment to reference issue #116801 for additional context on why unmapped properties are skipped during duplicate detection.

 if (!useExtensionProperty && jsonPropertyInfo != JsonPropertyInfo.s_missingProperty)

src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs:1825

[nitpick] Consider extending the 'RequiredMemberWithUnmappedMember' test to explicitly validate that duplicate detection is bypassed for unmapped properties, if such verification is feasible.

 [Fact]

dotnet-policy-service · 2025-06-19T05:57:48Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

eiriktsarpalis

Thanks for the fast fix @PranavSenthilnathan

PranavSenthilnathan · 2025-06-19T16:44:21Z

/ba-g Known test failures, unrelated to this PR. #116671 and #116558

joperezr · 2025-06-19T17:32:12Z

Thanks for fixing this @PranavSenthilnathan! Do you plan on backporting this to preview 6? We need it in order to be able to get the new aspnetcore Passkey feature working again

PranavSenthilnathan · 2025-06-19T17:44:36Z

/backport to release/10.0-preview6

github-actions · 2025-06-19T17:44:46Z

Started backporting to release/10.0-preview6: https://github.com/dotnet/runtime/actions/runs/15763591698

PranavSenthilnathan · 2025-06-19T05:57:14Z

During deserialization we keep track of the properties that are read in order to do duplicate detection and required property validation. When a parametrized constructor is specified for deserialization, there are four types of JSON properties:

Properties that map to a constructor parameter
Properties that don't map to a constructor parameter but still map to a property on the class
Properties that map to the ExtensionData property
Properties that are unmapped

(The last two cases are only differentiated by whether the class has a property with the ExtensionData attribute.)

#115856 added duplicate detection by keeping track of properties that were assigned. Paths to handle cases 1, 2 and 3 were added but case 4 was an edge case that was not considered. So when this case was hit we would try to find the mapping like we do for case 1 or 2 when we actually don't have one. This PR fixes this case by explicitly checking for it and skipping duplicate detection for it.

Fixes#116801

Copilot

Pull Request Overview

This PR fixes an issue where unmapped JSON properties were incorrectly being marked as "read" during deserialization, which affected duplicate detection and required property validation. Key changes include:

Updating tests to include the new behavior with a class having a required property.
Modifying the converter logic to skip marking unmapped properties as read.
Adding corresponding test cases to verify the fix.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
System.Text.Json.SourceGeneration.Tests/Serialization/ConstructorTests.cs	Added JsonSerializable attribute for ClassWithRequiredProperty in both metadata and default contexts.
ConstructorTests.ParameterMatching.cs	Added a new test case to ensure unmapped properties do not interfere with duplicate detection.
ObjectWithParameterizedConstructorConverter.cs	Adjusted condition and comment to prevent marking unmapped properties as read.

Comments suppressed due to low confidence (2)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs:632

[nitpick] Consider enhancing the comment to reference issue #116801 for additional context on why unmapped properties are skipped during duplicate detection.

 if (!useExtensionProperty && jsonPropertyInfo != JsonPropertyInfo.s_missingProperty)

src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs:1825

[nitpick] Consider extending the 'RequiredMemberWithUnmappedMember' test to explicitly validate that duplicate detection is bypassed for unmapped properties, if such verification is feasible.

 [Fact]

dotnet-policy-service · 2025-06-19T05:57:48Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

eiriktsarpalis

Thanks for the fast fix @PranavSenthilnathan

PranavSenthilnathan · 2025-06-19T16:44:21Z

/ba-g Known test failures, unrelated to this PR. #116671 and #116558

joperezr · 2025-06-19T17:32:12Z

Thanks for fixing this @PranavSenthilnathan! Do you plan on backporting this to preview 6? We need it in order to be able to get the new aspnetcore Passkey feature working again

PranavSenthilnathan · 2025-06-19T17:44:36Z

/backport to release/10.0-preview6

github-actions · 2025-06-19T17:44:46Z

Started backporting to release/10.0-preview6: https://github.com/dotnet/runtime/actions/runs/15763591698

Only mark mapped properties
e9b12a8

PranavSenthilnathan added this to the 10.0.0 milestone Jun 19, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 19, 2025 05:57

PranavSenthilnathan self-assigned this Jun 19, 2025

CopilotAI review requested due to automatic review settings June 19, 2025 05:57

PranavSenthilnathan added the area-System.Text.Json label Jun 19, 2025

CopilotAI reviewed Jun 19, 2025
View reviewed changes

This was referenced Jun 19, 2025
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
browser-wasm Windows build error #116746
Closed

eiriktsarpalis approved these changes Jun 19, 2025
View reviewed changes

PranavSenthilnathan merged commit c585026 into dotnet:mainJun 19, 2025

github-actionsBot mentioned this pull request Jun 19, 2025
[release/10.0-preview6] JSON: Don't mark unmapped properties as read #116828
Merged
4 tasks

github-actionsBot locked and limited conversation to collaborators Jul 20, 2025

Only mark mapped properties
e9b12a8

PranavSenthilnathan added this to the 10.0.0 milestone Jun 19, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 19, 2025 05:57

PranavSenthilnathan self-assigned this Jun 19, 2025

CopilotAI review requested due to automatic review settings June 19, 2025 05:57

PranavSenthilnathan added the area-System.Text.Json label Jun 19, 2025

CopilotAI reviewed Jun 19, 2025
View reviewed changes

This was referenced Jun 19, 2025
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
browser-wasm Windows build error #116746
Closed

eiriktsarpalis approved these changes Jun 19, 2025
View reviewed changes

PranavSenthilnathan merged commit c585026 into dotnet:mainJun 19, 2025

github-actionsBot mentioned this pull request Jun 19, 2025
[release/10.0-preview6] JSON: Don't mark unmapped properties as read #116828
Merged
4 tasks

github-actionsBot locked and limited conversation to collaborators Jul 20, 2025

Only mark mapped properties
e9b12a8

PranavSenthilnathan added this to the 10.0.0 milestone Jun 19, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 19, 2025 05:57

PranavSenthilnathan self-assigned this Jun 19, 2025

CopilotAI review requested due to automatic review settings June 19, 2025 05:57

PranavSenthilnathan added the area-System.Text.Json label Jun 19, 2025

CopilotAI reviewed Jun 19, 2025
View reviewed changes

This was referenced Jun 19, 2025
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
browser-wasm Windows build error #116746
Closed

eiriktsarpalis approved these changes Jun 19, 2025
View reviewed changes

PranavSenthilnathan merged commit c585026 into dotnet:mainJun 19, 2025

github-actionsBot mentioned this pull request Jun 19, 2025
[release/10.0-preview6] JSON: Don't mark unmapped properties as read #116828
Merged
4 tasks

github-actionsBot locked and limited conversation to collaborators Jul 20, 2025

Only mark mapped properties
e9b12a8

PranavSenthilnathan added this to the 10.0.0 milestone Jun 19, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 19, 2025 05:57

PranavSenthilnathan self-assigned this Jun 19, 2025

CopilotAI review requested due to automatic review settings June 19, 2025 05:57

PranavSenthilnathan added the area-System.Text.Json label Jun 19, 2025

CopilotAI reviewed Jun 19, 2025
View reviewed changes

This was referenced Jun 19, 2025
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
browser-wasm Windows build error #116746
Closed

eiriktsarpalis approved these changes Jun 19, 2025
View reviewed changes

PranavSenthilnathan merged commit c585026 into dotnet:mainJun 19, 2025

github-actionsBot mentioned this pull request Jun 19, 2025
[release/10.0-preview6] JSON: Don't mark unmapped properties as read #116828
Merged
4 tasks

github-actionsBot locked and limited conversation to collaborators Jul 20, 2025

Only mark mapped properties
e9b12a8

PranavSenthilnathan added this to the 10.0.0 milestone Jun 19, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 19, 2025 05:57

PranavSenthilnathan self-assigned this Jun 19, 2025

CopilotAI review requested due to automatic review settings June 19, 2025 05:57

PranavSenthilnathan added the area-System.Text.Json label Jun 19, 2025

CopilotAI reviewed Jun 19, 2025
View reviewed changes

This was referenced Jun 19, 2025
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
browser-wasm Windows build error #116746
Closed

eiriktsarpalis approved these changes Jun 19, 2025
View reviewed changes

PranavSenthilnathan merged commit c585026 into dotnet:mainJun 19, 2025

github-actionsBot mentioned this pull request Jun 19, 2025
[release/10.0-preview6] JSON: Don't mark unmapped properties as read #116828
Merged
4 tasks

github-actionsBot locked and limited conversation to collaborators Jul 20, 2025

Only mark mapped properties
e9b12a8

PranavSenthilnathan added this to the 10.0.0 milestone Jun 19, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 19, 2025 05:57

PranavSenthilnathan self-assigned this Jun 19, 2025

CopilotAI review requested due to automatic review settings June 19, 2025 05:57

PranavSenthilnathan added the area-System.Text.Json label Jun 19, 2025

CopilotAI reviewed Jun 19, 2025
View reviewed changes

This was referenced Jun 19, 2025
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
browser-wasm Windows build error #116746
Closed

eiriktsarpalis approved these changes Jun 19, 2025
View reviewed changes

PranavSenthilnathan merged commit c585026 into dotnet:mainJun 19, 2025

github-actionsBot mentioned this pull request Jun 19, 2025
[release/10.0-preview6] JSON: Don't mark unmapped properties as read #116828
Merged
4 tasks

github-actionsBot locked and limited conversation to collaborators Jul 20, 2025

Only mark mapped properties
e9b12a8

PranavSenthilnathan added this to the 10.0.0 milestone Jun 19, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 19, 2025 05:57

PranavSenthilnathan self-assigned this Jun 19, 2025

CopilotAI review requested due to automatic review settings June 19, 2025 05:57

PranavSenthilnathan added the area-System.Text.Json label Jun 19, 2025

CopilotAI reviewed Jun 19, 2025
View reviewed changes

This was referenced Jun 19, 2025
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
browser-wasm Windows build error #116746
Closed

eiriktsarpalis approved these changes Jun 19, 2025
View reviewed changes

PranavSenthilnathan merged commit c585026 into dotnet:mainJun 19, 2025

github-actionsBot mentioned this pull request Jun 19, 2025
[release/10.0-preview6] JSON: Don't mark unmapped properties as read #116828
Merged
4 tasks

github-actionsBot locked and limited conversation to collaborators Jul 20, 2025

Only mark mapped properties
e9b12a8

PranavSenthilnathan added this to the 10.0.0 milestone Jun 19, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 19, 2025 05:57

PranavSenthilnathan self-assigned this Jun 19, 2025

CopilotAI review requested due to automatic review settings June 19, 2025 05:57

PranavSenthilnathan added the area-System.Text.Json label Jun 19, 2025

CopilotAI reviewed Jun 19, 2025
View reviewed changes

This was referenced Jun 19, 2025
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
browser-wasm Windows build error #116746
Closed

eiriktsarpalis approved these changes Jun 19, 2025
View reviewed changes

PranavSenthilnathan merged commit c585026 into dotnet:mainJun 19, 2025

github-actionsBot mentioned this pull request Jun 19, 2025
[release/10.0-preview6] JSON: Don't mark unmapped properties as read #116828
Merged
4 tasks

github-actionsBot locked and limited conversation to collaborators Jul 20, 2025

Uh oh!

Conversation

PranavSenthilnathan commented Jun 19, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

dotnet-policy-serviceBot commented Jun 19, 2025

Uh oh!

eiriktsarpalis left a comment

Choose a reason for hiding this comment

Uh oh!

PranavSenthilnathan commented Jun 19, 2025

Uh oh!

joperezr commented Jun 19, 2025

Uh oh!

PranavSenthilnathan commented Jun 19, 2025

Uh oh!

github-actionsBot commented Jun 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

PranavSenthilnathan commented Jun 19, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

dotnet-policy-serviceBot commented Jun 19, 2025

Uh oh!

eiriktsarpalis left a comment

Choose a reason for hiding this comment

Uh oh!

PranavSenthilnathan commented Jun 19, 2025

Uh oh!

joperezr commented Jun 19, 2025

Uh oh!

PranavSenthilnathan commented Jun 19, 2025

Uh oh!

github-actionsBot commented Jun 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

PranavSenthilnathan commented Jun 19, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

dotnet-policy-serviceBot commented Jun 19, 2025

Uh oh!

eiriktsarpalis left a comment

Choose a reason for hiding this comment

Uh oh!

PranavSenthilnathan commented Jun 19, 2025

Uh oh!

joperezr commented Jun 19, 2025

Uh oh!

PranavSenthilnathan commented Jun 19, 2025

Uh oh!