[release/9.0] Stop testing with nodejs - #120193

Merged
lewing merged 2 commits into
release/9.0-stagingfrom
backport/pr-108582-to-release/9.0
Oct 13, 2025
Merged

[release/9.0] Stop testing with nodejs#120193
lewing merged 2 commits into
release/9.0-stagingfrom
backport/pr-108582-to-release/9.0

Conversation

@ilonatommy

@ilonatommyilonatommy commented Sep 29, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Backport of #108582 to release/9.0

/cc @pavelsavara

Customer Impact

  • Customer reported
  • Found internally

Cleanup backport, tell mode. It affects only tests that used to fail infrequently on net9. We don't have them running on main for some time already. Fixes#111753.

Regression

  • Yes
  • No

Testing

CI.

Risk

Low, it's adjusting the set supported scenarios in the tests to match main's set.

@ilonatommyilonatommy self-assigned this Sep 29, 2025
CopilotAI review requested due to automatic review settings September 29, 2025 12:22
CopilotAI reviewed Sep 29, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Node.js support from WebAssembly (WASM) test infrastructure as a backport cleanup change. The primary goal is to align the release/9.0 branch with the main branch by eliminating Node.js-related testing scenarios that were already removed from main and were causing intermittent test failures.

Key changes include:

  • Removal of Node.js host runner and related test infrastructure
  • Update of test project configurations to use browser-only test archives
  • Cleanup of documentation references to Node.js support

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
src/mono/wasm/testassets/Blazor_net50/Complete removal of Blazor .NET 5.0 test asset files
src/mono/wasm/features.mdRemoved documentation sections about Node.js support and requirements
src/mono/wasm/Wasm.Build.Tests/Removed Node.js host runner and updated RunHost enum
src/libraries/sendtohelix-browser.targetsRemoved Node.js scenario references and test configurations
Multiple test .csproj filesChanged TestArchiveTestsRoot from browserornodejs to browseronly
eng/testing/ and eng/pipelines/Removed Node.js test scenarios and pipeline configurations

@ilonatommyilonatommy added the arch-wasm WebAssembly architecture label Sep 29, 2025
@ilonatommy

ilonatommy commented Sep 29, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to release/8.0-staging

@github-actions

github-actionsBot commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18096836610

@github-actions

github-actionsBot commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

@ilonatommy backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Using index info to reconstruct a base tree...
M	eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	eng/testing/WasmRunnerTemplate.sh
M	eng/testing/tests.browser.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
M	src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
M	src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
A	src/libraries/sendtohelix-browser.targets
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
CONFLICT (content): Merge conflict in eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging eng/testing/WasmRunnerTemplate.sh
CONFLICT (content): Merge conflict in eng/testing/WasmRunnerTemplate.sh
Auto-merging eng/testing/tests.browser.targets
CONFLICT (content): Merge conflict in eng/testing/tests.browser.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
Auto-merging src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
Auto-merging src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
Auto-merging src/libraries/sendtohelix-wasm.targets
CONFLICT (content): Merge conflict in src/libraries/sendtohelix-wasm.targets
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@ilonatommy
ilonatommyforce-pushed the backport/pr-108582-to-release/9.0 branch from 535ea7b to 9d59c71CompareSeptember 29, 2025 15:52
@ilonatommyilonatommy mentioned this pull request Sep 30, 2025
Closed
@ilonatommyilonatommy added the Servicing-consider Issue for next servicing release review label Oct 6, 2025
@PranavSenthilnathan

PranavSenthilnathan commented Oct 10, 2025

Copy link
Copy Markdown
Member

Reminder that PRs into release/9.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/9.0 if you want to make the November release.

@lewinglewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 13, 2025
@lewing

lewing commented Oct 13, 2025

Copy link
Copy Markdown
Member

This is a tell-mode test infrastructure only change.

@lewing
lewing merged commit 4fe34ed into release/9.0-stagingOct 13, 2025
162 of 165 checks passed
@stephentoub
stephentoub deleted the backport/pr-108582-to-release/9.0 branch October 17, 2025 12:49
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Nov 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architectureServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ilonatommy@PranavSenthilnathan@lewing@akoeplinger@maraf
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[release/9.0] Stop testing with nodejs - #120193
Merged
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Oct 13, 2025
Merged
[release/9.0] Stop testing with nodejs#120193
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 29, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Backport of #108582 to release/9.0
/cc @pavelsavara
Customer Impact
  •  Customer reported
  •  Found internally
Cleanup backport, tell mode. It affects only tests that used to fail infrequently on net9. We don't have them running on main for some time already. Fixes#111753.
Regression
  •  Yes
  •  No
Testing
CI.
Risk
Low, it's adjusting the set supported scenarios in the tests to match main's set.
@ilonatommyilonatommy
self-assigned this
Sep 29, 2025
CopilotAI
review requested due to automatic review settings
September 29, 2025 12:22
CopilotAI
reviewed
Sep 29, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR removes Node.js support from WebAssembly (WASM) test infrastructure as a backport cleanup change. The primary goal is to align the release/9.0 branch with the main branch by eliminating Node.js-related testing scenarios that were already removed from main and were causing intermittent test failures.
Key changes include:
  • Removal of Node.js host runner and related test infrastructure
  • Update of test project configurations to use browser-only test archives
  • Cleanup of documentation references to Node.js support
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/mono/wasm/testassets/Blazor_net50/Complete removal of Blazor .NET 5.0 test asset files
src/mono/wasm/features.mdRemoved documentation sections about Node.js support and requirements
src/mono/wasm/Wasm.Build.Tests/Removed Node.js host runner and updated RunHost enum
src/libraries/sendtohelix-browser.targetsRemoved Node.js scenario references and test configurations
Multiple test .csproj filesChanged TestArchiveTestsRoot from browserornodejs to browseronly
eng/testing/ and eng/pipelines/Removed Node.js test scenarios and pipeline configurations
@ilonatommyilonatommy
added
the 
arch-wasm
WebAssembly architecture
label
Sep 29, 2025
@ilonatommy
ilonatommy
commented
Sep 29, 2025

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18096836610
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Using index info to reconstruct a base tree...
M	eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	eng/testing/WasmRunnerTemplate.sh
M	eng/testing/tests.browser.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
M	src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
M	src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
A	src/libraries/sendtohelix-browser.targets
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
CONFLICT (content): Merge conflict in eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging eng/testing/WasmRunnerTemplate.sh
CONFLICT (content): Merge conflict in eng/testing/WasmRunnerTemplate.sh
Auto-merging eng/testing/tests.browser.targets
CONFLICT (content): Merge conflict in eng/testing/tests.browser.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
Auto-merging src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
Auto-merging src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
Auto-merging src/libraries/sendtohelix-wasm.targets
CONFLICT (content): Merge conflict in src/libraries/sendtohelix-wasm.targets
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@ilonatommy
ilonatommyforce-pushed
the
backport/pr-108582-to-release/9.0
branch
from
535ea7b to
9d59c71CompareSeptember 29, 2025 15:52
@ilonatommyilonatommy
mentioned this pull request
Sep 30, 2025

Closed

@ilonatommyilonatommy
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 6, 2025
@PranavSenthilnathan
PranavSenthilnathan
commented
Oct 10, 2025

Copy link


Copy Markdown

Member
Reminder that PRs into release/9.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/9.0 if you want to make the November release.
@lewinglewing
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 13, 2025
@lewing
lewing
commented
Oct 13, 2025

Copy link


Copy Markdown

Member
This is a tell-mode test infrastructure only change.
@lewing
lewing
merged commit 4fe34ed
into
release/9.0-stagingOct 13, 2025

162 of 165 checks passed

@stephentoub
stephentoub
deleted the

backport/pr-108582-to-release/9.0

branch
October 17, 2025 12:49
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 17, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architectureServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@ilonatommy@PranavSenthilnathan@lewing@akoeplinger@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/9.0] Stop testing with nodejs - #120193
Merged
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Oct 13, 2025
Merged
[release/9.0] Stop testing with nodejs#120193
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 29, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Backport of #108582 to release/9.0
/cc @pavelsavara
Customer Impact
  •  Customer reported
  •  Found internally
Cleanup backport, tell mode. It affects only tests that used to fail infrequently on net9. We don't have them running on main for some time already. Fixes#111753.
Regression
  •  Yes
  •  No
Testing
CI.
Risk
Low, it's adjusting the set supported scenarios in the tests to match main's set.
@ilonatommyilonatommy
self-assigned this
Sep 29, 2025
CopilotAI
review requested due to automatic review settings
September 29, 2025 12:22
CopilotAI
reviewed
Sep 29, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR removes Node.js support from WebAssembly (WASM) test infrastructure as a backport cleanup change. The primary goal is to align the release/9.0 branch with the main branch by eliminating Node.js-related testing scenarios that were already removed from main and were causing intermittent test failures.
Key changes include:
  • Removal of Node.js host runner and related test infrastructure
  • Update of test project configurations to use browser-only test archives
  • Cleanup of documentation references to Node.js support
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/mono/wasm/testassets/Blazor_net50/Complete removal of Blazor .NET 5.0 test asset files
src/mono/wasm/features.mdRemoved documentation sections about Node.js support and requirements
src/mono/wasm/Wasm.Build.Tests/Removed Node.js host runner and updated RunHost enum
src/libraries/sendtohelix-browser.targetsRemoved Node.js scenario references and test configurations
Multiple test .csproj filesChanged TestArchiveTestsRoot from browserornodejs to browseronly
eng/testing/ and eng/pipelines/Removed Node.js test scenarios and pipeline configurations
@ilonatommyilonatommy
added
the 
arch-wasm
WebAssembly architecture
label
Sep 29, 2025
@ilonatommy
ilonatommy
commented
Sep 29, 2025

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18096836610
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Using index info to reconstruct a base tree...
M	eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	eng/testing/WasmRunnerTemplate.sh
M	eng/testing/tests.browser.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
M	src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
M	src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
A	src/libraries/sendtohelix-browser.targets
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
CONFLICT (content): Merge conflict in eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging eng/testing/WasmRunnerTemplate.sh
CONFLICT (content): Merge conflict in eng/testing/WasmRunnerTemplate.sh
Auto-merging eng/testing/tests.browser.targets
CONFLICT (content): Merge conflict in eng/testing/tests.browser.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
Auto-merging src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
Auto-merging src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
Auto-merging src/libraries/sendtohelix-wasm.targets
CONFLICT (content): Merge conflict in src/libraries/sendtohelix-wasm.targets
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@ilonatommy
ilonatommyforce-pushed
the
backport/pr-108582-to-release/9.0
branch
from
535ea7b to
9d59c71CompareSeptember 29, 2025 15:52
@ilonatommyilonatommy
mentioned this pull request
Sep 30, 2025

Closed

@ilonatommyilonatommy
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 6, 2025
@PranavSenthilnathan
PranavSenthilnathan
commented
Oct 10, 2025

Copy link


Copy Markdown

Member
Reminder that PRs into release/9.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/9.0 if you want to make the November release.
@lewinglewing
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 13, 2025
@lewing
lewing
commented
Oct 13, 2025

Copy link


Copy Markdown

Member
This is a tell-mode test infrastructure only change.
@lewing
lewing
merged commit 4fe34ed
into
release/9.0-stagingOct 13, 2025

162 of 165 checks passed

@stephentoub
stephentoub
deleted the

backport/pr-108582-to-release/9.0

branch
October 17, 2025 12:49
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 17, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architectureServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@ilonatommy@PranavSenthilnathan@lewing@akoeplinger@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/9.0] Stop testing with nodejs - #120193
Merged
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Oct 13, 2025
Merged
[release/9.0] Stop testing with nodejs#120193
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 29, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Backport of #108582 to release/9.0
/cc @pavelsavara
Customer Impact
  •  Customer reported
  •  Found internally
Cleanup backport, tell mode. It affects only tests that used to fail infrequently on net9. We don't have them running on main for some time already. Fixes#111753.
Regression
  •  Yes
  •  No
Testing
CI.
Risk
Low, it's adjusting the set supported scenarios in the tests to match main's set.
@ilonatommyilonatommy
self-assigned this
Sep 29, 2025
CopilotAI
review requested due to automatic review settings
September 29, 2025 12:22
CopilotAI
reviewed
Sep 29, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR removes Node.js support from WebAssembly (WASM) test infrastructure as a backport cleanup change. The primary goal is to align the release/9.0 branch with the main branch by eliminating Node.js-related testing scenarios that were already removed from main and were causing intermittent test failures.
Key changes include:
  • Removal of Node.js host runner and related test infrastructure
  • Update of test project configurations to use browser-only test archives
  • Cleanup of documentation references to Node.js support
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/mono/wasm/testassets/Blazor_net50/Complete removal of Blazor .NET 5.0 test asset files
src/mono/wasm/features.mdRemoved documentation sections about Node.js support and requirements
src/mono/wasm/Wasm.Build.Tests/Removed Node.js host runner and updated RunHost enum
src/libraries/sendtohelix-browser.targetsRemoved Node.js scenario references and test configurations
Multiple test .csproj filesChanged TestArchiveTestsRoot from browserornodejs to browseronly
eng/testing/ and eng/pipelines/Removed Node.js test scenarios and pipeline configurations
@ilonatommyilonatommy
added
the 
arch-wasm
WebAssembly architecture
label
Sep 29, 2025
@ilonatommy
ilonatommy
commented
Sep 29, 2025

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18096836610
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Using index info to reconstruct a base tree...
M	eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	eng/testing/WasmRunnerTemplate.sh
M	eng/testing/tests.browser.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
M	src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
M	src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
A	src/libraries/sendtohelix-browser.targets
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
CONFLICT (content): Merge conflict in eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging eng/testing/WasmRunnerTemplate.sh
CONFLICT (content): Merge conflict in eng/testing/WasmRunnerTemplate.sh
Auto-merging eng/testing/tests.browser.targets
CONFLICT (content): Merge conflict in eng/testing/tests.browser.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
Auto-merging src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
Auto-merging src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
Auto-merging src/libraries/sendtohelix-wasm.targets
CONFLICT (content): Merge conflict in src/libraries/sendtohelix-wasm.targets
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@ilonatommy
ilonatommyforce-pushed
the
backport/pr-108582-to-release/9.0
branch
from
535ea7b to
9d59c71CompareSeptember 29, 2025 15:52
@ilonatommyilonatommy
mentioned this pull request
Sep 30, 2025

Closed

@ilonatommyilonatommy
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 6, 2025
@PranavSenthilnathan
PranavSenthilnathan
commented
Oct 10, 2025

Copy link


Copy Markdown

Member
Reminder that PRs into release/9.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/9.0 if you want to make the November release.
@lewinglewing
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 13, 2025
@lewing
lewing
commented
Oct 13, 2025

Copy link


Copy Markdown

Member
This is a tell-mode test infrastructure only change.
@lewing
lewing
merged commit 4fe34ed
into
release/9.0-stagingOct 13, 2025

162 of 165 checks passed

@stephentoub
stephentoub
deleted the

backport/pr-108582-to-release/9.0

branch
October 17, 2025 12:49
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 17, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architectureServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@ilonatommy@PranavSenthilnathan@lewing@akoeplinger@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[release/9.0] Stop testing with nodejs - #120193
Merged
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Oct 13, 2025
Merged
[release/9.0] Stop testing with nodejs#120193
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 29, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Backport of #108582 to release/9.0
/cc @pavelsavara
Customer Impact
  •  Customer reported
  •  Found internally
Cleanup backport, tell mode. It affects only tests that used to fail infrequently on net9. We don't have them running on main for some time already. Fixes#111753.
Regression
  •  Yes
  •  No
Testing
CI.
Risk
Low, it's adjusting the set supported scenarios in the tests to match main's set.
@ilonatommyilonatommy
self-assigned this
Sep 29, 2025
CopilotAI
review requested due to automatic review settings
September 29, 2025 12:22
CopilotAI
reviewed
Sep 29, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR removes Node.js support from WebAssembly (WASM) test infrastructure as a backport cleanup change. The primary goal is to align the release/9.0 branch with the main branch by eliminating Node.js-related testing scenarios that were already removed from main and were causing intermittent test failures.
Key changes include:
  • Removal of Node.js host runner and related test infrastructure
  • Update of test project configurations to use browser-only test archives
  • Cleanup of documentation references to Node.js support
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/mono/wasm/testassets/Blazor_net50/Complete removal of Blazor .NET 5.0 test asset files
src/mono/wasm/features.mdRemoved documentation sections about Node.js support and requirements
src/mono/wasm/Wasm.Build.Tests/Removed Node.js host runner and updated RunHost enum
src/libraries/sendtohelix-browser.targetsRemoved Node.js scenario references and test configurations
Multiple test .csproj filesChanged TestArchiveTestsRoot from browserornodejs to browseronly
eng/testing/ and eng/pipelines/Removed Node.js test scenarios and pipeline configurations
@ilonatommyilonatommy
added
the 
arch-wasm
WebAssembly architecture
label
Sep 29, 2025
@ilonatommy
ilonatommy
commented
Sep 29, 2025

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18096836610
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Using index info to reconstruct a base tree...
M	eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	eng/testing/WasmRunnerTemplate.sh
M	eng/testing/tests.browser.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
M	src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
M	src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
A	src/libraries/sendtohelix-browser.targets
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
CONFLICT (content): Merge conflict in eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging eng/testing/WasmRunnerTemplate.sh
CONFLICT (content): Merge conflict in eng/testing/WasmRunnerTemplate.sh
Auto-merging eng/testing/tests.browser.targets
CONFLICT (content): Merge conflict in eng/testing/tests.browser.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
Auto-merging src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
Auto-merging src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
Auto-merging src/libraries/sendtohelix-wasm.targets
CONFLICT (content): Merge conflict in src/libraries/sendtohelix-wasm.targets
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@ilonatommy
ilonatommyforce-pushed
the
backport/pr-108582-to-release/9.0
branch
from
535ea7b to
9d59c71CompareSeptember 29, 2025 15:52
@ilonatommyilonatommy
mentioned this pull request
Sep 30, 2025

Closed

@ilonatommyilonatommy
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 6, 2025
@PranavSenthilnathan
PranavSenthilnathan
commented
Oct 10, 2025

Copy link


Copy Markdown

Member
Reminder that PRs into release/9.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/9.0 if you want to make the November release.
@lewinglewing
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 13, 2025
@lewing
lewing
commented
Oct 13, 2025

Copy link


Copy Markdown

Member
This is a tell-mode test infrastructure only change.
@lewing
lewing
merged commit 4fe34ed
into
release/9.0-stagingOct 13, 2025

162 of 165 checks passed

@stephentoub
stephentoub
deleted the

backport/pr-108582-to-release/9.0

branch
October 17, 2025 12:49
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 17, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architectureServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@ilonatommy@PranavSenthilnathan@lewing@akoeplinger@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/9.0] Stop testing with nodejs - #120193
Merged
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Oct 13, 2025
Merged
[release/9.0] Stop testing with nodejs#120193
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 29, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Backport of #108582 to release/9.0
/cc @pavelsavara
Customer Impact
  •  Customer reported
  •  Found internally
Cleanup backport, tell mode. It affects only tests that used to fail infrequently on net9. We don't have them running on main for some time already. Fixes#111753.
Regression
  •  Yes
  •  No
Testing
CI.
Risk
Low, it's adjusting the set supported scenarios in the tests to match main's set.
@ilonatommyilonatommy
self-assigned this
Sep 29, 2025
CopilotAI
review requested due to automatic review settings
September 29, 2025 12:22
CopilotAI
reviewed
Sep 29, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR removes Node.js support from WebAssembly (WASM) test infrastructure as a backport cleanup change. The primary goal is to align the release/9.0 branch with the main branch by eliminating Node.js-related testing scenarios that were already removed from main and were causing intermittent test failures.
Key changes include:
  • Removal of Node.js host runner and related test infrastructure
  • Update of test project configurations to use browser-only test archives
  • Cleanup of documentation references to Node.js support
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/mono/wasm/testassets/Blazor_net50/Complete removal of Blazor .NET 5.0 test asset files
src/mono/wasm/features.mdRemoved documentation sections about Node.js support and requirements
src/mono/wasm/Wasm.Build.Tests/Removed Node.js host runner and updated RunHost enum
src/libraries/sendtohelix-browser.targetsRemoved Node.js scenario references and test configurations
Multiple test .csproj filesChanged TestArchiveTestsRoot from browserornodejs to browseronly
eng/testing/ and eng/pipelines/Removed Node.js test scenarios and pipeline configurations
@ilonatommyilonatommy
added
the 
arch-wasm
WebAssembly architecture
label
Sep 29, 2025
@ilonatommy
ilonatommy
commented
Sep 29, 2025

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18096836610
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Using index info to reconstruct a base tree...
M	eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	eng/testing/WasmRunnerTemplate.sh
M	eng/testing/tests.browser.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
M	src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
M	src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
A	src/libraries/sendtohelix-browser.targets
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
CONFLICT (content): Merge conflict in eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging eng/testing/WasmRunnerTemplate.sh
CONFLICT (content): Merge conflict in eng/testing/WasmRunnerTemplate.sh
Auto-merging eng/testing/tests.browser.targets
CONFLICT (content): Merge conflict in eng/testing/tests.browser.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
Auto-merging src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
Auto-merging src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
Auto-merging src/libraries/sendtohelix-wasm.targets
CONFLICT (content): Merge conflict in src/libraries/sendtohelix-wasm.targets
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@ilonatommy
ilonatommyforce-pushed
the
backport/pr-108582-to-release/9.0
branch
from
535ea7b to
9d59c71CompareSeptember 29, 2025 15:52
@ilonatommyilonatommy
mentioned this pull request
Sep 30, 2025

Closed

@ilonatommyilonatommy
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 6, 2025
@PranavSenthilnathan
PranavSenthilnathan
commented
Oct 10, 2025

Copy link


Copy Markdown

Member
Reminder that PRs into release/9.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/9.0 if you want to make the November release.
@lewinglewing
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 13, 2025
@lewing
lewing
commented
Oct 13, 2025

Copy link


Copy Markdown

Member
This is a tell-mode test infrastructure only change.
@lewing
lewing
merged commit 4fe34ed
into
release/9.0-stagingOct 13, 2025

162 of 165 checks passed

@stephentoub
stephentoub
deleted the

backport/pr-108582-to-release/9.0

branch
October 17, 2025 12:49
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 17, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architectureServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@ilonatommy@PranavSenthilnathan@lewing@akoeplinger@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/9.0] Stop testing with nodejs - #120193
Merged
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Oct 13, 2025
Merged
[release/9.0] Stop testing with nodejs#120193
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 29, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Backport of #108582 to release/9.0
/cc @pavelsavara
Customer Impact
  •  Customer reported
  •  Found internally
Cleanup backport, tell mode. It affects only tests that used to fail infrequently on net9. We don't have them running on main for some time already. Fixes#111753.
Regression
  •  Yes
  •  No
Testing
CI.
Risk
Low, it's adjusting the set supported scenarios in the tests to match main's set.
@ilonatommyilonatommy
self-assigned this
Sep 29, 2025
CopilotAI
review requested due to automatic review settings
September 29, 2025 12:22
CopilotAI
reviewed
Sep 29, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR removes Node.js support from WebAssembly (WASM) test infrastructure as a backport cleanup change. The primary goal is to align the release/9.0 branch with the main branch by eliminating Node.js-related testing scenarios that were already removed from main and were causing intermittent test failures.
Key changes include:
  • Removal of Node.js host runner and related test infrastructure
  • Update of test project configurations to use browser-only test archives
  • Cleanup of documentation references to Node.js support
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/mono/wasm/testassets/Blazor_net50/Complete removal of Blazor .NET 5.0 test asset files
src/mono/wasm/features.mdRemoved documentation sections about Node.js support and requirements
src/mono/wasm/Wasm.Build.Tests/Removed Node.js host runner and updated RunHost enum
src/libraries/sendtohelix-browser.targetsRemoved Node.js scenario references and test configurations
Multiple test .csproj filesChanged TestArchiveTestsRoot from browserornodejs to browseronly
eng/testing/ and eng/pipelines/Removed Node.js test scenarios and pipeline configurations
@ilonatommyilonatommy
added
the 
arch-wasm
WebAssembly architecture
label
Sep 29, 2025
@ilonatommy
ilonatommy
commented
Sep 29, 2025

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18096836610
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Using index info to reconstruct a base tree...
M	eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	eng/testing/WasmRunnerTemplate.sh
M	eng/testing/tests.browser.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
M	src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
M	src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
A	src/libraries/sendtohelix-browser.targets
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
CONFLICT (content): Merge conflict in eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging eng/testing/WasmRunnerTemplate.sh
CONFLICT (content): Merge conflict in eng/testing/WasmRunnerTemplate.sh
Auto-merging eng/testing/tests.browser.targets
CONFLICT (content): Merge conflict in eng/testing/tests.browser.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
Auto-merging src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
Auto-merging src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
Auto-merging src/libraries/sendtohelix-wasm.targets
CONFLICT (content): Merge conflict in src/libraries/sendtohelix-wasm.targets
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@ilonatommy
ilonatommyforce-pushed
the
backport/pr-108582-to-release/9.0
branch
from
535ea7b to
9d59c71CompareSeptember 29, 2025 15:52
@ilonatommyilonatommy
mentioned this pull request
Sep 30, 2025

Closed

@ilonatommyilonatommy
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 6, 2025
@PranavSenthilnathan
PranavSenthilnathan
commented
Oct 10, 2025

Copy link


Copy Markdown

Member
Reminder that PRs into release/9.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/9.0 if you want to make the November release.
@lewinglewing
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 13, 2025
@lewing
lewing
commented
Oct 13, 2025

Copy link


Copy Markdown

Member
This is a tell-mode test infrastructure only change.
@lewing
lewing
merged commit 4fe34ed
into
release/9.0-stagingOct 13, 2025

162 of 165 checks passed

@stephentoub
stephentoub
deleted the

backport/pr-108582-to-release/9.0

branch
October 17, 2025 12:49
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 17, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architectureServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@ilonatommy@PranavSenthilnathan@lewing@akoeplinger@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[release/9.0] Stop testing with nodejs - #120193
Merged
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Oct 13, 2025
Merged
[release/9.0] Stop testing with nodejs#120193
lewing merged 2 commits into
release/9.0-stagingfrom 
backport/pr-108582-to-release/9.0
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 29, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Backport of #108582 to release/9.0
/cc @pavelsavara
Customer Impact
  •  Customer reported
  •  Found internally
Cleanup backport, tell mode. It affects only tests that used to fail infrequently on net9. We don't have them running on main for some time already. Fixes#111753.
Regression
  •  Yes
  •  No
Testing
CI.
Risk
Low, it's adjusting the set supported scenarios in the tests to match main's set.
@ilonatommyilonatommy
self-assigned this
Sep 29, 2025
CopilotAI
review requested due to automatic review settings
September 29, 2025 12:22
CopilotAI
reviewed
Sep 29, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR removes Node.js support from WebAssembly (WASM) test infrastructure as a backport cleanup change. The primary goal is to align the release/9.0 branch with the main branch by eliminating Node.js-related testing scenarios that were already removed from main and were causing intermittent test failures.
Key changes include:
  • Removal of Node.js host runner and related test infrastructure
  • Update of test project configurations to use browser-only test archives
  • Cleanup of documentation references to Node.js support
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/mono/wasm/testassets/Blazor_net50/Complete removal of Blazor .NET 5.0 test asset files
src/mono/wasm/features.mdRemoved documentation sections about Node.js support and requirements
src/mono/wasm/Wasm.Build.Tests/Removed Node.js host runner and updated RunHost enum
src/libraries/sendtohelix-browser.targetsRemoved Node.js scenario references and test configurations
Multiple test .csproj filesChanged TestArchiveTestsRoot from browserornodejs to browseronly
eng/testing/ and eng/pipelines/Removed Node.js test scenarios and pipeline configurations
@ilonatommyilonatommy
added
the 
arch-wasm
WebAssembly architecture
label
Sep 29, 2025
@ilonatommy
ilonatommy
commented
Sep 29, 2025

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0-staging
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18096836610
@github-actions
github-actionsBot
commented
Sep 29, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Using index info to reconstruct a base tree...
M	eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	eng/testing/WasmRunnerTemplate.sh
M	eng/testing/tests.browser.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
M	src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
M	src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
M	src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
A	src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
A	src/libraries/sendtohelix-browser.targets
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
CONFLICT (content): Merge conflict in eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging eng/testing/WasmRunnerTemplate.sh
CONFLICT (content): Merge conflict in eng/testing/WasmRunnerTemplate.sh
Auto-merging eng/testing/tests.browser.targets
CONFLICT (content): Merge conflict in eng/testing/tests.browser.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets
Auto-merging src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props
Auto-merging src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization.Calendars/tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Globalization/tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
Auto-merging src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression.ZipFile/tests/System.IO.Compression.ZipFile.Tests.csproj
Auto-merging src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
Auto-merging src/libraries/sendtohelix-wasm.targets
CONFLICT (content): Merge conflict in src/libraries/sendtohelix-wasm.targets
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Backport all changes from https://github.com/dotnet/runtime/pull/108582.
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@ilonatommy
ilonatommyforce-pushed
the
backport/pr-108582-to-release/9.0
branch
from
535ea7b to
9d59c71CompareSeptember 29, 2025 15:52
@ilonatommyilonatommy
mentioned this pull request
Sep 30, 2025

Closed

@ilonatommyilonatommy
added
the 
Servicing-consider
Issue for next servicing release review
label
Oct 6, 2025
@PranavSenthilnathan
PranavSenthilnathan
commented
Oct 10, 2025

Copy link


Copy Markdown

Member
Reminder that PRs into release/9.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/9.0 if you want to make the November release.
@lewinglewing
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Oct 13, 2025
@lewing
lewing
commented
Oct 13, 2025

Copy link


Copy Markdown

Member
This is a tell-mode test infrastructure only change.
@lewing
lewing
merged commit 4fe34ed
into
release/9.0-stagingOct 13, 2025

162 of 165 checks passed

@stephentoub
stephentoub
deleted the

backport/pr-108582-to-release/9.0

branch
October 17, 2025 12:49
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 17, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafmaraf approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architectureServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@ilonatommy@PranavSenthilnathan@lewing@akoeplinger@maraf