Skip to content

[RyuJit/WASM] Register allocator skeleton - #122414

Merged
AndyAyersMS merged 3 commits into
dotnet:mainfrom
SingleAccretion:WasmJit-Stk
Dec 17, 2025
Merged

[RyuJit/WASM] Register allocator skeleton#122414
AndyAyersMS merged 3 commits into
dotnet:mainfrom
SingleAccretion:WasmJit-Stk

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Force all locals to stack and add an interface for the SP/FP.

Implement GT_LCL_ADDR / GT_LCL_FLD as samples.

Next step is to add the stackifier (it'll run before RA and liveness, since it may need to introduce locals and we want to be able to enregister them). After that - parameter homing, and that should bring us to syntactically (if not yet semantically) valid WASM.

@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 10, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Dec 10, 2025
@SingleAccretion
SingleAccretionforce-pushed the WasmJit-Stk branch 4 times, most recently from cf539e7 to 19436a5CompareDecember 11, 2025 13:58
This was referenced Dec 11, 2025
Open
Open
Closed
Closed
@SingleAccretion
SingleAccretionforce-pushed the WasmJit-Stk branch 3 times, most recently from c9db6c0 to a5f251cCompareDecember 11, 2025 21:26
@SingleAccretion
[RyuJit/WASM] Register allocator skeleton
e12a8cd
Force all locals to stack and add an interface for the SP/FP.
Implement GT_LCL_ADDR / GT_LCL_FLD as samples.
CopilotAI mentioned this pull request Dec 12, 2025
Closed
@build-analysisbuild-analysisBot mentioned this pull request Dec 15, 2025
Open
3 tasks
@SingleAccretion
SingleAccretion marked this pull request as ready for review December 15, 2025 20:58
@SingleAccretion

SingleAccretion commented Dec 15, 2025

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

@am11am11 added the arch-wasm WebAssembly architecture label Dec 16, 2025
@dotnet-policy-service

dotnet-policy-serviceBot commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@SingleAccretion

SingleAccretion commented Dec 16, 2025

Copy link
Copy Markdown
ContributorAuthor

I have went through the change again and noticed an issue with the LCL_ADDR implementation, so have pushed a change with some fix(es).

@AndyAyersMS

AndyAyersMS commented Dec 16, 2025

Copy link
Copy Markdown
Member

We just took a GUID update so SPMI failures are "expected"... new collections on the way.

@AndyAyersMS

AndyAyersMS commented Dec 17, 2025

Copy link
Copy Markdown
Member

Going to give up on trying to get SPMI to pass, this PR should have no impact on it.

@AndyAyersMS
AndyAyersMS merged commit dd1dc37 into dotnet:mainDec 17, 2025
122 of 127 checks passed
@SingleAccretion
SingleAccretion deleted the WasmJit-Stk branch December 17, 2025 16:18
This was referenced Jan 9, 2026
Closed
Merged
AndyAyersMS
AndyAyersMS reviewed Jan 16, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/regallocwasm.cpp
}
else
{
store = m_compiler->gtNewStoreIndNode(lclNode->TypeGet(), lclNode, lclNode->Data(), indFlags);

@AndyAyersMSAndyAyersMSJan 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(post merge note) This is hitting asserts when the local is TYP_LONG as it is not a valid indir addr type... seems like the retyping done below needs to happen earlier?

@SingleAccretionSingleAccretionJan 16, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed; fix incoming in #123261.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 16, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@AndyAyersMS@am11