Skip to content

Disable UniqueMarshalling COM tests causing "Over release of MOW - COM" assertion - #122473

Closed
jkotas with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-over-release-com-assertion
Closed

Disable UniqueMarshalling COM tests causing "Over release of MOW - COM" assertion#122473
jkotas with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-over-release-com-assertion

Conversation

CopilotAI commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

The tests added in #121643 for UniqueComInterfaceMarshaller are triggering assertion failures in comwrappers.cpp:519 with "Over release of MOW - COM". This is causing widespread CI failures across 24+ builds.

Changes

  • Added [ActiveIssue] attribute to GetSameComInterfaceTwiceReturnsUniqueInstances in LibraryImportGenerator.Tests
  • Added [ActiveIssue] attribute to MethodReturningComInterfaceReturnsUniqueInstance in ComInterfaceGenerator.Tests

Both tests exercise IUniqueMarshalling.GetThis() which returns the same COM object through the unique marshalling path, exposing a reference counting issue in the COM wrapper infrastructure.

Contributes to #122520

Original prompt

This section details on the original issue you should resolve

<issue_title>"Over release of MOW - COM" assert in COM wrappers</issue_title>
<issue_description>```
Discovering: LibraryImportGenerator.Tests (method display = ClassAndMethod, method display options = None)
Discovered: LibraryImportGenerator.Tests (found 162 of 165 test cases)
Starting: LibraryImportGenerator.Tests (parallel test collections = on [2 threads], stop on fail = off)
Assertion failed: (!"Over release of MOW - COM") (/__w/1/s/src/coreclr/interop/comwrappers.cpp: Release: 519)

https://github.com/dotnet/runtime/pull/122407/checks?check_run_id=57752025260
<!-- Error message template -->
### Known Issue Error Message
Fill the error message using [step by step known issues guidance](https://github.com/dotnet/arcade/blob/main/Documentation/Projects/Build%20Analysis/KnownIssueJsonStepByStep.md).
<!-- Use ErrorMessage for String.Contains matches. Use ErrorPattern for regex matches (single line/no backtracking). Set BuildRetry to `true` to retry builds with this error. Set ExcludeConsoleLog to `true` to skip helix logs analysis. -->
```json
{
"ErrorMessage": "Over release of MOW - COM",
"ErrorPattern": "",
"BuildRetry": false,
"ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎
Result validation:⚠️ Validation could not be done without an Azure DevOps build URL on the issue. Please add it to the "Build: 🔎" line.
Validation performed at: 12/11/2025 3:35:19 PM UTC

Report

BuildDefinitionTestPull Request
1228887dotnet/runtimeLibraryImportGenerator.Tests.WorkItemExecution#121679
1228892dotnet/runtimeLibraryImportGenerator.Tests.WorkItemExecution#122211
1228819dotnet/runtimeLibraryImportGenerator.Tests.WorkItemExecution#122414
1228776dotnet/runtimeLibraryImportGenerator.Tests.WorkItemExecution#122466
1228768dotnet/runtimeLibraryImportGenerator.Tests.WorkItemExecution#121513
1228677dotnet/runtimeLibraryImportGenerator.Tests.WorkItemExecution#122463
1228706dotnet/runtimeLibraryImportGenerator.Tests.WorkItemExecution
1228445dotnet/runtimeLibraryImportGenerator.Tests.WorkItemExecution#119352
1228658dotnet/runtimeLibraryImportGenerator.Tests.WorkItemExecution#122460
1228403dotnet/runtimeLibraryImportGenerator.Tests.WorkItemExecution#122023
[1228505](https://dev.azure.com/d...

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI changed the title [WIP] Fix over release of MOW - COM assertion in wrappersDisable UniqueMarshalling COM tests causing "Over release of MOW - COM" assertionDec 12, 2025
CopilotAI requested a review from jkotasDecember 12, 2025 01:44
@stephentoub
stephentoub marked this pull request as ready for review December 12, 2025 04:13
CopilotAI review requested due to automatic review settings December 12, 2025 04:13
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@jkotas

Copy link
Copy Markdown
Member

Duplicate of#122474

@jkotasjkotas marked this as a duplicate of #122474Dec 12, 2025
@jkotasjkotas closed this Dec 12, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily disables two failing tests related to UniqueComInterfaceMarshaller that are causing widespread CI failures due to a COM reference counting issue. The tests trigger an "Over release of MOW - COM" assertion in the CoreCLR COM wrapper infrastructure.

Key changes:

  • Added [ActiveIssue] attributes to disable two tests until the underlying COM wrapper bug is fixed
  • Both disabled tests exercise the same unique marshalling path via IUniqueMarshalling.GetThis()

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
LibraryImportGenerator.Tests/NativeMarshallingAttributeTests.csDisables GetSameComInterfaceTwiceReturnsUniqueInstances test that verifies unique instances are returned when calling a LibraryImport method twice
ComInterfaceGenerator.Tests/NativeMarshallingAttributeTests.csDisables MethodReturningComInterfaceReturnsUniqueInstance test that verifies a COM interface method returning itself creates a new managed instance

The changes are minimal, consistent, and correctly formatted. Both tests use the same [ActiveIssue] URL referencing issue #122520, which matches the tracking issue mentioned in the PR description. The approach follows established patterns in the codebase for disabling failing tests pending fixes.

@jkotas
jkotas deleted the copilot/fix-over-release-com-assertion branch December 22, 2025 05:38
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 21, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Over release of MOW - COM" assert in COM wrappers

4 participants

@jkotas@stephentoub