Runtime-async Exception.ToString() by rcj1 · Pull Request #122722 · dotnet/runtime

rcj1 · 2025-12-24T05:50:09Z

This PR implements exception stack trace collection in runtime-async stacks for both coreclr and nativeAOT.

Augmenting stack unwinding logic in AsyncHelpers.CoreCLR.cs to append frames from runtime-async async-await chain to exception stacktrace using DiagnosticIP of Continuation.
Implements ThrowExact helper to throw exception that has been stored in Continuation, while keeping its existing stack trace intact. Accomplished by creating throw helpers that set ExKind.RethrowFlag. Would be open to rename "RethrowFlag" and companions to "NoEraseFlag" or something similar, or leave as is.
ILC changes: Ensuring that stack trace records are emitted for runtime-async methods, and hidden for resumption stubs.
Testing: Added tests for line/method/document correctness including v1-v2 chaining.

@dotnet/ilc-contrib

- Add new JIT-EE API to report back debug information about the generated state machine and continuations - Refactor debug info storage on VM side to be more easily extensible. The new format has either a thin or fat header. The fat header is used when we have either uninstrumented bounds, patchpoint info, rich debug info or async debug info, and stores the blob sizes of all of those components in addition to the bounds and vars. - Add new async debug information to the storage on the VM side - Set get target method desc for async resumption stubs, to be used for mapping from continuations back to the async IL function that it will resume.

…mental APIs in async tests

…ostics

Copilot

Pull request overview

Copilot reviewed 41 out of 41 changed files in this pull request and generated 5 comments.

rcj1 · 2026-02-04T12:29:42Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2026-02-04T12:29:53Z

Azure Pipelines successfully started running 1 pipeline(s).

rcj1 · 2026-02-04T21:05:10Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2026-02-04T21:05:21Z

Azure Pipelines successfully started running 1 pipeline(s).

rcj1 · 2026-02-04T21:08:23Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2026-02-04T21:08:33Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 41 out of 41 changed files in this pull request and generated 1 comment.

rcj1 · 2026-02-05T02:48:39Z

/ba-g unrelated failures

…3831) Testing on dotnet#122722 revealed some issues with dotnet#123333 so I am fixing these here. After dotnet#123333 there remain two error cases: 1. Our IL offset is greater than the previously found offset, but lower than the max found offset. In this case, we would like to advance the line number in accordance with the new IL offset, which was omitted after dotnet#123333. 2. Our IL offset is greater than the highest IL offset for which there exists a sequence point. In this case, we want to ensure we can create a native <-> line mapping - dotnet#123333 had left these IL offsets with a Document of null, meaning no mappings were possible. This fixes both of these issues. Before: <img width="1298" height="268" alt="Screenshot 2026-01-30 192451" src="https://github.com/user-attachments/assets/ab46947f-ea52-4530-949b-3e36bf3b3df6" /> <img width="1312" height="359" alt="Screenshot 2026-01-30 192408" src="https://github.com/user-attachments/assets/b08a8f45-0af2-484a-8392-8d12c3694361" /> After: <img width="1020" height="311" alt="Screenshot 2026-01-30 190332" src="https://github.com/user-attachments/assets/ac8bca54-6466-4436-9fac-1f6f685e7bd0" /> <img width="1030" height="400" alt="Screenshot 2026-01-30 190613" src="https://github.com/user-attachments/assets/321c8160-cf06-4f43-8c36-352d2bd6908a" /> [foo.txt](https://github.com/user-attachments/files/24984632/foo.txt) [foo2.txt](https://github.com/user-attachments/files/24984633/foo2.txt) [New Compressed (zipped) Folder.zip](https://github.com/user-attachments/files/24976959/New.Compressed.zipped.Folder.zip) --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

This PR implements exception stack trace collection in runtime-async stacks for both coreclr and nativeAOT. * Augmenting stack unwinding logic in AsyncHelpers.CoreCLR.cs to append frames from runtime-async async-await chain to exception stacktrace using DiagnosticIP of Continuation. * Implements ThrowExact helper to throw exception that has been stored in Continuation, while keeping its existing stack trace intact. Accomplished by creating throw helpers that set ExKind.RethrowFlag. Would be open to rename "RethrowFlag" and companions to "NoEraseFlag" or something similar, or leave as is. * ILC changes: Ensuring that stack trace records are emitted for runtime-async methods, and hidden for resumption stubs. * Testing: Added tests for line/method/document correctness including v1-v2 chaining. @dotnet/ilc-contrib --------- Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com> Co-authored-by: Adeel <3840695+am11@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…3831) Testing on dotnet#122722 revealed some issues with dotnet#123333 so I am fixing these here. After dotnet#123333 there remain two error cases: 1. Our IL offset is greater than the previously found offset, but lower than the max found offset. In this case, we would like to advance the line number in accordance with the new IL offset, which was omitted after dotnet#123333. 2. Our IL offset is greater than the highest IL offset for which there exists a sequence point. In this case, we want to ensure we can create a native <-> line mapping - dotnet#123333 had left these IL offsets with a Document of null, meaning no mappings were possible. This fixes both of these issues. Before: <img width="1298" height="268" alt="Screenshot 2026-01-30 192451" src="https://github.com/user-attachments/assets/ab46947f-ea52-4530-949b-3e36bf3b3df6" /> <img width="1312" height="359" alt="Screenshot 2026-01-30 192408" src="https://github.com/user-attachments/assets/b08a8f45-0af2-484a-8392-8d12c3694361" /> After: <img width="1020" height="311" alt="Screenshot 2026-01-30 190332" src="https://github.com/user-attachments/assets/ac8bca54-6466-4436-9fac-1f6f685e7bd0" /> <img width="1030" height="400" alt="Screenshot 2026-01-30 190613" src="https://github.com/user-attachments/assets/321c8160-cf06-4f43-8c36-352d2bd6908a" /> [foo.txt](https://github.com/user-attachments/files/24984632/foo.txt) [foo2.txt](https://github.com/user-attachments/files/24984633/foo2.txt) [New Compressed (zipped) Folder.zip](https://github.com/user-attachments/files/24976959/New.Compressed.zipped.Folder.zip) --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

This PR implements exception stack trace collection in runtime-async stacks for both coreclr and nativeAOT. * Augmenting stack unwinding logic in AsyncHelpers.CoreCLR.cs to append frames from runtime-async async-await chain to exception stacktrace using DiagnosticIP of Continuation. * Implements ThrowExact helper to throw exception that has been stored in Continuation, while keeping its existing stack trace intact. Accomplished by creating throw helpers that set ExKind.RethrowFlag. Would be open to rename "RethrowFlag" and companions to "NoEraseFlag" or something similar, or leave as is. * ILC changes: Ensuring that stack trace records are emitted for runtime-async methods, and hidden for resumption stubs. * Testing: Added tests for line/method/document correctness including v1-v2 chaining. @dotnet/ilc-contrib --------- Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com> Co-authored-by: Adeel <3840695+am11@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jakobbotschand others added 30 commits October 1, 2025 14:54

Set target method desc for resumption stubs
b7bb968

Add JIT-EE boilerplate
d5d0864

Update managed view
6addd0e

Remove TODOs
6a5bf19

Leaf transition
262260a

Comment
4e2a829

Delete unused enum
820afa9

Restore comment
3621eae

Fix osx build
f597424

Fix GCC build
6bb6cee

Change sentinel value, fix contract
f580e3f

Bump R2R
55b9522

Clean up
c9c64be

Expose async debug info accessor APIs
db77446

Missed bumping R2R version for naot
c808390

Fix reverse mapping to IL local nums
3ec5160

Fix monotonicity for async vars
bb12c77

Code style
bf3364b

Fix JIT-EE prompt tools from Egor's instructions, allow use of experi…
b49f38f
…mental APIs in async tests

Address feedback, make comment less misleading
d1bf49f

Add AsyncContinuationVarInfo.GCIndex
579714e

Publish NextContinuation in TLS
c056793

Rename ThunkTask -> RuntimeAsyncTask
9679f91

testing
abd7d8b

Merge branch 'main' of github.com:dotnet/runtime into jit-async-diagn…
7a34475
…ostics

Report native offsets instead
e839409

Run jit-format
d8ad0c1

Print reported async debug info, always report it
9fdd8a7

exception tostring
1da796e

rcj1 added 2 commits February 3, 2026 21:03

asm
06f8c10

fix for mac and naming
f9d633d

CopilotAI review requested due to automatic review settings February 4, 2026 06:46

Copilotstarted reviewing on behalf of rcj1 February 4, 2026 06:46 View session

CopilotAI reviewed Feb 4, 2026
View reviewed changes

build-analysisBot mentioned this pull request Feb 4, 2026
System.Net.WebSockets.Client.Tests: Assertion failed: !_hasWaiter #121157
Closed

Update line number in Quuux test case
f7a2ec7

disabling failing test
8385119

CopilotAI review requested due to automatic review settings February 4, 2026 21:04

Copilotstarted reviewing on behalf of rcj1 February 4, 2026 21:05 View session

CopilotAI reviewed Feb 4, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/common.h

steveisok enabled auto-merge (squash) February 5, 2026 03:30

hoyosjs disabled auto-merge February 5, 2026 04:22

hoyosjs merged commit 7fa306e into dotnet:mainFeb 5, 2026
175 of 179 checks passed

kotlarmilos mentioned this pull request Feb 5, 2026
Disable failing ToString_Async test on Apple mobile with CoreCLR R2R and interpreter #124037
Merged

dotnet-maestroBot mentioned this pull request Feb 6, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#4680
Merged

This was referenced Feb 8, 2026
Implement CORINFO_HELP_THROWEXACT #122549
Closed
Stack traces with async variants #122547
Open

github-actionsBot locked and limited conversation to collaborators Mar 7, 2026

Navigation Menu

Uh oh!

Runtime-async Exception.ToString() - #122722

Runtime-async Exception.ToString()#122722
hoyosjs merged 101 commits into
dotnet:mainfrom
rcj1:dev/rachel/asyncv2-exception-tostring

rcj1 commented Dec 24, 2025•
edited
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rcj1 commented Feb 4, 2026

Uh oh!

azure-pipelinesBot commented Feb 4, 2026

Uh oh!

rcj1 commented Feb 4, 2026

Uh oh!

azure-pipelinesBot commented Feb 4, 2026

Uh oh!

rcj1 commented Feb 4, 2026

Uh oh!

azure-pipelinesBot commented Feb 4, 2026

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

rcj1 commented Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

rcj1 commented Dec 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rcj1 commented Feb 4, 2026

Uh oh!

azure-pipelinesBot commented Feb 4, 2026

Uh oh!

rcj1 commented Feb 4, 2026

Uh oh!

azure-pipelinesBot commented Feb 4, 2026

Uh oh!

rcj1 commented Feb 4, 2026

Uh oh!

azure-pipelinesBot commented Feb 4, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

rcj1 commented Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

rcj1 commented Dec 24, 2025•
edited
Loading