Skip to content

Disable failing ToString_Async test on Apple mobile with CoreCLR R2R and interpreter - #124037

Merged
jkotas merged 3 commits into
dotnet:mainfrom
kotlarmilos:bugfix/clr-ios-async-handler
Feb 6, 2026
Merged

Disable failing ToString_Async test on Apple mobile with CoreCLR R2R and interpreter#124037
jkotas merged 3 commits into
dotnet:mainfrom
kotlarmilos:bugfix/clr-ios-async-handler

Conversation

@kotlarmilos

@kotlarmiloskotlarmilos commented Feb 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR disables failing test ToString_Async on Apple mobile.

Tracking issue #124044

CopilotAI review requested due to automatic review settings February 5, 2026 10:55
@kotlarmiloskotlarmilos self-assigned this Feb 5, 2026
@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 5, 2026
@kotlarmiloskotlarmilos added os-ios Apple iOS area-ExceptionHandling-coreclr only use for closed issues runtime-async and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 5, 2026
@kotlarmiloskotlarmilos added this to the 11.0.0 milestone Feb 5, 2026
CopilotAI reviewed Feb 5, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a garbage collection protection bug in the AsyncHelpers_AddContinuationToExInternal function by adding GCPROTECT_BEGIN and GCPROTECT_END around the call to StackTraceInfo::AppendElement. This function was introduced in PR #122722 which implemented runtime-async exception stack trace collection.

Changes:

  • Added GCPROTECT for the exception object reference in AsyncHelpers_AddContinuationToExInternal to prevent crashes from GC moving the object during stack trace appending
  • Removed trailing whitespace from multiple lines throughout the file for code formatting consistency

jkotas
jkotas reviewed Feb 5, 2026
View reviewed changes
Comment threadsrc/coreclr/vm/debugdebugger.cpp Outdated
@kotlarmiloskotlarmilos changed the title Add GCPROTECT for exception handling in AsyncHelpersDisable failing ToString_Async test on Apple mobile with CoreCLR R2R and interpreterFeb 5, 2026
jkotas
jkotas reviewed Feb 5, 2026
View reviewed changes
Comment threadsrc/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs Outdated
jkotas
jkotas reviewed Feb 5, 2026
View reviewed changes
Comment threadsrc/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs
@build-analysisbuild-analysisBot mentioned this pull request Feb 5, 2026
Closed
CopilotAI review requested due to automatic review settings February 5, 2026 22:22
CopilotAI reviewed Feb 5, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadsrc/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs
@jkotas

jkotas commented Feb 6, 2026

Copy link
Copy Markdown
Member

/ba-g Unrelated tvos crash with no actionable details "App terminated due to signal 11"

@jkotas
jkotas merged commit 8b675a6 into dotnet:mainFeb 6, 2026
134 of 137 checks passed
@kotlarmiloskotlarmilos mentioned this pull request Feb 6, 2026
Merged
@dotnet-maestrodotnet-maestroBot mentioned this pull request Feb 7, 2026
Merged
lewing pushed a commit to lewing/runtime that referenced this pull request Feb 9, 2026
@kotlarmilos@jkotas@lewing
Disable failing ToString_Async test on Apple mobile with CoreCLR R2R …
db22f79
…and interpreter (dotnet#124037)
## Description
This PR disables failing test ToString_Async on Apple mobile.
Tracking issue dotnet#124044
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
iremyux pushed a commit to iremyux/dotnet-runtime that referenced this pull request Mar 2, 2026
@kotlarmilos@jkotas@iremyux
Disable failing ToString_Async test on Apple mobile with CoreCLR R2R …
fdd048e
…and interpreter (dotnet#124037)
## Description
This PR disables failing test ToString_Async on Apple mobile.
Tracking issue dotnet#124044
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 8, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rcj1rcj1Awaiting requested review from rcj1

Assignees

@kotlarmiloskotlarmilos

Labels

area-ExceptionHandling-coreclronly use for closed issuesos-iosApple iOSruntime-async

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@jkotas