Add support for async thunk methods in GetNativeCodeInfo

[tommcdon]

The runtime by default caches the async thunk when looking up runtime async methods in the methoddef map:

runtime/src/coreclr/vm/clsload.cpp

Lines 2804 to 2810 in 0c7ef81

	// For {Task-returning, Async} variants of the same definition
	// we associate the methoddef with the Task-returning variant since it
	// matches the methadata signature.
	if (!pMD->IsUnboxingStub() && !pMD->IsAsyncVariantMethod())
	{
	pModule->EnsuredStoreMethodDef(pMD->GetMemberDef(), pMD);
	}

This causes DacDbiInterfaceImpl::GetNativeCodeInfo to incorrectly return data for the async thunk and not the actual method.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR attempts to fix an issue where DacDbiInterfaceImpl::GetNativeCodeInfo incorrectly returns data for async thunk methods instead of the actual async implementation method. The runtime caches async thunks in the methoddef map (see clsload.cpp:2804-2810), causing FindLoadedMethodRefOrDef to return the thunk. This PR adds logic to detect async thunk methods and attempts to find the corresponding async implementation method by iterating through all methods in the type.

Changes:

• Added logic to detect async thunk methods using IsAsyncThunkMethod()
• Implemented a loop to iterate through all introduced methods in the method table
• Filters methods using IsDiagnosticsHidden() to find the actual async implementation method

[tommcdon]

/ba-g changes only affect the DAC

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[noahfalk]

LGTM

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

---

You can also share your feedback on Copilot code review. Take the survey.

[tommcdon]

/ba-g failures are known issues

[tommcdon]

The runtime by default caches the async thunk when looking up runtime async methods in the methoddef map:

runtime/src/coreclr/vm/clsload.cpp

Lines 2804 to 2810 in 0c7ef81

	// For {Task-returning, Async} variants of the same definition
	// we associate the methoddef with the Task-returning variant since it
	// matches the methadata signature.
	if (!pMD->IsUnboxingStub() && !pMD->IsAsyncVariantMethod())
	{
	pModule->EnsuredStoreMethodDef(pMD->GetMemberDef(), pMD);
	}

This causes DacDbiInterfaceImpl::GetNativeCodeInfo to incorrectly return data for the async thunk and not the actual method.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR attempts to fix an issue where DacDbiInterfaceImpl::GetNativeCodeInfo incorrectly returns data for async thunk methods instead of the actual async implementation method. The runtime caches async thunks in the methoddef map (see clsload.cpp:2804-2810), causing FindLoadedMethodRefOrDef to return the thunk. This PR adds logic to detect async thunk methods and attempts to find the corresponding async implementation method by iterating through all methods in the type.

Changes:

• Added logic to detect async thunk methods using IsAsyncThunkMethod()
• Implemented a loop to iterate through all introduced methods in the method table
• Filters methods using IsDiagnosticsHidden() to find the actual async implementation method

[tommcdon]

/ba-g changes only affect the DAC

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[noahfalk]

LGTM

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

---

You can also share your feedback on Copilot code review. Take the survey.

[tommcdon]

/ba-g failures are known issues

[tommcdon]

The runtime by default caches the async thunk when looking up runtime async methods in the methoddef map:

runtime/src/coreclr/vm/clsload.cpp

Lines 2804 to 2810 in 0c7ef81

	// For {Task-returning, Async} variants of the same definition
	// we associate the methoddef with the Task-returning variant since it
	// matches the methadata signature.
	if (!pMD->IsUnboxingStub() && !pMD->IsAsyncVariantMethod())
	{
	pModule->EnsuredStoreMethodDef(pMD->GetMemberDef(), pMD);
	}

This causes DacDbiInterfaceImpl::GetNativeCodeInfo to incorrectly return data for the async thunk and not the actual method.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR attempts to fix an issue where DacDbiInterfaceImpl::GetNativeCodeInfo incorrectly returns data for async thunk methods instead of the actual async implementation method. The runtime caches async thunks in the methoddef map (see clsload.cpp:2804-2810), causing FindLoadedMethodRefOrDef to return the thunk. This PR adds logic to detect async thunk methods and attempts to find the corresponding async implementation method by iterating through all methods in the type.

Changes:

• Added logic to detect async thunk methods using IsAsyncThunkMethod()
• Implemented a loop to iterate through all introduced methods in the method table
• Filters methods using IsDiagnosticsHidden() to find the actual async implementation method

[tommcdon]

/ba-g changes only affect the DAC

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[noahfalk]

LGTM

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

---

You can also share your feedback on Copilot code review. Take the survey.

[tommcdon]

/ba-g failures are known issues

[tommcdon]

The runtime by default caches the async thunk when looking up runtime async methods in the methoddef map:

runtime/src/coreclr/vm/clsload.cpp

Lines 2804 to 2810 in 0c7ef81

	// For {Task-returning, Async} variants of the same definition
	// we associate the methoddef with the Task-returning variant since it
	// matches the methadata signature.
	if (!pMD->IsUnboxingStub() && !pMD->IsAsyncVariantMethod())
	{
	pModule->EnsuredStoreMethodDef(pMD->GetMemberDef(), pMD);
	}

This causes DacDbiInterfaceImpl::GetNativeCodeInfo to incorrectly return data for the async thunk and not the actual method.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR attempts to fix an issue where DacDbiInterfaceImpl::GetNativeCodeInfo incorrectly returns data for async thunk methods instead of the actual async implementation method. The runtime caches async thunks in the methoddef map (see clsload.cpp:2804-2810), causing FindLoadedMethodRefOrDef to return the thunk. This PR adds logic to detect async thunk methods and attempts to find the corresponding async implementation method by iterating through all methods in the type.

Changes:

• Added logic to detect async thunk methods using IsAsyncThunkMethod()
• Implemented a loop to iterate through all introduced methods in the method table
• Filters methods using IsDiagnosticsHidden() to find the actual async implementation method

[tommcdon]

/ba-g changes only affect the DAC

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[noahfalk]

LGTM

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

---

You can also share your feedback on Copilot code review. Take the survey.

[tommcdon]

/ba-g failures are known issues

[tommcdon]

The runtime by default caches the async thunk when looking up runtime async methods in the methoddef map:

runtime/src/coreclr/vm/clsload.cpp

Lines 2804 to 2810 in 0c7ef81

	// For {Task-returning, Async} variants of the same definition
	// we associate the methoddef with the Task-returning variant since it
	// matches the methadata signature.
	if (!pMD->IsUnboxingStub() && !pMD->IsAsyncVariantMethod())
	{
	pModule->EnsuredStoreMethodDef(pMD->GetMemberDef(), pMD);
	}

This causes DacDbiInterfaceImpl::GetNativeCodeInfo to incorrectly return data for the async thunk and not the actual method.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR attempts to fix an issue where DacDbiInterfaceImpl::GetNativeCodeInfo incorrectly returns data for async thunk methods instead of the actual async implementation method. The runtime caches async thunks in the methoddef map (see clsload.cpp:2804-2810), causing FindLoadedMethodRefOrDef to return the thunk. This PR adds logic to detect async thunk methods and attempts to find the corresponding async implementation method by iterating through all methods in the type.

Changes:

• Added logic to detect async thunk methods using IsAsyncThunkMethod()
• Implemented a loop to iterate through all introduced methods in the method table
• Filters methods using IsDiagnosticsHidden() to find the actual async implementation method

[tommcdon]

/ba-g changes only affect the DAC

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[noahfalk]

LGTM

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

---

You can also share your feedback on Copilot code review. Take the survey.

[tommcdon]

/ba-g failures are known issues

[tommcdon]

The runtime by default caches the async thunk when looking up runtime async methods in the methoddef map:

runtime/src/coreclr/vm/clsload.cpp

Lines 2804 to 2810 in 0c7ef81

	// For {Task-returning, Async} variants of the same definition
	// we associate the methoddef with the Task-returning variant since it
	// matches the methadata signature.
	if (!pMD->IsUnboxingStub() && !pMD->IsAsyncVariantMethod())
	{
	pModule->EnsuredStoreMethodDef(pMD->GetMemberDef(), pMD);
	}

This causes DacDbiInterfaceImpl::GetNativeCodeInfo to incorrectly return data for the async thunk and not the actual method.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR attempts to fix an issue where DacDbiInterfaceImpl::GetNativeCodeInfo incorrectly returns data for async thunk methods instead of the actual async implementation method. The runtime caches async thunks in the methoddef map (see clsload.cpp:2804-2810), causing FindLoadedMethodRefOrDef to return the thunk. This PR adds logic to detect async thunk methods and attempts to find the corresponding async implementation method by iterating through all methods in the type.

Changes:

• Added logic to detect async thunk methods using IsAsyncThunkMethod()
• Implemented a loop to iterate through all introduced methods in the method table
• Filters methods using IsDiagnosticsHidden() to find the actual async implementation method

[tommcdon]

/ba-g changes only affect the DAC

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[noahfalk]

LGTM

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

---

You can also share your feedback on Copilot code review. Take the survey.

[tommcdon]

/ba-g failures are known issues

[tommcdon]

The runtime by default caches the async thunk when looking up runtime async methods in the methoddef map:

runtime/src/coreclr/vm/clsload.cpp

Lines 2804 to 2810 in 0c7ef81

	// For {Task-returning, Async} variants of the same definition
	// we associate the methoddef with the Task-returning variant since it
	// matches the methadata signature.
	if (!pMD->IsUnboxingStub() && !pMD->IsAsyncVariantMethod())
	{
	pModule->EnsuredStoreMethodDef(pMD->GetMemberDef(), pMD);
	}

This causes DacDbiInterfaceImpl::GetNativeCodeInfo to incorrectly return data for the async thunk and not the actual method.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR attempts to fix an issue where DacDbiInterfaceImpl::GetNativeCodeInfo incorrectly returns data for async thunk methods instead of the actual async implementation method. The runtime caches async thunks in the methoddef map (see clsload.cpp:2804-2810), causing FindLoadedMethodRefOrDef to return the thunk. This PR adds logic to detect async thunk methods and attempts to find the corresponding async implementation method by iterating through all methods in the type.

Changes:

• Added logic to detect async thunk methods using IsAsyncThunkMethod()
• Implemented a loop to iterate through all introduced methods in the method table
• Filters methods using IsDiagnosticsHidden() to find the actual async implementation method

[tommcdon]

/ba-g changes only affect the DAC

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[noahfalk]

LGTM

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

---

You can also share your feedback on Copilot code review. Take the survey.

[tommcdon]

/ba-g failures are known issues

[tommcdon]

The runtime by default caches the async thunk when looking up runtime async methods in the methoddef map:

runtime/src/coreclr/vm/clsload.cpp

Lines 2804 to 2810 in 0c7ef81

	// For {Task-returning, Async} variants of the same definition
	// we associate the methoddef with the Task-returning variant since it
	// matches the methadata signature.
	if (!pMD->IsUnboxingStub() && !pMD->IsAsyncVariantMethod())
	{
	pModule->EnsuredStoreMethodDef(pMD->GetMemberDef(), pMD);
	}

This causes DacDbiInterfaceImpl::GetNativeCodeInfo to incorrectly return data for the async thunk and not the actual method.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR attempts to fix an issue where DacDbiInterfaceImpl::GetNativeCodeInfo incorrectly returns data for async thunk methods instead of the actual async implementation method. The runtime caches async thunks in the methoddef map (see clsload.cpp:2804-2810), causing FindLoadedMethodRefOrDef to return the thunk. This PR adds logic to detect async thunk methods and attempts to find the corresponding async implementation method by iterating through all methods in the type.

Changes:

• Added logic to detect async thunk methods using IsAsyncThunkMethod()
• Implemented a loop to iterate through all introduced methods in the method table
• Filters methods using IsDiagnosticsHidden() to find the actual async implementation method

[tommcdon]

/ba-g changes only affect the DAC

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

You can also share your feedback on Copilot code review. Take the survey.

[noahfalk]

LGTM

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

---

You can also share your feedback on Copilot code review. Take the survey.

[tommcdon]

/ba-g failures are known issues