Add support for async thunk methods in GetNativeCodeInfo by max-charlamb · Pull Request #124529 · dotnet/runtime

max-charlamb · 2026-02-17T21:57:10Z

Fork of #124354 which uses the existing FindOrCreateAssociatedMethodDesc logic

dotnet-policy-service · 2026-02-17T21:58:07Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This pull request adds support for async thunk methods in GetNativeCodeInfo by enabling the debugger DAC to resolve async thunk methods to their actual implementation method descriptors. The runtime caches async thunks in the methoddef map, which causes the debugger to incorrectly return data for the thunk instead of the actual method. This PR addresses that by:

Adding DAC support to the generic method infrastructure (genmeth.cpp, instmethhash.cpp, generics.cpp)
Creating a new GetAsyncOtherVariantNoCreate method that finds async variants without creating new ones (DAC-safe)
Using this new method in GetNativeCodeInfo to resolve async thunk methods to their actual implementations

Changes:

Added DAC compilation support to generic method code by moving genmeth.cpp to DAC+WKS build and adding appropriate DACCESS_COMPILE guards
Created GetAsyncOtherVariantNoCreate method to look up async method variants without allocation
Modified GetNativeCodeInfo to resolve async thunk methods to actual methods using the new lookup function

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/coreclr/vm/method.hpp	Adds `GetAsyncOtherVariantNoCreate` method that calls `FindOrCreateAssociatedMethodDesc` with `allowCreate=FALSE`
src/coreclr/vm/instmethhash.cpp	Makes Hash function DAC-compatible by using `dac_cast`, moves `FindMethodDesc` outside `DACCESS_COMPILE` guard
src/coreclr/vm/genmeth.cpp	Adds extensive `DACCESS_COMPILE` guards around creation code, adds `SUPPORTS_DAC` markers to contracts
src/coreclr/vm/generics.cpp	Moves `CheckInstantiation` outside `DACCESS_COMPILE` guard to make it available for DAC builds
src/coreclr/vm/CMakeLists.txt	Moves `genmeth.cpp` from `VM_SOURCES_WKS` to `VM_SOURCES_DAC_AND_WKS_COMMON` to enable DAC compilation
src/coreclr/debug/daccess/dacdbiimpl.cpp	Resolves async thunk methods to actual methods by calling `GetAsyncOtherVariantNoCreate`

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

dotnet-policy-service · 2026-04-10T10:53:32Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

max-charlamb · 2026-02-17T21:57:10Z

Fork of #124354 which uses the existing FindOrCreateAssociatedMethodDesc logic

dotnet-policy-service · 2026-02-17T21:58:07Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This pull request adds support for async thunk methods in GetNativeCodeInfo by enabling the debugger DAC to resolve async thunk methods to their actual implementation method descriptors. The runtime caches async thunks in the methoddef map, which causes the debugger to incorrectly return data for the thunk instead of the actual method. This PR addresses that by:

Adding DAC support to the generic method infrastructure (genmeth.cpp, instmethhash.cpp, generics.cpp)
Creating a new GetAsyncOtherVariantNoCreate method that finds async variants without creating new ones (DAC-safe)
Using this new method in GetNativeCodeInfo to resolve async thunk methods to their actual implementations

Changes:

Added DAC compilation support to generic method code by moving genmeth.cpp to DAC+WKS build and adding appropriate DACCESS_COMPILE guards
Created GetAsyncOtherVariantNoCreate method to look up async method variants without allocation
Modified GetNativeCodeInfo to resolve async thunk methods to actual methods using the new lookup function

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/coreclr/vm/method.hpp	Adds `GetAsyncOtherVariantNoCreate` method that calls `FindOrCreateAssociatedMethodDesc` with `allowCreate=FALSE`
src/coreclr/vm/instmethhash.cpp	Makes Hash function DAC-compatible by using `dac_cast`, moves `FindMethodDesc` outside `DACCESS_COMPILE` guard
src/coreclr/vm/genmeth.cpp	Adds extensive `DACCESS_COMPILE` guards around creation code, adds `SUPPORTS_DAC` markers to contracts
src/coreclr/vm/generics.cpp	Moves `CheckInstantiation` outside `DACCESS_COMPILE` guard to make it available for DAC builds
src/coreclr/vm/CMakeLists.txt	Moves `genmeth.cpp` from `VM_SOURCES_WKS` to `VM_SOURCES_DAC_AND_WKS_COMMON` to enable DAC compilation
src/coreclr/debug/daccess/dacdbiimpl.cpp	Resolves async thunk methods to actual methods by calling `GetAsyncOtherVariantNoCreate`

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

dotnet-policy-service · 2026-04-10T10:53:32Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

max-charlamb · 2026-02-17T21:57:10Z

Fork of #124354 which uses the existing FindOrCreateAssociatedMethodDesc logic

dotnet-policy-service · 2026-02-17T21:58:07Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This pull request adds support for async thunk methods in GetNativeCodeInfo by enabling the debugger DAC to resolve async thunk methods to their actual implementation method descriptors. The runtime caches async thunks in the methoddef map, which causes the debugger to incorrectly return data for the thunk instead of the actual method. This PR addresses that by:

Adding DAC support to the generic method infrastructure (genmeth.cpp, instmethhash.cpp, generics.cpp)
Creating a new GetAsyncOtherVariantNoCreate method that finds async variants without creating new ones (DAC-safe)
Using this new method in GetNativeCodeInfo to resolve async thunk methods to their actual implementations

Changes:

Added DAC compilation support to generic method code by moving genmeth.cpp to DAC+WKS build and adding appropriate DACCESS_COMPILE guards
Created GetAsyncOtherVariantNoCreate method to look up async method variants without allocation
Modified GetNativeCodeInfo to resolve async thunk methods to actual methods using the new lookup function

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/coreclr/vm/method.hpp	Adds `GetAsyncOtherVariantNoCreate` method that calls `FindOrCreateAssociatedMethodDesc` with `allowCreate=FALSE`
src/coreclr/vm/instmethhash.cpp	Makes Hash function DAC-compatible by using `dac_cast`, moves `FindMethodDesc` outside `DACCESS_COMPILE` guard
src/coreclr/vm/genmeth.cpp	Adds extensive `DACCESS_COMPILE` guards around creation code, adds `SUPPORTS_DAC` markers to contracts
src/coreclr/vm/generics.cpp	Moves `CheckInstantiation` outside `DACCESS_COMPILE` guard to make it available for DAC builds
src/coreclr/vm/CMakeLists.txt	Moves `genmeth.cpp` from `VM_SOURCES_WKS` to `VM_SOURCES_DAC_AND_WKS_COMMON` to enable DAC compilation
src/coreclr/debug/daccess/dacdbiimpl.cpp	Resolves async thunk methods to actual methods by calling `GetAsyncOtherVariantNoCreate`

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

dotnet-policy-service · 2026-04-10T10:53:32Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

max-charlamb · 2026-02-17T21:57:10Z

Fork of #124354 which uses the existing FindOrCreateAssociatedMethodDesc logic

dotnet-policy-service · 2026-02-17T21:58:07Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This pull request adds support for async thunk methods in GetNativeCodeInfo by enabling the debugger DAC to resolve async thunk methods to their actual implementation method descriptors. The runtime caches async thunks in the methoddef map, which causes the debugger to incorrectly return data for the thunk instead of the actual method. This PR addresses that by:

Adding DAC support to the generic method infrastructure (genmeth.cpp, instmethhash.cpp, generics.cpp)
Creating a new GetAsyncOtherVariantNoCreate method that finds async variants without creating new ones (DAC-safe)
Using this new method in GetNativeCodeInfo to resolve async thunk methods to their actual implementations

Changes:

Added DAC compilation support to generic method code by moving genmeth.cpp to DAC+WKS build and adding appropriate DACCESS_COMPILE guards
Created GetAsyncOtherVariantNoCreate method to look up async method variants without allocation
Modified GetNativeCodeInfo to resolve async thunk methods to actual methods using the new lookup function

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/coreclr/vm/method.hpp	Adds `GetAsyncOtherVariantNoCreate` method that calls `FindOrCreateAssociatedMethodDesc` with `allowCreate=FALSE`
src/coreclr/vm/instmethhash.cpp	Makes Hash function DAC-compatible by using `dac_cast`, moves `FindMethodDesc` outside `DACCESS_COMPILE` guard
src/coreclr/vm/genmeth.cpp	Adds extensive `DACCESS_COMPILE` guards around creation code, adds `SUPPORTS_DAC` markers to contracts
src/coreclr/vm/generics.cpp	Moves `CheckInstantiation` outside `DACCESS_COMPILE` guard to make it available for DAC builds
src/coreclr/vm/CMakeLists.txt	Moves `genmeth.cpp` from `VM_SOURCES_WKS` to `VM_SOURCES_DAC_AND_WKS_COMMON` to enable DAC compilation
src/coreclr/debug/daccess/dacdbiimpl.cpp	Resolves async thunk methods to actual methods by calling `GetAsyncOtherVariantNoCreate`

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

dotnet-policy-service · 2026-04-10T10:53:32Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

max-charlamb · 2026-02-17T21:57:10Z

Fork of #124354 which uses the existing FindOrCreateAssociatedMethodDesc logic

dotnet-policy-service · 2026-02-17T21:58:07Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This pull request adds support for async thunk methods in GetNativeCodeInfo by enabling the debugger DAC to resolve async thunk methods to their actual implementation method descriptors. The runtime caches async thunks in the methoddef map, which causes the debugger to incorrectly return data for the thunk instead of the actual method. This PR addresses that by:

Adding DAC support to the generic method infrastructure (genmeth.cpp, instmethhash.cpp, generics.cpp)
Creating a new GetAsyncOtherVariantNoCreate method that finds async variants without creating new ones (DAC-safe)
Using this new method in GetNativeCodeInfo to resolve async thunk methods to their actual implementations

Changes:

Added DAC compilation support to generic method code by moving genmeth.cpp to DAC+WKS build and adding appropriate DACCESS_COMPILE guards
Created GetAsyncOtherVariantNoCreate method to look up async method variants without allocation
Modified GetNativeCodeInfo to resolve async thunk methods to actual methods using the new lookup function

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/coreclr/vm/method.hpp	Adds `GetAsyncOtherVariantNoCreate` method that calls `FindOrCreateAssociatedMethodDesc` with `allowCreate=FALSE`
src/coreclr/vm/instmethhash.cpp	Makes Hash function DAC-compatible by using `dac_cast`, moves `FindMethodDesc` outside `DACCESS_COMPILE` guard
src/coreclr/vm/genmeth.cpp	Adds extensive `DACCESS_COMPILE` guards around creation code, adds `SUPPORTS_DAC` markers to contracts
src/coreclr/vm/generics.cpp	Moves `CheckInstantiation` outside `DACCESS_COMPILE` guard to make it available for DAC builds
src/coreclr/vm/CMakeLists.txt	Moves `genmeth.cpp` from `VM_SOURCES_WKS` to `VM_SOURCES_DAC_AND_WKS_COMMON` to enable DAC compilation
src/coreclr/debug/daccess/dacdbiimpl.cpp	Resolves async thunk methods to actual methods by calling `GetAsyncOtherVariantNoCreate`

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

dotnet-policy-service · 2026-04-10T10:53:32Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

max-charlamb · 2026-02-17T21:57:10Z

Fork of #124354 which uses the existing FindOrCreateAssociatedMethodDesc logic

dotnet-policy-service · 2026-02-17T21:58:07Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This pull request adds support for async thunk methods in GetNativeCodeInfo by enabling the debugger DAC to resolve async thunk methods to their actual implementation method descriptors. The runtime caches async thunks in the methoddef map, which causes the debugger to incorrectly return data for the thunk instead of the actual method. This PR addresses that by:

Adding DAC support to the generic method infrastructure (genmeth.cpp, instmethhash.cpp, generics.cpp)
Creating a new GetAsyncOtherVariantNoCreate method that finds async variants without creating new ones (DAC-safe)
Using this new method in GetNativeCodeInfo to resolve async thunk methods to their actual implementations

Changes:

Added DAC compilation support to generic method code by moving genmeth.cpp to DAC+WKS build and adding appropriate DACCESS_COMPILE guards
Created GetAsyncOtherVariantNoCreate method to look up async method variants without allocation
Modified GetNativeCodeInfo to resolve async thunk methods to actual methods using the new lookup function

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/coreclr/vm/method.hpp	Adds `GetAsyncOtherVariantNoCreate` method that calls `FindOrCreateAssociatedMethodDesc` with `allowCreate=FALSE`
src/coreclr/vm/instmethhash.cpp	Makes Hash function DAC-compatible by using `dac_cast`, moves `FindMethodDesc` outside `DACCESS_COMPILE` guard
src/coreclr/vm/genmeth.cpp	Adds extensive `DACCESS_COMPILE` guards around creation code, adds `SUPPORTS_DAC` markers to contracts
src/coreclr/vm/generics.cpp	Moves `CheckInstantiation` outside `DACCESS_COMPILE` guard to make it available for DAC builds
src/coreclr/vm/CMakeLists.txt	Moves `genmeth.cpp` from `VM_SOURCES_WKS` to `VM_SOURCES_DAC_AND_WKS_COMMON` to enable DAC compilation
src/coreclr/debug/daccess/dacdbiimpl.cpp	Resolves async thunk methods to actual methods by calling `GetAsyncOtherVariantNoCreate`

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

dotnet-policy-service · 2026-04-10T10:53:32Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

max-charlamb · 2026-02-17T21:57:10Z

Fork of #124354 which uses the existing FindOrCreateAssociatedMethodDesc logic

dotnet-policy-service · 2026-02-17T21:58:07Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This pull request adds support for async thunk methods in GetNativeCodeInfo by enabling the debugger DAC to resolve async thunk methods to their actual implementation method descriptors. The runtime caches async thunks in the methoddef map, which causes the debugger to incorrectly return data for the thunk instead of the actual method. This PR addresses that by:

Adding DAC support to the generic method infrastructure (genmeth.cpp, instmethhash.cpp, generics.cpp)
Creating a new GetAsyncOtherVariantNoCreate method that finds async variants without creating new ones (DAC-safe)
Using this new method in GetNativeCodeInfo to resolve async thunk methods to their actual implementations

Changes:

Added DAC compilation support to generic method code by moving genmeth.cpp to DAC+WKS build and adding appropriate DACCESS_COMPILE guards
Created GetAsyncOtherVariantNoCreate method to look up async method variants without allocation
Modified GetNativeCodeInfo to resolve async thunk methods to actual methods using the new lookup function

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/coreclr/vm/method.hpp	Adds `GetAsyncOtherVariantNoCreate` method that calls `FindOrCreateAssociatedMethodDesc` with `allowCreate=FALSE`
src/coreclr/vm/instmethhash.cpp	Makes Hash function DAC-compatible by using `dac_cast`, moves `FindMethodDesc` outside `DACCESS_COMPILE` guard
src/coreclr/vm/genmeth.cpp	Adds extensive `DACCESS_COMPILE` guards around creation code, adds `SUPPORTS_DAC` markers to contracts
src/coreclr/vm/generics.cpp	Moves `CheckInstantiation` outside `DACCESS_COMPILE` guard to make it available for DAC builds
src/coreclr/vm/CMakeLists.txt	Moves `genmeth.cpp` from `VM_SOURCES_WKS` to `VM_SOURCES_DAC_AND_WKS_COMMON` to enable DAC compilation
src/coreclr/debug/daccess/dacdbiimpl.cpp	Resolves async thunk methods to actual methods by calling `GetAsyncOtherVariantNoCreate`

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

dotnet-policy-service · 2026-04-10T10:53:32Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

max-charlamb · 2026-02-17T21:57:10Z

Fork of #124354 which uses the existing FindOrCreateAssociatedMethodDesc logic

dotnet-policy-service · 2026-02-17T21:58:07Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This pull request adds support for async thunk methods in GetNativeCodeInfo by enabling the debugger DAC to resolve async thunk methods to their actual implementation method descriptors. The runtime caches async thunks in the methoddef map, which causes the debugger to incorrectly return data for the thunk instead of the actual method. This PR addresses that by:

Adding DAC support to the generic method infrastructure (genmeth.cpp, instmethhash.cpp, generics.cpp)
Creating a new GetAsyncOtherVariantNoCreate method that finds async variants without creating new ones (DAC-safe)
Using this new method in GetNativeCodeInfo to resolve async thunk methods to their actual implementations

Changes:

Added DAC compilation support to generic method code by moving genmeth.cpp to DAC+WKS build and adding appropriate DACCESS_COMPILE guards
Created GetAsyncOtherVariantNoCreate method to look up async method variants without allocation
Modified GetNativeCodeInfo to resolve async thunk methods to actual methods using the new lookup function

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/coreclr/vm/method.hpp	Adds `GetAsyncOtherVariantNoCreate` method that calls `FindOrCreateAssociatedMethodDesc` with `allowCreate=FALSE`
src/coreclr/vm/instmethhash.cpp	Makes Hash function DAC-compatible by using `dac_cast`, moves `FindMethodDesc` outside `DACCESS_COMPILE` guard
src/coreclr/vm/genmeth.cpp	Adds extensive `DACCESS_COMPILE` guards around creation code, adds `SUPPORTS_DAC` markers to contracts
src/coreclr/vm/generics.cpp	Moves `CheckInstantiation` outside `DACCESS_COMPILE` guard to make it available for DAC builds
src/coreclr/vm/CMakeLists.txt	Moves `genmeth.cpp` from `VM_SOURCES_WKS` to `VM_SOURCES_DAC_AND_WKS_COMMON` to enable DAC compilation
src/coreclr/debug/daccess/dacdbiimpl.cpp	Resolves async thunk methods to actual methods by calling `GetAsyncOtherVariantNoCreate`

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

dotnet-policy-service · 2026-04-10T10:53:32Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

tommcdonand others added 2 commits February 12, 2026 15:50

Add support for async thunk methods in GetNativeCodeInfo
cf4515c

dacize and use FindOrCreateAssociatedMethodDesc
40d89df

CopilotAI review requested due to automatic review settings February 17, 2026 21:57

github-actionsBot added the area-VM-coreclr label Feb 17, 2026

dotnet-policy-serviceBot assigned max-charlamb Feb 17, 2026

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 21:58 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated

Apply suggestions from code review
d5a4798
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings February 17, 2026 22:19

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 22:20 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

max-charlamb mentioned this pull request Feb 17, 2026
Add support for async thunk methods in GetNativeCodeInfo #124354
Merged

jkotas added the runtime-async label Mar 11, 2026

dotnet-policy-serviceBot closed this Apr 10, 2026

github-actionsBot locked and limited conversation to collaborators May 11, 2026

tommcdonand others added 2 commits February 12, 2026 15:50

Add support for async thunk methods in GetNativeCodeInfo
cf4515c

dacize and use FindOrCreateAssociatedMethodDesc
40d89df

CopilotAI review requested due to automatic review settings February 17, 2026 21:57

github-actionsBot added the area-VM-coreclr label Feb 17, 2026

dotnet-policy-serviceBot assigned max-charlamb Feb 17, 2026

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 21:58 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated

Apply suggestions from code review
d5a4798
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings February 17, 2026 22:19

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 22:20 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

max-charlamb mentioned this pull request Feb 17, 2026
Add support for async thunk methods in GetNativeCodeInfo #124354
Merged

jkotas added the runtime-async label Mar 11, 2026

dotnet-policy-serviceBot closed this Apr 10, 2026

github-actionsBot locked and limited conversation to collaborators May 11, 2026

tommcdonand others added 2 commits February 12, 2026 15:50

Add support for async thunk methods in GetNativeCodeInfo
cf4515c

dacize and use FindOrCreateAssociatedMethodDesc
40d89df

CopilotAI review requested due to automatic review settings February 17, 2026 21:57

github-actionsBot added the area-VM-coreclr label Feb 17, 2026

dotnet-policy-serviceBot assigned max-charlamb Feb 17, 2026

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 21:58 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated

Apply suggestions from code review
d5a4798
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings February 17, 2026 22:19

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 22:20 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

max-charlamb mentioned this pull request Feb 17, 2026
Add support for async thunk methods in GetNativeCodeInfo #124354
Merged

jkotas added the runtime-async label Mar 11, 2026

dotnet-policy-serviceBot closed this Apr 10, 2026

github-actionsBot locked and limited conversation to collaborators May 11, 2026

tommcdonand others added 2 commits February 12, 2026 15:50

Add support for async thunk methods in GetNativeCodeInfo
cf4515c

dacize and use FindOrCreateAssociatedMethodDesc
40d89df

CopilotAI review requested due to automatic review settings February 17, 2026 21:57

github-actionsBot added the area-VM-coreclr label Feb 17, 2026

dotnet-policy-serviceBot assigned max-charlamb Feb 17, 2026

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 21:58 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated

Apply suggestions from code review
d5a4798
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings February 17, 2026 22:19

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 22:20 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

max-charlamb mentioned this pull request Feb 17, 2026
Add support for async thunk methods in GetNativeCodeInfo #124354
Merged

jkotas added the runtime-async label Mar 11, 2026

dotnet-policy-serviceBot closed this Apr 10, 2026

github-actionsBot locked and limited conversation to collaborators May 11, 2026

tommcdonand others added 2 commits February 12, 2026 15:50

Add support for async thunk methods in GetNativeCodeInfo
cf4515c

dacize and use FindOrCreateAssociatedMethodDesc
40d89df

CopilotAI review requested due to automatic review settings February 17, 2026 21:57

github-actionsBot added the area-VM-coreclr label Feb 17, 2026

dotnet-policy-serviceBot assigned max-charlamb Feb 17, 2026

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 21:58 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated

Apply suggestions from code review
d5a4798
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings February 17, 2026 22:19

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 22:20 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

max-charlamb mentioned this pull request Feb 17, 2026
Add support for async thunk methods in GetNativeCodeInfo #124354
Merged

jkotas added the runtime-async label Mar 11, 2026

dotnet-policy-serviceBot closed this Apr 10, 2026

github-actionsBot locked and limited conversation to collaborators May 11, 2026

tommcdonand others added 2 commits February 12, 2026 15:50

Add support for async thunk methods in GetNativeCodeInfo
cf4515c

dacize and use FindOrCreateAssociatedMethodDesc
40d89df

CopilotAI review requested due to automatic review settings February 17, 2026 21:57

github-actionsBot added the area-VM-coreclr label Feb 17, 2026

dotnet-policy-serviceBot assigned max-charlamb Feb 17, 2026

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 21:58 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated

Apply suggestions from code review
d5a4798
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings February 17, 2026 22:19

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 22:20 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

max-charlamb mentioned this pull request Feb 17, 2026
Add support for async thunk methods in GetNativeCodeInfo #124354
Merged

jkotas added the runtime-async label Mar 11, 2026

dotnet-policy-serviceBot closed this Apr 10, 2026

github-actionsBot locked and limited conversation to collaborators May 11, 2026

tommcdonand others added 2 commits February 12, 2026 15:50

Add support for async thunk methods in GetNativeCodeInfo
cf4515c

dacize and use FindOrCreateAssociatedMethodDesc
40d89df

CopilotAI review requested due to automatic review settings February 17, 2026 21:57

github-actionsBot added the area-VM-coreclr label Feb 17, 2026

dotnet-policy-serviceBot assigned max-charlamb Feb 17, 2026

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 21:58 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated

Apply suggestions from code review
d5a4798
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings February 17, 2026 22:19

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 22:20 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

max-charlamb mentioned this pull request Feb 17, 2026
Add support for async thunk methods in GetNativeCodeInfo #124354
Merged

jkotas added the runtime-async label Mar 11, 2026

dotnet-policy-serviceBot closed this Apr 10, 2026

github-actionsBot locked and limited conversation to collaborators May 11, 2026

tommcdonand others added 2 commits February 12, 2026 15:50

Add support for async thunk methods in GetNativeCodeInfo
cf4515c

dacize and use FindOrCreateAssociatedMethodDesc
40d89df

CopilotAI review requested due to automatic review settings February 17, 2026 21:57

github-actionsBot added the area-VM-coreclr label Feb 17, 2026

dotnet-policy-serviceBot assigned max-charlamb Feb 17, 2026

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 21:58 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp Outdated

Apply suggestions from code review
d5a4798
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings February 17, 2026 22:19

Copilotstarted reviewing on behalf of max-charlamb February 17, 2026 22:20 View session

CopilotAI reviewed Feb 17, 2026
View reviewed changes

max-charlamb mentioned this pull request Feb 17, 2026
Add support for async thunk methods in GetNativeCodeInfo #124354
Merged

jkotas added the runtime-async label Mar 11, 2026

dotnet-policy-serviceBot closed this Apr 10, 2026

github-actionsBot locked and limited conversation to collaborators May 11, 2026

Uh oh!

Conversation

max-charlamb commented Feb 17, 2026

Uh oh!

dotnet-policy-serviceBot commented Feb 17, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

dotnet-policy-serviceBot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

max-charlamb commented Feb 17, 2026

Uh oh!

dotnet-policy-serviceBot commented Feb 17, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

dotnet-policy-serviceBot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

max-charlamb commented Feb 17, 2026

Uh oh!

dotnet-policy-serviceBot commented Feb 17, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

dotnet-policy-serviceBot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!