Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4 - #124637

Merged
tannergooding merged 18 commits into
dotnet:mainfrom
a74nh:svesets_github
Apr 13, 2026
Merged

Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4#124637
tannergooding merged 18 commits into
dotnet:mainfrom
a74nh:svesets_github

Conversation

@a74nh

@a74nha74nh commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Mostly a copy/paste of #115117

CopilotAI review requested due to automatic review settings February 20, 2026 12:50
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 20, 2026
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Feb 20, 2026
@a74nh
a74nh marked this pull request as draft February 20, 2026 12:51
@dotnet-policy-service

dotnet-policy-serviceBot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

CopilotAI reviewed Feb 20, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds end-to-end ARM64 instruction set detection and plumbing for SHA3/SM4 and SVE crypto extensions so the runtime/JIT/R2R toolchain can recognize and gate these features consistently across platforms.

Changes:

  • Extend minipal_getcpufeatures to detect SHA3/SM4 and SVE AES/SHA3/SM4 (Linux hwcaps, Apple sysctlbyname, Windows IsProcessorFeaturePresent).
  • Add new ARM64 instruction sets (including R2R IDs/implications) and propagate them through CoreCLR instruction-set enums and helpers.
  • Gate JIT enablement via new CLRConfig/JitConfig switches and wire feature bits into EE JIT compile flags.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
src/native/minipal/cpufeatures.hAdds new ARM64 feature-bit constants for SHA3/SM4 and SVE crypto extensions.
src/native/minipal/cpufeatures.cDetects new ARM64 capabilities via HWCAP/HWCAP2, sysctl, and Windows PF_* flags.
src/coreclr/vm/codeman.cppSets CPU compile flags for new instruction sets, gated by CLRConfig switches.
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txtRegisters new ARM64 instruction sets, R2R bits, and ISA implications.
src/coreclr/tools/Common/JitInterface/CorInfoInstructionSet.csUpdates managed instruction-set enums and implication handling for new ARM64 ISAs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSetHelper.csMaps new ARM64 instruction sets to R2R instruction set IDs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSet.csAdds new R2R instruction set enum values for ARM64 SHA3/SM4 and SVE crypto.
src/coreclr/jit/jitconfigvalues.hIntroduces JIT config toggles for enabling/disabling the new ARM64 ISAs.
src/coreclr/jit/hwintrinsicarm64.cppAdds name-to-instruction-set and Arm64-variant mapping for new ISAs.
src/coreclr/jit/hwintrinsic.cppExtends ISA range table to include the new ARM64 instruction sets.
src/coreclr/jit/compiler.cppEnables new ARM64 instruction sets in “enable available ISAs” flow based on JitConfig.
src/coreclr/inc/readytoruninstructionset.hAdds new R2R instruction set IDs on the native side.
src/coreclr/inc/jiteeversionguid.hBumps JIT/EE version GUID due to instruction-set enum changes.
src/coreclr/inc/corinfoinstructionset.hExtends CORINFO instruction-set enums/validation/mappings for new ARM64 ISAs.
src/coreclr/inc/clrconfigvalues.hAdds CLRConfig switches to gate the new ARM64 ISAs.

Comment threadsrc/native/minipal/cpufeatures.h
Comment threadsrc/native/minipal/cpufeatures.c
CopilotAI review requested due to automatic review settings February 20, 2026 14:30
CopilotAI reviewed Feb 20, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs Outdated
Comment threadsrc/coreclr/inc/clrconfigvalues.h Outdated
Comment threadsrc/coreclr/jit/jitconfigvalues.h Outdated
@a74nh
Update src/coreclr/jit/jitconfigvalues.h
06c126e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings February 20, 2026 14:38
a74nhand others added 2 commits February 20, 2026 14:38
@a74nh
Update src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
04c6104
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@a74nh
Update src/coreclr/inc/clrconfigvalues.h
96aa117
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI reviewed Feb 20, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
@a74nh
a74nh marked this pull request as ready for review February 20, 2026 16:48
@a74nh

a74nh commented Feb 20, 2026

Copy link
Copy Markdown
ContributorAuthor

@dotnet/arm64-contrib
This is ready now

This was referenced Feb 20, 2026
Open
Open
Open
Closed
@build-analysisbuild-analysisBot mentioned this pull request Feb 23, 2026
Closed
@jkotas

jkotas commented Mar 18, 2026

Copy link
Copy Markdown
Member

@jkotas - I think we need someone from your area to review this. Could you take a look please.

@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?

I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.

@a74nh

a74nh commented Mar 18, 2026

Copy link
Copy Markdown
ContributorAuthor

@jkotas - I think we need someone from your area to review this. Could you take a look please.

@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?

These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet

Approvals are:
#98696
#98692
#94426
#94425
#94423

I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.

Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.

If people agree, then I'm happy to drop these - and we'd remove them from #121787

This was referenced Mar 18, 2026
Open
Closed
@a74nha74nh mentioned this pull request Apr 1, 2026
Closed
20 tasks
@dhartglassMSFT

dhartglassMSFT commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

@jkotas - I think we need someone from your area to review this. Could you take a look please.

@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?

These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet

Approvals are: #98696#98692#94426#94425#94423

I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.

Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.

If people agree, then I'm happy to drop these - and we'd remove them from #121787

I talked to Jan offline

This change is good to go in, I'll update the branch and requeue check

But priority should still be SVE2 light-up

@dhartglassMSFT
dhartglassMSFT enabled auto-merge (squash) April 7, 2026 18:22
This was referenced Apr 8, 2026
Closed
Closed
CopilotAI review requested due to automatic review settings April 9, 2026 13:22
auto-merge was automatically disabled April 9, 2026 13:22

Head branch was pushed to by a user without write access

CopilotAI reviewed Apr 9, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

This was referenced Apr 9, 2026
Closed
Open
Closed
Closed
@a74nh

a74nh commented Apr 10, 2026

Copy link
Copy Markdown
ContributorAuthor

@dhartglassMSFT : looks like my commits caused automerge to turn off.

Failures seems to be unrelated wasm issues.

CopilotAI mentioned this pull request Apr 11, 2026
Merged
1 task
@tannergooding

tannergooding commented Apr 13, 2026

Copy link
Copy Markdown
Member

/ba-g unrelated timeout

@tannergooding
tannergooding merged commit 1f1f5fd into dotnet:mainApr 13, 2026
186 of 190 checks passed
@build-analysisbuild-analysisBot mentioned this pull request Apr 13, 2026
Closed
@a74nh
a74nh deleted the svesets_github branch April 14, 2026 10:23
@dotnet-maestrodotnet-maestroBot mentioned this pull request Apr 15, 2026
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 15, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dhartglassMSFTdhartglassMSFTdhartglassMSFT approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@jkotasjkotasAwaiting requested review from jkotas

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@a74nh@dhartglassMSFT@jkotas@tannergooding
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4 - #124637
Merged
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Apr 13, 2026
Merged
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4#124637
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Conversation
@a74nh
@a74nha74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Mostly a copy/paste of #115117
CopilotAI
review requested due to automatic review settings
February 20, 2026 12:50
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 20, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 20, 2026
@a74nh
a74nh
marked this pull request as draft
February 20, 2026 12:51
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds end-to-end ARM64 instruction set detection and plumbing for SHA3/SM4 and SVE crypto extensions so the runtime/JIT/R2R toolchain can recognize and gate these features consistently across platforms.
Changes:
  • Extend minipal_getcpufeatures to detect SHA3/SM4 and SVE AES/SHA3/SM4 (Linux hwcaps, Apple sysctlbyname, Windows IsProcessorFeaturePresent).
  • Add new ARM64 instruction sets (including R2R IDs/implications) and propagate them through CoreCLR instruction-set enums and helpers.
  • Gate JIT enablement via new CLRConfig/JitConfig switches and wire feature bits into EE JIT compile flags.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/native/minipal/cpufeatures.hAdds new ARM64 feature-bit constants for SHA3/SM4 and SVE crypto extensions.
src/native/minipal/cpufeatures.cDetects new ARM64 capabilities via HWCAP/HWCAP2, sysctl, and Windows PF_* flags.
src/coreclr/vm/codeman.cppSets CPU compile flags for new instruction sets, gated by CLRConfig switches.
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txtRegisters new ARM64 instruction sets, R2R bits, and ISA implications.
src/coreclr/tools/Common/JitInterface/CorInfoInstructionSet.csUpdates managed instruction-set enums and implication handling for new ARM64 ISAs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSetHelper.csMaps new ARM64 instruction sets to R2R instruction set IDs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSet.csAdds new R2R instruction set enum values for ARM64 SHA3/SM4 and SVE crypto.
src/coreclr/jit/jitconfigvalues.hIntroduces JIT config toggles for enabling/disabling the new ARM64 ISAs.
src/coreclr/jit/hwintrinsicarm64.cppAdds name-to-instruction-set and Arm64-variant mapping for new ISAs.
src/coreclr/jit/hwintrinsic.cppExtends ISA range table to include the new ARM64 instruction sets.
src/coreclr/jit/compiler.cppEnables new ARM64 instruction sets in “enable available ISAs” flow based on JitConfig.
src/coreclr/inc/readytoruninstructionset.hAdds new R2R instruction set IDs on the native side.
src/coreclr/inc/jiteeversionguid.hBumps JIT/EE version GUID due to instruction-set enum changes.
src/coreclr/inc/corinfoinstructionset.hExtends CORINFO instruction-set enums/validation/mappings for new ARM64 ISAs.
src/coreclr/inc/clrconfigvalues.hAdds CLRConfig switches to gate the new ARM64 ISAs.
Comment threadsrc/native/minipal/cpufeatures.h
Comment threadsrc/native/minipal/cpufeatures.c
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:30
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
Outdated

Comment threadsrc/coreclr/inc/clrconfigvalues.h
Outdated

Comment threadsrc/coreclr/jit/jitconfigvalues.h
Outdated

@a74nh
Update src/coreclr/jit/jitconfigvalues.h
06c126e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:38
a74nhand others
added 2 commits
February 20, 2026 14:38
@a74nh
Update src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
04c6104
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@a74nh
Update src/coreclr/inc/clrconfigvalues.h
96aa117
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
@a74nh
a74nh
marked this pull request as ready for review
February 20, 2026 16:48
@a74nh
a74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib

This is ready now

This was referenced Feb 20, 2026

Open


Open


Open


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 23, 2026

Closed

@jkotas
jkotas
commented
Mar 18, 2026

Copy link


Copy Markdown

Member
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
@a74nh
a74nh
commented
Mar 18, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are:
#98696
#98692
#94426
#94425
#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787

This was referenced Mar 18, 2026

Open


Closed

@a74nha74nh
mentioned this pull request
Apr 1, 2026

Closed

20 tasks
@dhartglassMSFT
dhartglassMSFT
commented
Apr 7, 2026

Copy link


Copy Markdown

Contributor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are: #98696#98692#94426#94425#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787
I talked to Jan offline
This change is good to go in, I'll update the branch and requeue check
But priority should still be SVE2 light-up
@dhartglassMSFT
dhartglassMSFT
enabled auto-merge (squash)
April 7, 2026 18:22

This was referenced Apr 8, 2026

Closed


Closed

CopilotAI
review requested due to automatic review settings
April 9, 2026 13:22

auto-merge was automatically disabled
April 9, 2026 13:22
Head branch was pushed to by a user without write access
CopilotAI
reviewed
Apr 9, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

This was referenced Apr 9, 2026

Closed


Open


Closed


Closed

@a74nh
a74nh
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@dhartglassMSFT : looks like my commits caused automerge to turn off.
Failures seems to be unrelated wasm issues.
CopilotAI
mentioned this pull request
Apr 11, 2026
 Merged

1 task
@tannergooding
tannergooding
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated timeout
@tannergooding
tannergooding
merged commit 1f1f5fd
into
dotnet:mainApr 13, 2026

186 of 190 checks passed

@build-analysisbuild-analysisBot
mentioned this pull request
Apr 13, 2026

Closed

@a74nh
a74nh
deleted the

svesets_github

branch
April 14, 2026 10:23
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 15, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dhartglassMSFTdhartglassMSFTdhartglassMSFT approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@jkotasjkotasAwaiting requested review from jkotas

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@a74nh@dhartglassMSFT@jkotas@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4 - #124637
Merged
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Apr 13, 2026
Merged
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4#124637
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Conversation
@a74nh
@a74nha74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Mostly a copy/paste of #115117
CopilotAI
review requested due to automatic review settings
February 20, 2026 12:50
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 20, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 20, 2026
@a74nh
a74nh
marked this pull request as draft
February 20, 2026 12:51
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds end-to-end ARM64 instruction set detection and plumbing for SHA3/SM4 and SVE crypto extensions so the runtime/JIT/R2R toolchain can recognize and gate these features consistently across platforms.
Changes:
  • Extend minipal_getcpufeatures to detect SHA3/SM4 and SVE AES/SHA3/SM4 (Linux hwcaps, Apple sysctlbyname, Windows IsProcessorFeaturePresent).
  • Add new ARM64 instruction sets (including R2R IDs/implications) and propagate them through CoreCLR instruction-set enums and helpers.
  • Gate JIT enablement via new CLRConfig/JitConfig switches and wire feature bits into EE JIT compile flags.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/native/minipal/cpufeatures.hAdds new ARM64 feature-bit constants for SHA3/SM4 and SVE crypto extensions.
src/native/minipal/cpufeatures.cDetects new ARM64 capabilities via HWCAP/HWCAP2, sysctl, and Windows PF_* flags.
src/coreclr/vm/codeman.cppSets CPU compile flags for new instruction sets, gated by CLRConfig switches.
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txtRegisters new ARM64 instruction sets, R2R bits, and ISA implications.
src/coreclr/tools/Common/JitInterface/CorInfoInstructionSet.csUpdates managed instruction-set enums and implication handling for new ARM64 ISAs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSetHelper.csMaps new ARM64 instruction sets to R2R instruction set IDs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSet.csAdds new R2R instruction set enum values for ARM64 SHA3/SM4 and SVE crypto.
src/coreclr/jit/jitconfigvalues.hIntroduces JIT config toggles for enabling/disabling the new ARM64 ISAs.
src/coreclr/jit/hwintrinsicarm64.cppAdds name-to-instruction-set and Arm64-variant mapping for new ISAs.
src/coreclr/jit/hwintrinsic.cppExtends ISA range table to include the new ARM64 instruction sets.
src/coreclr/jit/compiler.cppEnables new ARM64 instruction sets in “enable available ISAs” flow based on JitConfig.
src/coreclr/inc/readytoruninstructionset.hAdds new R2R instruction set IDs on the native side.
src/coreclr/inc/jiteeversionguid.hBumps JIT/EE version GUID due to instruction-set enum changes.
src/coreclr/inc/corinfoinstructionset.hExtends CORINFO instruction-set enums/validation/mappings for new ARM64 ISAs.
src/coreclr/inc/clrconfigvalues.hAdds CLRConfig switches to gate the new ARM64 ISAs.
Comment threadsrc/native/minipal/cpufeatures.h
Comment threadsrc/native/minipal/cpufeatures.c
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:30
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
Outdated

Comment threadsrc/coreclr/inc/clrconfigvalues.h
Outdated

Comment threadsrc/coreclr/jit/jitconfigvalues.h
Outdated

@a74nh
Update src/coreclr/jit/jitconfigvalues.h
06c126e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:38
a74nhand others
added 2 commits
February 20, 2026 14:38
@a74nh
Update src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
04c6104
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@a74nh
Update src/coreclr/inc/clrconfigvalues.h
96aa117
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
@a74nh
a74nh
marked this pull request as ready for review
February 20, 2026 16:48
@a74nh
a74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib

This is ready now

This was referenced Feb 20, 2026

Open


Open


Open


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 23, 2026

Closed

@jkotas
jkotas
commented
Mar 18, 2026

Copy link


Copy Markdown

Member
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
@a74nh
a74nh
commented
Mar 18, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are:
#98696
#98692
#94426
#94425
#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787

This was referenced Mar 18, 2026

Open


Closed

@a74nha74nh
mentioned this pull request
Apr 1, 2026

Closed

20 tasks
@dhartglassMSFT
dhartglassMSFT
commented
Apr 7, 2026

Copy link


Copy Markdown

Contributor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are: #98696#98692#94426#94425#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787
I talked to Jan offline
This change is good to go in, I'll update the branch and requeue check
But priority should still be SVE2 light-up
@dhartglassMSFT
dhartglassMSFT
enabled auto-merge (squash)
April 7, 2026 18:22

This was referenced Apr 8, 2026

Closed


Closed

CopilotAI
review requested due to automatic review settings
April 9, 2026 13:22

auto-merge was automatically disabled
April 9, 2026 13:22
Head branch was pushed to by a user without write access
CopilotAI
reviewed
Apr 9, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

This was referenced Apr 9, 2026

Closed


Open


Closed


Closed

@a74nh
a74nh
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@dhartglassMSFT : looks like my commits caused automerge to turn off.
Failures seems to be unrelated wasm issues.
CopilotAI
mentioned this pull request
Apr 11, 2026
 Merged

1 task
@tannergooding
tannergooding
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated timeout
@tannergooding
tannergooding
merged commit 1f1f5fd
into
dotnet:mainApr 13, 2026

186 of 190 checks passed

@build-analysisbuild-analysisBot
mentioned this pull request
Apr 13, 2026

Closed

@a74nh
a74nh
deleted the

svesets_github

branch
April 14, 2026 10:23
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 15, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dhartglassMSFTdhartglassMSFTdhartglassMSFT approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@jkotasjkotasAwaiting requested review from jkotas

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@a74nh@dhartglassMSFT@jkotas@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4 - #124637
Merged
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Apr 13, 2026
Merged
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4#124637
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Conversation
@a74nh
@a74nha74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Mostly a copy/paste of #115117
CopilotAI
review requested due to automatic review settings
February 20, 2026 12:50
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 20, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 20, 2026
@a74nh
a74nh
marked this pull request as draft
February 20, 2026 12:51
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds end-to-end ARM64 instruction set detection and plumbing for SHA3/SM4 and SVE crypto extensions so the runtime/JIT/R2R toolchain can recognize and gate these features consistently across platforms.
Changes:
  • Extend minipal_getcpufeatures to detect SHA3/SM4 and SVE AES/SHA3/SM4 (Linux hwcaps, Apple sysctlbyname, Windows IsProcessorFeaturePresent).
  • Add new ARM64 instruction sets (including R2R IDs/implications) and propagate them through CoreCLR instruction-set enums and helpers.
  • Gate JIT enablement via new CLRConfig/JitConfig switches and wire feature bits into EE JIT compile flags.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/native/minipal/cpufeatures.hAdds new ARM64 feature-bit constants for SHA3/SM4 and SVE crypto extensions.
src/native/minipal/cpufeatures.cDetects new ARM64 capabilities via HWCAP/HWCAP2, sysctl, and Windows PF_* flags.
src/coreclr/vm/codeman.cppSets CPU compile flags for new instruction sets, gated by CLRConfig switches.
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txtRegisters new ARM64 instruction sets, R2R bits, and ISA implications.
src/coreclr/tools/Common/JitInterface/CorInfoInstructionSet.csUpdates managed instruction-set enums and implication handling for new ARM64 ISAs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSetHelper.csMaps new ARM64 instruction sets to R2R instruction set IDs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSet.csAdds new R2R instruction set enum values for ARM64 SHA3/SM4 and SVE crypto.
src/coreclr/jit/jitconfigvalues.hIntroduces JIT config toggles for enabling/disabling the new ARM64 ISAs.
src/coreclr/jit/hwintrinsicarm64.cppAdds name-to-instruction-set and Arm64-variant mapping for new ISAs.
src/coreclr/jit/hwintrinsic.cppExtends ISA range table to include the new ARM64 instruction sets.
src/coreclr/jit/compiler.cppEnables new ARM64 instruction sets in “enable available ISAs” flow based on JitConfig.
src/coreclr/inc/readytoruninstructionset.hAdds new R2R instruction set IDs on the native side.
src/coreclr/inc/jiteeversionguid.hBumps JIT/EE version GUID due to instruction-set enum changes.
src/coreclr/inc/corinfoinstructionset.hExtends CORINFO instruction-set enums/validation/mappings for new ARM64 ISAs.
src/coreclr/inc/clrconfigvalues.hAdds CLRConfig switches to gate the new ARM64 ISAs.
Comment threadsrc/native/minipal/cpufeatures.h
Comment threadsrc/native/minipal/cpufeatures.c
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:30
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
Outdated

Comment threadsrc/coreclr/inc/clrconfigvalues.h
Outdated

Comment threadsrc/coreclr/jit/jitconfigvalues.h
Outdated

@a74nh
Update src/coreclr/jit/jitconfigvalues.h
06c126e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:38
a74nhand others
added 2 commits
February 20, 2026 14:38
@a74nh
Update src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
04c6104
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@a74nh
Update src/coreclr/inc/clrconfigvalues.h
96aa117
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
@a74nh
a74nh
marked this pull request as ready for review
February 20, 2026 16:48
@a74nh
a74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib

This is ready now

This was referenced Feb 20, 2026

Open


Open


Open


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 23, 2026

Closed

@jkotas
jkotas
commented
Mar 18, 2026

Copy link


Copy Markdown

Member
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
@a74nh
a74nh
commented
Mar 18, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are:
#98696
#98692
#94426
#94425
#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787

This was referenced Mar 18, 2026

Open


Closed

@a74nha74nh
mentioned this pull request
Apr 1, 2026

Closed

20 tasks
@dhartglassMSFT
dhartglassMSFT
commented
Apr 7, 2026

Copy link


Copy Markdown

Contributor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are: #98696#98692#94426#94425#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787
I talked to Jan offline
This change is good to go in, I'll update the branch and requeue check
But priority should still be SVE2 light-up
@dhartglassMSFT
dhartglassMSFT
enabled auto-merge (squash)
April 7, 2026 18:22

This was referenced Apr 8, 2026

Closed


Closed

CopilotAI
review requested due to automatic review settings
April 9, 2026 13:22

auto-merge was automatically disabled
April 9, 2026 13:22
Head branch was pushed to by a user without write access
CopilotAI
reviewed
Apr 9, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

This was referenced Apr 9, 2026

Closed


Open


Closed


Closed

@a74nh
a74nh
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@dhartglassMSFT : looks like my commits caused automerge to turn off.
Failures seems to be unrelated wasm issues.
CopilotAI
mentioned this pull request
Apr 11, 2026
 Merged

1 task
@tannergooding
tannergooding
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated timeout
@tannergooding
tannergooding
merged commit 1f1f5fd
into
dotnet:mainApr 13, 2026

186 of 190 checks passed

@build-analysisbuild-analysisBot
mentioned this pull request
Apr 13, 2026

Closed

@a74nh
a74nh
deleted the

svesets_github

branch
April 14, 2026 10:23
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 15, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dhartglassMSFTdhartglassMSFTdhartglassMSFT approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@jkotasjkotasAwaiting requested review from jkotas

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@a74nh@dhartglassMSFT@jkotas@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4 - #124637
Merged
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Apr 13, 2026
Merged
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4#124637
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Conversation
@a74nh
@a74nha74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Mostly a copy/paste of #115117
CopilotAI
review requested due to automatic review settings
February 20, 2026 12:50
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 20, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 20, 2026
@a74nh
a74nh
marked this pull request as draft
February 20, 2026 12:51
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds end-to-end ARM64 instruction set detection and plumbing for SHA3/SM4 and SVE crypto extensions so the runtime/JIT/R2R toolchain can recognize and gate these features consistently across platforms.
Changes:
  • Extend minipal_getcpufeatures to detect SHA3/SM4 and SVE AES/SHA3/SM4 (Linux hwcaps, Apple sysctlbyname, Windows IsProcessorFeaturePresent).
  • Add new ARM64 instruction sets (including R2R IDs/implications) and propagate them through CoreCLR instruction-set enums and helpers.
  • Gate JIT enablement via new CLRConfig/JitConfig switches and wire feature bits into EE JIT compile flags.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/native/minipal/cpufeatures.hAdds new ARM64 feature-bit constants for SHA3/SM4 and SVE crypto extensions.
src/native/minipal/cpufeatures.cDetects new ARM64 capabilities via HWCAP/HWCAP2, sysctl, and Windows PF_* flags.
src/coreclr/vm/codeman.cppSets CPU compile flags for new instruction sets, gated by CLRConfig switches.
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txtRegisters new ARM64 instruction sets, R2R bits, and ISA implications.
src/coreclr/tools/Common/JitInterface/CorInfoInstructionSet.csUpdates managed instruction-set enums and implication handling for new ARM64 ISAs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSetHelper.csMaps new ARM64 instruction sets to R2R instruction set IDs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSet.csAdds new R2R instruction set enum values for ARM64 SHA3/SM4 and SVE crypto.
src/coreclr/jit/jitconfigvalues.hIntroduces JIT config toggles for enabling/disabling the new ARM64 ISAs.
src/coreclr/jit/hwintrinsicarm64.cppAdds name-to-instruction-set and Arm64-variant mapping for new ISAs.
src/coreclr/jit/hwintrinsic.cppExtends ISA range table to include the new ARM64 instruction sets.
src/coreclr/jit/compiler.cppEnables new ARM64 instruction sets in “enable available ISAs” flow based on JitConfig.
src/coreclr/inc/readytoruninstructionset.hAdds new R2R instruction set IDs on the native side.
src/coreclr/inc/jiteeversionguid.hBumps JIT/EE version GUID due to instruction-set enum changes.
src/coreclr/inc/corinfoinstructionset.hExtends CORINFO instruction-set enums/validation/mappings for new ARM64 ISAs.
src/coreclr/inc/clrconfigvalues.hAdds CLRConfig switches to gate the new ARM64 ISAs.
Comment threadsrc/native/minipal/cpufeatures.h
Comment threadsrc/native/minipal/cpufeatures.c
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:30
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
Outdated

Comment threadsrc/coreclr/inc/clrconfigvalues.h
Outdated

Comment threadsrc/coreclr/jit/jitconfigvalues.h
Outdated

@a74nh
Update src/coreclr/jit/jitconfigvalues.h
06c126e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:38
a74nhand others
added 2 commits
February 20, 2026 14:38
@a74nh
Update src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
04c6104
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@a74nh
Update src/coreclr/inc/clrconfigvalues.h
96aa117
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
@a74nh
a74nh
marked this pull request as ready for review
February 20, 2026 16:48
@a74nh
a74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib

This is ready now

This was referenced Feb 20, 2026

Open


Open


Open


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 23, 2026

Closed

@jkotas
jkotas
commented
Mar 18, 2026

Copy link


Copy Markdown

Member
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
@a74nh
a74nh
commented
Mar 18, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are:
#98696
#98692
#94426
#94425
#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787

This was referenced Mar 18, 2026

Open


Closed

@a74nha74nh
mentioned this pull request
Apr 1, 2026

Closed

20 tasks
@dhartglassMSFT
dhartglassMSFT
commented
Apr 7, 2026

Copy link


Copy Markdown

Contributor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are: #98696#98692#94426#94425#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787
I talked to Jan offline
This change is good to go in, I'll update the branch and requeue check
But priority should still be SVE2 light-up
@dhartglassMSFT
dhartglassMSFT
enabled auto-merge (squash)
April 7, 2026 18:22

This was referenced Apr 8, 2026

Closed


Closed

CopilotAI
review requested due to automatic review settings
April 9, 2026 13:22

auto-merge was automatically disabled
April 9, 2026 13:22
Head branch was pushed to by a user without write access
CopilotAI
reviewed
Apr 9, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

This was referenced Apr 9, 2026

Closed


Open


Closed


Closed

@a74nh
a74nh
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@dhartglassMSFT : looks like my commits caused automerge to turn off.
Failures seems to be unrelated wasm issues.
CopilotAI
mentioned this pull request
Apr 11, 2026
 Merged

1 task
@tannergooding
tannergooding
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated timeout
@tannergooding
tannergooding
merged commit 1f1f5fd
into
dotnet:mainApr 13, 2026

186 of 190 checks passed

@build-analysisbuild-analysisBot
mentioned this pull request
Apr 13, 2026

Closed

@a74nh
a74nh
deleted the

svesets_github

branch
April 14, 2026 10:23
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 15, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dhartglassMSFTdhartglassMSFTdhartglassMSFT approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@jkotasjkotasAwaiting requested review from jkotas

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@a74nh@dhartglassMSFT@jkotas@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4 - #124637
Merged
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Apr 13, 2026
Merged
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4#124637
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Conversation
@a74nh
@a74nha74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Mostly a copy/paste of #115117
CopilotAI
review requested due to automatic review settings
February 20, 2026 12:50
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 20, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 20, 2026
@a74nh
a74nh
marked this pull request as draft
February 20, 2026 12:51
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds end-to-end ARM64 instruction set detection and plumbing for SHA3/SM4 and SVE crypto extensions so the runtime/JIT/R2R toolchain can recognize and gate these features consistently across platforms.
Changes:
  • Extend minipal_getcpufeatures to detect SHA3/SM4 and SVE AES/SHA3/SM4 (Linux hwcaps, Apple sysctlbyname, Windows IsProcessorFeaturePresent).
  • Add new ARM64 instruction sets (including R2R IDs/implications) and propagate them through CoreCLR instruction-set enums and helpers.
  • Gate JIT enablement via new CLRConfig/JitConfig switches and wire feature bits into EE JIT compile flags.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/native/minipal/cpufeatures.hAdds new ARM64 feature-bit constants for SHA3/SM4 and SVE crypto extensions.
src/native/minipal/cpufeatures.cDetects new ARM64 capabilities via HWCAP/HWCAP2, sysctl, and Windows PF_* flags.
src/coreclr/vm/codeman.cppSets CPU compile flags for new instruction sets, gated by CLRConfig switches.
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txtRegisters new ARM64 instruction sets, R2R bits, and ISA implications.
src/coreclr/tools/Common/JitInterface/CorInfoInstructionSet.csUpdates managed instruction-set enums and implication handling for new ARM64 ISAs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSetHelper.csMaps new ARM64 instruction sets to R2R instruction set IDs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSet.csAdds new R2R instruction set enum values for ARM64 SHA3/SM4 and SVE crypto.
src/coreclr/jit/jitconfigvalues.hIntroduces JIT config toggles for enabling/disabling the new ARM64 ISAs.
src/coreclr/jit/hwintrinsicarm64.cppAdds name-to-instruction-set and Arm64-variant mapping for new ISAs.
src/coreclr/jit/hwintrinsic.cppExtends ISA range table to include the new ARM64 instruction sets.
src/coreclr/jit/compiler.cppEnables new ARM64 instruction sets in “enable available ISAs” flow based on JitConfig.
src/coreclr/inc/readytoruninstructionset.hAdds new R2R instruction set IDs on the native side.
src/coreclr/inc/jiteeversionguid.hBumps JIT/EE version GUID due to instruction-set enum changes.
src/coreclr/inc/corinfoinstructionset.hExtends CORINFO instruction-set enums/validation/mappings for new ARM64 ISAs.
src/coreclr/inc/clrconfigvalues.hAdds CLRConfig switches to gate the new ARM64 ISAs.
Comment threadsrc/native/minipal/cpufeatures.h
Comment threadsrc/native/minipal/cpufeatures.c
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:30
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
Outdated

Comment threadsrc/coreclr/inc/clrconfigvalues.h
Outdated

Comment threadsrc/coreclr/jit/jitconfigvalues.h
Outdated

@a74nh
Update src/coreclr/jit/jitconfigvalues.h
06c126e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:38
a74nhand others
added 2 commits
February 20, 2026 14:38
@a74nh
Update src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
04c6104
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@a74nh
Update src/coreclr/inc/clrconfigvalues.h
96aa117
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
@a74nh
a74nh
marked this pull request as ready for review
February 20, 2026 16:48
@a74nh
a74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib

This is ready now

This was referenced Feb 20, 2026

Open


Open


Open


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 23, 2026

Closed

@jkotas
jkotas
commented
Mar 18, 2026

Copy link


Copy Markdown

Member
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
@a74nh
a74nh
commented
Mar 18, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are:
#98696
#98692
#94426
#94425
#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787

This was referenced Mar 18, 2026

Open


Closed

@a74nha74nh
mentioned this pull request
Apr 1, 2026

Closed

20 tasks
@dhartglassMSFT
dhartglassMSFT
commented
Apr 7, 2026

Copy link


Copy Markdown

Contributor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are: #98696#98692#94426#94425#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787
I talked to Jan offline
This change is good to go in, I'll update the branch and requeue check
But priority should still be SVE2 light-up
@dhartglassMSFT
dhartglassMSFT
enabled auto-merge (squash)
April 7, 2026 18:22

This was referenced Apr 8, 2026

Closed


Closed

CopilotAI
review requested due to automatic review settings
April 9, 2026 13:22

auto-merge was automatically disabled
April 9, 2026 13:22
Head branch was pushed to by a user without write access
CopilotAI
reviewed
Apr 9, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

This was referenced Apr 9, 2026

Closed


Open


Closed


Closed

@a74nh
a74nh
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@dhartglassMSFT : looks like my commits caused automerge to turn off.
Failures seems to be unrelated wasm issues.
CopilotAI
mentioned this pull request
Apr 11, 2026
 Merged

1 task
@tannergooding
tannergooding
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated timeout
@tannergooding
tannergooding
merged commit 1f1f5fd
into
dotnet:mainApr 13, 2026

186 of 190 checks passed

@build-analysisbuild-analysisBot
mentioned this pull request
Apr 13, 2026

Closed

@a74nh
a74nh
deleted the

svesets_github

branch
April 14, 2026 10:23
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 15, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dhartglassMSFTdhartglassMSFTdhartglassMSFT approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@jkotasjkotasAwaiting requested review from jkotas

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@a74nh@dhartglassMSFT@jkotas@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4 - #124637
Merged
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Apr 13, 2026
Merged
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4#124637
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Conversation
@a74nh
@a74nha74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Mostly a copy/paste of #115117
CopilotAI
review requested due to automatic review settings
February 20, 2026 12:50
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 20, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 20, 2026
@a74nh
a74nh
marked this pull request as draft
February 20, 2026 12:51
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds end-to-end ARM64 instruction set detection and plumbing for SHA3/SM4 and SVE crypto extensions so the runtime/JIT/R2R toolchain can recognize and gate these features consistently across platforms.
Changes:
  • Extend minipal_getcpufeatures to detect SHA3/SM4 and SVE AES/SHA3/SM4 (Linux hwcaps, Apple sysctlbyname, Windows IsProcessorFeaturePresent).
  • Add new ARM64 instruction sets (including R2R IDs/implications) and propagate them through CoreCLR instruction-set enums and helpers.
  • Gate JIT enablement via new CLRConfig/JitConfig switches and wire feature bits into EE JIT compile flags.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/native/minipal/cpufeatures.hAdds new ARM64 feature-bit constants for SHA3/SM4 and SVE crypto extensions.
src/native/minipal/cpufeatures.cDetects new ARM64 capabilities via HWCAP/HWCAP2, sysctl, and Windows PF_* flags.
src/coreclr/vm/codeman.cppSets CPU compile flags for new instruction sets, gated by CLRConfig switches.
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txtRegisters new ARM64 instruction sets, R2R bits, and ISA implications.
src/coreclr/tools/Common/JitInterface/CorInfoInstructionSet.csUpdates managed instruction-set enums and implication handling for new ARM64 ISAs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSetHelper.csMaps new ARM64 instruction sets to R2R instruction set IDs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSet.csAdds new R2R instruction set enum values for ARM64 SHA3/SM4 and SVE crypto.
src/coreclr/jit/jitconfigvalues.hIntroduces JIT config toggles for enabling/disabling the new ARM64 ISAs.
src/coreclr/jit/hwintrinsicarm64.cppAdds name-to-instruction-set and Arm64-variant mapping for new ISAs.
src/coreclr/jit/hwintrinsic.cppExtends ISA range table to include the new ARM64 instruction sets.
src/coreclr/jit/compiler.cppEnables new ARM64 instruction sets in “enable available ISAs” flow based on JitConfig.
src/coreclr/inc/readytoruninstructionset.hAdds new R2R instruction set IDs on the native side.
src/coreclr/inc/jiteeversionguid.hBumps JIT/EE version GUID due to instruction-set enum changes.
src/coreclr/inc/corinfoinstructionset.hExtends CORINFO instruction-set enums/validation/mappings for new ARM64 ISAs.
src/coreclr/inc/clrconfigvalues.hAdds CLRConfig switches to gate the new ARM64 ISAs.
Comment threadsrc/native/minipal/cpufeatures.h
Comment threadsrc/native/minipal/cpufeatures.c
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:30
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
Outdated

Comment threadsrc/coreclr/inc/clrconfigvalues.h
Outdated

Comment threadsrc/coreclr/jit/jitconfigvalues.h
Outdated

@a74nh
Update src/coreclr/jit/jitconfigvalues.h
06c126e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:38
a74nhand others
added 2 commits
February 20, 2026 14:38
@a74nh
Update src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
04c6104
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@a74nh
Update src/coreclr/inc/clrconfigvalues.h
96aa117
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
@a74nh
a74nh
marked this pull request as ready for review
February 20, 2026 16:48
@a74nh
a74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib

This is ready now

This was referenced Feb 20, 2026

Open


Open


Open


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 23, 2026

Closed

@jkotas
jkotas
commented
Mar 18, 2026

Copy link


Copy Markdown

Member
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
@a74nh
a74nh
commented
Mar 18, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are:
#98696
#98692
#94426
#94425
#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787

This was referenced Mar 18, 2026

Open


Closed

@a74nha74nh
mentioned this pull request
Apr 1, 2026

Closed

20 tasks
@dhartglassMSFT
dhartglassMSFT
commented
Apr 7, 2026

Copy link


Copy Markdown

Contributor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are: #98696#98692#94426#94425#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787
I talked to Jan offline
This change is good to go in, I'll update the branch and requeue check
But priority should still be SVE2 light-up
@dhartglassMSFT
dhartglassMSFT
enabled auto-merge (squash)
April 7, 2026 18:22

This was referenced Apr 8, 2026

Closed


Closed

CopilotAI
review requested due to automatic review settings
April 9, 2026 13:22

auto-merge was automatically disabled
April 9, 2026 13:22
Head branch was pushed to by a user without write access
CopilotAI
reviewed
Apr 9, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

This was referenced Apr 9, 2026

Closed


Open


Closed


Closed

@a74nh
a74nh
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@dhartglassMSFT : looks like my commits caused automerge to turn off.
Failures seems to be unrelated wasm issues.
CopilotAI
mentioned this pull request
Apr 11, 2026
 Merged

1 task
@tannergooding
tannergooding
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated timeout
@tannergooding
tannergooding
merged commit 1f1f5fd
into
dotnet:mainApr 13, 2026

186 of 190 checks passed

@build-analysisbuild-analysisBot
mentioned this pull request
Apr 13, 2026

Closed

@a74nh
a74nh
deleted the

svesets_github

branch
April 14, 2026 10:23
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 15, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dhartglassMSFTdhartglassMSFTdhartglassMSFT approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@jkotasjkotasAwaiting requested review from jkotas

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@a74nh@dhartglassMSFT@jkotas@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4 - #124637
Merged
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Apr 13, 2026
Merged
Add instruction set detection for SVE_AES, SVE_SHA3, SVE_SM4, SHA3, SM4#124637
tannergooding merged 18 commits into
dotnet:mainfrom 
a74nh:svesets_github
Conversation
@a74nh
@a74nha74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Mostly a copy/paste of #115117
CopilotAI
review requested due to automatic review settings
February 20, 2026 12:50
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 20, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Feb 20, 2026
@a74nh
a74nh
marked this pull request as draft
February 20, 2026 12:51
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Feb 20, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Adds end-to-end ARM64 instruction set detection and plumbing for SHA3/SM4 and SVE crypto extensions so the runtime/JIT/R2R toolchain can recognize and gate these features consistently across platforms.
Changes:
  • Extend minipal_getcpufeatures to detect SHA3/SM4 and SVE AES/SHA3/SM4 (Linux hwcaps, Apple sysctlbyname, Windows IsProcessorFeaturePresent).
  • Add new ARM64 instruction sets (including R2R IDs/implications) and propagate them through CoreCLR instruction-set enums and helpers.
  • Gate JIT enablement via new CLRConfig/JitConfig switches and wire feature bits into EE JIT compile flags.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/native/minipal/cpufeatures.hAdds new ARM64 feature-bit constants for SHA3/SM4 and SVE crypto extensions.
src/native/minipal/cpufeatures.cDetects new ARM64 capabilities via HWCAP/HWCAP2, sysctl, and Windows PF_* flags.
src/coreclr/vm/codeman.cppSets CPU compile flags for new instruction sets, gated by CLRConfig switches.
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txtRegisters new ARM64 instruction sets, R2R bits, and ISA implications.
src/coreclr/tools/Common/JitInterface/CorInfoInstructionSet.csUpdates managed instruction-set enums and implication handling for new ARM64 ISAs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSetHelper.csMaps new ARM64 instruction sets to R2R instruction set IDs.
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSet.csAdds new R2R instruction set enum values for ARM64 SHA3/SM4 and SVE crypto.
src/coreclr/jit/jitconfigvalues.hIntroduces JIT config toggles for enabling/disabling the new ARM64 ISAs.
src/coreclr/jit/hwintrinsicarm64.cppAdds name-to-instruction-set and Arm64-variant mapping for new ISAs.
src/coreclr/jit/hwintrinsic.cppExtends ISA range table to include the new ARM64 instruction sets.
src/coreclr/jit/compiler.cppEnables new ARM64 instruction sets in “enable available ISAs” flow based on JitConfig.
src/coreclr/inc/readytoruninstructionset.hAdds new R2R instruction set IDs on the native side.
src/coreclr/inc/jiteeversionguid.hBumps JIT/EE version GUID due to instruction-set enum changes.
src/coreclr/inc/corinfoinstructionset.hExtends CORINFO instruction-set enums/validation/mappings for new ARM64 ISAs.
src/coreclr/inc/clrconfigvalues.hAdds CLRConfig switches to gate the new ARM64 ISAs.
Comment threadsrc/native/minipal/cpufeatures.h
Comment threadsrc/native/minipal/cpufeatures.c
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:30
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
Outdated

Comment threadsrc/coreclr/inc/clrconfigvalues.h
Outdated

Comment threadsrc/coreclr/jit/jitconfigvalues.h
Outdated

@a74nh
Update src/coreclr/jit/jitconfigvalues.h
06c126e
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
February 20, 2026 14:38
a74nhand others
added 2 commits
February 20, 2026 14:38
@a74nh
Update src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
04c6104
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@a74nh
Update src/coreclr/inc/clrconfigvalues.h
96aa117
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Feb 20, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Comment threadsrc/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
@a74nh
a74nh
marked this pull request as ready for review
February 20, 2026 16:48
@a74nh
a74nh
commented
Feb 20, 2026

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib

This is ready now

This was referenced Feb 20, 2026

Open


Open


Open


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Feb 23, 2026

Closed

@jkotas
jkotas
commented
Mar 18, 2026

Copy link


Copy Markdown

Member
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
@a74nh
a74nh
commented
Mar 18, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.
Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are:
#98696
#98692
#94426
#94425
#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787

This was referenced Mar 18, 2026

Open


Closed

@a74nha74nh
mentioned this pull request
Apr 1, 2026

Closed

20 tasks
@dhartglassMSFT
dhartglassMSFT
commented
Apr 7, 2026

Copy link


Copy Markdown

Contributor
@jkotas - I think we need someone from your area to review this. Could you take a look please.
@dhartglassMSFT is on my team.

Do we have approved APIs from these extensions? When is the hardware with the extensions going to be broadly available?
These are all available on cobalt 100 and 200, so the the idea was to add everything available on the cobalts that hadn't been added to .NET yet
Approvals are: #98696#98692#94426#94425#94423
I do not see a problem with adding this proactively, but I would rather want to see more energy to be spent on making SVE/SVE2 work great. SVE/SVE2 is much more important than a future HW crypto extensions. The HW crypto extensions are low value for .NET runtime since we depend on OpenSSL exclusively for anything crypto related.
Agreed getting SVE/SVE2 working better is much more important. I was expecting these not to take too long to implement given they are only a few APIs per set - I have a PR ready to push that implements all of SHA3 and SVE SHA3 in one go.
If people agree, then I'm happy to drop these - and we'd remove them from #121787
I talked to Jan offline
This change is good to go in, I'll update the branch and requeue check
But priority should still be SVE2 light-up
@dhartglassMSFT
dhartglassMSFT
enabled auto-merge (squash)
April 7, 2026 18:22

This was referenced Apr 8, 2026

Closed


Closed

CopilotAI
review requested due to automatic review settings
April 9, 2026 13:22

auto-merge was automatically disabled
April 9, 2026 13:22
Head branch was pushed to by a user without write access
CopilotAI
reviewed
Apr 9, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

This was referenced Apr 9, 2026

Closed


Open


Closed


Closed

@a74nh
a74nh
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@dhartglassMSFT : looks like my commits caused automerge to turn off.
Failures seems to be unrelated wasm issues.
CopilotAI
mentioned this pull request
Apr 11, 2026
 Merged

1 task
@tannergooding
tannergooding
commented
Apr 13, 2026

Copy link


Copy Markdown

Member
/ba-g unrelated timeout
@tannergooding
tannergooding
merged commit 1f1f5fd
into
dotnet:mainApr 13, 2026

186 of 190 checks passed

@build-analysisbuild-analysisBot
mentioned this pull request
Apr 13, 2026

Closed

@a74nh
a74nh
deleted the

svesets_github

branch
April 14, 2026 10:23
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Apr 15, 2026
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 15, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dhartglassMSFTdhartglassMSFTdhartglassMSFT approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@jkotasjkotasAwaiting requested review from jkotas

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@a74nh@dhartglassMSFT@jkotas@tannergooding